October 2026 - gerrit-log - lists.osmocom.org

[S] Change in osmo-ttcn3-hacks[master]: SGP32Definitions_Templates: add new template (authClientError)
by laforge 16 Oct '26

16 Oct '26

Attention is currently required from: dexter. laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43823?usp=email ) Change subject: SGP32Definitions_Templates: add new template (authClientError) ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43823?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I4e5db6125315d9a77b98a5f089bd350effaaa9ff Gerrit-Change-Number: 43823 Gerrit-PatchSet: 5 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Fri, 16 Oct 2026 14:26:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-ttcn3-hacks[master]: esx_header_Types_JSON: add parameters to ts/tr_responseHeader
by laforge 16 Oct '26

16 Oct '26

Attention is currently required from: dexter. laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43822?usp=email ) Change subject: esx_header_Types_JSON: add parameters to ts/tr_responseHeader ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43822?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie65532432b24899505e0c51d6714be58cf5f594b Gerrit-Change-Number: 43822 Gerrit-PatchSet: 4 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Fri, 16 Oct 2026 14:26:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ttcn3-hacks[master]: eIM_Tests: remove code dup in f_esipa_transceive
by laforge 16 Oct '26

16 Oct '26

Attention is currently required from: dexter. laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43820?usp=email ) Change subject: eIM_Tests: remove code dup in f_esipa_transceive ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43820?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I11f0b7bcf1bf8c763e6915eda34c3ede2a9a5c94 Gerrit-Change-Number: 43820 Gerrit-PatchSet: 4 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Fri, 16 Oct 2026 14:25:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in libosmo-sigtran[master]: tcap: Add SUA spec references regarding TCAP routing
by laforge 16 Oct '26

16 Oct '26

Attention is currently required from: daniel, lynxis lazus, pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/43903?usp=email ) Change subject: tcap: Add SUA spec references regarding TCAP routing ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43903?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I9c1806570529e1568c5f65152b4bb298f19afe14 Gerrit-Change-Number: 43903 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <daniel(a)totalueberwachung.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: daniel <daniel(a)totalueberwachung.de> Gerrit-Comment-Date: Fri, 16 Oct 2026 14:25:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in libosmocore[master]: Gb: ensure a BSSGP Tx Status don't overflow on too big messages
by laforge 16 Oct '26

16 Oct '26

laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/43890?usp=email ) Change subject: Gb: ensure a BSSGP Tx Status don't overflow on too big messages ...................................................................... Gb: ensure a BSSGP Tx Status don't overflow on too big messages When sending a BSSGP Status, ensure the containing message don't overflow the new message. TS 48.018 specifies the BSSGP layer should take the lower layer MTU into account. However this is the legacy code, keep it simple and ensure it doesn't try to overflow the new message. The newer BSSGP code already handles this in a better way. Reported-by: tsato Fixes: OS#7096 Change-Id: I427d23887dcc05705228b553428d14fda086b06f --- M src/gb/gprs_bssgp_util.c M tests/gb/gprs_bssgp_test.c M tests/gb/gprs_bssgp_test.ok 3 files changed, 48 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve diff --git a/src/gb/gprs_bssgp_util.c b/src/gb/gprs_bssgp_util.c index 92896c1..8673584 100644 --- a/src/gb/gprs_bssgp_util.c +++ b/src/gb/gprs_bssgp_util.c @@ -584,7 +584,8 @@ msgb_tvlv_put(msg, BSSGP_IE_BVCI, 2, (uint8_t *) &_bvci); } msgb_tvlv_put(msg, BSSGP_IE_PDU_IN_ERROR, - msgb_bssgp_len(orig_msg), msgb_bssgph(orig_msg)); + OSMO_MIN(msgb_bssgp_len(orig_msg), msgb_tailroom(msg) - 3), /* Tag: 1 byte, Length: 2 bytes */ + msgb_bssgph(orig_msg)); return bssgp_ns_send(bssgp_ns_send_data, msg); } diff --git a/tests/gb/gprs_bssgp_test.c b/tests/gb/gprs_bssgp_test.c index 775ae43..4ae8315 100644 --- a/tests/gb/gprs_bssgp_test.c +++ b/tests/gb/gprs_bssgp_test.c @@ -289,6 +289,49 @@ printf("----- %s END\n", __func__); } + +static struct msgb *_msg_too_big = NULL; +static int _test_bssgp_tx_status_too_big_gprs_ns_sendmsg(void *ctx, struct msgb *msg) +{ + _msg_too_big = msg; + return 0; +} + +/* test if bssgp_tx_status() can handle tooo big messages */ +static void test_bssgp_tx_status_too_big(void) +{ + struct msgb *msg; + struct bssgp_normal_hdr *bgph; + + uint16_t bvci = htons(4); + + bssgp_set_bssgp_callback(_test_bssgp_tx_status_too_big_gprs_ns_sendmsg, NULL); + + printf("----- %s START\n", __func__); + msg = msgb_alloc_headroom(8096, 128, "testtoobig"); + OSMO_ASSERT(msg != NULL); + + /* fill a dummy BSSGP header */ + msgb_bssgph(msg) = msg->data; + bgph = (struct bssgp_normal_hdr *) msgb_put(msg, sizeof(*bgph)); + msgb_nsei(msg) = 23; + msgb_bvci(msg) = 42; /* ns bvci */ + msgb_tvlv_put(msg, BSSGP_IE_BVCI, 2, (uint8_t *) &bvci); + bgph->pdu_type = BSSGP_PDUT_FLUSH_LL; + msgb_put(msg, 5120); + + bssgp_tx_status(BSSGP_CAUSE_INV_MAND_INF, &bvci, msg); + + OSMO_ASSERT(_msg_too_big); + OSMO_ASSERT(msgb_nsei(_msg_too_big) == 23); + OSMO_ASSERT(msgb_bvci(_msg_too_big) == 0); /* BVCI is 0 for STATUS in most cases. see exceptions */ + msgb_free(msg); + msgb_free(_msg_too_big); + + printf("----- %s END\n", __func__); +} + + static struct log_info info = {}; int main(int argc, char **argv) @@ -317,6 +360,7 @@ test_bssgp_bad_reset(); test_bssgp_flow_control_bvc(); test_bssgp_msgb_copy(); + test_bssgp_tx_status_too_big(); printf("===== BSSGP test END\n\n"); exit(EXIT_SUCCESS); diff --git a/tests/gb/gprs_bssgp_test.ok b/tests/gb/gprs_bssgp_test.ok index c5b3e7d..e11a94a 100644 --- a/tests/gb/gprs_bssgp_test.ok +++ b/tests/gb/gprs_bssgp_test.ok @@ -17,5 +17,7 @@ Old msgb: [L3]> 22 04 82 00 02 07 81 08 New msgb: [L3]> 22 04 82 00 02 07 81 08 ----- test_bssgp_msgb_copy END +----- test_bssgp_tx_status_too_big START +----- test_bssgp_tx_status_too_big END ===== BSSGP test END -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/43890?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I427d23887dcc05705228b553428d14fda086b06f Gerrit-Change-Number: 43890 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in libosmocore[master]: Gb: ensure a BSSGP Tx Status don't overflow on too big messages
by laforge 16 Oct '26

16 Oct '26

Attention is currently required from: lynxis lazus. laforge has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmocore/+/43890?usp=email ) Change subject: Gb: ensure a BSSGP Tx Status don't overflow on too big messages ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/43890?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I427d23887dcc05705228b553428d14fda086b06f Gerrit-Change-Number: 43890 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Fri, 16 Oct 2026 14:24:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-msc[master]: libvlr: only use SGS fsm for CS
by laforge 16 Oct '26

16 Oct '26

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/43889?usp=email ) Change subject: libvlr: only use SGS fsm for CS ...................................................................... libvlr: only use SGS fsm for CS The SGS interface towards the MME only exists in CS. Don't initialize or use the interfaces when running in PS. Change-Id: I319123e52ddb6a5ee086e77b75f18caaa85589bd --- M src/libvlr/vlr.c M src/libvlr/vlr_lu_fsm.c 2 files changed, 11 insertions(+), 6 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve diff --git a/src/libvlr/vlr.c b/src/libvlr/vlr.c index 5baf2c3..95e4f28 100644 --- a/src/libvlr/vlr.c +++ b/src/libvlr/vlr.c @@ -420,7 +420,8 @@ /* Create an SGs FSM, which is needed to control CSFB, * in cases where CSFB/SGs is not in use, this FSM will * just do nothing. (see also: sgs_iface.c) */ - vlr_sgs_fsm_create(vsub); + if (vlr_is_cs(vlr)) + vlr_sgs_fsm_create(vsub); llist_add_tail(&vsub->list, &vlr->subscribers); vlr_stat_item_inc(vlr, VLR_STAT_SUBSCRIBER_COUNT); @@ -476,7 +477,8 @@ osmo_timer_del(&vsub->sgs.Ts5); /* Remove SGs FSM (see also: sgs_iface.c) */ - vlr_sgs_fsm_remove(vsub); + if (vlr_is_cs(vsub->vlr)) + vlr_sgs_fsm_remove(vsub); talloc_free(vsub); } @@ -1621,13 +1623,14 @@ vlr_lu_fsm_init(is_ps); /* vlr_access_request_fsm.c */ vlr_parq_fsm_init(is_ps); - /* vlr_sgs_fsm.c */ - vlr_sgs_fsm_init(); if (is_ps) vlr_tdefs = sgsn_tdefs_vlr; - else + else { /* is_cs */ + /* vlr_sgs_fsm.c */ + vlr_sgs_fsm_init(); vlr_tdefs = msc_tdefs_vlr; + } return vlr; diff --git a/src/libvlr/vlr_lu_fsm.c b/src/libvlr/vlr_lu_fsm.c index c306ff7..cc7dfc4 100644 --- a/src/libvlr/vlr_lu_fsm.c +++ b/src/libvlr/vlr_lu_fsm.c @@ -379,7 +379,9 @@ vlr_subscr_get(vsub, VSUB_USE_ATTACHED); } _vlr_lu_compl_fsm_done(fi, VLR_FSM_RESULT_SUCCESS, 0); - vlr_sgs_fsm_update_id(vsub); + + if (vlr_is_cs(vsub->vlr)) + vlr_sgs_fsm_update_id(vsub); } static void vlr_lu_compl_fsm_dispatch_result(struct osmo_fsm_inst *fi, -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/43889?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I319123e52ddb6a5ee086e77b75f18caaa85589bd Gerrit-Change-Number: 43889 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-msc[master]: libvlr: only use SGS fsm for CS
by laforge 16 Oct '26

16 Oct '26

Attention is currently required from: lynxis lazus, neels. laforge has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-msc/+/43889?usp=email ) Change subject: libvlr: only use SGS fsm for CS ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/43889?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I319123e52ddb6a5ee086e77b75f18caaa85589bd Gerrit-Change-Number: 43889 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Fri, 16 Oct 2026 14:24:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[L] Change in osmo-ttcn3-hacks[master]: smf,pgw: Split GTPv2C S2b/S5/S8c create session into multiple func he...
by laforge 16 Oct '26

16 Oct '26

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43895?usp=email ) Change subject: smf,pgw: Split GTPv2C S2b/S5/S8c create session into multiple func helpers ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43895?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I07896c37d06014873b120f87457f99f529f4601a Gerrit-Change-Number: 43895 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 16 Oct 2026 14:23:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-ttcn3-hacks[master]: GTPv2_Templates: Allow passing servingNetwork IE
by laforge 16 Oct '26

16 Oct '26

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43894?usp=email ) Change subject: GTPv2_Templates: Allow passing servingNetwork IE ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43894?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I627652f5c08db1de4d541ba3dfc950b7e75d865b Gerrit-Change-Number: 43894 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 16 Oct 2026 14:23:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0