Attention is currently required from: dexter.
Hello Jenkins Builder, jolly, laforge,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43850?usp=email
to look at the new patch set (#4).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
The change is no longer submittable: Verified is unsatisfied now.
Change subject: esipa_Types_JSON: make eimAcknowledgements mandatory
......................................................................
esipa_Types_JSON: make eimAcknowledgements mandatory
The JSON type JSON_ESipa_ProvideEimPackageResultResponse has
only one optional member eimAcknowledgements (next to the mandatory
header field, that all message types have in common). In case the
eimAcknowledgements member is missing. The
JSON_ESipa_ProvideEimPackageResultResponse becomes indistinguishable
from JSON_ESipa_EmptyResponse. To make it distinguishable, let's
make the eimAcknowledgements mandatory. So that when it is included,
the decoder will decode the message as
JSON_ESipa_ProvideEimPackageResultResponse and as
JSON_ESipa_EmptyResponse otherwise. It is then up to the API user
to interpret the response accordingly.
Change-Id: I8e151d7570ee9c3293340a5f8e52cfc62c60a018
Related: SYS#8203
---
M library/euicc/esipa_Types_JSON.ttcn
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/50/43850/4
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43850?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I8e151d7570ee9c3293340a5f8e52cfc62c60a018
Gerrit-Change-Number: 43850
Gerrit-PatchSet: 4
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Attention is currently required from: dexter.
Hello Jenkins Builder, jolly, laforge,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43842?usp=email
to look at the new patch set (#4).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
The change is no longer submittable: Verified is unsatisfied now.
Change subject: eIM_Tests: use constants from SGP23_constants
......................................................................
eIM_Tests: use constants from SGP23_constants
The eIM tests define some custom constants for some values, Let's
use the constants from SGP23_constants.
Related: SYS#8203
Change-Id: I9d554a10d1f8e84bf86562448765962aa1f02518
---
M eim/eIM_Tests.ttcn
1 file changed, 34 insertions(+), 35 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/42/43842/4
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43842?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I9d554a10d1f8e84bf86562448765962aa1f02518
Gerrit-Change-Number: 43842
Gerrit-PatchSet: 4
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Attention is currently required from: dexter.
Hello Jenkins Builder, jolly, laforge,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43849?usp=email
to look at the new patch set (#4).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
The change is no longer submittable: Verified is unsatisfied now.
Change subject: RSPDefinitions_Templates: add parameters to tr/ts_profileInstallationResult
......................................................................
RSPDefinitions_Templates: add parameters to tr/ts_profileInstallationResult
The template tr/ts_profileInstallationResult has all parameters hardcoded.
To use the template more flexible, let's add parameters.
Change-Id: I4578440fc2dc4851d5d068e47952c831f18bf4d9
Related: SYS#8203
---
M library/euicc/RSPDefinitions_Templates.ttcn
1 file changed, 8 insertions(+), 6 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/49/43849/4
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43849?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I4578440fc2dc4851d5d068e47952c831f18bf4d9
Gerrit-Change-Number: 43849
Gerrit-PatchSet: 4
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Attention is currently required from: dexter.
Hello Jenkins Builder, jolly, laforge,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43851?usp=email
to look at the new patch set (#4).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
The change is no longer submittable: Verified is unsatisfied now.
Change subject: SGP32Definitions_Templates: rework tr_SGP32_pendingNotification_prfleInstRslt
......................................................................
SGP32Definitions_Templates: rework tr_SGP32_pendingNotification_prfleInstRslt
The template ts_SGP32_pendingNotification_prfleInstRslt has only one
parameter, which is the notificationAddress. This parameter is passed
to another template within the template. This is an unfortunate
combination.
Let's untangle this by adding a dedicated template for the SGP32 Profile
Installation Result and use this template as parameter for
tr/ts_SGP32_pendingNotification_prfleInstRslt. This slightly changes
the API of the template, so we have to re-align eIM_Tests as well.
Change-Id: I1867dad3a817785623029b9fd1fc9c4f746a6faa
Related: SYS#8203
---
M eim/eIM_Tests.ttcn
M library/euicc/SGP32Definitions_Templates.ttcn
2 files changed, 23 insertions(+), 11 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/51/43851/4
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43851?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I1867dad3a817785623029b9fd1fc9c4f746a6faa
Gerrit-Change-Number: 43851
Gerrit-PatchSet: 4
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Attention is currently required from: dexter.
Hello Jenkins Builder, jolly, laforge,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43852?usp=email
to look at the new patch set (#4).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
The change is no longer submittable: Verified is unsatisfied now.
Change subject: RSPDefinitions_Templates: Add missing defaults to ts_otherSignedNotification
......................................................................
RSPDefinitions_Templates: Add missing defaults to ts_otherSignedNotification
The parameters euiccCertificate and eumCertificate have no default
value.
Change-Id: I83f1b766b20cb43d798046ab6762664e6ec080f9
Related: SYS#8203
---
M library/euicc/RSPDefinitions_Templates.ttcn
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/52/43852/4
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43852?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I83f1b766b20cb43d798046ab6762664e6ec080f9
Gerrit-Change-Number: 43852
Gerrit-PatchSet: 4
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Attention is currently required from: dexter.
Hello Jenkins Builder, jolly, laforge,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43853?usp=email
to look at the new patch set (#4).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
The change is no longer submittable: Verified is unsatisfied now.
Change subject: RSPDefinitions_Templates: add suffix to template tr/ts_pendingNotification
......................................................................
RSPDefinitions_Templates: add suffix to template tr/ts_pendingNotification
The template tr/ts_pendingNotification coresponds to the SGP.32
template tr/ts_SGP32_pendingNotification_prfleInstRslt, which
has the suffix "_prfleInstRslt". Let's add the same suffix to
the SGP.22 variant in RSPDefinitions_Templates
(This is to make room for a related _otherSignedNotif template,
which we will add in a follow-up patch.)
Change-Id: I7362cca65d21a149a158e583532c99c7900decb2
Related: SYS#8203
---
M library/euicc/RSPDefinitions_Templates.ttcn
1 file changed, 5 insertions(+), 3 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/53/43853/4
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43853?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I7362cca65d21a149a158e583532c99c7900decb2
Gerrit-Change-Number: 43853
Gerrit-PatchSet: 4
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Attention is currently required from: dexter.
Hello Jenkins Builder, jolly, laforge,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43854?usp=email
to look at the new patch set (#4).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
The change is no longer submittable: Verified is unsatisfied now.
Change subject: RSPDefinitions_Templates: Add new template (otherSignedNotif)
......................................................................
RSPDefinitions_Templates: Add new template (otherSignedNotif)
We already have a template to match/generate a notification with a
Profile Installation Result. Let's now add a variant to generate/match
an Other Signed Notification.
Change-Id: I7a18cb9bfe9b3098d3c6ffc1f54a5242f0cb980f
Related: SYS#8203
---
M library/euicc/RSPDefinitions_Templates.ttcn
1 file changed, 8 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/54/43854/4
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43854?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I7a18cb9bfe9b3098d3c6ffc1f54a5242f0cb980f
Gerrit-Change-Number: 43854
Gerrit-PatchSet: 4
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Attention is currently required from: dexter.
Hello Jenkins Builder, jolly, laforge,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43876?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
The change is no longer submittable: Verified is unsatisfied now.
Change subject: RSPDefinitions_Templates: fix profileManagementOperation value
......................................................................
RSPDefinitions_Templates: fix profileManagementOperation value
The constant for profileManagementOperation in
ts_profileInstallationResultData is incorrectly set.
(should be the first bit instead of the second bit)
Change-Id: I05c333ecd4f750bd4ae94863696144b2b5b0f036
Related: SYS#8203
---
M library/euicc/RSPDefinitions_Templates.ttcn
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/76/43876/3
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43876?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I05c333ecd4f750bd4ae94863696144b2b5b0f036
Gerrit-Change-Number: 43876
Gerrit-PatchSet: 3
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Attention is currently required from: dexter.
Hello Jenkins Builder, jolly, laforge,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43875?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
The change is no longer submittable: Verified is unsatisfied now.
Change subject: RSPDefinitions_Templates: add parameters to ts/tr_profileInstallationResultData
......................................................................
RSPDefinitions_Templates: add parameters to ts/tr_profileInstallationResultData
The templates ts/tr_profileInstallationResultData currently do not
allow to set parameters. In particular not in the finalResult field.
Let's extend the template so that we can set the parameters.
Change-Id: I445c906a0142a401c305dbcbb3e94843a8f5fce9
Related: SYS#8203
---
M library/euicc/RSPDefinitions_Templates.ttcn
1 file changed, 21 insertions(+), 8 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/75/43875/3
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43875?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I445c906a0142a401c305dbcbb3e94843a8f5fce9
Gerrit-Change-Number: 43875
Gerrit-PatchSet: 3
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>