January 2026 - gerrit-log - lists.osmocom.org

[S] Change in osmo-ttcn3-hacks[master]: bts: use existing API in as_l1_sacch_loop()
by fixeria 22 Jan '26

22 Jan '26

Attention is currently required from: fixeria, pespin. Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41897?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by pespin, Verified+1 by Jenkins Builder Change subject: bts: use existing API in as_l1_sacch_loop() ...................................................................... bts: use existing API in as_l1_sacch_loop() Change-Id: I5ab2988152b948e457c3cfa4930df484c170d053 --- M bts/BTS_Tests.ttcn 1 file changed, 6 insertions(+), 22 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/97/41897/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41897?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I5ab2988152b948e457c3cfa4930df484c170d053 Gerrit-Change-Number: 41897 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[M] Change in libosmocore[master]: osmo_io: Support rx of segments up to ~UINT16_MAX
by pespin 22 Jan '26

22 Jan '26

Attention is currently required from: daniel, laforge. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmocore/+/41911?usp=email ) Change subject: osmo_io: Support rx of segments up to ~UINT16_MAX ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: > this sounds like the kind of code where we definitely would want test coverage. There is actually code coverage for regular segmentation under tests/osmo_io/osmo_io_test, but agree, I'll see if I can add a corner case triggering those. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41911?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I8c11a7edbed2335ada40a1f93d081041974c3586 Gerrit-Change-Number: 41911 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Thu, 22 Jan 2026 12:04:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org>

1 0

[XS] Change in libosmocore[master]: osmo_io: Reorder iofd_handle_segmented_read()
by pespin 22 Jan '26

22 Jan '26

Attention is currently required from: daniel, fixeria, jolly, laforge, osmith. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmocore/+/41910?usp=email ) Change subject: osmo_io: Reorder iofd_handle_segmented_read() ...................................................................... Patch Set 1: (1 comment) File src/core/osmo_io.c: https://gerrit.osmocom.org/c/libosmocore/+/41910/comment/cc5a7a28_fd73aeb5?… : PS1, Line 362: vo > I'm wondering why this function is not declared static? I can only see one user and that's in the […] Ack. Maybe it was called before in some other place, because I can see it defined in osmo_io_internal.h. I'll submit an extra patch making it static. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41910?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I88683334e77901776c806dad776ef46ea20b4480 Gerrit-Change-Number: 41910 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Thu, 22 Jan 2026 12:03:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org>

1 0

[S] Change in libosmocore[master]: osmo_io: Propagate segment_cb errors to the read_cb
by laforge 22 Jan '26

22 Jan '26

Attention is currently required from: daniel, pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmocore/+/41914?usp=email ) Change subject: osmo_io: Propagate segment_cb errors to the read_cb ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: once again sounds like critical and hard to get right error paths that should have some test coverage. If they had, we might have caught it earlier. But now that we have been made aware of it, we would still benefit from it. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41914?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I572e68df6799b903507229a9beee6fa7d7d6d652 Gerrit-Change-Number: 41914 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Thu, 22 Jan 2026 12:02:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[M] Change in libosmocore[master]: osmo_io: Support rx of segments up to ~UINT16_MAX
by laforge 22 Jan '26

22 Jan '26

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmocore/+/41911?usp=email ) Change subject: osmo_io: Support rx of segments up to ~UINT16_MAX ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: this sounds like the kind of code where we definitely would want test coverage. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41911?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I8c11a7edbed2335ada40a1f93d081041974c3586 Gerrit-Change-Number: 41911 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 22 Jan 2026 12:01:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in libosmocore[master]: osmo_io: Assert osmo_iofd_set_alloc_info() params fit in a 16bit value
by laforge 22 Jan '26

22 Jan '26

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmocore/+/41912?usp=email ) Change subject: osmo_io: Assert osmo_iofd_set_alloc_info() params fit in a 16bit value ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41912?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I32822574db8997a02bf18b71bf6ab596e726cb82 Gerrit-Change-Number: 41912 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 22 Jan 2026 11:59:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmocore[master]: osmo_io: Reorder iofd_handle_segmented_read()
by laforge 22 Jan '26

22 Jan '26

Attention is currently required from: daniel, fixeria, jolly, osmith, pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmocore/+/41910?usp=email ) Change subject: osmo_io: Reorder iofd_handle_segmented_read() ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File src/core/osmo_io.c: https://gerrit.osmocom.org/c/libosmocore/+/41910/comment/1ae86e4b_e6994923?… : PS1, Line 362: vo I'm wondering why this function is not declared static? I can only see one user and that's in the very same file? We don't need it exported and we don't need it declared in the header file, right? It's also not in the .map file so nobody outside the lib can ever have used it. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41910?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I88683334e77901776c806dad776ef46ea20b4480 Gerrit-Change-Number: 41910 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Thu, 22 Jan 2026 11:59:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[M] Change in libosmocore[master]: Add Emscripten build support and JS callback logging backend
by pespin 22 Jan '26

22 Jan '26

Attention is currently required from: Timur Davydov, laforge, neels. pespin has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/libosmocore/+/41813?usp=email ) Change subject: Add Emscripten build support and JS callback logging backend ...................................................................... Patch Set 15: (1 comment) File src/core/netdev.c: https://gerrit.osmocom.org/c/libosmocore/+/41813/comment/75e36e1b_149639fa?… : PS5, Line 67: #if (!EMBEDDED) && !defined(__EMSCRIPTEN__) > And yet afaict the new version of this patch doesn't depend on those ones? I have the feeling you ar […] I'm delaying review of this patch until the previous one regarding netdev is solved, because anyway it will affect how this patch will look like. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41813?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ia8d5f4bb6570b5e055826f3a051e5e5896866e31 Gerrit-Change-Number: 41813 Gerrit-PatchSet: 15 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Comment-Date: Thu, 22 Jan 2026 11:52:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: Timur Davydov <dtv.comp(a)gmail.com>

1 0

[M] Change in libosmocore[master]: build: detect netns support via configure-time capability checks
by pespin 22 Jan '26

22 Jan '26

Attention is currently required from: Timur Davydov. pespin has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/libosmocore/+/41878?usp=email ) Change subject: build: detect netns support via configure-time capability checks ...................................................................... Patch Set 6: (2 comments) Patchset: PS6: In any case, the new version of the patch doesn't do what I requested in the previous patch version :) File include/osmocom/core/netdev.h: https://gerrit.osmocom.org/c/libosmocore/+/41878/comment/50799640_75deba73?… : PS6, Line 6: #include "config.h" You cannot include config here, since this is a public header used by other projects, while "config.h" is a private header of the project. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41878?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I2322eb2936bea35596f1fd6b6a713ea5f997b1ea Gerrit-Change-Number: 41878 Gerrit-PatchSet: 6 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Comment-Date: Thu, 22 Jan 2026 11:51:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in libosmocore[master]: core: always build osmo_sock_multiaddr_* helpers
by pespin 22 Jan '26

22 Jan '26

Attention is currently required from: Timur Davydov, laforge. pespin has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/libosmocore/+/41895?usp=email ) Change subject: core: always build osmo_sock_multiaddr_* helpers ...................................................................... Patch Set 4: (1 comment) Commit Message: https://gerrit.osmocom.org/c/libosmocore/+/41895/comment/2f0c3afd_fe59a31a?… : PS1, Line 17: This fixes link failures in libosmo-netif when building with > Done, rebased and pushed. Done -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41895?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I3e70b7cd6cb4d022252e6ddc70a42ca5eea72bb1 Gerrit-Change-Number: 41895 Gerrit-PatchSet: 4 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Comment-Date: Thu, 22 Jan 2026 11:49:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: Timur Davydov <dtv.comp(a)gmail.com>

1 0

2026

2025

2024

2023

2022

gerrit-log January 2026