January 2026 - gerrit-log - lists.osmocom.org

[XS] Change in pysim[master]: pySim/card_key_provider: fix typo in keys
by laforge 31 Jan '26

31 Jan '26

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/41877?usp=email ) Change subject: pySim/card_key_provider: fix typo in keys ...................................................................... pySim/card_key_provider: fix typo in keys Change-Id: Ie76f351ae221da2a0aab65c311fafe8ae6d63663 --- M pySim/card_key_provider.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve diff --git a/pySim/card_key_provider.py b/pySim/card_key_provider.py index a6cd7ea..06a6b2b 100644 --- a/pySim/card_key_provider.py +++ b/pySim/card_key_provider.py @@ -58,7 +58,7 @@ 'UICC_SCP02': ['UICC_SCP02_KIC1', 'UICC_SCP02_KID1', 'UICC_SCP02_KIK1'], 'UICC_SCP03': ['UICC_SCP03_KIC1', 'UICC_SCP03_KID1', 'UICC_SCP03_KIK1'], 'SCP03_ISDR': ['SCP03_ENC_ISDR', 'SCP03_MAC_ISDR', 'SCP03_DEK_ISDR'], - 'SCP03_ISDA': ['SCP03_ENC_ISDR', 'SCP03_MAC_ISDA', 'SCP03_DEK_ISDA'], + 'SCP03_ISDA': ['SCP03_ENC_ISDA', 'SCP03_MAC_ISDA', 'SCP03_DEK_ISDA'], 'SCP03_ECASD': ['SCP03_ENC_ECASD', 'SCP03_MAC_ECASD', 'SCP03_DEK_ECASD'], } -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41877?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ie76f351ae221da2a0aab65c311fafe8ae6d63663 Gerrit-Change-Number: 41877 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

1 0

[XS] Change in pysim[master]: pySim/card_key_provider: fix typo in keys
by laforge 31 Jan '26

31 Jan '26

Attention is currently required from: lynxis lazus. laforge has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/pysim/+/41877?usp=email ) Change subject: pySim/card_key_provider: fix typo in keys ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41877?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ie76f351ae221da2a0aab65c311fafe8ae6d63663 Gerrit-Change-Number: 41877 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Sat, 31 Jan 2026 01:32:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in pysim[master]: Print SMSC in pySim-read.py
by laforge 31 Jan '26

31 Jan '26

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/41786?usp=email ) Change subject: Print SMSC in pySim-read.py ...................................................................... Print SMSC in pySim-read.py Change-Id: I17067b68086316d51fd71ba77049874605594e3f --- M pySim-read.py M tests/pySim-prog_test/Fairwaves-SIM.ok M tests/pySim-prog_test/Wavemobile-SIM.ok M tests/pySim-prog_test/fakemagicsim.ok M tests/pySim-prog_test/sysmoISIM-SJA2.ok M tests/pySim-prog_test/sysmoISIM-SJA5.ok M tests/pySim-prog_test/sysmoUSIM-SJS1.ok M tests/pySim-prog_test/sysmosim-gr1.ok 8 files changed, 17 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified dexter: Looks good to me, but someone else must approve; Verified diff --git a/pySim-read.py b/pySim-read.py index 9829a15..481e9da 100755 --- a/pySim-read.py +++ b/pySim-read.py @@ -44,6 +44,7 @@ from pySim.legacy.cards import card_detect, SimCard, UsimCard, IsimCard from pySim.utils import dec_imsi, dec_iccid from pySim.legacy.utils import format_xplmn_w_act, dec_st, dec_msisdn +from pySim.ts_51_011 import EF_SMSP option_parser = argparse.ArgumentParser(description='Legacy tool for reading some parts of a SIM card', formatter_class=argparse.ArgumentDefaultsHelpFormatter) @@ -141,6 +142,15 @@ (res, sw) = card.read_record('SMSP', 1) if sw == '9000': print("SMSP: %s" % (res,)) + ef_smsp = EF_SMSP() + smsc_a = ef_smsp.decode_record_bin(h2b(res), 1).get('tp_sc_addr', {}) + smsc_n = smsc_a.get('call_number', None) + if smsc_a.get('ton_npi', {}).get('type_of_number', None) == 'international' and smsc_n is not None: + smsc = '+' + smsc_n + else: + smsc = smsc_n + if smsc is not None: + print("SMSC: %s" % (smsc,)) else: print("SMSP: Can't read, response code = %s" % (sw,)) diff --git a/tests/pySim-prog_test/Fairwaves-SIM.ok b/tests/pySim-prog_test/Fairwaves-SIM.ok index 3751c57..303e8ae 100644 --- a/tests/pySim-prog_test/Fairwaves-SIM.ok +++ b/tests/pySim-prog_test/Fairwaves-SIM.ok @@ -6,6 +6,7 @@ GID1: ffffffffffffffff GID2: ffffffffffffffff SMSP: e1ffffffffffffffffffffffff0581005155f5ffffffffffff000000ffffffffffffffffffffffffffff +SMSC: 0015555 SPN: Fairwaves Show in HPLMN: False Hide in OPLMN: False diff --git a/tests/pySim-prog_test/Wavemobile-SIM.ok b/tests/pySim-prog_test/Wavemobile-SIM.ok index 7a0ecec..3c1e62d 100644 --- a/tests/pySim-prog_test/Wavemobile-SIM.ok +++ b/tests/pySim-prog_test/Wavemobile-SIM.ok @@ -6,6 +6,7 @@ GID1: Can't read file -- SW match failed! Expected 9000 and got 6a82. GID2: Can't read file -- SW match failed! Expected 9000 and got 6a82. SMSP: e1ffffffffffffffffffffffff0581005155f5ffffffffffff000000ffffffffffffffffffffffffffff +SMSC: 0015555 SPN: wavemobile Show in HPLMN: False Hide in OPLMN: False diff --git a/tests/pySim-prog_test/fakemagicsim.ok b/tests/pySim-prog_test/fakemagicsim.ok index 4c366f9..306cef9 100644 --- a/tests/pySim-prog_test/fakemagicsim.ok +++ b/tests/pySim-prog_test/fakemagicsim.ok @@ -6,6 +6,7 @@ GID1: Can't read file -- SW match failed! Expected 9000 and got 9404. GID2: Can't read file -- SW match failed! Expected 9000 and got 9404. SMSP: ffffffffffffffffffffffffe1ffffffffffffffffffffffff0581005155f5ffffffffffff000000 +SMSC: 0015555 SPN: Magic Show in HPLMN: True Hide in OPLMN: False diff --git a/tests/pySim-prog_test/sysmoISIM-SJA2.ok b/tests/pySim-prog_test/sysmoISIM-SJA2.ok index 5640171..5e2b45f 100644 --- a/tests/pySim-prog_test/sysmoISIM-SJA2.ok +++ b/tests/pySim-prog_test/sysmoISIM-SJA2.ok @@ -6,6 +6,7 @@ GID1: ffffffffffffffffffff GID2: ffffffffffffffffffff SMSP: ffffffffffffffffffffffffffffffffffffffffffffffffe1ffffffffffffffffffffffff0581005155f5ffffffffffff000000 +SMSC: 0015555 SPN: Magic Show in HPLMN: True Hide in OPLMN: True diff --git a/tests/pySim-prog_test/sysmoISIM-SJA5.ok b/tests/pySim-prog_test/sysmoISIM-SJA5.ok index 28b2875..b6d7862 100644 --- a/tests/pySim-prog_test/sysmoISIM-SJA5.ok +++ b/tests/pySim-prog_test/sysmoISIM-SJA5.ok @@ -6,6 +6,7 @@ GID1: ffffffffffffffffffff GID2: ffffffffffffffffffff SMSP: ffffffffffffffffffffffffffffffffffffffffffffffffe1ffffffffffffffffffffffff0581005155f5ffffffffffff000000 +SMSC: 0015555 SPN: Magic Show in HPLMN: True Hide in OPLMN: True diff --git a/tests/pySim-prog_test/sysmoUSIM-SJS1.ok b/tests/pySim-prog_test/sysmoUSIM-SJS1.ok index 2f48c2c..c669353 100644 --- a/tests/pySim-prog_test/sysmoUSIM-SJS1.ok +++ b/tests/pySim-prog_test/sysmoUSIM-SJS1.ok @@ -6,6 +6,7 @@ GID1: ffffffffffffffffffff GID2: ffffffffffffffffffff SMSP: ffffffffffffffffffffffffffffffffffffffffffffffffe1ffffffffffffffffffffffff0581005155f5ffffffffffff000000 +SMSC: 0015555 SPN: Magic Show in HPLMN: True Hide in OPLMN: True diff --git a/tests/pySim-prog_test/sysmosim-gr1.ok b/tests/pySim-prog_test/sysmosim-gr1.ok index 03b6a17..3d926e2 100644 --- a/tests/pySim-prog_test/sysmosim-gr1.ok +++ b/tests/pySim-prog_test/sysmosim-gr1.ok @@ -6,6 +6,7 @@ GID1: Can't read file -- SW match failed! Expected 9000 and got 9404. GID2: Can't read file -- SW match failed! Expected 9000 and got 9404. SMSP: ffffffffffffffffffffffffe1ffffffffffffffffffffffff0581005155f5ffffffffffff000000 +SMSC: 0015555 SPN: Not available Show in HPLMN: False Hide in OPLMN: False -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41786?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I17067b68086316d51fd71ba77049874605594e3f Gerrit-Change-Number: 41786 Gerrit-PatchSet: 16 Gerrit-Owner: phcoder <phcoder(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[S] Change in pysim[master]: Print SMSC in pySim-read.py
by laforge 31 Jan '26

31 Jan '26

Attention is currently required from: fixeria, phcoder. laforge has posted comments on this change by phcoder. ( https://gerrit.osmocom.org/c/pysim/+/41786?usp=email ) Change subject: Print SMSC in pySim-read.py ...................................................................... Patch Set 15: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41786?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I17067b68086316d51fd71ba77049874605594e3f Gerrit-Change-Number: 41786 Gerrit-PatchSet: 15 Gerrit-Owner: phcoder <phcoder(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: phcoder <phcoder(a)gmail.com> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Sat, 31 Jan 2026 01:30:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in pysim[master]: es9p_client: Fix type conversion in installation result notification
by laforge 31 Jan '26

31 Jan '26

laforge has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/41973?usp=email ) Change subject: es9p_client: Fix type conversion in installation result notification ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41973?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I83ad047e043dc6b3462b188ce6dd0b2cc0e52e87 Gerrit-Change-Number: 41973 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Sat, 31 Jan 2026 01:23:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in pysim[master]: pySim-trace: pySim.apdu_source.stdin_hex
by laforge 31 Jan '26

31 Jan '26

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/37925?usp=email ) Change subject: pySim-trace: pySim.apdu_source.stdin_hex ...................................................................... pySim-trace: pySim.apdu_source.stdin_hex This introduces an "APDU source" for pySim-trace which enables the decoding of APDUs that are copy+pasted from elsewhere, for example APDU logs in text form created by proprietary tools, or to decode personalization scripts or the like. Change-Id: I5aacf13b7c27cea9efd42f01dacca61068c3aa33 --- M pySim-trace.py A pySim/apdu_source/stdin_hex.py 2 files changed, 46 insertions(+), 0 deletions(-) Approvals: dexter: Looks good to me, approved; Verified laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/pySim-trace.py b/pySim-trace.py index 09e9584..0aa1e9c 100755 --- a/pySim-trace.py +++ b/pySim-trace.py @@ -23,6 +23,7 @@ from pySim.apdu_source.pyshark_rspro import PysharkRsproPcap, PysharkRsproLive from pySim.apdu_source.pyshark_gsmtap import PysharkGsmtapPcap from pySim.apdu_source.tca_loader_log import TcaLoaderLogApduSource +from pySim.apdu_source.stdin_hex import StdinHexApduSource from pySim.apdu.ts_102_221 import UiccSelect, UiccStatus @@ -190,6 +191,10 @@ parser_tcaloader_log.add_argument('-f', '--log-file', required=True, help='Name of the log file to be read') +parser_stdin_hex = subparsers.add_parser('stdin-hex', help=""" + Read APDUs as hex-string from stdin.""") + + if __name__ == '__main__': opts = option_parser.parse_args() @@ -205,6 +210,8 @@ s = PysharkGsmtapPcap(opts.pcap_file) elif opts.source == 'tca-loader-log': s = TcaLoaderLogApduSource(opts.log_file) + elif opts.source == 'stdin-hex': + s = StdinHexApduSource() else: raise ValueError("unsupported source %s", opts.source) diff --git a/pySim/apdu_source/stdin_hex.py b/pySim/apdu_source/stdin_hex.py new file mode 100644 index 0000000..67eeb7d --- /dev/null +++ b/pySim/apdu_source/stdin_hex.py @@ -0,0 +1,39 @@ +# coding=utf-8 + +# (C) 2024 by Harald Welte <laforge(a)osmocom.org> +# +# This program is free software: you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation, either version 2 of the License, or +# (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program. If not, see <http://www.gnu.org/licenses/>. + + +from pySim.utils import h2b + +from pySim.apdu.ts_102_221 import ApduCommands as UiccApduCommands +from pySim.apdu.ts_102_222 import ApduCommands as UiccAdmApduCommands +from pySim.apdu.ts_31_102 import ApduCommands as UsimApduCommands +from pySim.apdu.global_platform import ApduCommands as GpApduCommands + +from . import ApduSource, PacketType, CardReset + +ApduCommands = UiccApduCommands + UiccAdmApduCommands + UsimApduCommands + GpApduCommands + +class StdinHexApduSource(ApduSource): + """ApduSource for reading apdu hex-strings from stdin.""" + + def read_packet(self) -> PacketType: + while True: + command = input("C-APDU >") + if len(command) == 0: + continue + response = '9000' + return ApduCommands.parse_cmd_bytes(h2b(command) + h2b(response)) -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37925?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I5aacf13b7c27cea9efd42f01dacca61068c3aa33 Gerrit-Change-Number: 37925 Gerrit-PatchSet: 8 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

1 0

[XS] Change in docker-playground[master]: osmo-ns-master: drop python3-osmopy-utils / --enable-external-tests
by pespin 31 Jan '26

31 Jan '26

Attention is currently required from: fixeria, osmith. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/docker-playground/+/41996?usp=email ) Change subject: osmo-ns-master: drop python3-osmopy-utils / --enable-external-tests ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/41996?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I342099be87175dfe189a8906b53ee26328c0a417 Gerrit-Change-Number: 41996 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 30 Jan 2026 21:30:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in docker-playground[master]: osmo-ns-master: drop python3-osmopy-utils / --enable-external-tests
by fixeria 31 Jan '26

31 Jan '26

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/41996?usp=email ) Change subject: osmo-ns-master: drop python3-osmopy-utils / --enable-external-tests ...................................................................... osmo-ns-master: drop python3-osmopy-utils / --enable-external-tests --enable-external-tests requires python3-osmopy-utils, however this package is no longer available for debian:10. We're not running tests, so it's not really needed. Removing it fixes ttcn3-ns-test-fr. Change-Id: I342099be87175dfe189a8906b53ee26328c0a417 --- M osmo-ns-master/Dockerfile 1 file changed, 1 insertion(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/96/41996/1 diff --git a/osmo-ns-master/Dockerfile b/osmo-ns-master/Dockerfile index 35e360d..a76e459 100644 --- a/osmo-ns-master/Dockerfile +++ b/osmo-ns-master/Dockerfile @@ -8,7 +8,6 @@ debian*) \ apt-get update && \ apt-get install -y --no-install-recommends \ - python3-osmopy-utils \ libmnl-dev && \ apt-get clean \ ;; \ @@ -31,7 +30,7 @@ (git symbolic-ref -q HEAD && git reset --hard origin/$LIBOSMOCORE_BRANCH || exit 1); \ git rev-parse --abbrev-ref HEAD && git rev-parse HEAD && \ autoreconf -fi && \ - CONFIGURE_FLAGS="--disable-doxygen --disable-pcsc --enable-external-tests" && \ + CONFIGURE_FLAGS="--disable-doxygen --disable-pcsc" && \ if [ "$DISTRO" = "debian-buster" ]; then \ CONFIGURE_FLAGS="$CONFIGURE_FLAGS --disable-uring"; \ fi && \ -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/41996?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I342099be87175dfe189a8906b53ee26328c0a417 Gerrit-Change-Number: 41996 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[XS] Change in docker-playground[master]: ttcn3-bts-test: fail on unexpected respawn count
by pespin 31 Jan '26

31 Jan '26

pespin has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/41981?usp=email ) Change subject: ttcn3-bts-test: fail on unexpected respawn count ...................................................................... ttcn3-bts-test: fail on unexpected respawn count Suggested-by: Pau Espin Pedrol <pespin(a)sysmocom.de> Change-Id: Idd9f8dcf1a7186a0715c1026da44f404c1c574d9 --- M ttcn3-bts-test/jenkins.sh 1 file changed, 3 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve fixeria: Looks good to me, approved diff --git a/ttcn3-bts-test/jenkins.sh b/ttcn3-bts-test/jenkins.sh index 6d738c4..6f75266 100755 --- a/ttcn3-bts-test/jenkins.sh +++ b/ttcn3-bts-test/jenkins.sh @@ -279,7 +279,7 @@ docker_kill_wait ${BUILD_TAG}-bts } -show_respawn_count() { +check_respawn_count() { set +x local count=$(grep -P 'respawn: \d+: starting: ' "$VOL_BASE_DIR"/bts/osmo-bts.log | wc -l) # Currently we run generic/bts/oml configurations, which means 3 @@ -298,6 +298,7 @@ echo "================================================================" echo printf '\033[0m' + exit 1 } network_create @@ -346,4 +347,4 @@ # Show respawn count at the very end clean_up_common -show_respawn_count +check_respawn_count -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/41981?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Idd9f8dcf1a7186a0715c1026da44f404c1c574d9 Gerrit-Change-Number: 41981 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[L] Change in pysim[master]: personalization: add param_source.py, implement batch personalization
by laforge 31 Jan '26

31 Jan '26

Attention is currently required from: neels. laforge has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/40096?usp=email ) Change subject: personalization: add param_source.py, implement batch personalization ...................................................................... Patch Set 10: (3 comments) File pySim/esim/saip/param_source.py: https://gerrit.osmocom.org/c/pysim/+/40096/comment/b72f1045_0a1b2da0?usp=em… : PS10, Line 50: This is dead code. You would just write `pass` here as it is impossible to instantiate an instance of an ABC-inheriting class without overriding all the abstractmethods in that derived class. https://gerrit.osmocom.org/c/pysim/+/40096/comment/e47f088e_2679bd4c?usp=em… : PS10, Line 84: likewise here, just `pass` will do. File pySim/esim/saip/personalization.py: https://gerrit.osmocom.org/c/pysim/+/40096/comment/9c3482f5_4e1f1342?usp=em… : PS10, Line 705: def __init__(self, highly unusual formatting which we don't do this way in any other part o the code. Do we really need those kind of cosmetic experiments? Also, we use spaces between name of the parameter and the type annotation. I'm not sure why code added doesn't just by default always uses the surrounding style without any attempt to do something different. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/40096?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I497c60c101ea0eea980e8b1a4b1f36c0eda39002 Gerrit-Change-Number: 40096 Gerrit-PatchSet: 10 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Fri, 30 Jan 2026 19:38:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

2026

2025

2024

2023

2022

gerrit-log January 2026