January 2026 - gerrit-log - lists.osmocom.org

[S] Change in pysim[master]: contrib/csv-to-pgsql: add missing copyright header
by fixeria 29 Jan '26

29 Jan '26

Attention is currently required from: dexter. fixeria has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/41969?usp=email ) Change subject: contrib/csv-to-pgsql: add missing copyright header ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41969?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Iad8b2c1abb6a80764d05c823fbd03a9eae0ec0ab Gerrit-Change-Number: 41969 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 28 Jan 2026 18:27:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in pysim[master]: pySimLogger: user __name__ of the module when creating a new logger
by fixeria 29 Jan '26

29 Jan '26

Attention is currently required from: dexter, laforge. fixeria has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/41890?usp=email ) Change subject: pySimLogger: user __name__ of the module when creating a new logger ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41890?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I49a9beb98845f66247edd42ed548980c97a7151a Gerrit-Change-Number: 41890 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 28 Jan 2026 18:27:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[L] Change in libosmocore[master]: Implement log file target using osmo_io
by pespin 29 Jan '26

29 Jan '26

Attention is currently required from: fixeria, laforge, osmith. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmocore/+/41925?usp=email ) Change subject: Implement log file target using osmo_io ...................................................................... Patch Set 10: (1 comment) Patchset: PS10: I rewrote the patch to reuse log_target->wqueue->except_cb to store the osmo_io_fd, in order to avoid changing the public struct log_target... It's a hack, and I'm happy to hear about better approaches (other than the already proposed one to make the struct private). -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41925?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ieb6420246454ef59442b1fd7b1d14e2c00fa69a5 Gerrit-Change-Number: 41925 Gerrit-PatchSet: 10 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 28 Jan 2026 17:18:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in libosmocore[master]: logging_file: Clean log_target_file_reopen()
by pespin 29 Jan '26

29 Jan '26

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/41971?usp=email ) Change subject: logging_file: Clean log_target_file_reopen() ...................................................................... logging_file: Clean log_target_file_reopen() Move specific assert for wq further below. Do early return to get rid of extra indentation. Change-Id: Ibcb50320ad80b034115cccc3b7ab90501ac1d091 --- M src/core/logging_file.c 1 file changed, 19 insertions(+), 18 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/71/41971/1 diff --git a/src/core/logging_file.c b/src/core/logging_file.c index 6e01c26..078059a 100644 --- a/src/core/logging_file.c +++ b/src/core/logging_file.c @@ -52,34 +52,35 @@ struct osmo_wqueue *wq; int rc; - OSMO_ASSERT(target->type == LOG_TGT_TYPE_FILE || target->type == LOG_TGT_TYPE_STDERR); - OSMO_ASSERT(target->tgt_file.out || target->tgt_file.wqueue); + OSMO_ASSERT(target->type == LOG_TGT_TYPE_FILE || + target->type == LOG_TGT_TYPE_STDERR); if (target->type == LOG_TGT_TYPE_STDERR) return -ENOTSUP; - if (target->tgt_file.out) { + if (target->tgt_file.out) { /* stream mode */ fclose(target->tgt_file.out); target->tgt_file.out = fopen(target->tgt_file.fname, "a"); if (!target->tgt_file.out) return -errno; - } else { - wq = target->tgt_file.wqueue; - if (wq->bfd.fd >= 0) { - osmo_fd_unregister(&wq->bfd); - close(wq->bfd.fd); - wq->bfd.fd = -1; - } - - rc = open(target->tgt_file.fname, O_WRONLY|O_APPEND|O_CREAT|O_NONBLOCK, 0660); - if (rc < 0) - return -errno; - wq->bfd.fd = rc; - rc = osmo_fd_register(&wq->bfd); - if (rc < 0) - return rc; + return 0; } + OSMO_ASSERT(target->tgt_file.wqueue); + wq = target->tgt_file.wqueue; + if (wq->bfd.fd >= 0) { + osmo_fd_unregister(&wq->bfd); + close(wq->bfd.fd); + wq->bfd.fd = -1; + } + + rc = open(target->tgt_file.fname, O_WRONLY|O_APPEND|O_CREAT|O_NONBLOCK, 0660); + if (rc < 0) + return -errno; + wq->bfd.fd = rc; + rc = osmo_fd_register(&wq->bfd); + if (rc < 0) + return rc; return 0; } -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41971?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ibcb50320ad80b034115cccc3b7ab90501ac1d091 Gerrit-Change-Number: 41971 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[L] Change in libosmocore[master]: Implement log file target using osmo_io
by pespin 29 Jan '26

29 Jan '26

Attention is currently required from: osmith, pespin. Hello Jenkins Builder, osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/41925?usp=email to look at the new patch set (#10). The following approvals got outdated and were removed: Code-Review+1 by osmith, Verified+1 by Jenkins Builder Change subject: Implement log file target using osmo_io ...................................................................... Implement log file target using osmo_io Reuse (struct log_target)->tgt_file->wqueue->except_cb to store the iofd pointer internally, since we are not allowed to change the struct log_target because it's public and we don't want to break the ABI. Using the wqueue except_cb is fine since that field was never used. Related: OS#6918 Change-Id: Ieb6420246454ef59442b1fd7b1d14e2c00fa69a5 --- M src/core/logging_file.c M tests/logging/logging_test.c M tests/logging/logging_test.err 3 files changed, 152 insertions(+), 131 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/25/41925/10 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41925?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ieb6420246454ef59442b1fd7b1d14e2c00fa69a5 Gerrit-Change-Number: 41925 Gerrit-PatchSet: 10 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in libosmocore[master]: logging_file: Avoid reopning file for stderr
by pespin 29 Jan '26

29 Jan '26

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/41970?usp=email ) Change subject: logging_file: Avoid reopning file for stderr ...................................................................... logging_file: Avoid reopning file for stderr target->tgt_file.fname is NULL for stderr log target. Change-Id: I4a551b0c434c480e78852a0a4873700eac2f5853 --- M src/core/logging_file.c 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/70/41970/1 diff --git a/src/core/logging_file.c b/src/core/logging_file.c index a9a1cb7..6e01c26 100644 --- a/src/core/logging_file.c +++ b/src/core/logging_file.c @@ -55,6 +55,9 @@ OSMO_ASSERT(target->type == LOG_TGT_TYPE_FILE || target->type == LOG_TGT_TYPE_STDERR); OSMO_ASSERT(target->tgt_file.out || target->tgt_file.wqueue); + if (target->type == LOG_TGT_TYPE_STDERR) + return -ENOTSUP; + if (target->tgt_file.out) { fclose(target->tgt_file.out); target->tgt_file.out = fopen(target->tgt_file.fname, "a"); -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41970?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I4a551b0c434c480e78852a0a4873700eac2f5853 Gerrit-Change-Number: 41970 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in pysim[master]: contrib/csv-to-pgsql: add missing copyright header
by dexter 29 Jan '26

29 Jan '26

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/41969?usp=email ) Change subject: contrib/csv-to-pgsql: add missing copyright header ...................................................................... contrib/csv-to-pgsql: add missing copyright header Change-Id: Iad8b2c1abb6a80764d05c823fbd03a9eae0ec0ab --- M contrib/csv-to-pgsql.py 1 file changed, 18 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/69/41969/1 diff --git a/contrib/csv-to-pgsql.py b/contrib/csv-to-pgsql.py index dad408d..416d870 100755 --- a/contrib/csv-to-pgsql.py +++ b/contrib/csv-to-pgsql.py @@ -1,5 +1,23 @@ #!/usr/bin/env python3 +# (C) 2025 by sysmocom - s.f.m.c. GmbH +# All Rights Reserved +# +# Author: Philipp Maier +# +# This program is free software: you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation, either version 2 of the License, or +# (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program. If not, see <http://www.gnu.org/licenses/>. + import argparse import logging import csv -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41969?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Iad8b2c1abb6a80764d05c823fbd03a9eae0ec0ab Gerrit-Change-Number: 41969 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de>

1 0

[M] Change in osmo-ttcn3-hacks[master]: BSSAP_LE_Emulation: Handle N-PCSTATE.ind to wait for peer availability
by pespin 29 Jan '26

29 Jan '26

Attention is currently required from: pespin. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41967?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: BSSAP_LE_Emulation: Handle N-PCSTATE.ind to wait for peer availability ...................................................................... BSSAP_LE_Emulation: Handle N-PCSTATE.ind to wait for peer availability Take the chance to explicitly log and discard other .ind primitives which would otherwise block the processing of messages. Related: OS#6907 Change-Id: I6a40d1ddcd3a7dbde9f6c8b51439e9ab4d1da469 --- M library/BSSAP_LE_CodecPort.ttcn M library/BSSAP_LE_Emulation.ttcn 2 files changed, 67 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/67/41967/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41967?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I6a40d1ddcd3a7dbde9f6c8b51439e9ab4d1da469 Gerrit-Change-Number: 41967 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in osmo-ttcn3-hacks[master]: RAN_Emulation: Handle N-PCSTATE.ind to wait for peer availability
by pespin 29 Jan '26

29 Jan '26

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41968?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: RAN_Emulation: Handle N-PCSTATE.ind to wait for peer availability ...................................................................... RAN_Emulation: Handle N-PCSTATE.ind to wait for peer availability Take the chance to explicitly log and discard other .ind primitives which would otherwise block the processing of messages. Change-Id: I86b481fca9b7be84f3cda9fbce83e60820fe7fc1 Related: OS#6907 --- M bsc/BSC_Tests.ttcn M library/BSSAP_CodecPort.ttcn M library/RAN_Emulation.ttcnpp M library/ranap/RANAP_CodecPort.ttcn M msc/MSC_Tests.ttcn 5 files changed, 139 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/68/41968/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41968?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I86b481fca9b7be84f3cda9fbce83e60820fe7fc1 Gerrit-Change-Number: 41968 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder

1 0

[XS] Change in osmo-ttcn3-hacks[master]: cosmetic: library/BSSAP_CodecPort.ttcn: Fix trailing whitespace
by pespin 29 Jan '26

29 Jan '26

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41965?usp=email ) Change subject: cosmetic: library/BSSAP_CodecPort.ttcn: Fix trailing whitespace ...................................................................... cosmetic: library/BSSAP_CodecPort.ttcn: Fix trailing whitespace Change-Id: I3bbb035eda0690a862989a0ec4bda265b506db3a --- M library/BSSAP_CodecPort.ttcn 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/65/41965/1 diff --git a/library/BSSAP_CodecPort.ttcn b/library/BSSAP_CodecPort.ttcn index 2bb6ab6..ce9248e 100644 --- a/library/BSSAP_CodecPort.ttcn +++ b/library/BSSAP_CodecPort.ttcn @@ -354,7 +354,7 @@ } with {extension "prototype(fast)" } -/* +/* type port BSSAP_CODEC_PT message map to SCCPasp_PT { out BSSAP_N_CONNECT_req to ASP_SCCP_N_CONNECT_req with f_enc_ConnectReq(), BSSAP_N_CONNECT_res to ASP_SCCP_N_CONNECT_res with f_enc_ConnectRes(), -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41965?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I3bbb035eda0690a862989a0ec4bda265b506db3a Gerrit-Change-Number: 41965 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

2026

2025

2024

2023

2022

gerrit-log January 2026