January 2026 - gerrit-log - lists.osmocom.org

[XS] Change in osmo-dev[master]: sanitize.opts: Add osmocom-bb_{layer23,trxcon,virtphy}
by pespin 07 Jan '26

07 Jan '26

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-dev/+/41774?usp=email ) Change subject: sanitize.opts: Add osmocom-bb_{layer23,trxcon,virtphy} ...................................................................... sanitize.opts: Add osmocom-bb_{layer23,trxcon,virtphy} Change-Id: I89dc9c7da4d560162a77414412fb5edfb9d594ed --- M sanitize.opts 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-dev refs/changes/74/41774/1 diff --git a/sanitize.opts b/sanitize.opts index 1936e44..d9c4bf6 100644 --- a/sanitize.opts +++ b/sanitize.opts @@ -24,4 +24,7 @@ osmo-hnbgw --enable-sanitize osmo-gsm-shark --enable-sanitize osmo-uecups --enable-sanitize +osmocom-bb_layer23 --enable-sanitize +osmocom-bb_trxcon --enable-sanitize +osmocom-bb_virtphy --enable-sanitize upf-benchmark --enable-sanitize -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/41774?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: I89dc9c7da4d560162a77414412fb5edfb9d594ed Gerrit-Change-Number: 41774 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[L] Change in osmo-e1d[master]: Add Channel-Associated Signalling (CAS) support
by pespin 07 Jan '26

07 Jan '26

Attention is currently required from: jolly, tnt. pespin has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmo-e1d/+/41139?usp=email ) Change subject: Add Channel-Associated Signalling (CAS) support ...................................................................... Patch Set 3: (2 comments) File include/osmocom/e1d/proto_clnt.h: https://gerrit.osmocom.org/c/osmo-e1d/+/41139/comment/6a907233_2071e31c?usp… : PS3, Line 47: int osmo_e1dp_client_set_cas(struct osmo_e1dp_client *clnt, uint8_t intf, uint8_t line, uint8_t ts, Update TODO-RELEASE with an entry stating a new API is added. File src/ctl.c: https://gerrit.osmocom.org/c/osmo-e1d/+/41139/comment/f4ab51f8_056fea00?usp… : PS3, Line 382: if (line->ts[16].mode == E1_TS_MODE_CAS && hdr->ts == 16) { maybe not important, but sounds safer first checking hdr->ts and then accessing line->ts. -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/41139?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: Ib4f5e6ef02c9b0d1eec2a86d9c48376112805972 Gerrit-Change-Number: 41139 Gerrit-PatchSet: 3 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: tnt <tnt(a)246tNt.com> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: tnt <tnt(a)246tNt.com> Gerrit-Comment-Date: Wed, 07 Jan 2026 11:20:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in libosmo-abis[master]: Add CAS channel support
by pespin 07 Jan '26

07 Jan '26

Attention is currently required from: jolly. pespin has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/libosmo-abis/+/41140?usp=email ) Change subject: Add CAS channel support ...................................................................... Patch Set 2: Code-Review-1 (2 comments) File include/osmocom/abis/e1_input.h: https://gerrit.osmocom.org/c/libosmo-abis/+/41140/comment/723a603b_95194d6d… : PS2, Line 197: int (*set_cas)(struct e1inp_ts *ts, uint8_t bits, bool query_rx); You are breaking ABI here, see: ../osmo-bsc/src/ipaccess/ipaccess-config-e1-driver.c 453:static struct e1inp_driver ipaccess_config_driver = { So at least set the field at the end of the struct, and remember to add a TODO-RELEASE entry specifying ABI break of libosmoabis. https://gerrit.osmocom.org/c/libosmo-abis/+/41140/comment/619c8865_56cc14fd… : PS2, Line 414: uint8_t cas; ABI break, you must at least put this at the end of the struct and mention it in TODO-RELEASE, see accesses in: ../openbsc/openbsc/src/libbsc/bsc_init.c 342: struct input_signal_data *isd = signal_data; ../openbsc/openbsc/src/libbsc/bts_ericsson_rbs2000.c 111: struct input_signal_data *isd = signal_data; ../openbsc/openbsc/src/libbsc/bts_nokia_site.c 144: struct input_signal_data *isd = signal_data; ../openbsc/openbsc/src/libbsc/bts_siemens_bs11.c 566: struct input_signal_data *isd = signal_data; ../osmo-bsc/src/ipaccess/ipaccess-config.c 373: struct input_signal_data *isd = signal_data; ../osmo-bsc/src/ipaccess/ipaccess-config-e1-driver.c 80: struct input_signal_data isd; ../osmo-bsc/src/osmo-bsc/bts_ericsson_rbs2000.c 113: struct input_signal_data *isd = signal_data; ../osmo-bsc/src/osmo-bsc/bts_nokia_site.c 155: struct input_signal_data *isd = signal_data; ../osmo-bsc/src/osmo-bsc/bts_siemens_bs11.c 518: struct input_signal_data *isd = signal_data; ../osmo-bsc/src/osmo-bsc/osmo_bsc_main.c 455: struct input_signal_data *isd = signal_data; ../osmo-bts/src/common/abis.c 490: struct input_signal_data *isd = signal_data; Specially important this user of the struct, I at least improved it a bit by zero-initializing the struct here: https://gerrit.osmocom.org/c/osmo-bsc/+/41773 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/41140?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I81cc89e01bb4207dc899ab28f24a131f24b61c9c Gerrit-Change-Number: 41140 Gerrit-PatchSet: 2 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Wed, 07 Jan 2026 11:11:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-bsc[master]: ipaccess-config-e1-driver: Make sure struct input_signal_data is zero...
by pespin 07 Jan '26

07 Jan '26

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/41773?usp=email ) Change subject: ipaccess-config-e1-driver: Make sure struct input_signal_data is zero initialized ...................................................................... ipaccess-config-e1-driver: Make sure struct input_signal_data is zero initialized Change-Id: If97c4a4202eaf96446d48e821d5e59c98bafe51c --- M src/ipaccess/ipaccess-config-e1-driver.c 1 file changed, 8 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/73/41773/1 diff --git a/src/ipaccess/ipaccess-config-e1-driver.c b/src/ipaccess/ipaccess-config-e1-driver.c index 631e430..8164642 100644 --- a/src/ipaccess/ipaccess-config-e1-driver.c +++ b/src/ipaccess/ipaccess-config-e1-driver.c @@ -77,13 +77,14 @@ static int e1inp_int_snd_event(struct e1inp_ts *ts, struct e1inp_sign_link *link, int evt) { - struct input_signal_data isd; - isd.line = ts->line; - isd.ts_nr = ts->num; - isd.link_type = link->type; - isd.trx = link->trx; - isd.tei = link->tei; - isd.sapi = link->sapi; + struct input_signal_data isd = { + .line = ts->line, + .ts_nr = ts->num, + .link_type = link->type, + .trx = link->trx, + .tei = link->tei, + .sapi = link->sapi, + }; /* report further upwards */ osmo_signal_dispatch(SS_L_INPUT, evt, &isd); -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/41773?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: If97c4a4202eaf96446d48e821d5e59c98bafe51c Gerrit-Change-Number: 41773 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in ...osmo-s1gw[master]: enb_proxy: add inital MME pooling support
by pespin 07 Jan '26

07 Jan '26

Attention is currently required from: fixeria, osmith. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41624?usp=email ) Change subject: enb_proxy: add inital MME pooling support ...................................................................... Patch Set 5: (2 comments) File src/enb_proxy.erl: https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41624/comment/250afca7_e0d4… : PS5, Line 198: close_sock(S), I wonder why do we close and reconnect here... shouldn't we wait until timeout? https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41624/comment/44908d9a_fd3f… : PS5, Line 299: %% XXX: sctp_send_from_mme(Data, S), what about this? -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41624?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I83dc4a78c78a7b87e87f5ca9a941a168d6c1dc36 Gerrit-Change-Number: 41624 Gerrit-PatchSet: 5 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 07 Jan 2026 10:59:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[M] Change in ...osmo-s1gw[master]: s1ap_utils: add API for building S1 SETUP FAILURE PDU
by pespin 07 Jan '26

07 Jan '26

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41762?usp=email ) Change subject: s1ap_utils: add API for building S1 SETUP FAILURE PDU ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41762?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I5a4e060e0a2ebdfbcfafac42f9de2e49ac3583b8 Gerrit-Change-Number: 41762 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 07 Jan 2026 10:55:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in ...osmo-s1gw[master]: s1ap_utils_test: fix: expected value goes first
by pespin 07 Jan '26

07 Jan '26

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41761?usp=email ) Change subject: s1ap_utils_test: fix: expected value goes first ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41761?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: Ib7c6478b95a78c9797e86180a89c098e75b615e0 Gerrit-Change-Number: 41761 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 07 Jan 2026 10:52:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[L] Change in ...osmo-s1gw[master]: [REST] Add MmeList, MmeAdd, MmeInfo, MmeDelete
by pespin 07 Jan '26

07 Jan '26

Attention is currently required from: fixeria, osmith. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41282?usp=email ) Change subject: [REST] Add MmeList, MmeAdd, MmeInfo, MmeDelete ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41282?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: Iad249aed99face9e35fd19e0596cf2364ade4c77 Gerrit-Change-Number: 41282 Gerrit-PatchSet: 5 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 07 Jan 2026 10:52:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in ...osmo-s1gw[master]: s1ap_proxy: improve per-eNB counter reg/inc API
by pespin 07 Jan '26

07 Jan '26

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41759?usp=email ) Change subject: s1ap_proxy: improve per-eNB counter reg/inc API ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41759?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I2244190d0640209f8a2d4d78e5b64db580aa863d Gerrit-Change-Number: 41759 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 07 Jan 2026 10:49:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[L] Change in ...osmo-s1gw[master]: mme_registry: the MME registry (pool) implementation
by pespin 07 Jan '26

07 Jan '26

Attention is currently required from: fixeria, osmith. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41281?usp=email ) Change subject: mme_registry: the MME registry (pool) implementation ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41281?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: Id5480222439bf93eca2e994b291c619dff823b01 Gerrit-Change-Number: 41281 Gerrit-PatchSet: 5 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 07 Jan 2026 10:48:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

2026

2025

2024

2023

2022

gerrit-log January 2026