January 2026 - gerrit-log - lists.osmocom.org

[XS] Change in osmo-bts[master]: {bs,ms}_power_control: Reset state during lchan deactivation
by dexter 09 Jan '26

09 Jan '26

Attention is currently required from: pespin. dexter has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-bts/+/41793?usp=email ) Change subject: {bs,ms}_power_control: Reset state during lchan deactivation ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/41793?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I0c247414d27d7ac636c6dbb294b0dd3bffc4ed97 Gerrit-Change-Number: 41793 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 09 Jan 2026 16:52:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-bts[master]: {bs,ms}_power_control: Add helper function to reset state
by dexter 09 Jan '26

09 Jan '26

Attention is currently required from: pespin. dexter has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-bts/+/41792?usp=email ) Change subject: {bs,ms}_power_control: Add helper function to reset state ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Patchset: PS1: I have looked through this, everything looks good. The patch should not alter the behavior of the code. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/41792?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I3e010a4ed72ba2574ce6c1316b8460689fc1d482 Gerrit-Change-Number: 41792 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 09 Jan 2026 16:51:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-bts[master]: ta_control: Fix skip_block_num not reset when switching TS to PDCH
by dexter 09 Jan '26

09 Jan '26

Attention is currently required from: jolly, laforge, pespin. dexter has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-bts/+/41790?usp=email ) Change subject: ta_control: Fix skip_block_num not reset when switching TS to PDCH ...................................................................... Patch Set 2: Code-Review+1 (3 comments) Patchset: PS2: I have looked through the code, it does what the commit message says. File include/osmo-bts/ta_control.h: https://gerrit.osmocom.org/c/osmo-bts/+/41790/comment/1d3b0fc3_82c0e4d6?usp… : PS2, Line 6: maybe remove the line break? File src/common/ta_control.c: https://gerrit.osmocom.org/c/osmo-bts/+/41790/comment/7d3451b5_d3037c8d?usp… : PS2, Line 47: /* Trigger loop on first TA input: */ Maybe put this comment above the function? (I guess both assignments are required for the trigger) -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/41790?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Id3e81ebec04042dd7d8e4805762e3e518790706d Gerrit-Change-Number: 41790 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 09 Jan 2026 16:41:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-bts[master]: ta_control: Move skip_block logic to helper function
by dexter 09 Jan '26

09 Jan '26

Attention is currently required from: pespin. dexter has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-bts/+/41787?usp=email ) Change subject: ta_control: Move skip_block logic to helper function ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/41787?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I174f2f941fbedbe0793cc0b93d01e53e23328cf2 Gerrit-Change-Number: 41787 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 09 Jan 2026 16:35:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-bts[master]: ta_control: Move variable declaration to the top of the function
by dexter 09 Jan '26

09 Jan '26

Attention is currently required from: pespin. dexter has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-bts/+/41788?usp=email ) Change subject: ta_control: Move variable declaration to the top of the function ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/41788?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ia5ada61d74f5b17c4d1479123462104650a6ed0f Gerrit-Change-Number: 41788 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 09 Jan 2026 16:33:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-bts[master]: ta_control: Add missing include for lchan.h
by dexter 09 Jan '26

09 Jan '26

Attention is currently required from: pespin. dexter has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-bts/+/41789?usp=email ) Change subject: ta_control: Add missing include for lchan.h ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/41789?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Iea1f7ed303ebd0c12a48bb3edf73a494b8736a39 Gerrit-Change-Number: 41789 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 09 Jan 2026 16:30:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in pysim[master]: runtime/cosmetic: add line break
by dexter 09 Jan '26

09 Jan '26

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/41811?usp=email ) Change subject: runtime/cosmetic: add line break ...................................................................... runtime/cosmetic: add line break The other source files have a line break between the character encoding qualifier line and the python comment. Let's add a line break here as well to maintain consistency. Change-Id: Ied6b77eede748f1ddf6fde17c9b434fa4dd1114a --- M pySim/runtime.py 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/11/41811/1 diff --git a/pySim/runtime.py b/pySim/runtime.py index 35452a0..19d3538 100644 --- a/pySim/runtime.py +++ b/pySim/runtime.py @@ -1,4 +1,5 @@ # coding=utf-8 + """Representation of the runtime state of an application like pySim-shell. """ -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41811?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ied6b77eede748f1ddf6fde17c9b434fa4dd1114a Gerrit-Change-Number: 41811 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de>

1 0

[S] Change in pysim[master]: transport/init/cosmetic: move copryight header to the top
by dexter 09 Jan '26

09 Jan '26

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/41810?usp=email ) Change subject: transport/init/cosmetic: move copryight header to the top ...................................................................... transport/init/cosmetic: move copryight header to the top The copyright header seems to be misplaced, let's move it to the top. Change-Id: I8358cca3bc9adb5a186a8b38a3bd90d7aec60d5c --- M pySim/transport/__init__.py 1 file changed, 10 insertions(+), 13 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/10/41810/1 diff --git a/pySim/transport/__init__.py b/pySim/transport/__init__.py index 099b018..f82f4df 100644 --- a/pySim/transport/__init__.py +++ b/pySim/transport/__init__.py @@ -3,18 +3,6 @@ """ pySim: PCSC reader transport link base """ -import os -import abc -import argparse -from typing import Optional, Tuple -from construct import Construct -from osmocom.utils import b2h, h2b, i2h, Hexstr - -from pySim.exceptions import * -from pySim.utils import SwHexstr, SwMatchstr, ResTuple, sw_match, parse_command_apdu -from pySim.cat import ProactiveCommand, CommandDetails, DeviceIdentities, Result - -# # Copyright (C) 2009-2010 Sylvain Munaut <tnt(a)246tNt.com> # Copyright (C) 2021-2023 Harald Welte <laforge(a)osmocom.org> # @@ -30,8 +18,17 @@ # # You should have received a copy of the GNU General Public License # along with this program. If not, see <http://www.gnu.org/licenses/>. -# +import os +import abc +import argparse +from typing import Optional, Tuple +from construct import Construct +from osmocom.utils import b2h, h2b, i2h, Hexstr + +from pySim.exceptions import * +from pySim.utils import SwHexstr, SwMatchstr, ResTuple, sw_match, parse_command_apdu +from pySim.cat import ProactiveCommand, CommandDetails, DeviceIdentities, Result class ApduTracer: def trace_command(self, cmd): -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41810?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I8358cca3bc9adb5a186a8b38a3bd90d7aec60d5c Gerrit-Change-Number: 41810 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de>

1 0

[S] Change in pysim[master]: transport/init: use PySimLogger to print messages
by dexter 09 Jan '26

09 Jan '26

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/41812?usp=email ) Change subject: transport/init: use PySimLogger to print messages ...................................................................... transport/init: use PySimLogger to print messages The module still uses print to output information. Let's replace those print calls with the more modern PySimLogger method calls. Change-Id: I2e2ec2b84f3b84dbd8a029ae9bb64b7a96ddbde3 --- M pySim/transport/__init__.py 1 file changed, 11 insertions(+), 8 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/12/41812/1 diff --git a/pySim/transport/__init__.py b/pySim/transport/__init__.py index f82f4df..39c9886 100644 --- a/pySim/transport/__init__.py +++ b/pySim/transport/__init__.py @@ -29,6 +29,9 @@ from pySim.exceptions import * from pySim.utils import SwHexstr, SwMatchstr, ResTuple, sw_match, parse_command_apdu from pySim.cat import ProactiveCommand, CommandDetails, DeviceIdentities, Result +from pySim.log import PySimLogger + +log = PySimLogger.get("TRANSPORT") class ApduTracer: def trace_command(self, cmd): @@ -43,11 +46,11 @@ class StdoutApduTracer(ApduTracer): """Minimalistic APDU tracer, printing commands to stdout.""" def trace_response(self, cmd, sw, resp): - print("-> %s %s" % (cmd[:10], cmd[10:])) - print("<- %s: %s" % (sw, resp)) + log.info("-> %s %s" % (cmd[:10], cmd[10:])) + log.info("<- %s: %s" % (sw, resp)) def trace_reset(self): - print("-- RESET") + log.info("-- RESET") class ProactiveHandler(abc.ABC): """Abstract base class representing the interface of some code that handles @@ -174,7 +177,7 @@ if self.apdu_strict: raise ValueError(exeption_str) else: - print('Warning: %s' % exeption_str) + log.warning(exeption_str) return (data, sw) @@ -208,7 +211,7 @@ # parse the proactive command pcmd = ProactiveCommand() parsed = pcmd.from_tlv(h2b(fetch_rv[0])) - print("FETCH: %s (%s)" % (fetch_rv[0], type(parsed).__name__)) + log.info("FETCH: %s (%s)" % (fetch_rv[0], type(parsed).__name__)) if self.proactive_handler: # Extension point: If this does return a list of TLV objects, # they could be appended after the Result; if the first is a @@ -358,13 +361,13 @@ from pySim.transport.modem_atcmd import ModemATCommandLink sl = ModemATCommandLink(opts, **kwargs) else: # Serial reader is default - print("No reader/driver specified; falling back to default (Serial reader)") + log.warning("No reader/driver specified; falling back to default (Serial reader)") from pySim.transport.serial import SerialSimLink sl = SerialSimLink(opts, **kwargs) if os.environ.get('PYSIM_INTEGRATION_TEST') == "1": - print("Using %s reader interface" % (sl.name)) + log.info("Using %s reader interface" % (sl.name)) else: - print("Using reader %s" % sl) + log.info("Using reader %s" % sl) return sl -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41812?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I2e2ec2b84f3b84dbd8a029ae9bb64b7a96ddbde3 Gerrit-Change-Number: 41812 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de>

1 0

[S] Change in android-apdu-proxy[master]: OmapiCallbackHandlerVpcd: pass SELECT parameter P2 to OMAPI
by dexter 09 Jan '26

09 Jan '26

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/android-apdu-proxy/+/41805?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: OmapiCallbackHandlerVpcd: pass SELECT parameter P2 to OMAPI ...................................................................... OmapiCallbackHandlerVpcd: pass SELECT parameter P2 to OMAPI The OMAPI method openLogicalChannel may take an optional parameter p2, This parameter. Among other function, this paramter in particular controls how to deal with short DF-Names that match the AIDs of several applications. Since we always know this parameter from the TPDU that we receive from VPCD, let's pass it on to OMAPI when we create a new channel. Related: OS#6836 Change-Id: Ibab2cc197284e6177a83338007a0b7f77e0ab8b9 --- M app/src/main/java/org/osmocom/androidApduProxy/Omapi.java M app/src/main/java/org/osmocom/androidApduProxy/OmapiCallbackHandlerVpcd.java 2 files changed, 14 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/android-apdu-proxy refs/changes/05/41805/2 -- To view, visit https://gerrit.osmocom.org/c/android-apdu-proxy/+/41805?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: android-apdu-proxy Gerrit-Branch: master Gerrit-Change-Id: Ibab2cc197284e6177a83338007a0b7f77e0ab8b9 Gerrit-Change-Number: 41805 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder

1 0

2026

2025

2024

2023

2022

gerrit-log January 2026