September 2025 - gerrit-log - lists.osmocom.org

[M] Change in osmo-bts[master]: TCH UL path: add out-of-band BFI flag

by pespin

Attention is currently required from: dexter, falconia, fixeria. pespin has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/osmo-bts/+/41047?usp=email ) Change subject: TCH UL path: add out-of-band BFI flag ...................................................................... Patch Set 1: (3 comments) File include/osmo-bts/msg_utils.h: https://gerrit.osmocom.org/c/osmo-bts/+/41047/comment/e50ff293_01f8f716?usp… : PS1, Line 27: /* Accessor macros for control buffer words in RTP input path */ Can you add a a bit more framing to clearly separate the 2 groups of cb fields? eg: /**************************************************************** * Accessor macros for control buffer words in RTP input path (DL) *****************************************************************/ https://gerrit.osmocom.org/c/osmo-bts/+/41047/comment/58b8fd84_39ba8749?usp… : PS1, Line 39: #define tch_ul_msg_bfi(x) ((x)->cb[0]) I wonder whether this is a boolean, a flag, or an integer. File src/common/l1sap.c: https://gerrit.osmocom.org/c/osmo-bts/+/41047/comment/1fe57ebe_1de536f3?usp… : PS1, Line 2229: teh = 0xE0 | (tch_ul_msg_bfi(msg) << 1); and this kind of operation together with "I wonder whether this is a boolean, a flag, or an integer." comment makes it even more disturbing ;) EDIT: Ok, I see from below ("= true") that this is a boolean. Hence, I'd prefer to keep the assigning logic here as it was before, instead of shifting a boolean. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/41047?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I8097946429e83eae90f89e49d17ffb8eb0636fcb Gerrit-Change-Number: 41047 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Fri, 05 Sep 2025 12:45:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

2 weeks, 3 days

1
0
0 0

[XS] Change in libosmocore[master]: gsm_04_08: add GSM48_BCAP_RRQ_SPARE_NETWORK_TO_MS

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/libosmocore/+/41056?usp=email ) Change subject: gsm_04_08: add GSM48_BCAP_RRQ_SPARE_NETWORK_TO_MS ...................................................................... Patch Set 2: Code-Review+1 (1 comment) File include/osmocom/gsm/protocol/gsm_04_08.h: https://gerrit.osmocom.org/c/libosmocore/+/41056/comment/cef4f27e_ea7a3c5c?… : PS1, Line 2158: /* GSM 04.08 Table 10.72: In network to MS direction, the network must send > This kind of approach is usually placed inside the enum to quickly see it's related to it: […] It was rather close to that enum and the same prefix suggests the relation? Anyways, I am not opposed to having it inside of the enum. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41056?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I97101c977104eae82e4850d40f9abd15aa03e33e Gerrit-Change-Number: 41056 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 05 Sep 2025 12:38:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

2 weeks, 3 days

1
0
0 0

[XS] Change in libosmocore[master]: gsm_04_08: add GSM48_BCAP_RRQ_SPARE_NETWORK_TO_MS

by osmith

Attention is currently required from: fixeria, pespin. osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/libosmocore/+/41056?usp=email ) Change subject: gsm_04_08: add GSM48_BCAP_RRQ_SPARE_NETWORK_TO_MS ...................................................................... Patch Set 2: (1 comment) File include/osmocom/gsm/protocol/gsm_04_08.h: https://gerrit.osmocom.org/c/libosmocore/+/41056/comment/77b82491_d16ef9f2?… : PS1, Line 2158: /* GSM 04.08 Table 10.72: In network to MS direction, the network must send > This kind of approach is usually placed inside the enum to quickly see it's related to it: […] Done -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41056?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I97101c977104eae82e4850d40f9abd15aa03e33e Gerrit-Change-Number: 41056 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 05 Sep 2025 12:37:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

2 weeks, 3 days

1
0
0 0

[L] Change in ...osmo-python-tests[master]: Drop osmopy/twisted_ipa.py and scripts/{ctrl2cgi.py,soap.py}

by osmith

Attention is currently required from: fixeria. osmith has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/python/osmo-python-tests/+/41055?usp=email ) Change subject: Drop osmopy/twisted_ipa.py and scripts/{ctrl2cgi.py,soap.py} ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/python/osmo-python-tests/+/41055?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: python/osmo-python-tests Gerrit-Branch: master Gerrit-Change-Id: I848f60270dd683a56f56117c328d9961ac678d4b Gerrit-Change-Number: 41055 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 05 Sep 2025 12:37:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

2 weeks, 3 days

1
0
0 0

[XS] Change in ...osmo-python-tests[master]: debian: install /etc/osmocom/osmo-trap2cgi.ini

by osmith

Attention is currently required from: fixeria. osmith has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/python/osmo-python-tests/+/41054?usp=email ) Change subject: debian: install /etc/osmocom/osmo-trap2cgi.ini ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/python/osmo-python-tests/+/41054?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: python/osmo-python-tests Gerrit-Branch: master Gerrit-Change-Id: I6251364e36c691b7a8348c4adc4ee34ff141bca6 Gerrit-Change-Number: 41054 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 05 Sep 2025 12:36:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

2 weeks, 3 days

1
0
0 0

[S] Change in ...osmo-python-tests[master]: debian: add python3-osmopy-{libs,utils}.install

by osmith

Attention is currently required from: fixeria. osmith has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/python/osmo-python-tests/+/41053?usp=email ) Change subject: debian: add python3-osmopy-{libs,utils}.install ...................................................................... Patch Set 1: (1 comment) File debian/python3-osmopy-libs.install: https://gerrit.osmocom.org/c/python/osmo-python-tests/+/41053/comment/ad79f… : PS1, Line 1: usr/lib why is this file needed? looks like the contents of the -libs package stays the same, see end of: * https://jenkins.osmocom.org/jenkins/job/gerrit-binpkgs/17646/consoleFull * https://jenkins.osmocom.org/jenkins/job/gerrit-binpkgs/17644/consoleFull -- To view, visit https://gerrit.osmocom.org/c/python/osmo-python-tests/+/41053?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: python/osmo-python-tests Gerrit-Branch: master Gerrit-Change-Id: I94b940789e138341792f40eedeedb73d4e4d421e Gerrit-Change-Number: 41053 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 05 Sep 2025 12:36:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

2 weeks, 3 days

1
0
0 0

[L] Change in ...osmo-python-tests[master]: Drop osmopy/twisted_ipa.py and scripts/{ctrl2cgi.py,soap.py}

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/python/osmo-python-tests/+/41055?usp=email ) Change subject: Drop osmopy/twisted_ipa.py and scripts/{ctrl2cgi.py,soap.py} ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/python/osmo-python-tests/+/41055?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: python/osmo-python-tests Gerrit-Branch: master Gerrit-Change-Id: I848f60270dd683a56f56117c328d9961ac678d4b Gerrit-Change-Number: 41055 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 05 Sep 2025 12:34:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

2 weeks, 3 days

1
0
0 0

[XS] Change in ...osmo-python-tests[master]: debian: install /etc/osmocom/osmo-trap2cgi.ini

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/python/osmo-python-tests/+/41054?usp=email ) Change subject: debian: install /etc/osmocom/osmo-trap2cgi.ini ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/python/osmo-python-tests/+/41054?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: python/osmo-python-tests Gerrit-Branch: master Gerrit-Change-Id: I6251364e36c691b7a8348c4adc4ee34ff141bca6 Gerrit-Change-Number: 41054 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 05 Sep 2025 12:33:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

2 weeks, 3 days

1
0
0 0

[S] Change in ...osmo-python-tests[master]: debian: add python3-osmopy-{libs,utils}.install

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/python/osmo-python-tests/+/41053?usp=email ) Change subject: debian: add python3-osmopy-{libs,utils}.install ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: I'm lacking context here on *why* are you doing this or is this needed, please add some commit description so I can understand. -- To view, visit https://gerrit.osmocom.org/c/python/osmo-python-tests/+/41053?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: python/osmo-python-tests Gerrit-Branch: master Gerrit-Change-Id: I94b940789e138341792f40eedeedb73d4e4d421e Gerrit-Change-Number: 41053 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 05 Sep 2025 12:32:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

2 weeks, 3 days

1
0
0 0

[XS] Change in ...osmo-python-tests[master]: debian: python3-osmopy-utils does not need python3-treq

by osmith

Attention is currently required from: fixeria. osmith has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/python/osmo-python-tests/+/41052?usp=email ) Change subject: debian: python3-osmopy-utils does not need python3-treq ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/python/osmo-python-tests/+/41052?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: python/osmo-python-tests Gerrit-Branch: master Gerrit-Change-Id: I8a36109de244efaaa40bf5ac309bd5061cf0596d Gerrit-Change-Number: 41052 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 05 Sep 2025 12:32:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

2 weeks, 3 days

1
0
0 0

2025

2024

2023

2022

gerrit-log September 2025