September 2025 - gerrit-log - lists.osmocom.org

[M] Change in osmo-msc[master]: gsm48_cc_tx_setup_set_bearer_cap: split out

by fixeria

Attention is currently required from: osmith, pespin. fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-msc/+/41040?usp=email ) Change subject: gsm48_cc_tx_setup_set_bearer_cap: split out ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/41040?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I3fe6bb2af90d729bb32cae8f5a1a38dcf8f87eb9 Gerrit-Change-Number: 41040 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 05 Sep 2025 11:09:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

2 weeks, 3 days

1
0
0 0

[M] Change in osmo-msc[master]: gsm48_cc_tx_setup_select_codecs: split out

by fixeria

Attention is currently required from: osmith, pespin. fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-msc/+/41039?usp=email ) Change subject: gsm48_cc_tx_setup_select_codecs: split out ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/41039?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ic502f9ed77ea57de4cf6d362c0e7070d9147d6f3 Gerrit-Change-Number: 41039 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 05 Sep 2025 11:08:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

2 weeks, 3 days

1
0
0 0

[XS] Change in osmo-msc[master]: gsm48_cc_tx_setup_set_transaction_id: tweak error msg

by fixeria

Attention is currently required from: osmith. fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-msc/+/41057?usp=email ) Change subject: gsm48_cc_tx_setup_set_transaction_id: tweak error msg ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/41057?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I4007e99b6abd9b2e05945ccdedaac185a2aea19e Gerrit-Change-Number: 41057 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 05 Sep 2025 11:08:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

2 weeks, 3 days

1
0
0 0

[M] Change in osmo-msc[master]: gsm48_cc_tx_setup_set_transaction_id: split out

by fixeria

Attention is currently required from: osmith, pespin. fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-msc/+/41038?usp=email ) Change subject: gsm48_cc_tx_setup_set_transaction_id: split out ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/41038?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I715f12d09570211a98b667c56960309bd326e8d8 Gerrit-Change-Number: 41038 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 05 Sep 2025 11:07:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

2 weeks, 3 days

1
0
0 0

[S] Change in libosmo-asn1-tcap[master]: configure: add --enable-werror, --enable-sanitize

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/41025?usp=email ) ( 3 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: configure: add --enable-werror, --enable-sanitize ...................................................................... configure: add --enable-werror, --enable-sanitize Change-Id: I089b72068c095b9c88eb72970a9e691da3673ddf --- M configure.ac 1 file changed, 26 insertions(+), 0 deletions(-) Approvals: osmith: Verified laforge: Looks good to me, approved pespin: Looks good to me, approved diff --git a/configure.ac b/configure.ac index fc359c2..f6db329 100644 --- a/configure.ac +++ b/configure.ac @@ -27,6 +27,32 @@ CFLAGS="$saved_CFLAGS" AC_SUBST(SYMBOL_VISIBILITY) +AC_ARG_ENABLE(sanitize, + [AS_HELP_STRING( + [--enable-sanitize], + [Compile with address sanitizer enabled], + )], + [sanitize=$enableval], [sanitize="no"]) +if test x"$sanitize" = x"yes" +then + CFLAGS="$CFLAGS -fsanitize=address -fsanitize=undefined" + CPPFLAGS="$CPPFLAGS -fsanitize=address -fsanitize=undefined" +fi + +AC_ARG_ENABLE(werror, + [AS_HELP_STRING( + [--enable-werror], + [Turn all compiler warnings into errors] + )], + [werror=$enableval], [werror="no"]) +if test x"$werror" = x"yes" +then + WERROR_FLAGS="-Werror" + WERROR_FLAGS+=" -Werror=implicit-int -Werror=int-conversion -Werror=old-style-definition" + CFLAGS="$CFLAGS $WERROR_FLAGS" + CPPFLAGS="$CPPFLAGS $WERROR_FLAGS" +fi + AC_OUTPUT( libosmo-asn1-tcap.pc src/Makefile -- To view, visit https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/41025?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-asn1-tcap Gerrit-Branch: master Gerrit-Change-Id: I089b72068c095b9c88eb72970a9e691da3673ddf Gerrit-Change-Number: 41025 Gerrit-PatchSet: 4 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

2 weeks, 3 days

1
0
0 0

[S] Change in libosmo-asn1-tcap[master]: configure: add --enable-werror, --enable-sanitize

by osmith

osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/41025?usp=email ) Change subject: configure: add --enable-werror, --enable-sanitize ...................................................................... Patch Set 4: Verified+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/41025?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-asn1-tcap Gerrit-Branch: master Gerrit-Change-Id: I089b72068c095b9c88eb72970a9e691da3673ddf Gerrit-Change-Number: 41025 Gerrit-PatchSet: 4 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 05 Sep 2025 09:31:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

2 weeks, 3 days

1
0
0 0

[XS] Change in libosmo-asn1-tcap[master]: gitignore: add more files generated by autotools

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/41024?usp=email ) ( 3 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: gitignore: add more files generated by autotools ...................................................................... gitignore: add more files generated by autotools Change-Id: Ibc828502d0045b9c7c036ffdf552c9bba18bb7bd --- M .gitignore 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: pespin: Looks good to me, approved osmith: Verified laforge: Looks good to me, approved diff --git a/.gitignore b/.gitignore index fd36586..e9d5b47 100644 --- a/.gitignore +++ b/.gitignore @@ -8,6 +8,8 @@ aclocal.m4 config.* configure +*~ +compile depcomp libtool ltmain.sh -- To view, visit https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/41024?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-asn1-tcap Gerrit-Branch: master Gerrit-Change-Id: Ibc828502d0045b9c7c036ffdf552c9bba18bb7bd Gerrit-Change-Number: 41024 Gerrit-PatchSet: 4 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

2 weeks, 3 days

1
0
0 0

[XS] Change in libosmo-asn1-tcap[master]: gitignore: add more files generated by autotools

by osmith

osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/41024?usp=email ) Change subject: gitignore: add more files generated by autotools ...................................................................... Patch Set 4: Verified+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/41024?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-asn1-tcap Gerrit-Branch: master Gerrit-Change-Id: Ibc828502d0045b9c7c036ffdf552c9bba18bb7bd Gerrit-Change-Number: 41024 Gerrit-PatchSet: 4 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 05 Sep 2025 09:30:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

2 weeks, 3 days

1
0
0 0

[S] Change in libosmo-asn1-tcap[master]: (cosmetic) asn: Remove trailing whitespace

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/41020?usp=email ) ( 2 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: (cosmetic) asn: Remove trailing whitespace ...................................................................... (cosmetic) asn: Remove trailing whitespace Change-Id: Ib0aaa0f37f813851e8cfe28aaa22b105b5dcac17 --- M asn/tcap.asn 1 file changed, 23 insertions(+), 23 deletions(-) Approvals: pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved daniel: Looks good to me, but someone else must approve osmith: Verified fixeria: Looks good to me, approved diff --git a/asn/tcap.asn b/asn/tcap.asn index 5b98942..9df2e5b 100644 --- a/asn/tcap.asn +++ b/asn/tcap.asn @@ -3,17 +3,17 @@ DEFINITIONS ::= -BEGIN +BEGIN --EXPORTS OPERATION, ERROR, Component, InvokeId Type; -- WS stuff ExternalPDU ::= [UNIVERSAL 8] IMPLICIT SEQUENCE { oid OBJECT IDENTIFIER, - dialog [0] IMPLICIT Dialog1 + dialog [0] IMPLICIT Dialog1 } - - + + Dialog1 ::= OCTET STRING -- End WS -- Transaction Portion fields @@ -26,29 +26,29 @@ abort [APPLICATION 7] IMPLICIT Abort } -Unidirectional ::= SEQUENCE{ +Unidirectional ::= SEQUENCE{ dialoguePortion DialoguePortion OPTIONAL, components ComponentPortion } -Begin ::= SEQUENCE{ +Begin ::= SEQUENCE{ otid OrigTransactionID, dialoguePortion DialoguePortion OPTIONAL, - components ComponentPortion OPTIONAL + components ComponentPortion OPTIONAL } -End ::= SEQUENCE{ +End ::= SEQUENCE{ dtid DestTransactionID, dialoguePortion DialoguePortion OPTIONAL, - components ComponentPortion OPTIONAL + components ComponentPortion OPTIONAL } - -Continue ::= SEQUENCE { + +Continue ::= SEQUENCE { otid OrigTransactionID, dtid DestTransactionID, dialoguePortion DialoguePortion OPTIONAL, - components ComponentPortion OPTIONAL + components ComponentPortion OPTIONAL } Abort ::= SEQUENCE{ @@ -58,11 +58,11 @@ Reason ::= CHOICE{ p-abortCause P-AbortCause, - u-abortCause DialoguePortion + u-abortCause DialoguePortion } - --- NOTE - When the Abort Message is generated by the Transaction sublayer, a p-Abort Cause may be --- present. The u-abortCause may be generated by the component sublayer in which case it is an ABRT + +-- NOTE - When the Abort Message is generated by the Transaction sublayer, a p-Abort Cause may be +-- present. The u-abortCause may be generated by the component sublayer in which case it is an ABRT -- APDU, or by the TC-User in which case it could be either an ABRT APDU or data in some user-defined -- abstract syntax. @@ -104,7 +104,7 @@ returnResultLast [2] IMPLICIT ReturnResult, returnError [3] IMPLICIT ReturnError, reject [4] IMPLICIT Reject, - returnResultNotLast [7] IMPLICIT ReturnResult + returnResultNotLast [7] IMPLICIT ReturnResult } -- The Components are sequences of data elements. @@ -116,7 +116,7 @@ parameter Parameter OPTIONAL } Parameter ::= ANY - + -- ANY is filled by the single ASN.1 data type following the keyword PARAMETER or the keyword ARGUMENT -- in the type definition of a particular operation. @@ -135,7 +135,7 @@ invokeID InvokeIdType, errorCode ErrorCode, parameter Parameter OPTIONAL } - + -- ANY is filled by the single ASN.1 data type following the keyword PARAMETER in the type definition -- of a particular error. @@ -154,11 +154,11 @@ OPERATION ::= CHOICE { localValue INTEGER, - globalValue OBJECT IDENTIFIER } + globalValue OBJECT IDENTIFIER } ERROR ::= CHOICE { localValue INTEGER, - globalValue OBJECT IDENTIFIER } + globalValue OBJECT IDENTIFIER } -- OPERATIONS @@ -185,7 +185,7 @@ -- shall reference an error value --| type shall reference an error type -- if no error value is specified - + -- LinkedOperationNames ::= OperationList | empty -- OperationList ::= Operation | OperationList "," Operation -- Operation ::= value (OPERATION) @@ -244,4 +244,4 @@ privateer [PRIVATE 20] IMPLICIT INTEGER } -END -- end of the TCAP Package Module +END -- end of the TCAP Package Module -- To view, visit https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/41020?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-asn1-tcap Gerrit-Branch: master Gerrit-Change-Id: Ib0aaa0f37f813851e8cfe28aaa22b105b5dcac17 Gerrit-Change-Number: 41020 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

2 weeks, 3 days

1
0
0 0

[S] Change in libosmo-asn1-tcap[master]: (cosmetic) asn: Remove trailing whitespace

by osmith

osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/41020?usp=email ) Change subject: (cosmetic) asn: Remove trailing whitespace ...................................................................... Patch Set 3: Verified+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/41020?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-asn1-tcap Gerrit-Branch: master Gerrit-Change-Id: Ib0aaa0f37f813851e8cfe28aaa22b105b5dcac17 Gerrit-Change-Number: 41020 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 05 Sep 2025 09:30:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

2 weeks, 3 days

1
0
0 0

2025

2024

2023

2022

gerrit-log September 2025