September 2025 - gerrit-log - lists.osmocom.org

[XS] Change in libosmo-asn1-tcap[master]: rebuild-from-asn.sh: Update to work with present-day osmocom asn1c

by osmith

osmith has abandoned this change. ( https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/41019?usp=email ) Change subject: rebuild-from-asn.sh: Update to work with present-day osmocom asn1c ...................................................................... Abandoned this script will be removed in https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/41022 -- To view, visit https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/41019?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: abandon Gerrit-Project: libosmo-asn1-tcap Gerrit-Branch: master Gerrit-Change-Id: I1e9b64112805a39bd4bc9d94b64d3d99516bd6c6 Gerrit-Change-Number: 41019 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de>

2 weeks, 3 days

1
0
0 0

[M] Change in osmo-msc[master]: gsm48_cc_tx_setup: fix speech bearer capabilities

by osmith

Attention is currently required from: fixeria, pespin. osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-msc/+/41043?usp=email ) Change subject: gsm48_cc_tx_setup: fix speech bearer capabilities ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: this now depends on https://gerrit.osmocom.org/c/libosmocore/+/41056 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/41043?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I7046e9244fd9d4301ee2c4df1147a619f753739c Gerrit-Change-Number: 41043 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 05 Sep 2025 08:50:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

2 weeks, 3 days

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: msc: CC SETUP MT speech: verify bearer capabilities

by osmith

Attention is currently required from: fixeria, neels, pespin. osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41044?usp=email ) Change subject: msc: CC SETUP MT speech: verify bearer capabilities ...................................................................... Patch Set 5: (2 comments) File msc/BSC_ConnectionHandler.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41044/comment/0857e669_a1d5… : PS4, Line 1137: BSSAP.receive(tr_PDU_DTAP_MT(tr_ML3_MT_CC_SETUP(cpars.transaction_id, *, cpars.called_party))); > you may want to add explicit "*" param here to easily spot the differences. Done https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41044/comment/118b384a_7976… : PS4, Line 1142: valueof > No need to use `valueof()` here because `bcap` is a template parameter: […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41044?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I8fd33cf2f7fb8a1c34851ecf54fccddd2efd0536 Gerrit-Change-Number: 41044 Gerrit-PatchSet: 5 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 05 Sep 2025 08:43:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

2 weeks, 3 days

1
0
0 0

[M] Change in osmo-msc[master]: gsm48_cc_tx_setup: fix speech bearer capabilities

by osmith

Attention is currently required from: fixeria, pespin. osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-msc/+/41043?usp=email ) Change subject: gsm48_cc_tx_setup: fix speech bearer capabilities ...................................................................... Patch Set 3: (4 comments) File src/libmsc/gsm_04_08_cc.c: https://gerrit.osmocom.org/c/osmo-msc/+/41043/comment/2afb317b_1b134fdf?usp… : PS2, Line 994: * - We shall send spares for radio (which happens to be the same as > what's "spares"? "spare bits"? Done > What do you mean with "radio" here? '.radio' from the struct (radio channel requirement), clarified it https://gerrit.osmocom.org/c/osmo-msc/+/41043/comment/60e393ef_f00fa793?usp… : PS2, Line 997: * - We could send a speech version list in theory that MS are then > "We could in theory send a speech version list that" Done https://gerrit.osmocom.org/c/osmo-msc/+/41043/comment/3c3bb533_715b9a10?usp… : PS2, Line 1003: .radio = GSM48_BCAP_RRQ_FR_ONLY, /* spare */ > If it's a spare, imho it'd be better to add a hardcoded value, or add an explicit enum field (eg. […] Done, this patch now depends on https://gerrit.osmocom.org/c/libosmocore/+/41056 https://gerrit.osmocom.org/c/osmo-msc/+/41043/comment/5b76c735_3d3dd04c?usp… : PS2, Line 1000: if (bearer_cap.transfer == GSM48_BCAP_ITCAP_SPEECH) : bearer_cap = (struct gsm_mncc_bearer_cap){ : .transfer = GSM48_BCAP_ITCAP_SPEECH, : .radio = GSM48_BCAP_RRQ_FR_ONLY, /* spare */ : .speech_ver = { -1 }, : }; : > I suggest to avoid copying the given `struct gsm_mncc_bearer_cap`: […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/41043?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I7046e9244fd9d4301ee2c4df1147a619f753739c Gerrit-Change-Number: 41043 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 05 Sep 2025 08:43:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

2 weeks, 3 days

1
0
0 0

[M] Change in osmo-msc[master]: gsm48_cc_tx_setup_encode_msg: split out

by osmith

Attention is currently required from: fixeria, pespin. osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-msc/+/41041?usp=email ) Change subject: gsm48_cc_tx_setup_encode_msg: split out ...................................................................... Patch Set 2: (1 comment) File src/libmsc/gsm_04_08_cc.c: https://gerrit.osmocom.org/c/osmo-msc/+/41041/comment/150479ac_61234b92?usp… : PS1, Line 1052: msg = gsm48_cc_tx_setup_encode_msg(setup, &bearer_cap); > Acknowledged Done -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/41041?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I443b4b54c6ad40d852e4c21c896c2d0da5fac239 Gerrit-Change-Number: 41041 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 05 Sep 2025 08:42:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

2 weeks, 3 days

1
0
0 0

[M] Change in osmo-msc[master]: gsm48_cc_tx_setup_set_bearer_cap: split out

by osmith

Attention is currently required from: fixeria, pespin. osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-msc/+/41040?usp=email ) Change subject: gsm48_cc_tx_setup_set_bearer_cap: split out ...................................................................... Patch Set 2: (4 comments) File src/libmsc/gsm_04_08_cc.c: https://gerrit.osmocom.org/c/osmo-msc/+/41040/comment/7453c33a_e46c78f2?usp… : PS1, Line 918: static int gsm48_cc_tx_setup_set_bearer_cap(struct gsm_trans *trans, const struct gsm_mncc *setup, > Ack. […] Done https://gerrit.osmocom.org/c/osmo-msc/+/41040/comment/d0a6fc2f_03297e36?usp… : PS1, Line 945: rc > `rc` is set but not used here Done https://gerrit.osmocom.org/c/osmo-msc/+/41040/comment/eea0410a_7670ff2a?usp… : PS1, Line 971: rc > `rc` is set but not used here Done https://gerrit.osmocom.org/c/osmo-msc/+/41040/comment/2f84f9fb_a1fba147?usp… : PS1, Line 1008: rc = gsm48_cc_tx_setup_set_bearer_cap(trans, setup, &bearer_cap); > (trans, &bearer_cap, setup) Done -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/41040?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I3fe6bb2af90d729bb32cae8f5a1a38dcf8f87eb9 Gerrit-Change-Number: 41040 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 05 Sep 2025 08:41:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

2 weeks, 3 days

1
0
0 0

[M] Change in osmo-msc[master]: gsm48_cc_tx_setup_select_codecs: split out

by osmith

Attention is currently required from: fixeria, pespin. osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-msc/+/41039?usp=email ) Change subject: gsm48_cc_tx_setup_select_codecs: split out ...................................................................... Patch Set 2: (1 comment) File src/libmsc/gsm_04_08_cc.c: https://gerrit.osmocom.org/c/osmo-msc/+/41039/comment/a1f80fdd_287e3bf0?usp… : PS1, Line 928: if (setup->fields & MNCC_F_BEARER_CAP) > I believe because this chunk is not directly related to codec selection? Yes, this is about changing bearer_cap.transfer from the default of GSM48_BCAP_ITCAP_SPEECH to e.g. GSM48_BCAP_ITCAP_UNR_DIG_INF (CSD), not about codec selection. So IMHO it makes more sense to leave it there. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/41039?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ic502f9ed77ea57de4cf6d362c0e7070d9147d6f3 Gerrit-Change-Number: 41039 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 05 Sep 2025 08:40:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

2 weeks, 3 days

1
0
0 0

[M] Change in osmo-msc[master]: gsm48_cc_tx_setup_set_transaction_id: split out

by osmith

Attention is currently required from: fixeria, pespin. osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-msc/+/41038?usp=email ) Change subject: gsm48_cc_tx_setup_set_transaction_id: split out ...................................................................... Patch Set 2: (2 comments) File src/libmsc/gsm_04_08_cc.c: https://gerrit.osmocom.org/c/osmo-msc/+/41038/comment/d531a250_0f7cd311?usp… : PS1, Line 845: TX Setup with assigned transaction. This is not allowed > I find this message a bit confusing, maybe say "transaction ID is already assigned"? […] done in a separate patch https://gerrit.osmocom.org/c/osmo-msc/+/41038/comment/3cfe702f_04097fa2?usp… : PS1, Line 847: mncc_release_ind(trans->net, trans, trans->callref, : GSM48_CAUSE_LOC_PRN_S_LU, : GSM48_CC_CAUSE_RESOURCE_UNAVAIL); : > Maybe keep this in `gsm48_cc_tx_setup()`? […] I've considered it, but `gsm48_cc_tx_setup_set_bearer_cap` which gets split out later also sends `mncc_release_ind` in some (not all!) error code paths. There we can't also keep `mncc_release_ind` in `gsm48_cc_tx_setup`, so for consistency I'll keep it in the split-out functions for now. This is probably something that can be improved in future patches. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/41038?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I715f12d09570211a98b667c56960309bd326e8d8 Gerrit-Change-Number: 41038 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 05 Sep 2025 08:40:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

2 weeks, 3 days

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: msc: CC SETUP MT speech: verify bearer capabilities

by osmith

Attention is currently required from: neels, osmith, pespin. Hello Jenkins Builder, neels, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41044?usp=email to look at the new patch set (#5). The following approvals got outdated and were removed: Code-Review+1 by pespin, Verified+1 by Jenkins Builder Change subject: msc: CC SETUP MT speech: verify bearer capabilities ...................................................................... msc: CC SETUP MT speech: verify bearer capabilities Verify that the MSC sends the bearer capability IE from 3GPP TS 24.008 § D.1.2 for speech in the network to MS direction, instead of allowing e.g. what osmo-msc master and latest release currently do: - Filling out radio channel requirement the same way as the MS to Network direction, which is wrong for the Network to MS direction: "Bits 6 and 7 are spare bits. The sending side (i.e. the network) shall set bit 7 to value 0 and bit 6 to value 1." (3GPP TS 24.008 Table 10.5.102) - Sending a speech list in the Network to MS direction, which seems to be allowed in theory and MS are supposed to ignore it (end of Table 10.5.103) but causes bugs in some MS in practice. Therefore it is better to ensure that osmo-msc does not send it (OS#6656). Implement this in f_mt_call_complete(), which gets used e.g. by TC_lu_and_mt_call. Depends: osmo-msc I7046e9244fd9d4301ee2c4df1147a619f753739c Related: OS#6657, OS#6655, OS#6656 Change-Id: I8fd33cf2f7fb8a1c34851ecf54fccddd2efd0536 --- M library/L3_Templates.ttcn M msc/BSC_ConnectionHandler.ttcn 2 files changed, 28 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/44/41044/5 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41044?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I8fd33cf2f7fb8a1c34851ecf54fccddd2efd0536 Gerrit-Change-Number: 41044 Gerrit-PatchSet: 5 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de>

2 weeks, 3 days

1
0
0 0

[XS] Change in osmo-msc[master]: gsm48_cc_tx_setup_set_transaction_id: tweak error msg

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/41057?usp=email ) Change subject: gsm48_cc_tx_setup_set_transaction_id: tweak error msg ...................................................................... gsm48_cc_tx_setup_set_transaction_id: tweak error msg Reword the message to make it less confusing. Change-Id: I4007e99b6abd9b2e05945ccdedaac185a2aea19e --- M src/libmsc/gsm_04_08_cc.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/57/41057/1 diff --git a/src/libmsc/gsm_04_08_cc.c b/src/libmsc/gsm_04_08_cc.c index 3a78b6d..93b4995 100644 --- a/src/libmsc/gsm_04_08_cc.c +++ b/src/libmsc/gsm_04_08_cc.c @@ -842,7 +842,7 @@ /* Transaction ID must not be assigned */ if (trans->transaction_id != TRANS_ID_UNASSIGNED) { - LOG_TRANS(trans, LOGL_ERROR, "TX Setup with assigned transaction. This is not allowed!\n"); + LOG_TRANS(trans, LOGL_ERROR, "TX Setup: transaction ID is already assigned!\n"); mncc_release_ind(trans->net, trans, trans->callref, GSM48_CAUSE_LOC_PRN_S_LU, GSM48_CC_CAUSE_RESOURCE_UNAVAIL); -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/41057?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I4007e99b6abd9b2e05945ccdedaac185a2aea19e Gerrit-Change-Number: 41057 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

2 weeks, 3 days

1
0
0 0

2025

2024

2023

2022

gerrit-log September 2025