Attention is currently required from: osmith.
osmith has removed a vote from this change. ( https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/41059?usp=email )
Change subject: gitreview: new file
......................................................................
Removed Verified-1 by Jenkins Builder (1000002)
--
To view, visit https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/41059?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: deleteVote
Gerrit-Project: libosmo-asn1-tcap
Gerrit-Branch: master
Gerrit-Change-Id: I73e6d15b80c95d5a576bd1d0fb47c1e7baac2cba
Gerrit-Change-Number: 41059
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
fixeria has submitted this change. ( https://gerrit.osmocom.org/c/python/osmo-python-tests/+/41052?usp=email )
Change subject: debian: python3-osmopy-utils does not need python3-treq
......................................................................
debian: python3-osmopy-utils does not need python3-treq
This module is only used by scripts/{ctrl2cgi.py,soap.py}, which
have been deprecated and are no longer part of the package.
Change-Id: I8a36109de244efaaa40bf5ac309bd5061cf0596d
Fixes: 36cfd17 ("setup.py: do not install scripts/{soap,ctrl2cgi}.py")
---
M debian/control
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Jenkins Builder: Verified
pespin: Looks good to me, but someone else must approve
osmith: Looks good to me, approved
diff --git a/debian/control b/debian/control
index c6bd48f..e02fd77 100644
--- a/debian/control
+++ b/debian/control
@@ -17,7 +17,7 @@
Package: python3-osmopy-utils
Architecture: all
-Depends: ${python3:Depends}, ${misc:Depends}, python3-osmopy-libs, python3-twisted, python3-treq, python3-aiohttp
+Depends: ${python3:Depends}, ${misc:Depends}, python3-osmopy-libs, python3-twisted, python3-aiohttp
Description: Python code (not only) for testing of Osmocom programs
.
This package contains the Python 3 version of osmopy utils.
--
To view, visit https://gerrit.osmocom.org/c/python/osmo-python-tests/+/41052?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: python/osmo-python-tests
Gerrit-Branch: master
Gerrit-Change-Id: I8a36109de244efaaa40bf5ac309bd5061cf0596d
Gerrit-Change-Number: 41052
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
fixeria has submitted this change. ( https://gerrit.osmocom.org/c/python/osmo-python-tests/+/41051?usp=email )
Change subject: debian: do not install osmo-ctrl2cgi.service
......................................................................
debian: do not install osmo-ctrl2cgi.service
This service is calling scripts/ctrl2cgi.py, which has been deprecated
and is no longer part of the package (there's no /usr/bin/ctrl2cgi.py).
Change-Id: I6250f92d12774c69a8647b8cd26d0aa715646724
Fixes: 36cfd17 ("setup.py: do not install scripts/{soap,ctrl2cgi}.py")
---
D debian/python3-osmopy-utils.osmo-ctrl2cgi.service
M debian/rules
2 files changed, 0 insertions(+), 2 deletions(-)
Approvals:
pespin: Looks good to me, but someone else must approve
osmith: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/debian/python3-osmopy-utils.osmo-ctrl2cgi.service b/debian/python3-osmopy-utils.osmo-ctrl2cgi.service
deleted file mode 120000
index 9d9498d..0000000
--- a/debian/python3-osmopy-utils.osmo-ctrl2cgi.service
+++ /dev/null
@@ -1 +0,0 @@
-../contrib/systemd/osmo-ctrl2cgi.service
\ No newline at end of file
diff --git a/debian/rules b/debian/rules
index ff16a03..84ef719 100755
--- a/debian/rules
+++ b/debian/rules
@@ -12,5 +12,4 @@
override_dh_installinit:
# Install service file with different name than package name:
# https://unix.stackexchange.com/questions/306234/is-it-possible-to-install-t…
- dh_installinit --name=osmo-ctrl2cgi
dh_installinit --name=osmo-trap2cgi
--
To view, visit https://gerrit.osmocom.org/c/python/osmo-python-tests/+/41051?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: python/osmo-python-tests
Gerrit-Branch: master
Gerrit-Change-Id: I6250f92d12774c69a8647b8cd26d0aa715646724
Gerrit-Change-Number: 41051
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Attention is currently required from: daniel, fixeria, pespin.
osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/41021?usp=email )
Change subject: Fix decoding of TCAP messages
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS2:
> ok, can you update the commit description to mention it doesn't work either with newer asn1c (<inser […]
Done
--
To view, visit https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/41021?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmo-asn1-tcap
Gerrit-Branch: master
Gerrit-Change-Id: I4a27a52b2be70b1fc50e0a3d5441ded4c151fe65
Gerrit-Change-Number: 41021
Gerrit-PatchSet: 3
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-CC: daniel <dwillmann(a)sysmocom.de>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 05 Sep 2025 13:22:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Comment-In-Reply-To: daniel <dwillmann(a)sysmocom.de>
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/41058?usp=email )
Change subject: configure.ac: use subdir-objects
......................................................................
configure.ac: use subdir-objects
Fix a bunch of warnings:
src/Makefile.am:1: warning: source file 'gen/TCAP_DialoguePDU.c' is in a subdirectory,
src/Makefile.am:1: but option 'subdir-objects' is disabled
src/Makefile.am:1: warning: source file 'gen/TCAP_AUDT-apdu.c' is in a subdirectory,
src/Makefile.am:1: but option 'subdir-objects' is disabled
src/Makefile.am:1: warning: source file 'gen/NULL_ber.c' is in a subdirectory,
src/Makefile.am:1: but option 'subdir-objects' is disabled
src/Makefile.am:1: warning: source file 'gen/asn_codecs_prim_ber.c' is in a subdirectory,
src/Makefile.am:1: but option 'subdir-objects' is disabled
…
Change-Id: I800c8d8e39923a8dd17e3bf1e5aeb1cf691383d8
---
M configure.ac
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/libosmo-asn1-tcap refs/changes/58/41058/1
diff --git a/configure.ac b/configure.ac
index 7ab015e..e301c64 100644
--- a/configure.ac
+++ b/configure.ac
@@ -1,6 +1,6 @@
AC_INIT([libosmo-asn1-tcap], 0.0.0, [openbsc-devel(a)lists.openbsc.org])
-AM_INIT_AUTOMAKE([dist-bzip2])
+AM_INIT_AUTOMAKE([dist-bzip2 subdir-objects])
dnl kernel style compile messages
m4_ifdef([AM_SILENT_RULES], [AM_SILENT_RULES([yes])])
--
To view, visit https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/41058?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: libosmo-asn1-tcap
Gerrit-Branch: master
Gerrit-Change-Id: I800c8d8e39923a8dd17e3bf1e5aeb1cf691383d8
Gerrit-Change-Number: 41058
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>