September 2025 - gerrit-log - lists.osmocom.org

[M] Change in libosmo-asn1-tcap[master]: debian: initial

by osmith

Attention is currently required from: laforge, osmith. Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/41023?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Code-Review+1 by laforge, Verified+1 by Jenkins Builder Change subject: debian: initial ...................................................................... debian: initial Change-Id: I8ab1b2d69b5617c91ac694bf4a754d6c28b080dd --- M Makefile.am A debian/changelog A debian/compat A debian/control A debian/libosmo-asn1-tcap-dev.install A debian/libosmo-asn1-tcap0.install A debian/rules A debian/source/format 8 files changed, 70 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-asn1-tcap refs/changes/23/41023/4 -- To view, visit https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/41023?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmo-asn1-tcap Gerrit-Branch: master Gerrit-Change-Id: I8ab1b2d69b5617c91ac694bf4a754d6c28b080dd Gerrit-Change-Number: 41023 Gerrit-PatchSet: 4 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org>

2 weeks, 3 days

1
0
0 0

[XS] Change in libosmo-asn1-tcap[master]: Fix decoding of TCAP messages

by osmith

Attention is currently required from: daniel, fixeria, osmith. Hello Jenkins Builder, daniel, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/41021?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Code-Review+1 by daniel, Code-Review+1 by fixeria, Verified+1 by osmith Change subject: Fix decoding of TCAP messages ...................................................................... Fix decoding of TCAP messages Recent versions of asn1c fail while decoding the DialoguePortion of a TCAP message - probably because Tag APPLICATION 11 is sent as constructed tag and the WS adaptation expects a primitive one. Not sure if this ever worked with an older asn1c version, maybe it ignored this discrepancy. The described behavior also happens with mouse07410/asn1c 2c06555 used in the next patch to regenerate the code. In any case the correct encoding of the DialoguePortion is as EXTERNAL. Support for proper EXTERNAL asn1c decoding is missing in all versions of asn1c except https://github.com/mouse07410/asn1c (See PR #3/#5) so use that when regenerating. Related: SYS#7486 Change-Id: I4a27a52b2be70b1fc50e0a3d5441ded4c151fe65 --- M asn/tcap.asn 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-asn1-tcap refs/changes/21/41021/3 -- To view, visit https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/41021?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmo-asn1-tcap Gerrit-Branch: master Gerrit-Change-Id: I4a27a52b2be70b1fc50e0a3d5441ded4c151fe65 Gerrit-Change-Number: 41021 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: daniel <dwillmann(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>

2 weeks, 3 days

1
0
0 0

[XL] Change in libosmo-asn1-tcap[master]: Regenerate code with newer asn1c

by osmith

Attention is currently required from: daniel, osmith, pespin. Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/41022?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Code-Review-1 by pespin, Verified+1 by osmith Change subject: Regenerate code with newer asn1c ...................................................................... Regenerate code with newer asn1c asn1c used from: https://github.com/mouse07410/asn1c branch: vlm_master commit: 2c06555 ("Fix #239 by applying suggested fix") This no longer uses/requires libasn1c so drop the dependency and modify the build system similar to osmo-cbc/src/sbcap/ Tweaked-By: Oliver Smith <osmith(a)sysmocom.de> Related: SYS#5423 Change-Id: If43a5d518f94fa558a3dff563a1c7aa31c925fec --- M Makefile.am M configure.ac M contrib/jenkins.sh D include/AARE-apdu.h D include/AARQ-apdu.h D include/ABRT-apdu.h D include/AUDT-apdu.h D include/Abort.h D include/Associate-source-diagnostic.h D include/Begin.h D include/Continue.h D include/DialogueOC.h D include/EXTERNAL.h D include/End.h D include/Invoke.h M include/Makefile.am D include/RLRE-apdu.h D include/RLRQ-apdu.h D include/Reject.h D include/ReturnError.h D include/Unidirectional.h A include/osmocom/Makefile.am A include/osmocom/tcap/AARE-apdu.h A include/osmocom/tcap/AARQ-apdu.h A include/osmocom/tcap/ABRT-apdu.h R include/osmocom/tcap/ABRT-source.h A include/osmocom/tcap/ANY.h A include/osmocom/tcap/AUDT-apdu.h A include/osmocom/tcap/Abort.h R include/osmocom/tcap/Associate-result.h A include/osmocom/tcap/Associate-source-diagnostic.h A include/osmocom/tcap/BIT_STRING.h A include/osmocom/tcap/Begin.h R include/osmocom/tcap/Component.h R include/osmocom/tcap/ComponentPortion.h A include/osmocom/tcap/Continue.h R include/osmocom/tcap/DestTransactionID.h R include/osmocom/tcap/Dialog1.h R include/osmocom/tcap/DialoguePDU.h R include/osmocom/tcap/DialoguePortion.h R include/osmocom/tcap/ERROR.h A include/osmocom/tcap/EXTERNAL.h A include/osmocom/tcap/End.h R include/osmocom/tcap/ErrorCode.h R include/osmocom/tcap/ExternalPDU.h R include/osmocom/tcap/GeneralProblem.h A include/osmocom/tcap/GraphicString.h A include/osmocom/tcap/INTEGER.h A include/osmocom/tcap/Invoke.h R include/osmocom/tcap/InvokeIdType.h R include/osmocom/tcap/InvokeProblem.h A include/osmocom/tcap/Makefile.am A include/osmocom/tcap/NULL.h A include/osmocom/tcap/NativeInteger.h A include/osmocom/tcap/OBJECT_IDENTIFIER.h A include/osmocom/tcap/OCTET_STRING.h A include/osmocom/tcap/OPEN_TYPE.h R include/osmocom/tcap/OPERATION.h A include/osmocom/tcap/ObjectDescriptor.h R include/osmocom/tcap/OrigTransactionID.h R include/osmocom/tcap/P-AbortCause.h R include/osmocom/tcap/Parameter.h A include/osmocom/tcap/RLRE-apdu.h A include/osmocom/tcap/RLRQ-apdu.h R include/osmocom/tcap/Reason.h A include/osmocom/tcap/Reject.h R include/osmocom/tcap/Release-request-reason.h R include/osmocom/tcap/Release-response-reason.h A include/osmocom/tcap/ReturnError.h R include/osmocom/tcap/ReturnErrorProblem.h R include/osmocom/tcap/ReturnResult.h R include/osmocom/tcap/ReturnResultProblem.h A include/osmocom/tcap/TCAP_AARE-apdu.h A include/osmocom/tcap/TCAP_AARQ-apdu.h A include/osmocom/tcap/TCAP_ABRT-apdu.h A include/osmocom/tcap/TCAP_ABRT-source.h A include/osmocom/tcap/TCAP_AUDT-apdu.h A include/osmocom/tcap/TCAP_Abort.h A include/osmocom/tcap/TCAP_Associate-result.h A include/osmocom/tcap/TCAP_Associate-source-diagnostic.h A include/osmocom/tcap/TCAP_Begin.h A include/osmocom/tcap/TCAP_Component.h A include/osmocom/tcap/TCAP_ComponentPortion.h A include/osmocom/tcap/TCAP_Continue.h A include/osmocom/tcap/TCAP_DestTransactionID.h A include/osmocom/tcap/TCAP_Dialog1.h A include/osmocom/tcap/TCAP_DialoguePDU.h A include/osmocom/tcap/TCAP_DialoguePortion.h A include/osmocom/tcap/TCAP_ERROR.h A include/osmocom/tcap/TCAP_EXTERNAL.h A include/osmocom/tcap/TCAP_End.h A include/osmocom/tcap/TCAP_ErrorCode.h A include/osmocom/tcap/TCAP_ExternalPDU.h A include/osmocom/tcap/TCAP_GeneralProblem.h A include/osmocom/tcap/TCAP_Invoke.h A include/osmocom/tcap/TCAP_InvokeIdType.h A include/osmocom/tcap/TCAP_InvokeProblem.h A include/osmocom/tcap/TCAP_OPERATION.h A include/osmocom/tcap/TCAP_OrigTransactionID.h A include/osmocom/tcap/TCAP_P-AbortCause.h A include/osmocom/tcap/TCAP_Parameter.h A include/osmocom/tcap/TCAP_RLRE-apdu.h A include/osmocom/tcap/TCAP_RLRQ-apdu.h A include/osmocom/tcap/TCAP_Reason.h A include/osmocom/tcap/TCAP_Reject.h A include/osmocom/tcap/TCAP_Release-request-reason.h A include/osmocom/tcap/TCAP_Release-response-reason.h A include/osmocom/tcap/TCAP_ReturnError.h A include/osmocom/tcap/TCAP_ReturnErrorProblem.h A include/osmocom/tcap/TCAP_ReturnResult.h A include/osmocom/tcap/TCAP_ReturnResultProblem.h A include/osmocom/tcap/TCAP_TCMessage.h A include/osmocom/tcap/TCAP_UniDialoguePDU.h A include/osmocom/tcap/TCAP_Unidirectional.h A include/osmocom/tcap/TCAP_asn_constant.h R include/osmocom/tcap/TCMessage.h R include/osmocom/tcap/UniDialoguePDU.h A include/osmocom/tcap/Unidirectional.h A include/osmocom/tcap/asn_SEQUENCE_OF.h A include/osmocom/tcap/asn_SET_OF.h A include/osmocom/tcap/asn_application.h A include/osmocom/tcap/asn_bit_data.h A include/osmocom/tcap/asn_codecs.h A include/osmocom/tcap/asn_codecs_prim.h A include/osmocom/tcap/asn_config.h A include/osmocom/tcap/asn_constant.h A include/osmocom/tcap/asn_internal.h A include/osmocom/tcap/asn_ioc.h A include/osmocom/tcap/asn_random_fill.h A include/osmocom/tcap/asn_system.h A include/osmocom/tcap/ber_decoder.h A include/osmocom/tcap/ber_tlv_length.h A include/osmocom/tcap/ber_tlv_tag.h A include/osmocom/tcap/constr_CHOICE.h A include/osmocom/tcap/constr_SEQUENCE.h A include/osmocom/tcap/constr_SEQUENCE_OF.h A include/osmocom/tcap/constr_SET_OF.h A include/osmocom/tcap/constr_TYPE.h A include/osmocom/tcap/constraints.h A include/osmocom/tcap/der_encoder.h M libosmo-asn1-tcap.pc.in A move-asn1-header-files.sh D src/AARE-apdu.c D src/AARQ-apdu.c D src/ABRT-apdu.c D src/ABRT-source.c D src/AUDT-apdu.c D src/Abort.c D src/Associate-result.c D src/Associate-source-diagnostic.c D src/Begin.c D src/Component.c D src/ComponentPortion.c D src/Continue.c D src/DestTransactionID.c D src/Dialog1.c D src/DialogueOC.c D src/DialoguePDU.c D src/DialoguePortion.c D src/ERROR.c D src/End.c D src/ErrorCode.c D src/ExternalPDU.c D src/GeneralProblem.c D src/Invoke.c D src/InvokeIdType.c D src/InvokeProblem.c M src/Makefile.am D src/OPERATION.c D src/OrigTransactionID.c D src/P-AbortCause.c D src/Parameter.c D src/RLRE-apdu.c D src/RLRQ-apdu.c D src/Reason.c D src/Reject.c D src/Release-request-reason.c D src/Release-response-reason.c D src/ReturnError.c D src/ReturnErrorProblem.c D src/ReturnResult.c D src/ReturnResultProblem.c D src/TCMessage.c D src/UniDialoguePDU.c D src/Unidirectional.c A src/gen/ABRT-source.c A src/gen/ANY.c A src/gen/ANY_ber.c A src/gen/Associate-result.c A src/gen/BIT_STRING.c A src/gen/BIT_STRING_print.c A src/gen/BIT_STRING_rfill.c A src/gen/DialoguePortion.c A src/gen/GeneralProblem.c A src/gen/GraphicString.c A src/gen/INTEGER.c A src/gen/INTEGER_ber.c A src/gen/INTEGER_print.c A src/gen/INTEGER_rfill.c A src/gen/InvokeProblem.c A src/gen/NULL.c A src/gen/NULL_ber.c A src/gen/NULL_print.c A src/gen/NULL_rfill.c A src/gen/NativeInteger.c A src/gen/NativeInteger_ber.c A src/gen/NativeInteger_print.c A src/gen/NativeInteger_rfill.c A src/gen/OBJECT_IDENTIFIER.c A src/gen/OBJECT_IDENTIFIER_print.c A src/gen/OBJECT_IDENTIFIER_rfill.c A src/gen/OCTET_STRING.c A src/gen/OCTET_STRING_ber.c A src/gen/OCTET_STRING_print.c A src/gen/OCTET_STRING_rfill.c A src/gen/OPEN_TYPE.c A src/gen/OPEN_TYPE_ber.c A src/gen/ObjectDescriptor.c A src/gen/Release-request-reason.c A src/gen/Release-response-reason.c A src/gen/ReturnErrorProblem.c A src/gen/ReturnResultProblem.c A src/gen/TCAP_AARE-apdu.c A src/gen/TCAP_AARQ-apdu.c A src/gen/TCAP_ABRT-apdu.c A src/gen/TCAP_ABRT-source.c A src/gen/TCAP_AUDT-apdu.c A src/gen/TCAP_Abort.c A src/gen/TCAP_Associate-result.c A src/gen/TCAP_Associate-source-diagnostic.c A src/gen/TCAP_Begin.c A src/gen/TCAP_Component.c A src/gen/TCAP_ComponentPortion.c A src/gen/TCAP_Continue.c A src/gen/TCAP_DestTransactionID.c A src/gen/TCAP_Dialog1.c A src/gen/TCAP_DialoguePDU.c A src/gen/TCAP_DialoguePortion.c A src/gen/TCAP_ERROR.c A src/gen/TCAP_EXTERNAL.c A src/gen/TCAP_End.c A src/gen/TCAP_ErrorCode.c A src/gen/TCAP_ExternalPDU.c A src/gen/TCAP_GeneralProblem.c A src/gen/TCAP_Invoke.c A src/gen/TCAP_InvokeIdType.c A src/gen/TCAP_InvokeProblem.c A src/gen/TCAP_OPERATION.c A src/gen/TCAP_OrigTransactionID.c A src/gen/TCAP_P-AbortCause.c A src/gen/TCAP_Parameter.c A src/gen/TCAP_RLRE-apdu.c A src/gen/TCAP_RLRQ-apdu.c A src/gen/TCAP_Reason.c A src/gen/TCAP_Reject.c A src/gen/TCAP_Release-request-reason.c A src/gen/TCAP_Release-response-reason.c A src/gen/TCAP_ReturnError.c A src/gen/TCAP_ReturnErrorProblem.c A src/gen/TCAP_ReturnResult.c A src/gen/TCAP_ReturnResultProblem.c A src/gen/TCAP_TCMessage.c A src/gen/TCAP_UniDialoguePDU.c A src/gen/TCAP_Unidirectional.c A src/gen/asn_SEQUENCE_OF.c A src/gen/asn_SET_OF.c A src/gen/asn_application.c A src/gen/asn_bit_data.c A src/gen/asn_codecs_prim.c A src/gen/asn_codecs_prim_ber.c A src/gen/asn_internal.c A src/gen/asn_random_fill.c A src/gen/ber_decoder.c A src/gen/ber_tlv_length.c A src/gen/ber_tlv_tag.c A src/gen/constr_CHOICE.c A src/gen/constr_CHOICE_ber.c A src/gen/constr_CHOICE_print.c A src/gen/constr_CHOICE_rfill.c A src/gen/constr_SEQUENCE.c A src/gen/constr_SEQUENCE_OF.c A src/gen/constr_SEQUENCE_OF_ber.c A src/gen/constr_SEQUENCE_ber.c A src/gen/constr_SEQUENCE_print.c A src/gen/constr_SEQUENCE_rfill.c A src/gen/constr_SET_OF.c A src/gen/constr_SET_OF_ber.c A src/gen/constr_SET_OF_print.c A src/gen/constr_SET_OF_rfill.c A src/gen/constr_TYPE.c A src/gen/constraints.c A src/gen/der_encoder.c D src/rebuild-from-asn.sh A src/skel/ANY.h A src/skel/BIT_STRING.h A src/skel/BMPString.h A src/skel/BOOLEAN.h A src/skel/ENUMERATED.h A src/skel/GeneralString.h A src/skel/GeneralizedTime.h A src/skel/GraphicString.h A src/skel/IA5String.h A src/skel/INTEGER.h A src/skel/ISO646String.h A src/skel/NULL.h A src/skel/NativeEnumerated.h A src/skel/NativeInteger.h A src/skel/NativeReal.h A src/skel/NumericString.h A src/skel/OBJECT_IDENTIFIER.h A src/skel/OCTET_STRING.h A src/skel/OPEN_TYPE.h A src/skel/ObjectDescriptor.h A src/skel/PrintableString.h A src/skel/REAL.h A src/skel/RELATIVE-OID.h A src/skel/T61String.h A src/skel/TeletexString.h A src/skel/UTCTime.h A src/skel/UTF8String.h A src/skel/UniversalString.h A src/skel/VideotexString.h A src/skel/VisibleString.h A src/skel/aper_decoder.h A src/skel/aper_encoder.h A src/skel/aper_opentype.h A src/skel/aper_support.h A src/skel/asn_SEQUENCE_OF.h A src/skel/asn_SET_OF.h A src/skel/asn_application.h A src/skel/asn_bit_data.h A src/skel/asn_codecs.h A src/skel/asn_codecs_prim.h A src/skel/asn_config.h A src/skel/asn_internal.h A src/skel/asn_ioc.h A src/skel/asn_random_fill.h A src/skel/asn_system.h A src/skel/ber_decoder.h A src/skel/ber_tlv_length.h A src/skel/ber_tlv_tag.h A src/skel/constr_CHOICE.h A src/skel/constr_SEQUENCE.h A src/skel/constr_SEQUENCE_OF.h A src/skel/constr_SET.h A src/skel/constr_SET_OF.h A src/skel/constr_TYPE.h A src/skel/constraints.h A src/skel/der_encoder.h A src/skel/jer_decoder.h A src/skel/jer_encoder.h A src/skel/jer_support.h A src/skel/oer_decoder.h A src/skel/oer_encoder.h A src/skel/oer_support.h A src/skel/per_decoder.h A src/skel/per_encoder.h A src/skel/per_opentype.h A src/skel/per_support.h A src/skel/uper_decoder.h A src/skel/uper_encoder.h A src/skel/uper_opentype.h A src/skel/uper_support.h A src/skel/xer_decoder.h A src/skel/xer_encoder.h A src/skel/xer_support.h 366 files changed, 27,340 insertions(+), 5,258 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-asn1-tcap refs/changes/22/41022/4 -- To view, visit https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/41022?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmo-asn1-tcap Gerrit-Branch: master Gerrit-Change-Id: If43a5d518f94fa558a3dff563a1c7aa31c925fec Gerrit-Change-Number: 41022 Gerrit-PatchSet: 4 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>

2 weeks, 3 days

1
0
0 0

[M] Change in libosmo-asn1-tcap[master]: Add git-version-gen

by osmith

Attention is currently required from: osmith, pespin. Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/41026?usp=email to look at the new patch set (#5). The following approvals got outdated and were removed: Code-Review+1 by pespin, Verified+1 by Jenkins Builder Change subject: Add git-version-gen ...................................................................... Add git-version-gen Change-Id: Ic6245f4d0ccced5089c55eccbe07b36c43d71e9c --- M .gitignore M Makefile.am M configure.ac A git-version-gen 4 files changed, 165 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-asn1-tcap refs/changes/26/41026/5 -- To view, visit https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/41026?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmo-asn1-tcap Gerrit-Branch: master Gerrit-Change-Id: Ic6245f4d0ccced5089c55eccbe07b36c43d71e9c Gerrit-Change-Number: 41026 Gerrit-PatchSet: 5 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de>

2 weeks, 3 days

1
0
0 0

[S] Change in libosmo-asn1-tcap[master]: Generate a version.h file

by osmith

Attention is currently required from: fixeria, osmith, pespin. Hello Jenkins Builder, fixeria, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/41027?usp=email to look at the new patch set (#5). The following approvals got outdated and were removed: Code-Review+1 by pespin, Code-Review+2 by fixeria, Verified+1 by Jenkins Builder The change is no longer submittable: Code-Review and Verified are unsatisfied now. Change subject: Generate a version.h file ...................................................................... Generate a version.h file Related: OS#6626 Change-Id: I2ee394086af3ccf0ec789e2cba627054c09fe1cd --- M .gitignore M include/osmocom/tcap/Makefile.am A include/osmocom/tcap/version.h.tpl 3 files changed, 37 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-asn1-tcap refs/changes/27/41027/5 -- To view, visit https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/41027?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmo-asn1-tcap Gerrit-Branch: master Gerrit-Change-Id: I2ee394086af3ccf0ec789e2cba627054c09fe1cd Gerrit-Change-Number: 41027 Gerrit-PatchSet: 5 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>

2 weeks, 3 days

1
0
0 0

[XS] Change in libosmocore[master]: gsm_04_08: add GSM48_BCAP_RRQ_SPARE_NETWORK_TO_MS

by pespin

Attention is currently required from: fixeria, osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/libosmocore/+/41056?usp=email ) Change subject: gsm_04_08: add GSM48_BCAP_RRQ_SPARE_NETWORK_TO_MS ...................................................................... Patch Set 2: (1 comment) File include/osmocom/gsm/protocol/gsm_04_08.h: https://gerrit.osmocom.org/c/libosmocore/+/41056/comment/8bb558f1_547292d8?… : PS1, Line 2158: /* GSM 04.08 Table 10.72: In network to MS direction, the network must send > It was rather close to that enum and the same prefix suggests the relation? […] I really had to use CTRL+F to actually find the enum, so not close enough ;) Still, when looking at the enum you definetly want to see that field inside. I'm not looking outside. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41056?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I97101c977104eae82e4850d40f9abd15aa03e33e Gerrit-Change-Number: 41056 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 05 Sep 2025 13:08:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

2 weeks, 3 days

1
0
0 0

[M] Change in osmo-bts[master]: HRv1 codec: add support for TW-TS-002

by pespin

Attention is currently required from: falconia. pespin has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/osmo-bts/+/41050?usp=email ) Change subject: HRv1 codec: add support for TW-TS-002 ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/41050?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Icf11e43d4ce9df990d0e0a856d62d9ea11cb837c Gerrit-Change-Number: 41050 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Comment-Date: Fri, 05 Sep 2025 13:07:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

2 weeks, 3 days

1
0
0 0

[M] Change in osmo-bts[master]: FR/HR/EFR: implement SID filter in TCH UL path

by pespin

Attention is currently required from: falconia. pespin has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/osmo-bts/+/41049?usp=email ) Change subject: FR/HR/EFR: implement SID filter in TCH UL path ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File include/osmo-bts/lchan.h: https://gerrit.osmocom.org/c/osmo-bts/+/41049/comment/bac15ded_da67aece?usp… : PS1, Line 295: /* UL SID filter to catch DTXu half-blocks */ Maybe add link reference https://osmocom.org/projects/retro-gsm/wiki/DTXu_half-blocks here too? -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/41049?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I46c62312316b04567bcadf6050597673f071247d Gerrit-Change-Number: 41049 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Comment-Date: Fri, 05 Sep 2025 13:04:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

2 weeks, 3 days

1
0
0 0

[M] Change in osmo-bts[master]: FR/HR/EFR: centralize TCH UL SID classification

by pespin

Attention is currently required from: falconia. pespin has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/osmo-bts/+/41048?usp=email ) Change subject: FR/HR/EFR: centralize TCH UL SID classification ...................................................................... Patch Set 1: (2 comments) File include/osmo-bts/msg_utils.h: https://gerrit.osmocom.org/c/osmo-bts/+/41048/comment/867dc87a_7b5e3426?usp… : PS1, Line 25: * Additionally for HRv1 codec, we use a control buffer word to pass IMHO once you improve de comment framing (see first patch); this show go immediatelly above each field being defined (eg. line 43). File src/common/l1sap.c: https://gerrit.osmocom.org/c/osmo-bts/+/41048/comment/b933e9d1_c2a84a7a?usp… : PS1, Line 2349: tch_ul_msg_sid(msg) = sidc; I wonder whether this msg field should be called "hr_sid" instead of "sid". -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/41048?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Id6c8c146962de2f173760889eb232693bb4229d3 Gerrit-Change-Number: 41048 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Comment-Date: Fri, 05 Sep 2025 12:59:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

2 weeks, 3 days

1
0
0 0

[S] Change in ...osmo-python-tests[master]: debian: add python3-osmopy-{libs,utils}.install

by fixeria

Attention is currently required from: osmith. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/python/osmo-python-tests/+/41053?usp=email ) Change subject: debian: add python3-osmopy-{libs,utils}.install ...................................................................... Patch Set 1: (1 comment) File debian/python3-osmopy-libs.install: https://gerrit.osmocom.org/c/python/osmo-python-tests/+/41053/comment/e6f33… : PS1, Line 1: usr/lib > why is this file needed? looks like the contents of the -libs package stays the same, see end of: […] Yes, the package contents is not expected to change here. The idea here is to avoid overwriting Debian's automatic rules (see `debian/rules`) and facilitate installing misc files (systemd services, configs). I'll update the commit message. When `setup.py` is invoked, we get libraries in `usr/lib` and binaries in `usr/bin`. We include only the libraries for `python3-osmopy-libs`, and only the binaries for `python3-osmopy-utils`. -- To view, visit https://gerrit.osmocom.org/c/python/osmo-python-tests/+/41053?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: python/osmo-python-tests Gerrit-Branch: master Gerrit-Change-Id: I94b940789e138341792f40eedeedb73d4e4d421e Gerrit-Change-Number: 41053 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 05 Sep 2025 12:50:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>

2 weeks, 3 days

1
0
0 0

2025

2024

2023

2022

gerrit-log September 2025