pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/40995?usp=email )
Change subject: Fix wrong list entry derreference during bts_depend_find_entry()
......................................................................
Fix wrong list entry derreference during bts_depend_find_entry()
Commit 92dc38d1c2b49efd0d4626e7ad5fb2db5ae7e5bc converted
bts->depends_on from bitmask to a list, but introduced an error while
doing so, iterating the wrong list and hence derreferring wrong entries
from it.
This caused for instance sporadic malfunction where osmo-bsc refused a
BTS from connecting with "Dependency not full-filled".
Related: SYS#7062
Related: SYS#7624
Fixes: 92dc38d1c2b49efd0d4626e7ad5fb2db5ae7e5bc
Change-Id: I50c8111d71ee4493076cd2cf3d4d850fee3c0414
---
M src/osmo-bsc/bts.c
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Jenkins Builder: Verified
daniel: Looks good to me, but someone else must approve
fixeria: Looks good to me, approved
diff --git a/src/osmo-bsc/bts.c b/src/osmo-bsc/bts.c
index 730cf7a..2cc6153 100644
--- a/src/osmo-bsc/bts.c
+++ b/src/osmo-bsc/bts.c
@@ -932,7 +932,7 @@
static struct bts_depends_on_entry *bts_depend_find_entry(const struct gsm_bts *bts, gsm_bts_nr_t dep)
{
struct bts_depends_on_entry *entry;
- llist_for_each_entry(entry, &bts->trx_list, list) {
+ llist_for_each_entry(entry, &bts->depends_on, list) {
if (entry->bts_nr == dep)
return entry;
}
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/40995?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I50c8111d71ee4493076cd2cf3d4d850fee3c0414
Gerrit-Change-Number: 40995
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Attention is currently required from: pespin.
fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-bsc/+/40995?usp=email )
Change subject: Fix wrong list entry derreference during bts_depend_find_entry()
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/40995?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I50c8111d71ee4493076cd2cf3d4d850fee3c0414
Gerrit-Change-Number: 40995
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 02 Sep 2025 12:43:54 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: pespin.
daniel has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-bsc/+/40995?usp=email )
Change subject: Fix wrong list entry derreference during bts_depend_find_entry()
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/40995?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I50c8111d71ee4493076cd2cf3d4d850fee3c0414
Gerrit-Change-Number: 40995
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 02 Sep 2025 12:39:59 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-bsc/+/40995?usp=email
to look at the new patch set (#2).
Change subject: Fix wrong list entry derreference during bts_depend_find_entry()
......................................................................
Fix wrong list entry derreference during bts_depend_find_entry()
Commit 92dc38d1c2b49efd0d4626e7ad5fb2db5ae7e5bc converted
bts->depends_on from bitmask to a list, but introduced an error while
doing so, iterating the wrong list and hence derreferring wrong entries
from it.
This caused for instance sporadic malfunction where osmo-bsc refused a
BTS from connecting with "Dependency not full-filled".
Related: SYS#7062
Related: SYS#7624
Fixes: 92dc38d1c2b49efd0d4626e7ad5fb2db5ae7e5bc
Change-Id: I50c8111d71ee4493076cd2cf3d4d850fee3c0414
---
M src/osmo-bsc/bts.c
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/95/40995/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/40995?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I50c8111d71ee4493076cd2cf3d4d850fee3c0414
Gerrit-Change-Number: 40995
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/40995?usp=email )
Change subject: Fix wrong list entry derreference during bts_depend_find_entry()
......................................................................
Fix wrong list entry derreference during bts_depend_find_entry()
Commit 92dc38d1c2b49efd0d4626e7ad5fb2db5ae7e5bc converted
bts->depends_on from bitmask to a list, but introduced an error while
doing so, iterating the wrong list and hence derreferring wrong entries
from it.
This caused for instnace sporadic malfunction where osmo-bsc refused a
BTS from connecting with "Dependency not full-filled".
Related: SYS#7062
Related: SYS#7624
Fixes: 92dc38d1c2b49efd0d4626e7ad5fb2db5ae7e5bc
Change-Id: I50c8111d71ee4493076cd2cf3d4d850fee3c0414
---
M src/osmo-bsc/bts.c
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/95/40995/1
diff --git a/src/osmo-bsc/bts.c b/src/osmo-bsc/bts.c
index 730cf7a..2cc6153 100644
--- a/src/osmo-bsc/bts.c
+++ b/src/osmo-bsc/bts.c
@@ -932,7 +932,7 @@
static struct bts_depends_on_entry *bts_depend_find_entry(const struct gsm_bts *bts, gsm_bts_nr_t dep)
{
struct bts_depends_on_entry *entry;
- llist_for_each_entry(entry, &bts->trx_list, list) {
+ llist_for_each_entry(entry, &bts->depends_on, list) {
if (entry->bts_nr == dep)
return entry;
}
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/40995?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I50c8111d71ee4493076cd2cf3d4d850fee3c0414
Gerrit-Change-Number: 40995
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Attention is currently required from: fixeria, lynxis lazus, osmith.
pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/40988?usp=email )
Change subject: Introduce iu_rnc FSM
......................................................................
Patch Set 3:
(1 comment)
File src/sgsn/iu_rnc_fsm.c:
https://gerrit.osmocom.org/c/osmo-sgsn/+/40988/comment/866c1370_8489c384?us… :
PS3, Line 126: #define LEGACY_BEHAVIOR
> Is there a plan for removing the legacy behavior, maybe write an issue about it and point to it here […]
This is basically the same ifdef we already have in osmo-msc ran_peer_fsm.
I preferred keeping it in sync with what we do in osmo-msc, specially since changing to the other behavior would mean more behavioral changes I'm tyring to avoid now.
so my opinion is leave it like I presented and let everything stabilize, and we can look at this later once we find something unoptimal or problematic when running it and get some specific report.
--
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/40988?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: I18b7803500163e78ff6a684095194174b0fb6ee1
Gerrit-Change-Number: 40988
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Tue, 02 Sep 2025 12:09:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>