September 2025 - gerrit-log - lists.osmocom.org

[XL] Change in libosmo-netif[master]: bring twrtp into libosmo-netif

by falconia

Attention is currently required from: falconia. Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-netif/+/39281?usp=email to look at the new patch set (#8). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: bring twrtp into libosmo-netif ...................................................................... bring twrtp into libosmo-netif twrtp is the top layer of Themyscira Wireless RTP endpoint implementation, an alternative to Belledonne libortp. Unlike Belledonne software, ThemWi RTP library was developed specifically for use in Osmocom-based GSM, ISDN and IP-PSTN network elements, and is built on top of libosmocore primitives - thus it can function more natively in Osmocom universe than ortp. This ThemWi library was initially developed externally to Osmocom, but is now being brought into libosmo-netif so it can be used by native Osmocom projects, particularly OsmoBTS. Related: OS#6474 Change-Id: Ib63215aaf13ef8ab8f2e0c8d310164cd5c8824eb --- M include/osmocom/netif/Makefile.am A include/osmocom/netif/rtcp_defs.h A include/osmocom/netif/twrtp.h M src/Makefile.am A src/twrtp.c 5 files changed, 1,558 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/81/39281/8 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/39281?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Ib63215aaf13ef8ab8f2e0c8d310164cd5c8824eb Gerrit-Change-Number: 39281 Gerrit-PatchSet: 8 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org>

3 weeks

1
0
0 0

[XL] Change in libosmo-netif[master]: bring twjit into libosmo-netif

by falconia

Attention is currently required from: falconia, fixeria, jolly, laforge. Hello Jenkins Builder, fixeria, jolly, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-netif/+/39280?usp=email to look at the new patch set (#8). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: bring twjit into libosmo-netif ...................................................................... bring twjit into libosmo-netif twjit is the jitter buffer portion of Themyscira Wireless RTP endpoint implementation, an alternative to Belledonne libortp. Unlike Belledonne software, ThemWi RTP library was developed specifically for use in Osmocom-based GSM, ISDN and IP-PSTN network elements, and is built on top of libosmocore primitives - thus it can function more natively in Osmocom universe than ortp. This ThemWi library was initially developed externally to Osmocom, but is now being brought into libosmo-netif so it can be used by native Osmocom projects, particularly OsmoBTS. Related: OS#6474 Change-Id: Ia3be5834571ca18b68939abbcf1ce3a879156658 --- M configure.ac M contrib/libosmo-netif.spec.in M include/osmocom/netif/Makefile.am A include/osmocom/netif/twjit.h A include/osmocom/netif/twjit_private.h M src/Makefile.am A src/twjit.c A src/twjit_conf.c 8 files changed, 1,318 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/80/39280/8 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/39280?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Ia3be5834571ca18b68939abbcf1ce3a879156658 Gerrit-Change-Number: 39280 Gerrit-PatchSet: 8 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>

3 weeks

1
0
0 0

[XL] Change in osmo-ttcn3-hacks[master]: euicc: clean up superfluous encdec cpp files

by pespin

Attention is currently required from: Hoernchen, dexter, laforge. pespin has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40983?usp=email ) Change subject: euicc: clean up superfluous encdec cpp files ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40983?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ice4ab4328faf6ad34a060bc2004a44de10691cff Gerrit-Change-Number: 40983 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 01 Sep 2025 08:52:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

3 weeks, 1 day

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: euicc: changes and extensions to support es9p and es2p testing

by pespin

Attention is currently required from: Hoernchen, dexter, laforge. pespin has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40982?usp=email ) Change subject: euicc: changes and extensions to support es9p and es2p testing ...................................................................... Patch Set 2: Code-Review+1 (1 comment) File library/euicc/es9p_Types_JSON.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40982/comment/601209a1_a265… : PS2, Line 212: type record DecodedRPPReponse_Wrap { looks like this should be a union instead? Or can you have both fields present at the same time? -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40982?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9c622751e195d33f6f0a832265d6b10674d1c75c Gerrit-Change-Number: 40982 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 01 Sep 2025 08:51:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

3 weeks, 1 day

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: es12_Types_JSON: add ES12 JSON encoder/decoder

by pespin

Attention is currently required from: Hoernchen, dexter, laforge. pespin has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40981?usp=email ) Change subject: es12_Types_JSON: add ES12 JSON encoder/decoder ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40981?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I875cbb3a6dab6ac1eac5df1199f6fb71738a744e Gerrit-Change-Number: 40981 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 01 Sep 2025 08:49:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

3 weeks, 1 day

1
0
0 0

[L] Change in osmo-ttcn3-hacks[master]: es2p_Types_JSON: add ES2p JSON encoder/decoder

by pespin

Attention is currently required from: Hoernchen, dexter, laforge. pespin has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40980?usp=email ) Change subject: es2p_Types_JSON: add ES2p JSON encoder/decoder ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40980?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic6e230bdd0b2c43a5183cd1f53b930e6f3c53e66 Gerrit-Change-Number: 40980 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 01 Sep 2025 08:48:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

3 weeks, 1 day

1
0
0 0

[XL] Change in libosmo-netif[master]: bring twrtp into libosmo-netif

by pespin

Attention is currently required from: falconia. pespin has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/libosmo-netif/+/39281?usp=email ) Change subject: bring twrtp into libosmo-netif ...................................................................... Patch Set 7: (9 comments) File include/osmocom/netif/twrtp.h: https://gerrit.osmocom.org/c/libosmo-netif/+/39281/comment/24aabbf7_88ec686… : PS1, Line 26: struct osmo_twrtp_stats { > Please see how I handle it in Patchset 7. Done File src/twrtp.c: https://gerrit.osmocom.org/c/libosmo-netif/+/39281/comment/e32d73c2_19c0a0e… : PS6, Line 231: endp->iofd_rtp = osmo_iofd_setup(endp, -1, NULL, > Please see how I handle it in Patchset 7. Done File src/twrtp.c: https://gerrit.osmocom.org/c/libosmo-netif/+/39281/comment/6e241ec1_b6a1b9c… : PS7, Line 304: close(rtcp_fd); if (rtcp_fd >= 0) close(rtcp_fd); https://gerrit.osmocom.org/c/libosmo-netif/+/39281/comment/c2e0c004_3ba7c52… : PS7, Line 313: close(rtcp_fd); if (rtcp_fd >= 0) close(rtcp_fd); https://gerrit.osmocom.org/c/libosmo-netif/+/39281/comment/15f382b7_7a580ec… : PS7, Line 322: close(rtcp_fd); if (rtcp_fd >= 0) close(rtcp_fd); https://gerrit.osmocom.org/c/libosmo-netif/+/39281/comment/5c828ce9_226dadf… : PS7, Line 333: close(rtcp_fd); if (rtcp_fd >= 0) close(rtcp_fd); https://gerrit.osmocom.org/c/libosmo-netif/+/39281/comment/a7083f49_6118359… : PS7, Line 343: close(rtcp_fd); if (rtcp_fd >= 0) close(rtcp_fd); https://gerrit.osmocom.org/c/libosmo-netif/+/39281/comment/3f71ef68_97e0184… : PS7, Line 348: return 0; You could add return goto tags here for failing cases to make closing/freeing more organized and clean. File src/twrtp_base.c: https://gerrit.osmocom.org/c/libosmo-netif/+/39281/comment/7201a664_e91a75d… : PS1, Line 132: * another variant of this API with that alternative behavior. > Please see how I handle it in Patchset 7. Done -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/39281?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Ib63215aaf13ef8ab8f2e0c8d310164cd5c8824eb Gerrit-Change-Number: 39281 Gerrit-PatchSet: 7 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Comment-Date: Mon, 01 Sep 2025 08:45:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: falconia <falcon(a)freecalypso.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

3 weeks, 1 day

1
0
0 0

[XL] Change in libosmo-netif[master]: bring twjit into libosmo-netif

by pespin

Attention is currently required from: falconia, fixeria, jolly, laforge. pespin has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/libosmo-netif/+/39280?usp=email ) Change subject: bring twjit into libosmo-netif ...................................................................... Patch Set 7: (1 comment) File include/osmocom/netif/twjit.h: https://gerrit.osmocom.org/c/libosmo-netif/+/39280/comment/ec1f3339_b1caaf2… : PS7, Line 173: int osmo_twjit_set_buffer_depth(struct osmo_twjit_config *conf, I'd like these to be prefixed osmo_twjit_config_set_*, like you did to the above one. Not mandatory, but maybe since a config ptr is passed to osmo_twjit_create you may want to move these osmo_twjit_config APIs above that one. Other than that I'm fine with it. -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/39280?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Ia3be5834571ca18b68939abbcf1ce3a879156658 Gerrit-Change-Number: 39280 Gerrit-PatchSet: 7 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 01 Sep 2025 08:41:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

3 weeks, 1 day

1
0
0 0

[XS] Change in osmo-dev[master]: gen_makefile: --targets: fix subdir projects

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-dev/+/40978?usp=email ) Change subject: gen_makefile: --targets: fix subdir projects ...................................................................... gen_makefile: --targets: fix subdir projects Some projects are in subdirectories of git repositories, such as simtrace2_host, or osmocom-bb_layer23. When filtering the targets to be added to the Makefile, we must also add the main projects of such projects in subdirectories, so Makefile rules like the following work: .make.simtrace2_host.clone: .make.simtrace2.clone Fix for: make: *** No rule to make target '.make.simtrace2.clone', needed by '.make.simtrace2_host.clone'. Stop. Fixes: 1d13c9d7 ("gen_makefile: add --targets") Change-Id: I136f0d9cd982653b109005aeb35885b6f015eec8 --- M gen_makefile.py M tests/test_gen_makefile.py 2 files changed, 8 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve fixeria: Looks good to me, approved diff --git a/gen_makefile.py b/gen_makefile.py index 4730c59..3885e10 100755 --- a/gen_makefile.py +++ b/gen_makefile.py @@ -243,6 +243,12 @@ print() sys.exit(1) + # simtrace2_host -> simtrace2 + if "_" in project: + project_main = project.split("_")[0] + if project_main in projects_deps and project_main not in ret: + queue += [project_main] + deps = projects_deps[project] ret[project] = deps diff --git a/tests/test_gen_makefile.py b/tests/test_gen_makefile.py index 6232003..622f6e7 100644 --- a/tests/test_gen_makefile.py +++ b/tests/test_gen_makefile.py @@ -67,10 +67,11 @@ def test_gen_makefile_with_targets_arg(tmp_path): - run_cmd(["./gen_makefile.py", "-m", tmp_path, "--targets", "trxcon,osmo-mgw"], cwd=osmo_dev_path) + run_cmd(["./gen_makefile.py", "-m", tmp_path, "--targets", "trxcon,osmo-mgw,simtrace2_host"], cwd=osmo_dev_path) run_cmd("grep -q '^osmocom-bb_trxcon_files :=' Makefile", cwd=tmp_path, shell=True) run_cmd("grep -q '^osmo-mgw_files :=' Makefile", cwd=tmp_path, shell=True) run_cmd("grep -q '^libosmocore_files :=' Makefile", cwd=tmp_path, shell=True) + run_cmd("grep -q '^simtrace2_files :=' Makefile", cwd=tmp_path, shell=True) run_cmd("! grep -q '^osmo-bts_files :=' Makefile", cwd=tmp_path, shell=True) run_cmd("! grep -q '^osmo-s1gw_files :=' Makefile", cwd=tmp_path, shell=True) run_cmd("! grep -q '^open5gs_files :=' Makefile", cwd=tmp_path, shell=True) -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/40978?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: I136f0d9cd982653b109005aeb35885b6f015eec8 Gerrit-Change-Number: 40978 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

3 weeks, 1 day

1
0
0 0

[XS] Change in osmo-dev[master]: gen_makefile: --targets: fix subdir projects

by fixeria

Attention is currently required from: osmith. fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-dev/+/40978?usp=email ) Change subject: gen_makefile: --targets: fix subdir projects ...................................................................... Patch Set 1: Code-Review+2 (1 comment) File gen_makefile.py: https://gerrit.osmocom.org/c/osmo-dev/+/40978/comment/b89d12e5_764eb93a?usp… : PS1, Line 247: if "_" in project: > No, because this doesn't change `project` and because it checks if the resulting splitted string is […] Acknowledged -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/40978?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: I136f0d9cd982653b109005aeb35885b6f015eec8 Gerrit-Change-Number: 40978 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Mon, 01 Sep 2025 07:11:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

3 weeks, 1 day

1
0
0 0

2025

2024

2023

2022

gerrit-log September 2025