August 2025 - gerrit-log - lists.osmocom.org

[M] Change in ...osmo-s1gw[master]: enb_uptime: track eNB uptime

by fixeria

Attention is currently required from: laforge. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40831?usp=email ) Change subject: enb_uptime: track eNB uptime ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40831?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: Ie8a06fafa2ce3e7a5aec1eb8e71af3053599cf24 Gerrit-Change-Number: 40831 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 12 Aug 2025 10:11:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

4 weeks, 1 day

1
0
0 0

[XS] Change in libosmo-gprs[master]: tests: fix for debian 13 armv7l

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/40865?usp=email ) Change subject: tests: fix for debian 13 armv7l ...................................................................... tests: fix for debian 13 armv7l In Debian 13 armv7l, time_t and suseconds_t are "long long int" instead of "long unsigned int" as seen on x86_64 and aarch64. Fix it by casting to "long unsigned int". Related: OS#6828 Change-Id: I416b31dd11a82ad52f6a662d7e099123a5c77fff --- M tests/gmm/gmm_prim_test.h M tests/rlcmac/rlcmac_prim_test.c 2 files changed, 4 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-gprs refs/changes/65/40865/1 diff --git a/tests/gmm/gmm_prim_test.h b/tests/gmm/gmm_prim_test.h index 1e231b1..67391cb 100644 --- a/tests/gmm/gmm_prim_test.h +++ b/tests/gmm/gmm_prim_test.h @@ -10,7 +10,8 @@ osmo_clock_gettime(CLOCK_MONOTONIC, &ts); \ osmo_gettimeofday(&tv, NULL); \ fprintf(stdout, "sys={%lu.%06lu}, mono={%lu.%06lu}: " fmt "\n", \ - tv.tv_sec, tv.tv_usec, ts.tv_sec, ts.tv_nsec/1000, ##args); \ + (unsigned int long) tv.tv_sec, (unsigned int long) tv.tv_usec, \ + (unsigned int long) ts.tv_sec, ts.tv_nsec/1000, ##args); \ } while (0) static void clock_override_enable(bool enable) diff --git a/tests/rlcmac/rlcmac_prim_test.c b/tests/rlcmac/rlcmac_prim_test.c index 0697abf..95a50e7 100644 --- a/tests/rlcmac/rlcmac_prim_test.c +++ b/tests/rlcmac/rlcmac_prim_test.c @@ -245,7 +245,8 @@ osmo_clock_gettime(CLOCK_MONOTONIC, &ts); \ osmo_gettimeofday(&tv, NULL); \ fprintf(stdout, "sys={%lu.%06lu}, mono={%lu.%06lu}: " fmt "\n", \ - tv.tv_sec, tv.tv_usec, ts.tv_sec, ts.tv_nsec/1000, ##args); \ + (unsigned int long) tv.tv_sec, (unsigned int long) tv.tv_usec, \ + (unsigned int long) ts.tv_sec, ts.tv_nsec/1000, ##args); \ } while (0) static void clock_override_enable(bool enable) -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/40865?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I416b31dd11a82ad52f6a662d7e099123a5c77fff Gerrit-Change-Number: 40865 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

4 weeks, 1 day

1
0
0 0

[XS] Change in libosmocore[master]: tests: fix for debian 13 armv7l

by fixeria

Attention is currently required from: osmith. fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/libosmocore/+/40864?usp=email ) Change subject: tests: fix for debian 13 armv7l ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/40864?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I9580606d66bb0f891c0ef0179f99e2b901a8cf1c Gerrit-Change-Number: 40864 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 12 Aug 2025 09:13:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

4 weeks, 1 day

1
0
0 0

[XS] Change in libosmocore[master]: tests: fix for debian 13 armv7l

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/40864?usp=email ) Change subject: tests: fix for debian 13 armv7l ...................................................................... tests: fix for debian 13 armv7l In Debian 13 armv7l, time_t and suseconds_t are "long long int" instead of "long unsigned int" as seen on x86_64 and aarch64. This causes the the tdef, time_cc and iuup tests to fail. Example: -sys={0.000000}, clock_override_set +sys={4206924.000000}, (null) _tinit_timeout_retrans_transport_prim_cb() Transport: DL len=22: e0 00 df 99 16 00 51 67 3c 01 27 00 00 82 00 00 00 17 10 00 01 00 -sys={1.000000}, clock_override_set +sys={4206924.000001}, (null) _tinit_timeout_retrans_transport_prim_cb() Transport: DL len=22: e0 00 df 99 16 00 51 67 3c 01 27 00 00 82 00 00 00 17 10 00 01 00 -sys={2.000000}, clock_override_set +sys={4206924.000002}, (null) … Furthermore it causes compiler warnings such as: iuup/iuup_test.c: In function 'clock_override_set': iuup/iuup_test.c:169:24: warning: format '%lu' expects argument of type 'long unsigned int', but argument 2 has type '__time64_t' {aka 'long long int'} [-Wformat=] 169 | printf("sys={%lu.%06lu}, %s\n", osmo_gettimeofday_override_time.tv_sec, | ~~^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | | | | long unsigned int __time64_t {aka long long int} | %llu iuup/iuup_test.c:169:30: warning: format '%lu' expects argument of type 'long unsigned int', but argument 3 has type '__suseconds64_t' {aka 'long long int'} [-Wformat=] 169 | printf("sys={%lu.%06lu}, %s\n", osmo_gettimeofday_override_time.tv_sec, | ~~~~^ | | | long unsigned int | %06llu 170 | osmo_gettimeofday_override_time.tv_usec, __func__); | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | | | __suseconds64_t {aka long long int} CCLD iuup/iuup_test Fix it by casting to "long unsigned int". Related: OS#6828 Change-Id: I9580606d66bb0f891c0ef0179f99e2b901a8cf1c --- M tests/iuup/iuup_test.c M tests/tdef/tdef_test.c M tests/time_cc/time_cc_test.c 3 files changed, 5 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/64/40864/1 diff --git a/tests/iuup/iuup_test.c b/tests/iuup/iuup_test.c index 7798aa2..725a7d9 100644 --- a/tests/iuup/iuup_test.c +++ b/tests/iuup/iuup_test.c @@ -163,8 +163,8 @@ { osmo_gettimeofday_override_time.tv_sec = sec + usec / (1000*1000); osmo_gettimeofday_override_time.tv_usec = usec % (1000*1000); - printf("sys={%lu.%06lu}, %s\n", osmo_gettimeofday_override_time.tv_sec, - osmo_gettimeofday_override_time.tv_usec, __func__); + printf("sys={%lu.%06lu}, %s\n", (unsigned int long) osmo_gettimeofday_override_time.tv_sec, + (unsigned int long) osmo_gettimeofday_override_time.tv_usec, __func__); } void test_crc(void) diff --git a/tests/tdef/tdef_test.c b/tests/tdef/tdef_test.c index 710a4aa..1c2b04d 100644 --- a/tests/tdef/tdef_test.c +++ b/tests/tdef/tdef_test.c @@ -335,7 +335,8 @@ } osmo_timer_remaining(&fi->timer, &osmo_gettimeofday_override_time, &remaining); - printf(", %lu.%06lu s remaining\n", remaining.tv_sec, remaining.tv_usec); + printf(", %lu.%06lu s remaining\n", (unsigned int long) remaining.tv_sec, + (unsigned int long) remaining.tv_usec); } diff --git a/tests/time_cc/time_cc_test.c b/tests/time_cc/time_cc_test.c index e4a5aaf..9d1ab5c 100644 --- a/tests/time_cc/time_cc_test.c +++ b/tests/time_cc/time_cc_test.c @@ -165,7 +165,7 @@ osmo_clock_override_add(CLOCK_MONOTONIC, ms / 1000, (uint64_t)(ms % 1000) * 1000000); \ osmo_gettimeofday_override_add(ms / 1000, (uint64_t)(ms % 1000) * 1000); \ printf("%d ADD_MILLISECS(" #ms ") --> %ld.%03ld", my_obj.flag_cc_round.flag_state, \ - now->tv_sec, now->tv_nsec/1000000); \ + (unsigned int long) now->tv_sec, now->tv_nsec/1000000); \ printf("\n"); \ } while (0) -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/40864?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I9580606d66bb0f891c0ef0179f99e2b901a8cf1c Gerrit-Change-Number: 40864 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

4 weeks, 1 day

1
0
0 0

[S] Change in osmo-ci[master]: jobs/gerrit: binpkgs: update debian versions

by fixeria

Attention is currently required from: osmith. fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/40861?usp=email ) Change subject: jobs/gerrit: binpkgs: update debian versions ...................................................................... Patch Set 1: (1 comment) File jobs/gerrit-verifications.yml: https://gerrit.osmocom.org/c/osmo-ci/+/40861/comment/6f531ade_87523675?usp=… : PS1, Line 107: debian:11 debian:13 > Yes, this is intentional. […] Acknowledged -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/40861?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ifc1d603c9e6e5054ad2f121f53ba3fb7e4d05286 Gerrit-Change-Number: 40861 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 12 Aug 2025 08:35:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

4 weeks, 1 day

1
0
0 0

[S] Change in osmo-ci[master]: jobs/gerrit: binpkgs: update debian versions

by osmith

Attention is currently required from: fixeria. osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/40861?usp=email ) Change subject: jobs/gerrit: binpkgs: update debian versions ...................................................................... Patch Set 1: (1 comment) File jobs/gerrit-verifications.yml: https://gerrit.osmocom.org/c/osmo-ci/+/40861/comment/0049089e_742f01a9?usp=… : PS1, Line 107: debian:11 debian:13 > AFAIU, so far we have been building packages for `debian:10` and `debian:12`, but not for `debian:11 […] Yes, this is intentional. The idea is that we build for the most recent and oldest versions, assuming that then the version in the middle is unlikely to fail if the other two succeed. I think so far this has worked in all cases (and if it occasionally doesn't, it is not a big problem). So this is a trade-off for getting the builds done faster while still testing the most interesting versions. -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/40861?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ifc1d603c9e6e5054ad2f121f53ba3fb7e4d05286 Gerrit-Change-Number: 40861 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 12 Aug 2025 06:15:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

4 weeks, 1 day

1
0
0 0

[XS] Change in osmo-msc[master]: transaction: Fix potenial use after free of members

by matanp

Attention is currently required from: fixeria, laforge. matanp has posted comments on this change by matanp. ( https://gerrit.osmocom.org/c/osmo-msc/+/40853?usp=email ) Change subject: transaction: Fix potenial use after free of members ...................................................................... Patch Set 2: (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-msc/+/40853/comment/4216be81_02d037ac?usp… : PS2, Line 9: In the case of multithreading > We do not employ multithreading in osmo-msc and unlikely ever will, so I don't think it makes sense […] Shall I remove this commit or wait to @laforge@osmocom.org? -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/40853?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I177959fb298ae04c4e8df877582fc9a1bd4dc2cf Gerrit-Change-Number: 40853 Gerrit-PatchSet: 2 Gerrit-Owner: matanp <matan1008(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 12 Aug 2025 04:36:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

4 weeks, 1 day

1
0
0 0

[XS] Change in osmo-msc[master]: transaction: Fix potenial use after free of members

by fixeria

Attention is currently required from: laforge, matanp. fixeria has posted comments on this change by matanp. ( https://gerrit.osmocom.org/c/osmo-msc/+/40853?usp=email ) Change subject: transaction: Fix potenial use after free of members ...................................................................... Patch Set 2: Code-Review-1 (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-msc/+/40853/comment/e001f1d0_58e6747b?usp… : PS2, Line 9: In the case of multithreading We do not employ multithreading in osmo-msc and unlikely ever will, so I don't think it makes sense to merge this patch, sorry. No need to complicate the code due to circumstances that are not the case. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/40853?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I177959fb298ae04c4e8df877582fc9a1bd4dc2cf Gerrit-Change-Number: 40853 Gerrit-PatchSet: 2 Gerrit-Owner: matanp <matan1008(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: matanp <matan1008(a)gmail.com> Gerrit-Comment-Date: Mon, 11 Aug 2025 22:25:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

4 weeks, 1 day

1
0
0 0

[XS] Change in osmo-msc[master]: silent_call: Fix use after free of paging request

by fixeria

Attention is currently required from: matanp. fixeria has posted comments on this change by matanp. ( https://gerrit.osmocom.org/c/osmo-msc/+/40852?usp=email ) Change subject: silent_call: Fix use after free of paging request ...................................................................... Patch Set 2: Code-Review+1 (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-msc/+/40852/comment/ea25b850_934c07c7?usp… : PS2, Line 10: In some cases My curiosity was piqued, so I've implemented a reproducer testcase: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40863 Current osmo-msc segfaults when running it. This patch fixes the problem. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/40852?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I93913d189800d71f82c013b6e946bd63db362f65 Gerrit-Change-Number: 40852 Gerrit-PatchSet: 2 Gerrit-Owner: matanp <matan1008(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: matanp <matan1008(a)gmail.com> Gerrit-Comment-Date: Mon, 11 Aug 2025 22:19:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

4 weeks, 1 day

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: Makefile: add 'clean-logs' target

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40862?usp=email ) Change subject: Makefile: add 'clean-logs' target ...................................................................... Makefile: add 'clean-logs' target When running tests manually I oftentimes end up with hundreds of *.log files in testsuite directories. The present patch adds a convenience target for removing them. Change-Id: Id0597f9eeea9e128ce38a2b19f2126c729e71ffd --- M Makefile 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/62/40862/1 diff --git a/Makefile b/Makefile index 7a9ddb8..75e79ff 100644 --- a/Makefile +++ b/Makefile @@ -151,3 +151,6 @@ # trivial to clean up the builddir manually. clean: rm -rf _build + +clean-logs: + find $(SUBDIRS) -name "*.log" -print -delete -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40862?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id0597f9eeea9e128ce38a2b19f2126c729e71ffd Gerrit-Change-Number: 40862 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

4 weeks, 1 day

1
0
0 0

2025

2024

2023

2022

gerrit-log August 2025