July 2025 - gerrit-log - lists.osmocom.org

[M] Change in osmo-ttcn3-hacks[master]: sctp: Introduce test TC_stat_bsc_sctp_disconnected

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40681?usp=email ) Change subject: sctp: Introduce test TC_stat_bsc_sctp_disconnected ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40681?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic67d9d8120e9bd09b0e54b237e93f49f79262be0 Gerrit-Change-Number: 40681 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 15 Jul 2025 08:25:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

2 weeks, 3 days

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: smlc: Add suport to obtain statsd output

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40680?usp=email ) Change subject: smlc: Add suport to obtain statsd output ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40680?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I52813397890a85326a85b3580fd605f9ac10a26d Gerrit-Change-Number: 40680 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 15 Jul 2025 08:24:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

2 weeks, 3 days

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: smlc: Use static sigtran config between osmo-msc and osmo-stp

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40676?usp=email ) Change subject: smlc: Use static sigtran config between osmo-msc and osmo-stp ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40676?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I008dba252da29f445c52151c7b65428ca7054ed0 Gerrit-Change-Number: 40676 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 15 Jul 2025 08:23:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

2 weeks, 3 days

1
0
0 0

[XS] Change in osmo-sgsn[master]: gprs_gmm: fix endianess of GSM48_IE_GMM_PDP_CTX_STATUS

by lynxis lazus

lynxis lazus has submitted this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/40653?usp=email ) Change subject: gprs_gmm: fix endianess of GSM48_IE_GMM_PDP_CTX_STATUS ...................................................................... gprs_gmm: fix endianess of GSM48_IE_GMM_PDP_CTX_STATUS The pdp_status is actually encoded as little endian, but there is no tlvp_val16le yet. Change-Id: Ib9bee2f8d0b1f89986d15cf3ce6404ad76378c8c --- M src/sgsn/gprs_gmm.c 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved fixeria: Looks good to me, but someone else must approve daniel: Looks good to me, but someone else must approve diff --git a/src/sgsn/gprs_gmm.c b/src/sgsn/gprs_gmm.c index c34c1a1..1fa73b9 100644 --- a/src/sgsn/gprs_gmm.c +++ b/src/sgsn/gprs_gmm.c @@ -1975,7 +1975,8 @@ /* Look at PDP Context Status IE and see if MS's view of * activated/deactivated NSAPIs agrees with our view */ if (TLVP_PRESENT(&tp, GSM48_IE_GMM_PDP_CTX_STATUS)) { - uint16_t pdp_status = tlvp_val16be(&tp, GSM48_IE_GMM_PDP_CTX_STATUS); + /* TODO: Use tlvp_val16le when available */ + uint16_t pdp_status = osmo_load16le(TLVP_VAL(&tp, GSM48_IE_GMM_PDP_CTX_STATUS)); process_ms_ctx_status(ctx, pdp_status); -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/40653?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Ib9bee2f8d0b1f89986d15cf3ce6404ad76378c8c Gerrit-Change-Number: 40653 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

2 weeks, 3 days

1
0
0 0

[XS] Change in osmo-sgsn[master]: gprs_gmm: fix endianess of GSM48_IE_GMM_PDP_CTX_STATUS

by fixeria

Attention is currently required from: lynxis lazus. fixeria has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/40653?usp=email ) Change subject: gprs_gmm: fix endianess of GSM48_IE_GMM_PDP_CTX_STATUS ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/40653?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Ib9bee2f8d0b1f89986d15cf3ce6404ad76378c8c Gerrit-Change-Number: 40653 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 14 Jul 2025 19:37:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

2 weeks, 3 days

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: smlc: Add suport to obtain statsd output

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40680?usp=email ) Change subject: smlc: Add suport to obtain statsd output ...................................................................... smlc: Add suport to obtain statsd output It will be used in a follow-up commit introducing a new test. Change-Id: I52813397890a85326a85b3580fd605f9ac10a26d --- M smlc/SMLC_Tests.default M smlc/SMLC_Tests.ttcn M smlc/gen_links.sh M smlc/osmo-smlc.cfg M smlc/regen_makefile.sh 5 files changed, 40 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/80/40680/1 diff --git a/smlc/SMLC_Tests.default b/smlc/SMLC_Tests.default index 485d215..4fa1adc 100644 --- a/smlc/SMLC_Tests.default +++ b/smlc/SMLC_Tests.default @@ -12,6 +12,15 @@ *.SMLCVTY.CTRL_CLIENT_CLEANUP_LINEFEED := "yes" *.SMLCVTY.CTRL_DETECT_CONNECTION_ESTABLISHMENT_RESULT := "yes" *.SMLCVTY.PROMPT1 := "OsmoSMLC> " +*.STATSVTY.CTRL_MODE := "client" +*.STATSVTY.CTRL_HOSTNAME := "127.0.0.1" +*.STATSVTY.CTRL_PORTNUM := "4271" +*.STATSVTY.CTRL_LOGIN_SKIPPED := "yes" +*.STATSVTY.CTRL_DETECT_SERVER_DISCONNECTED := "yes" +*.STATSVTY.CTRL_READMODE := "buffered" +*.STATSVTY.CTRL_CLIENT_CLEANUP_LINEFEED := "yes" +*.STATSVTY.CTRL_DETECT_CONNECTION_ESTABLISHMENT_RESULT := "yes" +*.STATSVTY.PROMPT1 := "OsmoSMLC> " [MODULE_PARAMETERS] Osmocom_VTY_Functions.mp_prompt_prefix := "OsmoSMLC"; diff --git a/smlc/SMLC_Tests.ttcn b/smlc/SMLC_Tests.ttcn index 2a50666..7bd7c26 100644 --- a/smlc/SMLC_Tests.ttcn +++ b/smlc/SMLC_Tests.ttcn @@ -43,6 +43,11 @@ import from SCCP_Templates all; +import from StatsD_Types all; +import from StatsD_CodecPort all; +import from StatsD_CodecPort_CtrlFunct all; +import from StatsD_Checker all; + import from SCCPasp_Types all; import from BSC_ConnectionHandler all; @@ -54,12 +59,16 @@ { "foo:bar", 0 } }; -type component test_CT extends CTRL_Adapter_CT { +type component test_CT extends CTRL_Adapter_CT, StatsD_ConnHdlr { var BSSAP_LE_Adapter g_bssap_le[NUM_BSC]; port BSSAP_LE_CODEC_PT BSSAP_LE; port TELNETasp_PT SMLCVTY; + /* StatsD */ + var StatsD_Checker_CT vc_STATSD; + var float g_statd_timeout := 5.0; + /* are we initialized yet */ var boolean g_initialized := false; @@ -86,6 +95,10 @@ /* IP address at which the test binds */ charstring mp_test_ip := "127.0.0.1"; + /* port number to which to listen for STATSD metrics */ + integer mp_statsd_port := 8125; + charstring mp_statsd_prefix := "TTCN3."; + BSSAP_LE_Configurations mp_bssap_le_cfg := { { sccp_service_type := "mtp3_itu", @@ -178,6 +191,8 @@ f_bssap_le_adapter_init(g_bssap_le[bssap_le_idx], mp_bssap_le_cfg[bssap_le_idx], "VirtBSC", BSC_BssapLeOps); f_bssap_le_adapter_start(g_bssap_le[bssap_le_idx]); } + + f_init_statsd("SMLC_Test", vc_STATSD, mp_test_ip, mp_statsd_port, g_statd_timeout); } function f_init_vty(charstring id := "foo") runs on test_CT { diff --git a/smlc/gen_links.sh b/smlc/gen_links.sh index 4aeedd8..3308a0b 100755 --- a/smlc/gen_links.sh +++ b/smlc/gen_links.sh @@ -69,6 +69,7 @@ DIR=../library FILES="Misc_Helpers.ttcn General_Types.ttcn Osmocom_Types.ttcn GSM_Types.ttcn Osmocom_VTY_Functions.ttcn Native_Functions.ttcn Native_FunctionDefs.cc IPA_Types.ttcn IPA_CodecPort.ttcn IPA_CodecPort_CtrlFunct.ttcn IPA_CodecPort_CtrlFunctDef.cc IPA_Emulation.ttcnpp L3_Templates.ttcn BSSMAP_Templates.ttcn BSSAP_LE_Types.ttcn RAN_Emulation.ttcnpp RLCMAC_CSN1_Templates.ttcn RLCMAC_CSN1_Types.ttcn GSM_RR_Types.ttcn RSL_Types.ttcn RSL_Emulation.ttcn MGCP_Emulation.ttcn SDP_Templates.ttcn MGCP_Types.ttcn MGCP_Templates.ttcn MGCP_CodecPort.ttcn MGCP_CodecPort_CtrlFunct.ttcn MGCP_CodecPort_CtrlFunctDef.cc BSSAP_CodecPort.ttcn RAN_Adapter.ttcnpp Osmocom_CTRL_Types.ttcn Osmocom_CTRL_Functions.ttcn Osmocom_CTRL_Adapter.ttcn RTP_CodecPort.ttcn RTP_CodecPort_CtrlFunct.ttcn RTP_CodecPort_CtrlFunctDef.cc RTP_Emulation.ttcn IuUP_Types.ttcn IuUP_EncDec.cc IuUP_Emulation.ttcn SCCP_Templates.ttcn IPA_Testing.ttcn GSM_SystemInformation.ttcn GSM_RestOctets.ttcn " FILES+="BSSAP_LE_CodecPort.ttcn BSSAP_LE_Emulation.ttcn BSSAP_LE_Adapter.ttcn BSSLAP_Types.ttcn BSSMAP_LE_Templates.ttcn " +FILES+="StatsD_Types.ttcn StatsD_CodecPort.ttcn StatsD_CodecPort_CtrlFunct.ttcn StatsD_CodecPort_CtrlFunctdef.cc StatsD_Checker.ttcnpp " gen_links $DIR $FILES diff --git a/smlc/osmo-smlc.cfg b/smlc/osmo-smlc.cfg index d25c873..d034e9d 100644 --- a/smlc/osmo-smlc.cfg +++ b/smlc/osmo-smlc.cfg @@ -10,11 +10,21 @@ logging print extended-timestamp 1 logging print file basename last logging level set-all debug - +! +stats interval 0 +stats reporter statsd + prefix TTCN3 + level subscriber + remote-ip 127.0.0.203 + remote-port 8125 + flush-period 1 + mtu 1024 + enable +! line vty no login bind 0.0.0.0 - +! cs7 instance 0 point-code 0.23.6 asp asp-clnt-Lb-0 2905 2905 m3ua diff --git a/smlc/regen_makefile.sh b/smlc/regen_makefile.sh index ed37dac..c8e5e23 100755 --- a/smlc/regen_makefile.sh +++ b/smlc/regen_makefile.sh @@ -16,6 +16,7 @@ RTP_EncDec.cc SCTPasp_PT.cc SDP_EncDec.cc + StatsD_CodecPort_CtrlFunctdef.cc TCCConversion.cc TCCInterface.cc TELNETasp_PT.cc @@ -29,6 +30,7 @@ -DRAN_EMULATION_BSSAP -DRAN_EMULATION_MGCP -DRAN_EMULATION_CTRL + -DSTATSD_HAVE_VTY -DUSE_MTP3_DISTRIBUTOR " -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40680?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I52813397890a85326a85b3580fd605f9ac10a26d Gerrit-Change-Number: 40680 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

2 weeks, 3 days

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: sctp: Introduce test TC_stat_bsc_sctp_disconnected

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40681?usp=email ) Change subject: sctp: Introduce test TC_stat_bsc_sctp_disconnected ...................................................................... sctp: Introduce test TC_stat_bsc_sctp_disconnected Change-Id: Ic67d9d8120e9bd09b0e54b237e93f49f79262be0 Related: OS#5917 Depends: osmo-smlc.git Change-Id Ib01576036f34ac7f21c5bce0155b50932eb9b72a --- M smlc/SMLC_Tests.default M smlc/SMLC_Tests.ttcn M smlc/expected-results.xml 3 files changed, 101 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/81/40681/1 diff --git a/smlc/SMLC_Tests.default b/smlc/SMLC_Tests.default index 4fa1adc..c9cabe8 100644 --- a/smlc/SMLC_Tests.default +++ b/smlc/SMLC_Tests.default @@ -21,6 +21,15 @@ *.STATSVTY.CTRL_CLIENT_CLEANUP_LINEFEED := "yes" *.STATSVTY.CTRL_DETECT_CONNECTION_ESTABLISHMENT_RESULT := "yes" *.STATSVTY.PROMPT1 := "OsmoSMLC> " +*.STPVTY.CTRL_MODE := "client" +*.STPVTY.CTRL_HOSTNAME := "127.0.0.1" +*.STPVTY.CTRL_PORTNUM := "4239" +*.STPVTY.CTRL_LOGIN_SKIPPED := "yes" +*.STPVTY.CTRL_DETECT_SERVER_DISCONNECTED := "yes" +*.STPVTY.CTRL_READMODE := "buffered" +*.STPVTY.CTRL_CLIENT_CLEANUP_LINEFEED := "yes" +*.STPVTY.CTRL_DETECT_CONNECTION_ESTABLISHMENT_RESULT := "yes" +*.STPVTY.PROMPT1 := "OsmoSTP> " [MODULE_PARAMETERS] Osmocom_VTY_Functions.mp_prompt_prefix := "OsmoSMLC"; diff --git a/smlc/SMLC_Tests.ttcn b/smlc/SMLC_Tests.ttcn index 7bd7c26..be69c7d 100644 --- a/smlc/SMLC_Tests.ttcn +++ b/smlc/SMLC_Tests.ttcn @@ -64,6 +64,7 @@ port BSSAP_LE_CODEC_PT BSSAP_LE; port TELNETasp_PT SMLCVTY; + port TELNETasp_PT STPVTY; /* StatsD */ var StatsD_Checker_CT vc_STATSD; @@ -207,6 +208,31 @@ "sccp-timer iar " & int2str(g_smlc_sccp_timer_iar)}); } +private function f_init_vty_stp() runs on test_CT { + if (STPVTY.checkstate("Mapped")) { + /* skip initialization if already executed once */ + return; + } + map(self:STPVTY, system:STPVTY); + f_vty_set_prompts(STPVTY, prompt_prefix := "OsmoSTP"); + f_vty_transceive(STPVTY, "enable"); +} + +private function f_vty_stp_smlc_asp_cmd(charstring cmd) runs on test_CT +{ + var charstring asp_name := "smlc0-0"; + var charstring loc_port := int2str(2905); + var charstring rem_port := int2str(2905); + var charstring asp_proto := "m3ua"; + var charstring asp_node := "asp " & asp_name & " " & loc_port & " " & rem_port & " " & asp_proto; + f_vty_config2(STPVTY, {"cs7 instance 0", asp_node}, cmd); +} + +private function f_smlc_stats_prefix() return charstring +{ + return mp_statsd_prefix & "smlc.0."; +} + type function void_fn(charstring id) runs on BSC_ConnHdlr; private function f_connect_handler(inout BSC_ConnHdlr vc_conn, integer bssap_le_idx := 0) runs on test_CT { @@ -495,12 +521,77 @@ vc_conn.done; } +/* When the last local SCTP link/ASP is terminated, last AS goes inactive + * and a SCCP N-PCSTATE.ind (unavailable) should arrive to upper layers. + * As a result, osmo-smlc should immediately mark the ran_peer as unusable. + * In Lb, the SCCP N-PCSTATE is triggered by instructing the STP to + * shutdown the ASP serving the SMLC, which will close the SCTP assoc between + * itself and IUT (SMLC), which should then generate an N-PCSTATE.ind. + */ +testcase TC_stat_bsc_sctp_disconnected() runs on test_CT { + var BSC_ConnHdlr vc_conn; + var TestHdlrParams pars := f_gen_test_hdlr_pars(); + + var charstring smlc_stats_prefix := f_smlc_stats_prefix(); + + var StatsDExpects expect_connected := { + {name := smlc_stats_prefix & "lb_peers.total", mtype := "g", min := 1, max := 1}, + {name := smlc_stats_prefix & "lb_peers.active", mtype := "g", min := 1, max := 1} + }; + var StatsDExpects expect_disconnected := { + {name := smlc_stats_prefix & "lb_peers.total", mtype := "g", min := 1, max := 1}, + {name := smlc_stats_prefix & "lb_peers.active", mtype := "g", min := 0, max := 0} + }; + + g_statd_timeout := 15.0; + f_init(); + f_init_vty_stp(); + f_sleep(1.0); + + pars.sccp_addr_bsc := g_bssap_le[0].sccp_addr_own; + pars.sccp_addr_smlc := g_bssap_le[0].sccp_addr_peer; + + connect(self:STATSD_PROC, vc_STATSD:STATSD_PROC); + f_statsd_reset(); + f_statsd_expect(expect_connected, wait_converge := true); + disconnect(self:STATSD_PROC, vc_STATSD:STATSD_PROC); + + vc_conn := f_start_handler(refers(f_tc_smlc_location_request_with_ta_l3), pars); + vc_conn.done; + + f_logp(SMLCVTY, "Shutting down SMLC ASP in STP"); + f_vty_stp_smlc_asp_cmd("shutdown"); + + /* Wait for AS PENDING->INACTIVE transition (T(r) timeout after 2000msec): */ + connect(self:STATSD_PROC, vc_STATSD:STATSD_PROC); + f_statsd_expect(expect_disconnected, wait_converge := true); + disconnect(self:STATSD_PROC, vc_STATSD:STATSD_PROC); + + f_logp(SMLCVTY, "Restarting SMLC ASP in STP"); + f_vty_stp_smlc_asp_cmd("no shutdown"); + + connect(self:STATSD_PROC, vc_STATSD:STATSD_PROC); + f_statsd_expect(expect_connected, wait_converge := true); + disconnect(self:STATSD_PROC, vc_STATSD:STATSD_PROC); + + vc_conn := f_start_handler(refers(f_tc_smlc_location_request_with_ta_l3), pars); + vc_conn.done; + setverdict(pass); +} + control { execute( TC_smlc_location_request_with_ta_l3() ); execute( TC_smlc_location_request_without_ta_l3() ); execute( TC_smlc_location_request_bsslap_reset() ); execute( TC_smlc_location_request_bsslap_abort() ); execute( TC_smlc_location_request_abort() ); + + /* This "nightly" if can be removed once libosmo-sigtran (osmo-stp) > 2.1.0 is released. + * Currently released osmo-stp 2.1.0 ends up in in broken AS-ACTIVE+ASP-DOWN state when + * restarting the ASP after exiting the related asp node through VTY: */ + if (Misc_Helpers.f_osmo_repo_is("nightly")) { + execute( TC_stat_bsc_sctp_disconnected() ); + } } } diff --git a/smlc/expected-results.xml b/smlc/expected-results.xml index 7834ebd..438bfe1 100644 --- a/smlc/expected-results.xml +++ b/smlc/expected-results.xml @@ -5,4 +5,5 @@ <testcase classname='SMLC_Tests' name='TC_smlc_location_request_bsslap_reset' time='MASKED'/> <testcase classname='SMLC_Tests' name='TC_smlc_location_request_bsslap_abort' time='MASKED'/> <testcase classname='SMLC_Tests' name='TC_smlc_location_request_abort' time='MASKED'/> + <testcase classname='SMLC_Tests' name='TC_stat_bsc_sctp_disconnected' time='MASKED'/> </testsuite> -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40681?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic67d9d8120e9bd09b0e54b237e93f49f79262be0 Gerrit-Change-Number: 40681 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

2 weeks, 3 days

1
0
0 0

[M] Change in osmo-smlc[master]: smlc: Initial implementation of N-PCSTATE.ind

by pespin

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-smlc/+/40665?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: smlc: Initial implementation of N-PCSTATE.ind ...................................................................... smlc: Initial implementation of N-PCSTATE.ind Related: OS#5917 Change-Id: Id034a0c4d8bff0647a64658480dfa9b4cea563de --- M include/osmocom/smlc/lb_peer.h M src/osmo-smlc/lb_peer.c M src/osmo-smlc/sccp_lb_inst.c 3 files changed, 155 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-smlc refs/changes/65/40665/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-smlc/+/40665?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-smlc Gerrit-Branch: master Gerrit-Change-Id: Id034a0c4d8bff0647a64658480dfa9b4cea563de Gerrit-Change-Number: 40665 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder

2 weeks, 3 days

1
0
0 0

[M] Change in osmo-smlc[master]: Introduce stats msc.ran_peers.{total,active}

by pespin

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-smlc/+/40679?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: Introduce stats msc.ran_peers.{total,active} ...................................................................... Introduce stats msc.ran_peers.{total,active} osmo_stats_init() was already being called despite no stats were being used. Change-Id: Ib01576036f34ac7f21c5bce0155b50932eb9b72a --- M include/osmocom/smlc/smlc_data.h M src/osmo-smlc/lb_peer.c M src/osmo-smlc/smlc_data.c M src/osmo-smlc/smlc_vty.c 4 files changed, 55 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-smlc refs/changes/79/40679/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-smlc/+/40679?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-smlc Gerrit-Branch: master Gerrit-Change-Id: Ib01576036f34ac7f21c5bce0155b50932eb9b72a Gerrit-Change-Number: 40679 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder

2 weeks, 3 days

1
0
0 0

[XS] Change in osmo-smlc[master]: cell_locations.h: Fix includes

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-smlc/+/40677?usp=email ) Change subject: cell_locations.h: Fix includes ...................................................................... cell_locations.h: Fix includes No sigtran header is needed as a dependecy in that header. struct gsm0808_cell_id is defined in gsm0808_utils.h. Change-Id: Iceedd7a8c2e050e6631c5f471d2eb71ab8ee2432 --- M include/osmocom/smlc/cell_locations.h 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-smlc refs/changes/77/40677/1 diff --git a/include/osmocom/smlc/cell_locations.h b/include/osmocom/smlc/cell_locations.h index 9712718..5eb5d7e 100644 --- a/include/osmocom/smlc/cell_locations.h +++ b/include/osmocom/smlc/cell_locations.h @@ -23,7 +23,7 @@ #include <stdint.h> #include <osmocom/core/linuxlist.h> -#include <osmocom/sigtran/sccp_sap.h> +#include <osmocom/gsm/gsm0808_utils.h> struct osmo_gad; -- To view, visit https://gerrit.osmocom.org/c/osmo-smlc/+/40677?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-smlc Gerrit-Branch: master Gerrit-Change-Id: Iceedd7a8c2e050e6631c5f471d2eb71ab8ee2432 Gerrit-Change-Number: 40677 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

2 weeks, 3 days

1
0
0 0

2025

2024

2023

2022

gerrit-log July 2025