July 2025 - gerrit-log - lists.osmocom.org

[S] Change in osmo-msc[master]: sccp: Handle N-NOTICE.ind (Routing Failure of SCCP CL messages)

by pespin

Attention is currently required from: fixeria, laforge. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-msc/+/40710?usp=email ) Change subject: sccp: Handle N-NOTICE.ind (Routing Failure of SCCP CL messages) ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/40710?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Iddd10c8f97310b600374ff0141ea06e03087da8f Gerrit-Change-Number: 40710 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 17 Jul 2025 12:45:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

2 weeks, 6 days

1
0
0 0

[S] Change in osmo-smlc[master]: sccp: Handle N-NOTICE.ind (Routing Failure of SCCP CL messages)

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-smlc/+/40711?usp=email ) Change subject: sccp: Handle N-NOTICE.ind (Routing Failure of SCCP CL messages) ...................................................................... sccp: Handle N-NOTICE.ind (Routing Failure of SCCP CL messages) ITU Q.714 2.8: """ When an end node is informed of a routing failure, this information is forwarded towards the SCCP user by using the N-DISCONNECT primitive (refer to reason for release in 2.1.1.2.4/Q.711) or the N-NOTICE primitive (refer to reason for return in 2.2.2.2.4/Q.711) """ We are already handling N-DISCONNECT.ind for CO messages, but N-NOTICE.ind for CL messages was not being handled. If CL messages are not arriving to the Lb peer, then reset the link and mark the peer as disconnected, until a new RESET can successfully fo through. Related: OS#5917 Change-Id: I4bfea43a99c768162faefde06558941f697bd718 --- M src/osmo-smlc/sccp_lb_inst.c 1 file changed, 35 insertions(+), 0 deletions(-) Approvals: pespin: Looks good to me, approved daniel: Looks good to me, but someone else must approve Jenkins Builder: Verified osmith: Looks good to me, but someone else must approve diff --git a/src/osmo-smlc/sccp_lb_inst.c b/src/osmo-smlc/sccp_lb_inst.c index bfe8a0e..cea74bf 100644 --- a/src/osmo-smlc/sccp_lb_inst.c +++ b/src/osmo-smlc/sccp_lb_inst.c @@ -85,6 +85,36 @@ return sli; } +static void handle_notice_ind(struct sccp_lb_inst *sli, const struct osmo_scu_notice_param *ni) +{ + struct lb_peer *lbp; + + lbp = lb_peer_find(sli, &ni->calling_addr); + if (!lbp) { + LOG_SCCP_LB(sli, LOGL_DEBUG, "(calling_addr=%s) N-NOTICE.ind cause=%u='%s' importance=%u didn't match any lb_peer, ignoring\n", + osmo_sccp_addr_dump(&ni->calling_addr), + ni->cause, osmo_sccp_return_cause_name(ni->cause), + ni->importance); + return; + } + + LOG_LB_PEER(lbp, LOGL_NOTICE, "N-NOTICE.ind cause=%u='%s' importance=%u\n", + ni->cause, osmo_sccp_return_cause_name(ni->cause), + ni->importance); + + switch (ni->cause) { + case SCCP_RETURN_CAUSE_SUBSYSTEM_CONGESTION: + case SCCP_RETURN_CAUSE_NETWORK_CONGESTION: + /* Transient failures (hopefully), keep going. */ + return; + default: + break; + } + + /* Messages are not arriving to lb_peer. Signal it is unavailable to update local state. */ + osmo_fsm_inst_dispatch(lbp->fi, LB_PEER_EV_UNAVAILABLE, NULL); +} + static void handle_pcstate_ind(struct sccp_lb_inst *sli, const struct osmo_scu_pcstate_param *pcst) { struct osmo_ss7_instance *cs7 = osmo_sccp_get_ss7(sli->sccp); @@ -253,6 +283,11 @@ rc = lb_peer_up_l2(sli, peer_addr, false, 0, oph->msg); break; + case OSMO_PRIM(OSMO_SCU_PRIM_N_NOTICE, PRIM_OP_INDICATION): + handle_notice_ind(sli, &prim->u.notice); + rc = 0; + break; + case OSMO_PRIM(OSMO_SCU_PRIM_N_PCSTATE, PRIM_OP_INDICATION): handle_pcstate_ind(sli, &prim->u.pcstate); rc = 0; -- To view, visit https://gerrit.osmocom.org/c/osmo-smlc/+/40711?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-smlc Gerrit-Branch: master Gerrit-Change-Id: I4bfea43a99c768162faefde06558941f697bd718 Gerrit-Change-Number: 40711 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

2 weeks, 6 days

1
0
0 0

[S] Change in osmo-smlc[master]: sccp: Handle N-NOTICE.ind (Routing Failure of SCCP CL messages)

by pespin

Attention is currently required from: fixeria, laforge. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-smlc/+/40711?usp=email ) Change subject: sccp: Handle N-NOTICE.ind (Routing Failure of SCCP CL messages) ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-smlc/+/40711?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-smlc Gerrit-Branch: master Gerrit-Change-Id: I4bfea43a99c768162faefde06558941f697bd718 Gerrit-Change-Number: 40711 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 17 Jul 2025 12:45:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

2 weeks, 6 days

1
0
0 0

[S] Change in osmo-smlc[master]: sccp: Handle N-NOTICE.ind (Routing Failure of SCCP CL messages)

by daniel

Attention is currently required from: fixeria, laforge, pespin. daniel has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-smlc/+/40711?usp=email ) Change subject: sccp: Handle N-NOTICE.ind (Routing Failure of SCCP CL messages) ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-smlc/+/40711?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-smlc Gerrit-Branch: master Gerrit-Change-Id: I4bfea43a99c768162faefde06558941f697bd718 Gerrit-Change-Number: 40711 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 17 Jul 2025 12:20:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

2 weeks, 6 days

1
0
0 0

[XS] Change in osmo-hnbgw[master]: Use proper SCCP release cause enum value instead of hardcoded value

by daniel

Attention is currently required from: pespin. daniel has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/40712?usp=email ) Change subject: Use proper SCCP release cause enum value instead of hardcoded value ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/40712?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I9de79db8e16cf425919b678d837b46f24ffe9bbe Gerrit-Change-Number: 40712 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 17 Jul 2025 12:19:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

2 weeks, 6 days

1
0
0 0

[S] Change in osmo-hnbgw[master]: sccp: Handle N-NOTICE.ind (Routing Failure of SCCP CL messages)

by daniel

Attention is currently required from: fixeria, laforge, pespin. daniel has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/40707?usp=email ) Change subject: sccp: Handle N-NOTICE.ind (Routing Failure of SCCP CL messages) ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/40707?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Ie5f643ba9ac8c443ce95c7f0a89a198fb804c94d Gerrit-Change-Number: 40707 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 17 Jul 2025 12:19:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

2 weeks, 6 days

1
0
0 0

[S] Change in osmo-msc[master]: sccp: Handle N-NOTICE.ind (Routing Failure of SCCP CL messages)

by daniel

Attention is currently required from: fixeria, laforge, pespin. daniel has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-msc/+/40710?usp=email ) Change subject: sccp: Handle N-NOTICE.ind (Routing Failure of SCCP CL messages) ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/40710?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Iddd10c8f97310b600374ff0141ea06e03087da8f Gerrit-Change-Number: 40710 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 17 Jul 2025 12:18:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

2 weeks, 6 days

1
0
0 0

[XS] Change in osmo-trx[master]: lms: Use define LMS_LOG_CRITICAL instead of value

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/15257?usp=email ) Change subject: lms: Use define LMS_LOG_CRITICAL instead of value ...................................................................... lms: Use define LMS_LOG_CRITICAL instead of value The define is available since v20.01.0 [1] [1] https://github.com/myriadrf/LimeSuite/pull/275 Change-Id: Ie5bb99a76580c5780a24f190682700c5e69b3d85 --- M Transceiver52M/device/lms/LMSDevice.cpp 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: pespin: Verified osmith: Looks good to me, approved diff --git a/Transceiver52M/device/lms/LMSDevice.cpp b/Transceiver52M/device/lms/LMSDevice.cpp index 7c220d2..356d950 100644 --- a/Transceiver52M/device/lms/LMSDevice.cpp +++ b/Transceiver52M/device/lms/LMSDevice.cpp @@ -150,7 +150,7 @@ { /* map lime specific log levels */ static const int lvl_map[5] = { - [0] = LOGL_FATAL, + [LMS_LOG_CRITICAL] = LOGL_FATAL, [LMS_LOG_ERROR] = LOGL_ERROR, [LMS_LOG_WARNING] = LOGL_NOTICE, [LMS_LOG_INFO] = LOGL_INFO, -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/15257?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Ie5bb99a76580c5780a24f190682700c5e69b3d85 Gerrit-Change-Number: 15257 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

2 weeks, 6 days

1
0
0 0

[XS] Change in osmo-trx[master]: lms: Use define LMS_LOG_CRITICAL instead of value

by osmith

Attention is currently required from: pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-trx/+/15257?usp=email ) Change subject: lms: Use define LMS_LOG_CRITICAL instead of value ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/15257?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Ie5bb99a76580c5780a24f190682700c5e69b3d85 Gerrit-Change-Number: 15257 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 17 Jul 2025 10:31:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

2 weeks, 6 days

1
0
0 0

[XS] Change in osmo-trx[master]: lms: Use define LMS_LOG_CRITICAL instead of value

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-trx/+/15257?usp=email ) Change subject: lms: Use define LMS_LOG_CRITICAL instead of value ...................................................................... Patch Set 3: Verified+1 (1 comment) Patchset: PS3: linter is broken here. Dediced to ignore it for this patch after talk with @osmith@sysmocom.de -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/15257?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Ie5bb99a76580c5780a24f190682700c5e69b3d85 Gerrit-Change-Number: 15257 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 17 Jul 2025 10:02:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

2 weeks, 6 days

1
0
0 0

2025

2024

2023

2022

gerrit-log July 2025