June 2025 - gerrit-log - lists.osmocom.org

[S] Change in osmo-ggsn[master]: gtpie: make ies const for getter

by lynxis lazus

Attention is currently required from: pespin. lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/40432?usp=email ) Change subject: gtpie: make ies const for getter ...................................................................... Patch Set 1: (1 comment) File include/osmocom/gtp/gtpie.h: https://gerrit.osmocom.org/c/osmo-ggsn/+/40432/comment/e2e38284_992388a2?us… : PS1, Line 304: extern int gtpie_getie(union gtpie_member * const ie[], int type, int instance); > you can also consitfy the union pointer I guess? Should I? I'm unsure. -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/40432?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I43195314b1cf416a1f2fd4d3ddd48c4eee462b0b Gerrit-Change-Number: 40432 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 04 Jun 2025 16:24:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 month, 1 week

1
0
0 0

[XS] Change in osmo-ci[master]: jobs/osmocom-obs: add EMAIL_NOTIFICATIONS argument

by fixeria

Attention is currently required from: osmith. fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/40425?usp=email ) Change subject: jobs/osmocom-obs: add EMAIL_NOTIFICATIONS argument ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/40425?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I5009f7b722c7455ee6dfd25a6b5370929c9bc469 Gerrit-Change-Number: 40425 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Wed, 04 Jun 2025 16:20:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 month, 1 week

1
0
0 0

[S] Change in osmo-ggsn[master]: gtpie: make ies const for getter

by pespin

Attention is currently required from: lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/40432?usp=email ) Change subject: gtpie: make ies const for getter ...................................................................... Patch Set 1: (1 comment) File include/osmocom/gtp/gtpie.h: https://gerrit.osmocom.org/c/osmo-ggsn/+/40432/comment/0c97aa9e_976a7f2a?us… : PS1, Line 304: extern int gtpie_getie(union gtpie_member * const ie[], int type, int instance); you can also consitfy the union pointer I guess? -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/40432?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I43195314b1cf416a1f2fd4d3ddd48c4eee462b0b Gerrit-Change-Number: 40432 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 04 Jun 2025 15:45:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 month, 1 week

1
0
0 0

[S] Change in osmo-ggsn[master]: gtpie: make ies const for getter

by lynxis lazus

lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/40432?usp=email ) Change subject: gtpie: make ies const for getter ...................................................................... gtpie: make ies const for getter Getter's don't modify the ie. Making it const is compatible with previous versions. Change-Id: I43195314b1cf416a1f2fd4d3ddd48c4eee462b0b --- M gtp/gtpie.c M include/osmocom/gtp/gtpie.h 2 files changed, 22 insertions(+), 22 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ggsn refs/changes/32/40432/1 diff --git a/gtp/gtpie.c b/gtp/gtpie.c index 84a3ec2..1d2d4d2 100644 --- a/gtp/gtpie.c +++ b/gtp/gtpie.c @@ -155,7 +155,7 @@ * \param[in] type Tag/IEI for which we're looking * \param[in] instance Instance (number of occurence) of this IEI * \returns index into \a ie on success; -1 if not found */ -int gtpie_getie(union gtpie_member *ie[], int type, int instance) +int gtpie_getie(union gtpie_member * const ie[], int type, int instance) { int j; for (j = 0; j < GTPIE_SIZE; j++) { @@ -172,7 +172,7 @@ * \param[in] type Tag/IEI for which we're looking * \param[in] instance Instance (number of occurence) of this IEI * \returns 1 if IEI instance present in \a ie; 0 if not */ -int gtpie_exist(union gtpie_member *ie[], int type, int instance) +int gtpie_exist(union gtpie_member * const ie[], int type, int instance) { int j; for (j = 0; j < GTPIE_SIZE; j++) { @@ -192,7 +192,7 @@ * \param[inout] dst Caller-allocated buffer where to store value * \param[in] size Size of \a dst in bytes * \returns 0 on sucess; EOF in case value is larger than \a size */ -int gtpie_gettlv(union gtpie_member *ie[], int type, int instance, +int gtpie_gettlv(union gtpie_member * const ie[], int type, int instance, unsigned int *length, void *dst, unsigned int size) { int ien; @@ -214,7 +214,7 @@ * \param[inout] dst Caller-allocated buffer where to store value * \param[in] size Size of value in bytes * \returns 0 on sucess; EOF in case IE not found */ -int gtpie_gettv0(union gtpie_member *ie[], int type, int instance, +int gtpie_gettv0(union gtpie_member * const ie[], int type, int instance, void *dst, unsigned int size) { int ien; @@ -232,7 +232,7 @@ * \param[in] instance Instance (number of occurence) of this IEI * \param[inout] dst Caller-allocated buffer where to store value * \returns 0 on sucess; EOF in case IE not found */ -int gtpie_gettv1(union gtpie_member *ie[], int type, int instance, +int gtpie_gettv1(union gtpie_member * const ie[], int type, int instance, uint8_t * dst) { int ien; @@ -250,7 +250,7 @@ * \param[in] instance Instance (number of occurence) of this IEI * \param[inout] dst Caller-allocated buffer where to store value * \returns 0 on sucess; EOF in case IE not found */ -int gtpie_gettv2(union gtpie_member *ie[], int type, int instance, +int gtpie_gettv2(union gtpie_member * const ie[], int type, int instance, uint16_t * dst) { int ien; @@ -268,7 +268,7 @@ * \param[in] instance Instance (number of occurence) of this IEI * \param[inout] dst Caller-allocated buffer where to store value * \returns 0 on sucess; EOF in case IE not found */ -int gtpie_gettv4(union gtpie_member *ie[], int type, int instance, +int gtpie_gettv4(union gtpie_member * const ie[], int type, int instance, uint32_t * dst) { int ien; @@ -286,7 +286,7 @@ * \param[in] instance Instance (number of occurence) of this IEI * \param[inout] dst Caller-allocated buffer where to store value * \returns 0 on sucess; EOF in case IE not found */ -int gtpie_gettv8(union gtpie_member *ie[], int type, int instance, +int gtpie_gettv8(union gtpie_member * const ie[], int type, int instance, uint64_t * dst) { int ien; @@ -599,7 +599,7 @@ * \param[out] pack Pointer to caller-allocated buffer for raw GTP packet (GTPIE_MAX length) * \param[out] len Encoded length of \a pack in bytes * \returns 0 on sucess; 2 for out-of-space */ -int gtpie_encaps(union gtpie_member *ie[], void *pack, unsigned *len) +int gtpie_encaps(union gtpie_member * const ie[], void *pack, unsigned *len) { int i; unsigned char *p; @@ -774,7 +774,7 @@ * \param[out] pack Pointer to caller-allocated buffer for raw GTP packet (GTPIE_MAX length) * \param[out] len Encoded length of \a pack in bytes * \returns 0 on sucess; 2 for out-of-space */ -int gtpie_encaps2(union gtpie_member ie[], unsigned int size, +int gtpie_encaps2(const union gtpie_member ie[], unsigned int size, void *pack, unsigned *len) { unsigned int i, j; @@ -953,7 +953,7 @@ * \param[out] encoded_len Encoded length of \a pack in bytes * \returns 0 on success; 2 for out-of-space * GTP requires a certain order, the call must follow those which are defined for every message */ -int gtpie_encaps3(union gtpie_member *ies[], unsigned int ie_len, +int gtpie_encaps3(union gtpie_member * const ies[], unsigned int ie_len, void *pack, unsigned pack_len, unsigned *encoded_len) { unsigned int i; diff --git a/include/osmocom/gtp/gtpie.h b/include/osmocom/gtp/gtpie.h index b3e3ddf..b412159 100644 --- a/include/osmocom/gtp/gtpie.h +++ b/include/osmocom/gtp/gtpie.h @@ -301,27 +301,27 @@ uint8_t t, uint32_t v); extern int gtpie_tv8(void *p, unsigned int *length, unsigned int size, uint8_t t, uint64_t v); -extern int gtpie_getie(union gtpie_member *ie[], int type, int instance); -extern int gtpie_exist(union gtpie_member *ie[], int type, int instance); -extern int gtpie_gettlv(union gtpie_member *ie[], int type, int instance, +extern int gtpie_getie(union gtpie_member * const ie[], int type, int instance); +extern int gtpie_exist(union gtpie_member * const ie[], int type, int instance); +extern int gtpie_gettlv(union gtpie_member * const ie[], int type, int instance, unsigned int *length, void *dst, unsigned int size); -extern int gtpie_gettv0(union gtpie_member *ie[], int type, int instance, +extern int gtpie_gettv0(union gtpie_member * const ie[], int type, int instance, void *dst, unsigned int size); -extern int gtpie_gettv1(union gtpie_member *ie[], int type, int instance, +extern int gtpie_gettv1(union gtpie_member * const ie[], int type, int instance, uint8_t * dst); -extern int gtpie_gettv2(union gtpie_member *ie[], int type, int instance, +extern int gtpie_gettv2(union gtpie_member * const ie[], int type, int instance, uint16_t * dst); -extern int gtpie_gettv4(union gtpie_member *ie[], int type, int instance, +extern int gtpie_gettv4(union gtpie_member * const ie[], int type, int instance, uint32_t * dst); -extern int gtpie_gettv8(union gtpie_member *ie[], int type, int instance, +extern int gtpie_gettv8(union gtpie_member * const ie[], int type, int instance, uint64_t * dst); extern int gtpie_decaps(union gtpie_member *ie[], int version, const void *pack, unsigned len); -extern int gtpie_encaps(union gtpie_member *ie[], void *pack, unsigned *len); -extern int gtpie_encaps2(union gtpie_member ie[], unsigned int size, +extern int gtpie_encaps(union gtpie_member * const ie[], void *pack, unsigned *len); +extern int gtpie_encaps2(const union gtpie_member ie[], unsigned int size, void *pack, unsigned *len); -extern int gtpie_encaps3(union gtpie_member *ie[], unsigned int ie_len, +extern int gtpie_encaps3(union gtpie_member * const ie[], unsigned int ie_len, void *pack, unsigned pack_len, unsigned *encoded_len); #endif /* !_GTPIE_H */ -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/40432?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I43195314b1cf416a1f2fd4d3ddd48c4eee462b0b Gerrit-Change-Number: 40432 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>

1 month, 1 week

1
0
0 0

[M] Change in osmo-ci[master]: jobs/reminder-extend-obs-key: new job

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/40431?usp=email ) Change subject: jobs/reminder-extend-obs-key: new job ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File jobs/reminder-extend-obs-key.yml: https://gerrit.osmocom.org/c/osmo-ci/+/40431/comment/c6a323c0_4db094d8?usp=… : PS1, Line 35: - timed: "@daily" maybe weekly/monthly may be enough? -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/40431?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I934282efbe1fe3bd86813ad53df38ef79575bf8d Gerrit-Change-Number: 40431 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Wed, 04 Jun 2025 14:18:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 month, 1 week

1
0
0 0

[XS] Change in osmo-ci[master]: OBS: let meta package depend on osmocom-keyring

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/40430?usp=email ) Change subject: OBS: let meta package depend on osmocom-keyring ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/40430?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Id4d213f355338b39a9ec5ccffc16179f6e472102 Gerrit-Change-Number: 40430 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Wed, 04 Jun 2025 14:17:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 month, 1 week

1
0
0 0

[XS] Change in osmo-ci[master]: OBS: move meta_package_version to config variable

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/40429?usp=email ) Change subject: OBS: move meta_package_version to config variable ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/40429?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I003e27ed6d0247097ba33d33e578b9669be36f9a Gerrit-Change-Number: 40429 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Wed, 04 Jun 2025 14:17:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 month, 1 week

1
0
0 0

[XS] Change in osmo-ci[master]: OBS: add the new osmocom-keyring package

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/40428?usp=email ) Change subject: OBS: add the new osmocom-keyring package ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/40428?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I370b4fa0c6f7e8a925b1ddd7c1c47980a8f4fea2 Gerrit-Change-Number: 40428 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Wed, 04 Jun 2025 14:16:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 month, 1 week

1
0
0 0

[XS] Change in osmo-ci[master]: OBS: remove libosmo-sccp-legacy

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/40427?usp=email ) Change subject: OBS: remove libosmo-sccp-legacy ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/40427?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I086e3eff10e79bddd8ec23927b46cc58a7101de6 Gerrit-Change-Number: 40427 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Wed, 04 Jun 2025 14:16:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 month, 1 week

1
0
0 0

[XS] Change in osmo-ci[master]: OBS: repo without manuals: fix draft removal logic

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/40426?usp=email ) Change subject: OBS: repo without manuals: fix draft removal logic ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/40426?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ie93430a1f7bd2bae6886e87755e79ff93ea609e7 Gerrit-Change-Number: 40426 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Wed, 04 Jun 2025 14:16:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 month, 1 week

1
0
0 0

2025

2024

2023

2022

gerrit-log June 2025