May 2025 - gerrit-log - lists.osmocom.org

[XS] Change in osmo-ttcn3-hacks[master]: Makefile: add global per-project clean target

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40409?usp=email ) Change subject: Makefile: add global per-project clean target ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40409?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I434ecbe3f3dd25ea770d8f2d7adfa62c67dc0c1d Gerrit-Change-Number: 40409 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 30 May 2025 12:04:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

3 weeks, 2 days

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: library/ngap: Fix criticality of several NGAP messages

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40407?usp=email ) Change subject: library/ngap: Fix criticality of several NGAP messages ...................................................................... library/ngap: Fix criticality of several NGAP messages As defined in ASN.1 in 3GPP TS 38.413 section 9.4.3. Change-Id: I2283a5b025f0ce7d7445fa0ce9ba8405156c4533 --- M library/ngap/NGAP_Templates.ttcn 1 file changed, 37 insertions(+), 37 deletions(-) Approvals: fixeria: Looks good to me, approved Jenkins Builder: Verified diff --git a/library/ngap/NGAP_Templates.ttcn b/library/ngap/NGAP_Templates.ttcn index d297bea..dde7844 100644 --- a/library/ngap/NGAP_Templates.ttcn +++ b/library/ngap/NGAP_Templates.ttcn @@ -685,7 +685,7 @@ ) := { procedureCode := id_PDUSessionResourceNotify, - criticality := reject, + criticality := ignore, value_ := { PDUSessionResourceNotify := { protocolIEs := { @@ -723,7 +723,7 @@ ) := { procedureCode := id_PDUSessionResourceNotify, - criticality := reject, + criticality := ignore, value_ := { PDUSessionResourceNotify := { protocolIEs := { @@ -1673,7 +1673,7 @@ in template (value) PDUSessionResourceListCxtRelReq p_pDUSessionResourceListCxtRelReq ) := { procedureCode := id_UEContextReleaseRequest, - criticality := reject, + criticality := ignore, value_ := { UEContextReleaseRequest := { protocolIEs := { @@ -1710,7 +1710,7 @@ template (present) Cause p_cause := ? ) := { procedureCode := id_UEContextReleaseRequest, - criticality := reject, + criticality := ignore, value_ := { UEContextReleaseRequest := { protocolIEs := { @@ -2243,7 +2243,7 @@ in template (value) UserLocationInformation p_userLocationInformation ) := { procedureCode := id_RRCInactiveTransitionReport, - criticality := reject, + criticality := ignore, value_ := { RRCInactiveTransitionReport := { protocolIEs := { @@ -2286,7 +2286,7 @@ template (present) UserLocationInformation p_userLocationInformation := ? ) := { procedureCode := id_RRCInactiveTransitionReport, - criticality := reject, + criticality := ignore, value_ := { RRCInactiveTransitionReport := { protocolIEs := { @@ -4143,7 +4143,7 @@ in template (value) UserLocationInformation p_userLocationInformation ) := { procedureCode := id_HandoverNotification, - criticality := reject, + criticality := ignore, value_ := { HandoverNotify := { protocolIEs := { @@ -4180,7 +4180,7 @@ template (present) UserLocationInformation p_userLocationInformation := ? ) := { procedureCode := id_HandoverNotification, - criticality := reject, + criticality := ignore, value_ := { HandoverNotify := { protocolIEs := { @@ -4638,7 +4638,7 @@ in template (value) RANStatusTransfer_TransparentContainer p_rANStatusTransfer_TransparentContainer ) := { procedureCode := id_UplinkRANStatusTransfer, - criticality := reject, + criticality := ignore, value_ := { UplinkRANStatusTransfer := { protocolIEs := { @@ -4672,7 +4672,7 @@ template (present) RANStatusTransfer_TransparentContainer p_rANStatusTransfer_TransparentContainer := ? ) := { procedureCode := id_UplinkRANStatusTransfer, - criticality := reject, + criticality := ignore, value_ := { UplinkRANStatusTransfer := { protocolIEs := { @@ -4713,7 +4713,7 @@ in template (value) RANStatusTransfer_TransparentContainer p_rANStatusTransfer_TransparentContainer ) := { procedureCode := id_DownlinkRANStatusTransfer, - criticality := reject, + criticality := ignore, value_ := { DownlinkRANStatusTransfer := { protocolIEs := { @@ -4750,7 +4750,7 @@ template (present) RANStatusTransfer_TransparentContainer p_rANStatusTransfer_TransparentContainer := ? ) := { procedureCode := id_DownlinkRANStatusTransfer, - criticality := reject, + criticality := ignore, value_ := { DownlinkRANStatusTransfer := { protocolIEs := { @@ -4790,7 +4790,7 @@ in template (value) RAN_UE_NGAP_ID p_ranUeNgapID := PX_RAN_UE_NGAP_ID ) := { procedureCode := id_HandoverSuccess, - criticality := reject, + criticality := ignore, value_ := { HandoverSuccess := { protocolIEs := { @@ -4821,7 +4821,7 @@ template (present) RAN_UE_NGAP_ID p_ranUeNgapID := ? ) := { procedureCode := id_HandoverSuccess, - criticality := reject, + criticality := ignore, value_ := { HandoverSuccess := { protocolIEs := { @@ -4935,7 +4935,7 @@ in template (value) EarlyStatusTransfer_TransparentContainer p_earlyStatusTransfer_TransparentContainer ) := { procedureCode := id_DownlinkRANEarlyStatusTransfer, - criticality := reject, + criticality := ignore, value_ := { DownlinkRANEarlyStatusTransfer := { protocolIEs := { @@ -4972,7 +4972,7 @@ template (present) EarlyStatusTransfer_TransparentContainer p_earlyStatusTransfer_TransparentContainer := ? ) := { procedureCode := id_DownlinkRANEarlyStatusTransfer, - criticality := reject, + criticality := ignore, value_ := { DownlinkRANEarlyStatusTransfer := { protocolIEs := { @@ -5019,7 +5019,7 @@ in template (value) TAIListForPaging p_tAIListForPaging ) := { procedureCode := id_Paging, - criticality := reject, + criticality := ignore, value_ := { Paging := { protocolIEs := { @@ -5050,7 +5050,7 @@ template (present) TAIListForPaging p_tAIListForPaging := ? ) := { procedureCode := id_Paging, - criticality := reject, + criticality := ignore, value_ := { Paging := { protocolIEs := { @@ -5094,7 +5094,7 @@ in template (value) RRCEstablishmentCause p_rrcEstCause := PX_RRC_ESTABLISHMENT_CAUSE ) := { procedureCode := id_InitialUEMessage, - criticality := reject, + criticality := ignore, value_ := { InitialUEMessage := { protocolIEs := { @@ -5215,7 +5215,7 @@ template (present) RRCEstablishmentCause p_rrcEstCause := ? ) := { procedureCode := id_InitialUEMessage, - criticality := reject, + criticality := ignore, value_ := { InitialUEMessage := { protocolIEs := { @@ -5261,7 +5261,7 @@ in template (value) NAS_PDU p_nasPdu ) := { procedureCode := id_DownlinkNASTransport, - criticality := reject, + criticality := ignore, value_ := { DownlinkNASTransport := { protocolIEs := { @@ -5298,7 +5298,7 @@ template (present) NAS_PDU p_nasPdu := ? ) := { procedureCode := id_DownlinkNASTransport, - criticality := reject, + criticality := ignore, value_ := { DownlinkNASTransport := { protocolIEs := { @@ -5340,7 +5340,7 @@ in template (value) UserLocationInformation p_userLocationInformation ) := { procedureCode := id_UplinkNASTransport, - criticality := reject, + criticality := ignore, value_ := { UplinkNASTransport := { protocolIEs := { @@ -5383,7 +5383,7 @@ template (present) UserLocationInformation p_userLocationInformation := ? ) := { procedureCode := id_UplinkNASTransport, - criticality := reject, + criticality := ignore, value_ := { UplinkNASTransport := { protocolIEs := { @@ -5430,7 +5430,7 @@ in template (value) Cause p_cause := m_cause_nas(PX_CAUSE_NAS_NON_DELIVERY_INDICATION) ) := { procedureCode := id_NASNonDeliveryIndication, - criticality := reject, + criticality := ignore, value_ := { NASNonDeliveryIndication := { protocolIEs := { @@ -5473,7 +5473,7 @@ template (present) Cause p_cause := ? ) := { procedureCode := id_NASNonDeliveryIndication, - criticality := reject, + criticality := ignore, value_ := { NASNonDeliveryIndication := { protocolIEs := { @@ -6483,7 +6483,7 @@ in template (value) UnavailableGUAMIList p_unavailableGUAMIList ) := { procedureCode := id_AMFStatusIndication, - criticality := reject, + criticality := ignore, value_ := { AMFStatusIndication := { protocolIEs := { @@ -6508,7 +6508,7 @@ template (present) UnavailableGUAMIList p_unavailableGUAMIList := ? ) := { procedureCode := id_AMFStatusIndication, - criticality := reject, + criticality := ignore, value_ := { AMFStatusIndication := { protocolIEs := { @@ -6639,7 +6639,7 @@ */ template (value) InitiatingMessage m_n2_ErrorIndication := { procedureCode := id_ErrorIndication, - criticality := reject, + criticality := ignore, value_ := { ErrorIndication := { protocolIEs := { } @@ -6656,7 +6656,7 @@ in template (value) Cause p_cause ) := { procedureCode := id_ErrorIndication, - criticality := reject, + criticality := ignore, value_ := { ErrorIndication := { protocolIEs := { @@ -6743,7 +6743,7 @@ */ template (value) InitiatingMessage m_n2_OverloadStart := { procedureCode := id_OverloadStart, - criticality := reject, + criticality := ignore, value_ := { OverloadStart := { protocolIEs := { } @@ -6760,7 +6760,7 @@ */ template (present) InitiatingMessage mw_n2_OverloadStart := { procedureCode := id_OverloadStart, - criticality := reject, + criticality := ignore, value_ := { OverloadStart := { protocolIEs := { } @@ -6775,7 +6775,7 @@ template (present) OverloadStartNSSAIList p_overloadStartNSSAIList:= ? ):= { procedureCode := id_OverloadStart, - criticality := reject, + criticality := ignore, value_ := { OverloadStart := { protocolIEs := { @@ -6847,7 +6847,7 @@ */ template (value) InitiatingMessage m_n2_UplinkRANConfigurationTransfer := { procedureCode := id_UplinkRANConfigurationTransfer, - criticality := reject, + criticality := ignore, value_ := { UplinkRANConfigurationTransfer := { protocolIEs := { } @@ -6864,7 +6864,7 @@ */ template (present) InitiatingMessage mw_n2_UplinkRANConfigurationTransfer := { procedureCode := id_UplinkRANConfigurationTransfer, - criticality := reject, + criticality := ignore, value_ := { UplinkRANConfigurationTransfer := { protocolIEs := { } @@ -6885,7 +6885,7 @@ */ template (value) InitiatingMessage m_n2_DownlinkRANConfigurationTransfer := { procedureCode := id_DownlinkRANConfigurationTransfer, - criticality := reject, + criticality := ignore, value_ := { DownlinkRANConfigurationTransfer := { protocolIEs := { } @@ -6902,7 +6902,7 @@ */ template (present) InitiatingMessage mw_n2_DownlinkRANConfigurationTransfer := { procedureCode := id_DownlinkRANConfigurationTransfer, - criticality := reject, + criticality := ignore, value_ := { DownlinkRANConfigurationTransfer := { protocolIEs := { } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40407?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I2283a5b025f0ce7d7445fa0ce9ba8405156c4533 Gerrit-Change-Number: 40407 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

3 weeks, 2 days

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: library/ngap: Fix wrong id set on PWSFailureIndication templates

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40406?usp=email ) Change subject: library/ngap: Fix wrong id set on PWSFailureIndication templates ...................................................................... library/ngap: Fix wrong id set on PWSFailureIndication templates Change-Id: Ied1c7a5914c6cbacf64ba857aa31c12ca6f001fb --- M library/ngap/NGAP_Templates.ttcn 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/library/ngap/NGAP_Templates.ttcn b/library/ngap/NGAP_Templates.ttcn index b6be2d3..d297bea 100644 --- a/library/ngap/NGAP_Templates.ttcn +++ b/library/ngap/NGAP_Templates.ttcn @@ -7310,7 +7310,7 @@ in template (value) PWSFailedCellIDList p_pWSFailedCellIDList, in template (value) GlobalRANNodeID p_globalRANNodeID ) := { - procedureCode := id_PWSRestartIndication, + procedureCode := id_PWSFailureIndication, criticality := ignore, value_ := { PWSFailureIndication := { @@ -7341,7 +7341,7 @@ template (present) PWSFailedCellIDList p_pWSFailedCellIDList := ?, template (present) GlobalRANNodeID p_globalRANNodeID := ? ) := { - procedureCode := id_PWSRestartIndication, + procedureCode := id_PWSFailureIndication, criticality := ignore, value_ := { PWSFailureIndication := { -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40406?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ied1c7a5914c6cbacf64ba857aa31c12ca6f001fb Gerrit-Change-Number: 40406 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

3 weeks, 2 days

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: 5gc: Fix upfd failing to start outside podman

by fixeria

Attention is currently required from: osmith, pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40405?usp=email ) Change subject: 5gc: Fix upfd failing to start outside podman ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40405?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I5d3e0c3b7391d312304190acf07b347320481275 Gerrit-Change-Number: 40405 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 30 May 2025 10:15:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

3 weeks, 3 days

1
0
0 0

[L] Change in osmo-ttcn3-hacks[master]: 5gc: Initial NAS receiving support

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40408?usp=email ) Change subject: 5gc: Initial NAS receiving support ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40408?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I6697f30f95777fc9aed16a529a669d10f42c57be Gerrit-Change-Number: 40408 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 30 May 2025 10:15:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

3 weeks, 3 days

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: Makefile: add global per-project clean target

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40409?usp=email ) Change subject: Makefile: add global per-project clean target ...................................................................... Makefile: add global per-project clean target Change-Id: I434ecbe3f3dd25ea770d8f2d7adfa62c67dc0c1d --- M Makefile 1 file changed, 7 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/09/40409/1 diff --git a/Makefile b/Makefile index c64e130..7a9ddb8 100644 --- a/Makefile +++ b/Makefile @@ -114,6 +114,12 @@ @git clean -fx "$(1)" endef +define DIR_clean_template +.PHONY: $(1)/clean +$(1)/clean: + $(MAKE) -C $(BUILDDIR)/$(1) clean +endef + define DIR_all_template $(1): $(1)/all .PHONY: $(1)/all @@ -126,6 +132,7 @@ $(eval $(call DIR_Makefile_template,$(dir))) \ $(eval $(call DIR_compile_template,$(dir))) \ $(eval $(call DIR_clean_old_template,$(dir))) \ + $(eval $(call DIR_clean_template,$(dir))) \ $(eval $(call DIR_all_template,$(dir))) \ ) -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40409?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I434ecbe3f3dd25ea770d8f2d7adfa62c67dc0c1d Gerrit-Change-Number: 40409 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

3 weeks, 3 days

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: msc: add TC_lu_and_ussd_notify_during_mt_call

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40410?usp=email ) Change subject: msc: add TC_lu_and_ussd_notify_during_mt_call ...................................................................... msc: add TC_lu_and_ussd_notify_during_mt_call This is a more realistic scenario (race condition) that reproduces an assertion failure in osmo-msc (OS#6756). We already do have TC_mo_ussd_evil_ms reproducing the problem, but this scenario is unrealistic when using a "normal" (not "evil") MS/UE. Change-Id: I6935ad96aef7747c576505ae52f8b5d3e0611882 Related: osmo-msc.git I724f0f0c9ef8611d3c3653e9370361b252127f72 Related: OS#6756 --- M msc/MSC_Tests.ttcn M msc/expected-results.xml 2 files changed, 64 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/10/40410/1 diff --git a/msc/MSC_Tests.ttcn b/msc/MSC_Tests.ttcn index 2f8df4d..22b6608 100644 --- a/msc/MSC_Tests.ttcn +++ b/msc/MSC_Tests.ttcn @@ -3972,6 +3972,66 @@ vc_conn.done; } +friend function f_TC_lu_and_ussd_notify_during_mt_call(charstring id, BSC_ConnHdlrPars pars) +runs on BSC_ConnHdlr { + var CallParameters cpars := valueof(t_CallParams); + + f_init_handler(pars); + + /* Perform location update */ + f_perform_lu(); + /* Initiate a MT call */ + f_mt_call_establish(cpars); + + /* Facility IE with network-originated USSD notification */ + var OCTN facility_req := f_USSD_FACILITY_IE_INVOKE(op_code := SS_OP_CODE_USS_NOTIFY, + ussd_string := "Knock knock"); + /* Facility IE with acknowledgment to the USSD notification */ + var OCTN facility_rsp := enc_SS_FacilityInformation( + valueof(ts_SS_USSD_FACILITY_RETURN_RESULT_EMPTY()) + ); + + /* HLR sends a USSD notification */ + GSUP.send(ts_GSUP_PROC_SS_REQ(imsi := g_pars.imsi, + sid := g_pars.gsup_sid, + state := OSMO_GSUP_SESSION_STATE_BEGIN, + ss := facility_req)); + /* ... and immediately terminates the session */ + GSUP.send(ts_GSUP_PROC_SS_REQ(imsi := g_pars.imsi, + sid := g_pars.gsup_sid, + state := OSMO_GSUP_SESSION_STATE_END)); + + /* MSC forwards USSD notification to the MS */ + f_expect_mt_dtap_msg(tr_ML3_MT_SS_REGISTER(tid := 0, + ti_flag := c_TIF_ORIG, + facility := facility_req)); + /* ... immediately followed by the RELEASE COMPLETE message */ + f_expect_mt_dtap_msg(tr_ML3_MT_SS_RELEASE_COMPLETE(tid := 0, + ti_flag := c_TIF_ORIG, + facility := omit)); + + /* MS didn't receive the RELEASE COMPLETE yet, so it responds */ + BSSAP.send(ts_PDU_DTAP_MO(ts_ML3_MO_SS_FACILITY(tid := 0, + ti_flag := c_TIF_REPL, + facility := facility_rsp))); + /* this response is rejected because the SS transaction is gone */ + f_expect_mt_dtap_msg(tr_ML3_MT_SS_RELEASE_COMPLETE(tid := 0, + ti_flag := c_TIF_ORIG, + facility := omit)); + + /* ... old osmo-msc crashes here (OS#6756) ... + * fixed in osmo-msc.git I724f0f0c9ef8611d3c3653e9370361b252127f72 */ + + /* Release the call (does Clear Complete itself) */ + f_call_hangup(cpars, true); +} +testcase TC_lu_and_ussd_notify_during_mt_call() runs on MTC_CT { + var BSC_ConnHdlr vc_conn; + f_init(); + vc_conn := f_start_handler(refers(f_TC_lu_and_ussd_notify_during_mt_call), 111); + vc_conn.done; +} + /* LU followed by MO USSD request and MO Release during transaction */ friend function f_tc_lu_and_mo_ussd_mo_release(charstring id, BSC_ConnHdlrPars pars) @@ -4395,7 +4455,8 @@ /* MO (mobile-originated) SS/USSD FACILITY for an unknown transaction, * and CM SERVICE REQUEST with wrong establishment cause prior to that. - * This is an "evil MS" scenario that can be used to reproduce OS#6756. */ + * This is an "evil MS" scenario that can be used to reproduce OS#6756. + * More realistic scenario for this bug: TC_lu_and_ussd_notify_during_mt_call. */ friend function f_TC_mo_ussd_evil_ms(charstring id, BSC_ConnHdlrPars pars) runs on BSC_ConnHdlr { f_init_handler(pars); @@ -7613,6 +7674,7 @@ execute( TC_proc_ss_abort() ); if (Misc_Helpers.f_osmo_repo_is("nightly")) { + execute( TC_lu_and_ussd_notify_during_mt_call() ); /* XXX: crashes osmo-msc */ execute( TC_mo_ussd_evil_ms() ); /* XXX: crashes osmo-msc */ } diff --git a/msc/expected-results.xml b/msc/expected-results.xml index dacb840..9d7e315 100644 --- a/msc/expected-results.xml +++ b/msc/expected-results.xml @@ -94,6 +94,7 @@ <testcase classname='MSC_Tests' name='TC_proc_ss_for_unknown_session' time='MASKED'/> <testcase classname='MSC_Tests' name='TC_proc_ss_paging_fail' time='MASKED'/> <testcase classname='MSC_Tests' name='TC_proc_ss_abort' time='MASKED'/> + <testcase classname='MSC_Tests' name='TC_lu_and_ussd_notify_during_mt_call' time='MASKED'/> <testcase classname='MSC_Tests' name='TC_mo_ussd_evil_ms' time='MASKED'/> <testcase classname='MSC_Tests' name='TC_multi_lu_and_mo_ussd' time='MASKED'/> <testcase classname='MSC_Tests' name='TC_multi_lu_and_mt_ussd' time='MASKED'/> -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40410?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I6935ad96aef7747c576505ae52f8b5d3e0611882 Gerrit-Change-Number: 40410 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

3 weeks, 3 days

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: library/ngap: Fix criticality of several NGAP messages

by fixeria

Attention is currently required from: jolly, pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40407?usp=email ) Change subject: library/ngap: Fix criticality of several NGAP messages ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40407?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I2283a5b025f0ce7d7445fa0ce9ba8405156c4533 Gerrit-Change-Number: 40407 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 30 May 2025 08:31:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

3 weeks, 3 days

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: library/ngap: Fix wrong id set on PWSFailureIndication templates

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40406?usp=email ) Change subject: library/ngap: Fix wrong id set on PWSFailureIndication templates ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40406?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ied1c7a5914c6cbacf64ba857aa31c12ca6f001fb Gerrit-Change-Number: 40406 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 30 May 2025 08:31:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

3 weeks, 3 days

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: library/ngap: Fix criticality of several NGAP messages

by pespin

Attention is currently required from: jolly. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40407?usp=email ) Change subject: library/ngap: Fix criticality of several NGAP messages ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: @andreas@eversberg.eu I think this commit may fix the encoding problems you were having with libfftranscode, but not sure tbh. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40407?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I2283a5b025f0ce7d7445fa0ce9ba8405156c4533 Gerrit-Change-Number: 40407 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-CC: Jenkins Builder Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Thu, 29 May 2025 17:43:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

3 weeks, 3 days

1
0
0 0

2025

2024

2023

2022

gerrit-log May 2025