April 2025 - gerrit-log - lists.osmocom.org

[S] Change in ...osmo_dia2gsup[master]: osmo_dia2gsup: disable Nagle for TCP/SCTP by default

by fixeria

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/40126?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: osmo_dia2gsup: disable Nagle for TCP/SCTP by default ...................................................................... osmo_dia2gsup: disable Nagle for TCP/SCTP by default Disable the Nagle's algorithm by default in order to reduce latency of the DIAMETER peer. Allow re-enabling it via the environment parameter 'diameter_nodelay' (false enables the Nagle). Change-Id: I1e62cdbcbbdb29a0a98f390b33cf14592079d579 --- M src/osmo_dia2gsup.erl 1 file changed, 15 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo_dia2gsup refs/changes/26/40126/2 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/40126?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I1e62cdbcbbdb29a0a98f390b33cf14592079d579 Gerrit-Change-Number: 40126 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder

3 months, 3 weeks

1
0
0 0

[S] Change in ...osmo_dia2gsup[master]: osmo_dia2gsup: add get_env/2 for convenience

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/40123?usp=email ) Change subject: osmo_dia2gsup: add get_env/2 for convenience ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/40123?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I4c6ce2899c8b41a81fd0278ad065ab65bfd0311d Gerrit-Change-Number: 40123 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 23 Apr 2025 13:22:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

3 months, 3 weeks

1
0
0 0

[S] Change in ...osmo_dia2gsup[master]: osmo_dia2gsup: add and use parse_addr/1

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/40124?usp=email ) Change subject: osmo_dia2gsup: add and use parse_addr/1 ...................................................................... osmo_dia2gsup: add and use parse_addr/1 Change-Id: If02c3486c937595fcc0d3813ab64445ebccb746e --- M src/osmo_dia2gsup.erl 1 file changed, 14 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo_dia2gsup refs/changes/24/40124/1 diff --git a/src/osmo_dia2gsup.erl b/src/osmo_dia2gsup.erl index 7c4f2c1..4986e7d 100644 --- a/src/osmo_dia2gsup.erl +++ b/src/osmo_dia2gsup.erl @@ -106,7 +106,7 @@ Port = get_env(diameter_port, 3868), Proto = get_env(diameter_proto, sctp), ConnectTimer = get_env(diameter_connect_timer, 30000), - listen(?SVC_NAME, {address, Proto, element(2,inet:parse_address(Ip)), Port}, {timer, ConnectTimer}), + listen(?SVC_NAME, {address, Proto, parse_addr(Ip), Port}, {timer, ConnectTimer}), lager:info("Diameter HSS Application started on IP ~s, ~p port ~p~n", [Ip, Proto, Port]), {ok, State}. @@ -156,3 +156,16 @@ tmod(tcp) -> diameter_tcp; tmod(sctp) -> diameter_sctp. + +parse_addr(AddrStr) when is_list(AddrStr) -> + {ok, Addr} = inet:parse_address(AddrStr), + Addr; + +parse_addr(addr) -> + case addr of + any -> any; + localhost -> localhost; + _ -> + true = inet:is_ip_address(addr), + addr + end. -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/40124?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: If02c3486c937595fcc0d3813ab64445ebccb746e Gerrit-Change-Number: 40124 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

3 months, 3 weeks

1
0
0 0

[S] Change in ...osmo_dia2gsup[master]: osmo_dia2gsup: move env parsing and logging to listen/1

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/40125?usp=email ) Change subject: osmo_dia2gsup: move env parsing and logging to listen/1 ...................................................................... osmo_dia2gsup: move env parsing and logging to listen/1 In preparation for follow-up patches, make the listen/1 function self-contained by letting it consume the environment on its own. Change-Id: I8ca4cc0b830d281ada5ba56bc98a9511937b8b81 --- M src/osmo_dia2gsup.erl 1 file changed, 13 insertions(+), 12 deletions(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo_dia2gsup refs/changes/25/40125/1 diff --git a/src/osmo_dia2gsup.erl b/src/osmo_dia2gsup.erl index 4986e7d..98a766c 100644 --- a/src/osmo_dia2gsup.erl +++ b/src/osmo_dia2gsup.erl @@ -101,13 +101,7 @@ % DIAMETER side ProdName = atom_to_list(?MODULE), ok = diameter:start_service(?SVC_NAME, ?SERVICE(ProdName)), - - Ip = get_env(diameter_ip, "127.0.0.8"), - Port = get_env(diameter_port, 3868), - Proto = get_env(diameter_proto, sctp), - ConnectTimer = get_env(diameter_connect_timer, 30000), - listen(?SVC_NAME, {address, Proto, parse_addr(Ip), Port}, {timer, ConnectTimer}), - lager:info("Diameter HSS Application started on IP ~s, ~p port ~p~n", [Ip, Proto, Port]), + listen(?SVC_NAME), {ok, State}. %% @callback gen_server @@ -147,12 +141,19 @@ %% Internal Function Definitions %% ------------------------------------------------------------------ -listen(Name, {address, Protocol, IPAddr, Port}, {timer, ConnectTimer}) -> - TransOpts = [{transport_module, tmod(Protocol)}, - {transport_config, [{reuseaddr, true}, - {ip, IPAddr}, {port, Port}]}, +listen(Name) -> + LAddr = get_env(diameter_ip, "127.0.0.8"), + LPort = get_env(diameter_port, 3868), + Proto = get_env(diameter_proto, sctp), + ConnectTimer = get_env(diameter_connect_timer, 30000), + TransOpts = [{transport_module, tmod(Proto)}, + {transport_config, [{ip, parse_addr(LAddr)}, + {port, LPort}, + {reuseaddr, true}]}, {connect_timer, ConnectTimer}], - {ok, _} = diameter:add_transport(Name, {listen, TransOpts}). + {ok, _} = diameter:add_transport(Name, {listen, TransOpts}), + lager:info("Diameter HSS Application started on IP ~s, ~p port ~p~n", + [LAddr, Proto, LPort]). tmod(tcp) -> diameter_tcp; tmod(sctp) -> diameter_sctp. -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/40125?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I8ca4cc0b830d281ada5ba56bc98a9511937b8b81 Gerrit-Change-Number: 40125 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

3 months, 3 weeks

1
0
0 0

[S] Change in ...osmo_dia2gsup[master]: osmo_dia2gsup: add get_env/2 for convenience

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/40123?usp=email ) Change subject: osmo_dia2gsup: add get_env/2 for convenience ...................................................................... osmo_dia2gsup: add get_env/2 for convenience Change-Id: I4c6ce2899c8b41a81fd0278ad065ab65bfd0311d --- M src/osmo_dia2gsup.erl M src/osmo_dia2gsup_sup.erl 2 files changed, 13 insertions(+), 10 deletions(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo_dia2gsup refs/changes/23/40123/1 diff --git a/src/osmo_dia2gsup.erl b/src/osmo_dia2gsup.erl index b8d7a34..7c4f2c1 100644 --- a/src/osmo_dia2gsup.erl +++ b/src/osmo_dia2gsup.erl @@ -36,7 +36,7 @@ -include_lib("diameter/include/diameter_gen_base_rfc6733.hrl"). %-include_lib("diameter_settings.hrl"). --export([main/1]). +-export([get_env/2, main/1]). % API -export([start_link/0]). @@ -56,9 +56,9 @@ -define(DIAMETER_DICT_HSS, diameter_3gpp_ts29_272). -define(APPID_S6, #'diameter_base_Vendor-Specific-Application-Id'{'Vendor-Id'=10415, 'Auth-Application-Id'=[16777251]}). --define(SERVICE(Name), [{'Origin-Host', application:get_env(osmo_dia2gsup, origin_host, "hss.localdomain")}, - {'Origin-Realm', application:get_env(osmo_dia2gsup, origin_realm, "localdomain")}, - {'Vendor-Id', application:get_env(osmo_dia2gsup, vendor_id, 0)}, +-define(SERVICE(Name), [{'Origin-Host', get_env(origin_host, "hss.localdomain")}, + {'Origin-Realm', get_env(origin_realm, "localdomain")}, + {'Vendor-Id', get_env(vendor_id, 0)}, {'Origin-State-Id', diameter:origin_state_id()}, {'Product-Name', Name}, {'Auth-Application-Id', []}, @@ -85,6 +85,9 @@ stop() -> gen_server:cast(?SERVER, stop). +get_env(Param, Default) -> + application:get_env(?MODULE, Param, Default). + main(_Args) -> application:ensure_all_started(?MODULE), timer:sleep(infinity). @@ -99,10 +102,10 @@ ProdName = atom_to_list(?MODULE), ok = diameter:start_service(?SVC_NAME, ?SERVICE(ProdName)), - Ip = application:get_env(osmo_dia2gsup, diameter_ip, "127.0.0.8"), - Port = application:get_env(osmo_dia2gsup, diameter_port, 3868), - Proto = application:get_env(osmo_dia2gsup, diameter_proto, sctp), - ConnectTimer = application:get_env(osmo_dia2gsup, diameter_connect_timer, 30000), + Ip = get_env(diameter_ip, "127.0.0.8"), + Port = get_env(diameter_port, 3868), + Proto = get_env(diameter_proto, sctp), + ConnectTimer = get_env(diameter_connect_timer, 30000), listen(?SVC_NAME, {address, Proto, element(2,inet:parse_address(Ip)), Port}, {timer, ConnectTimer}), lager:info("Diameter HSS Application started on IP ~s, ~p port ~p~n", [Ip, Proto, Port]), {ok, State}. diff --git a/src/osmo_dia2gsup_sup.erl b/src/osmo_dia2gsup_sup.erl index dbb1ae6..929206d 100644 --- a/src/osmo_dia2gsup_sup.erl +++ b/src/osmo_dia2gsup_sup.erl @@ -10,8 +10,8 @@ init([]) -> % GSUP side - HlrIp = application:get_env(osmo_dia2gsup, hlr_ip, "127.0.0.1"), - HlrPort = application:get_env(osmo_dia2gsup, hlr_port, 4222), + HlrIp = osmo_dia2gsup:get_env(hlr_ip, "127.0.0.1"), + HlrPort = osmo_dia2gsup:get_env(hlr_port, 4222), Args = [{local, gsup_client}, gsup_client, [HlrIp, HlrPort, "HSS-00-00-00-00-00-00"], []], GsupChild = {gsup_client, {gen_server, start_link, Args}, permanent, 2000, worker, [gsup_client]}, % DIAMETER side -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/40123?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I4c6ce2899c8b41a81fd0278ad065ab65bfd0311d Gerrit-Change-Number: 40123 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

3 months, 3 weeks

1
0
0 0

[XS] Change in ...osmo_dia2gsup[master]: osmo_dia2gsup: set sndbuf/recbuf explicitly for SCTP

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/40127?usp=email ) Change subject: osmo_dia2gsup: set sndbuf/recbuf explicitly for SCTP ...................................................................... osmo_dia2gsup: set sndbuf/recbuf explicitly for SCTP When opening an SCTP socket on Linux, Erlang/OTP does set its own default SO_SNDBUF/SO_RCVBUF values if the respective socket options (sndbuf and recbuf) are not given to gen_sctp:open/N explicitly. For some reason, the default RCVBUF size (1024) is much smaller than the default SNDBUF size (65536), and both are well below modern Linux defaults. Such a small RCVBUF size becomes problematic when the remote peer is sending large packets. Let's explicitly set both sndbuf/recbuf parameters to 65536, allowing the user to overwrite this default via the environment parameters. For more details, see https://github.com/erlang/otp/issues/9722. Change-Id: I793f1295ab42bfc548511fc5ffbda9070280745f --- M src/osmo_dia2gsup.erl 1 file changed, 4 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo_dia2gsup refs/changes/27/40127/1 diff --git a/src/osmo_dia2gsup.erl b/src/osmo_dia2gsup.erl index 1739360..c8a1d2b 100644 --- a/src/osmo_dia2gsup.erl +++ b/src/osmo_dia2gsup.erl @@ -48,6 +48,7 @@ -define(SERVER, ?MODULE). -define(ENV_DEFAULT_SCTP_NODELAY, true). +-define(ENV_DEFAULT_SCTP_BUFSZ, 65536). % Diameter application definitions @@ -162,7 +163,9 @@ tcfg(Cfg, LAddr, LPort); tcfg(sctp, LAddr, LPort) -> - Cfg = #{sctp_nodelay => get_env(diameter_nodelay, ?ENV_DEFAULT_SCTP_NODELAY)}, + Cfg = #{sctp_nodelay => get_env(diameter_nodelay, ?ENV_DEFAULT_SCTP_NODELAY), + recbuf => get_env(diameter_sctp_recbuf, ?ENV_DEFAULT_SCTP_BUFSZ), + sndbuf => get_env(diameter_sctp_sndbuf, ?ENV_DEFAULT_SCTP_BUFSZ)}, tcfg(Cfg, LAddr, LPort); tcfg(Cfg, LAddr, LPort) when is_map(Cfg) -> -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/40127?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I793f1295ab42bfc548511fc5ffbda9070280745f Gerrit-Change-Number: 40127 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

3 months, 3 weeks

1
0
0 0

[S] Change in ...osmo_dia2gsup[master]: osmo_dia2gsup: disable Nagle for TCP/SCTP by default

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/40126?usp=email ) Change subject: osmo_dia2gsup: disable Nagle for TCP/SCTP by default ...................................................................... osmo_dia2gsup: disable Nagle for TCP/SCTP by default Disable the Nagle's algorithm by default in order to reduce latency of the DIAMETER peer. Allow re-enabling it via the environment parameter 'diameter_nodelay' (false enables the Nagle). Change-Id: I1e62cdbcbbdb29a0a98f390b33cf14592079d579 --- M src/osmo_dia2gsup.erl 1 file changed, 15 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo_dia2gsup refs/changes/26/40126/1 diff --git a/src/osmo_dia2gsup.erl b/src/osmo_dia2gsup.erl index 98a766c..1739360 100644 --- a/src/osmo_dia2gsup.erl +++ b/src/osmo_dia2gsup.erl @@ -47,6 +47,7 @@ -export([code_change/3, terminate/2]). -define(SERVER, ?MODULE). +-define(ENV_DEFAULT_SCTP_NODELAY, true). % Diameter application definitions @@ -147,9 +148,7 @@ Proto = get_env(diameter_proto, sctp), ConnectTimer = get_env(diameter_connect_timer, 30000), TransOpts = [{transport_module, tmod(Proto)}, - {transport_config, [{ip, parse_addr(LAddr)}, - {port, LPort}, - {reuseaddr, true}]}, + {transport_config, tcfg(Proto, LAddr, LPort)}, {connect_timer, ConnectTimer}], {ok, _} = diameter:add_transport(Name, {listen, TransOpts}), lager:info("Diameter HSS Application started on IP ~s, ~p port ~p~n", @@ -158,6 +157,19 @@ tmod(tcp) -> diameter_tcp; tmod(sctp) -> diameter_sctp. +tcfg(tcp, LAddr, LPort) -> + Cfg = #{nodelay => get_env(diameter_nodelay, ?ENV_DEFAULT_SCTP_NODELAY)}, + tcfg(Cfg, LAddr, LPort); + +tcfg(sctp, LAddr, LPort) -> + Cfg = #{sctp_nodelay => get_env(diameter_nodelay, ?ENV_DEFAULT_SCTP_NODELAY)}, + tcfg(Cfg, LAddr, LPort); + +tcfg(Cfg, LAddr, LPort) when is_map(Cfg) -> + maps:to_list(Cfg#{ip => parse_addr(LAddr), + port => LPort, + reuseaddr => true}). + parse_addr(AddrStr) when is_list(AddrStr) -> {ok, Addr} = inet:parse_address(AddrStr), Addr; -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/40126?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I1e62cdbcbbdb29a0a98f390b33cf14592079d579 Gerrit-Change-Number: 40126 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

3 months, 3 weeks

1
0
0 0

[XS] Change in libosmo-netif[master]: stream: Improve error logging sctp_recvmsg without sctp_sndrcvinfo

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-netif/+/40122?usp=email ) Change subject: stream: Improve error logging sctp_recvmsg without sctp_sndrcvinfo ...................................................................... stream: Improve error logging sctp_recvmsg without sctp_sndrcvinfo Related: OS#6775 Change-Id: I4ef03a2505ca7409d50fd34371ae4ec40bebb40f --- M src/stream.c 1 file changed, 5 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/22/40122/1 diff --git a/src/stream.c b/src/stream.c index fb15f93..f0902a4 100644 --- a/src/stream.c +++ b/src/stream.c @@ -266,8 +266,11 @@ return ret; } - if (OSMO_UNLIKELY(ret > 0 && !sinfo)) - LOGP(DLINP, LOGL_ERROR, "%s sctp_recvmsg without SNDRCV cmsg?!?\n", log_pfx); + if (OSMO_UNLIKELY(ret > 0 && !sinfo)) { + char buf[512]; + LOGP(DLINP, LOGL_ERROR, "%s sctp_recvmsg without SNDRCV cmsg?!? ret=%d, flags=0x%x, %s\n", + log_pfx, ret, flags, msgb_hexdump_buf(buf, sizeof(buf), msg)); + } return ret; } -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/40122?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I4ef03a2505ca7409d50fd34371ae4ec40bebb40f Gerrit-Change-Number: 40122 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

3 months, 3 weeks

1
0
0 0

[XS] Change in libosmo-netif[master]: cosmetic: stream: Fix line indentation

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-netif/+/40121?usp=email ) Change subject: cosmetic: stream: Fix line indentation ...................................................................... cosmetic: stream: Fix line indentation Change-Id: I8ea52e30ff25851dfb51cbbb6c3da910c0692bd1 --- M src/stream.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/21/40121/1 diff --git a/src/stream.c b/src/stream.c index 5033f4c..fb15f93 100644 --- a/src/stream.c +++ b/src/stream.c @@ -296,7 +296,7 @@ struct cmsghdr *cmsg = NULL; for (cmsg = CMSG_FIRSTHDR((struct msghdr *) msgh); cmsg != NULL; - cmsg = CMSG_NXTHDR((struct msghdr *) msgh, cmsg)) { + cmsg = CMSG_NXTHDR((struct msghdr *) msgh, cmsg)) { if (cmsg->cmsg_level == IPPROTO_SCTP && cmsg->cmsg_type == SCTP_SNDRCV) { sinfo = (const struct sctp_sndrcvinfo *)CMSG_DATA(cmsg); break; -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/40121?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I8ea52e30ff25851dfb51cbbb6c3da910c0692bd1 Gerrit-Change-Number: 40121 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

3 months, 3 weeks

1
0
0 0

[S] Change in ...pyosmocom[master]: osmocom.construct: Bytes + GreedyBytes with automatic hexstring-conve...

by laforge

Attention is currently required from: dexter. laforge has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/python/pyosmocom/+/40117?usp=email ) Change subject: osmocom.construct: Bytes + GreedyBytes with automatic hexstring-conversion ...................................................................... Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/python/pyosmocom/+/40117?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: python/pyosmocom Gerrit-Branch: master Gerrit-Change-Id: I59f500c925848872a7fa38d6dbf3d6ea72bc3a90 Gerrit-Change-Number: 40117 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 23 Apr 2025 12:11:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

3 months, 3 weeks

1
0
0 0

2025

2024

2023

2022

gerrit-log April 2025