April 2025 - gerrit-log - lists.osmocom.org

[XS] Change in pysim[master]: filesystem: fix WARNING: Block quote ends without a blank line

by neels

Attention is currently required from: fixeria. neels has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/pysim/+/40134?usp=email ) Change subject: filesystem: fix WARNING: Block quote ends without a blank line ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/40134?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ie7f59685a78534eb2c43ec4bc39685d3fd264778 Gerrit-Change-Number: 40134 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 24 Apr 2025 01:50:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

3 months, 3 weeks

1
0
0 0

[M] Change in pysim[master]: docs/saip-tool: fix ERROR: Unexpected indentation

by neels

Attention is currently required from: dexter, fixeria. neels has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/pysim/+/40135?usp=email ) Change subject: docs/saip-tool: fix ERROR: Unexpected indentation ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/40135?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: If548bf66339433c1f3f9e2a557821e808c6afa26 Gerrit-Change-Number: 40135 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 24 Apr 2025 01:50:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

3 months, 3 weeks

1
0
0 0

[M] Change in pysim[master]: docs/saip-tool: fix ERROR: Unexpected indentation

by laforge

Attention is currently required from: dexter, fixeria. laforge has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/pysim/+/40135?usp=email ) Change subject: docs/saip-tool: fix ERROR: Unexpected indentation ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/40135?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: If548bf66339433c1f3f9e2a557821e808c6afa26 Gerrit-Change-Number: 40135 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: Jenkins Builder Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 23 Apr 2025 20:39:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

3 months, 3 weeks

1
0
0 0

[XS] Change in pysim[master]: filesystem: fix WARNING: Block quote ends without a blank line

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/pysim/+/40134?usp=email ) Change subject: filesystem: fix WARNING: Block quote ends without a blank line ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/40134?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ie7f59685a78534eb2c43ec4bc39685d3fd264778 Gerrit-Change-Number: 40134 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 23 Apr 2025 20:38:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

3 months, 3 weeks

1
0
0 0

[XS] Change in pysim[master]: doc/card-key-provider: fix WARNING: Title underline too short

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/pysim/+/40133?usp=email ) Change subject: doc/card-key-provider: fix WARNING: Title underline too short ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/40133?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I29fda8350de75c4e7c0020fa4dce4cd0e5defda7 Gerrit-Change-Number: 40133 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: Jenkins Builder Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 23 Apr 2025 20:37:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

3 months, 3 weeks

1
0
0 0

[XS] Change in pysim[master]: filesystem: fix WARNING: Block quote ends without a blank line

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/40134?usp=email ) Change subject: filesystem: fix WARNING: Block quote ends without a blank line ...................................................................... filesystem: fix WARNING: Block quote ends without a blank line Use the 'r' (raw) qualifier to avoid rendering '\n' as the actual line break in the auto-generated documentation. Change-Id: Ie7f59685a78534eb2c43ec4bc39685d3fd264778 --- M pySim/filesystem.py 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/34/40134/1 diff --git a/pySim/filesystem.py b/pySim/filesystem.py index 7f350ec..2d9a07e 100644 --- a/pySim/filesystem.py +++ b/pySim/filesystem.py @@ -301,7 +301,7 @@ @staticmethod def export(as_json: bool, lchan): - """ + r""" Export file contents in the form of commandline script. This method is meant to be overloaded by a subclass in case any exportable contents are present. The generated script may contain multiple command lines separated by line breaks ("\n"), where the last commandline shall have no line break at the end -- To view, visit https://gerrit.osmocom.org/c/pysim/+/40134?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ie7f59685a78534eb2c43ec4bc39685d3fd264778 Gerrit-Change-Number: 40134 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

3 months, 3 weeks

1
0
0 0

[XS] Change in pysim[master]: doc/card-key-provider: fix WARNING: Title underline too short

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/40133?usp=email ) Change subject: doc/card-key-provider: fix WARNING: Title underline too short ...................................................................... doc/card-key-provider: fix WARNING: Title underline too short Change-Id: I29fda8350de75c4e7c0020fa4dce4cd0e5defda7 --- M docs/card-key-provider.rst 1 file changed, 1 insertion(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/33/40133/1 diff --git a/docs/card-key-provider.rst b/docs/card-key-provider.rst index 7b4bf2c..390a7c7 100644 --- a/docs/card-key-provider.rst +++ b/docs/card-key-provider.rst @@ -1,6 +1,5 @@ - Retrieving card-individual keys via CardKeyProvider -================================================== +=================================================== When working with a batch of cards, or more than one card in general, it is a lot of effort to manually retrieve the card-specific PIN (like -- To view, visit https://gerrit.osmocom.org/c/pysim/+/40133?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I29fda8350de75c4e7c0020fa4dce4cd0e5defda7 Gerrit-Change-Number: 40133 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

3 months, 3 weeks

1
0
0 0

[M] Change in pysim[master]: docs/saip-tool: fix ERROR: Unexpected indentation

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/40135?usp=email ) Change subject: docs/saip-tool: fix ERROR: Unexpected indentation ...................................................................... docs/saip-tool: fix ERROR: Unexpected indentation According to [1], the literal block must be indented (and, like all paragraphs, separated from the surrounding ones by blank lines). [1] https://www.sphinx-doc.org/en/master/usage/restructuredtext/basics.html#lit… While at it, fix tabs-vs-spaces: use 2 spaces like in other places. Change-Id: If548bf66339433c1f3f9e2a557821e808c6afa26 --- M docs/saip-tool.rst 1 file changed, 50 insertions(+), 45 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/35/40135/1 diff --git a/docs/saip-tool.rst b/docs/saip-tool.rst index 8aa8cd7..347d430 100644 --- a/docs/saip-tool.rst +++ b/docs/saip-tool.rst @@ -36,24 +36,25 @@ Example: Adding a JAVA-card applet to an existing profile package :: - # Step #1: Create the application PE and load the ijc contents from the .cap file: - $ ./contrib/saip-tool.py upp.der add-app --output-file upp_with_app.der --applet-file app.cap --aid '1122334455' - Read 28 PEs from file 'upp.der' - Applying applet file: 'app.cap'... - application PE inserted into PE Sequence after securityDomain PE AID: a000000151000000 - Writing 29 PEs to file 'upp_with_app.der'... - # Step #2: Create the application instance inside the application PE created in step #1: - $ ./contrib/saip-tool.py upp_with_app.der add-app-inst --output-file upp_with_app_and_instance.der \ - --aid '1122334455' \ - --class-aid '112233445501' \ - --inst-aid '112233445501' \ - --app-privileges '00' \ - --app-spec-pars '00' \ - --uicc-toolkit-app-spec-pars '01001505000000000000000000000000' - Read 29 PEs from file 'upp_with_app.der' - Found Load Package AID: 1122334455, adding new instance AID: 112233445501 to Application PE... - Writing 29 PEs to file 'upp_with_app_and_instance.der'... + # Step #1: Create the application PE and load the ijc contents from the .cap file: + $ ./contrib/saip-tool.py upp.der add-app --output-file upp_with_app.der --applet-file app.cap --aid '1122334455' + Read 28 PEs from file 'upp.der' + Applying applet file: 'app.cap'... + application PE inserted into PE Sequence after securityDomain PE AID: a000000151000000 + Writing 29 PEs to file 'upp_with_app.der'... + + # Step #2: Create the application instance inside the application PE created in step #1: + $ ./contrib/saip-tool.py upp_with_app.der add-app-inst --output-file upp_with_app_and_instance.der \ + --aid '1122334455' \ + --class-aid '112233445501' \ + --inst-aid '112233445501' \ + --app-privileges '00' \ + --app-spec-pars '00' \ + --uicc-toolkit-app-spec-pars '01001505000000000000000000000000' + Read 29 PEs from file 'upp_with_app.der' + Found Load Package AID: 1122334455, adding new instance AID: 112233445501 to Application PE... + Writing 29 PEs to file 'upp_with_app_and_instance.der'... NOTE: The parameters of the sub-commands `add-app` and `add-app-inst` are application specific. It is up to the application developer to pick parameters that suit the application correctly. For an exact command reference see section @@ -70,30 +71,32 @@ Example: Listing applications and their parameters :: - $ ./contrib/saip-tool.py upp_with_app_and_instance.der info --apps - Read 29 PEs from file 'upp_with_app_and_instance.der' - Application #0: - loadBlock: - loadPackageAID: '1122334455' (5 bytes) - loadBlockObject: '01000fdecaffed010204000105d07002ca440200...681080056810a00633b44104b431066800a10231' (569 bytes) - instanceList[0]: - applicationLoadPackageAID: '1122334455' (5 bytes) - classAID: '112233445501' (8 bytes) - instanceAID: '112233445501' (8 bytes) - applicationPrivileges: '00' (1 bytes) - lifeCycleState: '07' (1 bytes) - applicationSpecificParametersC9: '00' (1 bytes) - applicationParameters: - uiccToolkitApplicationSpecificParametersField: '01001505000000000000000000000000' (16 bytes) + + $ ./contrib/saip-tool.py upp_with_app_and_instance.der info --apps + Read 29 PEs from file 'upp_with_app_and_instance.der' + Application #0: + loadBlock: + loadPackageAID: '1122334455' (5 bytes) + loadBlockObject: '01000fdecaffed010204000105d07002ca440200...681080056810a00633b44104b431066800a10231' (569 bytes) + instanceList[0]: + applicationLoadPackageAID: '1122334455' (5 bytes) + classAID: '112233445501' (8 bytes) + instanceAID: '112233445501' (8 bytes) + applicationPrivileges: '00' (1 bytes) + lifeCycleState: '07' (1 bytes) + applicationSpecificParametersC9: '00' (1 bytes) + applicationParameters: + uiccToolkitApplicationSpecificParametersField: '01001505000000000000000000000000' (16 bytes) In case further analysis with external tools or transfer of applications from one profile package to another is necessary, the executable code in the `loadBlockObject` field can be extracted to an `.ijc` or an `.cap` file. Example: Extracting applications from a profile package :: - $ ./contrib/saip-tool.py upp_with_app_and_instance.der extract-apps --output-dir ./apps --format ijc - Read 29 PEs from file 'upp_with_app_and_instance.der' - Writing Load Package AID: 1122334455 to file ./apps/8949449999999990023f-1122334455.ijc + + $ ./contrib/saip-tool.py upp_with_app_and_instance.der extract-apps --output-dir ./apps --format ijc + Read 29 PEs from file 'upp_with_app_and_instance.der' + Writing Load Package AID: 1122334455 to file ./apps/8949449999999990023f-1122334455.ijc Removing applications @@ -104,11 +107,12 @@ Example: Remove an application from a profile package :: - $ ./contrib/saip-tool.py upp_with_app_and_instance.der remove-app --output-file upp_without_app.der --aid '1122334455' - Read 29 PEs from file 'upp_with_app_and_instance.der' - Found Load Package AID: 1122334455, removing related PE (id=23) from Sequence... - Removing PE application (id=23) from Sequence... - Writing 28 PEs to file 'upp_without_app.der'... + + $ ./contrib/saip-tool.py upp_with_app_and_instance.der remove-app --output-file upp_without_app.der --aid '1122334455' + Read 29 PEs from file 'upp_with_app_and_instance.der' + Found Load Package AID: 1122334455, removing related PE (id=23) from Sequence... + Removing PE application (id=23) from Sequence... + Writing 28 PEs to file 'upp_without_app.der'... In some cases it is useful to remove only an instance from an existing application PE. This may be the case when the an application developer wants to modify parameters of an application by removing and re-adding the instance. The @@ -116,11 +120,12 @@ Example: Remove an application instance from an application PE :: - $ ./contrib/saip-tool.py upp_with_app_and_instance.der remove-app-inst --output-file upp_without_app.der --aid '1122334455' --inst-aid '112233445501' - Read 29 PEs from file 'upp_with_app_and_instance.der' - Found Load Package AID: 1122334455, removing instance AID: 112233445501 from Application PE... - Removing instance from Application PE... - Writing 29 PEs to file 'upp_with_app.der'... + + $ ./contrib/saip-tool.py upp_with_app_and_instance.der remove-app-inst --output-file upp_without_app.der --aid '1122334455' --inst-aid '112233445501' + Read 29 PEs from file 'upp_with_app_and_instance.der' + Found Load Package AID: 1122334455, removing instance AID: 112233445501 from Application PE... + Removing instance from Application PE... + Writing 29 PEs to file 'upp_with_app.der'... saip-tool syntax -- To view, visit https://gerrit.osmocom.org/c/pysim/+/40135?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: If548bf66339433c1f3f9e2a557821e808c6afa26 Gerrit-Change-Number: 40135 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

3 months, 3 weeks

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: Move f_{dec,enc}_mcc_mnc() API BSSMAP_Templates.ttcn -> GSM_Types.ttcn

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40112?usp=email ) Change subject: Move f_{dec,enc}_mcc_mnc() API BSSMAP_Templates.ttcn -> GSM_Types.ttcn ...................................................................... Move f_{dec,enc}_mcc_mnc() API BSSMAP_Templates.ttcn -> GSM_Types.ttcn The GsmMcc and GsmMnc types used in the function are defined in GSM_Types.ttcn, which is also incldued by BSSMAP_Templates. Hence, move the function there so that it can be used in other testsuites including more generic GSM_Types.ttcn but not BSSMAP_Templates.ttcn. Change-Id: Iafafd2957a11d34a9402d252a169fec40593f483 --- M cbc/CBC_Tests.ttcn M library/BSSMAP_Templates.ttcn M library/GSM_Types.ttcn 3 files changed, 18 insertions(+), 18 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/cbc/CBC_Tests.ttcn b/cbc/CBC_Tests.ttcn index 52f6378..a00b5d1 100644 --- a/cbc/CBC_Tests.ttcn +++ b/cbc/CBC_Tests.ttcn @@ -3,6 +3,7 @@ import from Osmocom_Types all; import from Socket_API_Definitions all; +import from GSM_Types all; import from BSSAP_Types all; import from BSSMAP_Templates all; import from CBSP_Types all; diff --git a/library/BSSMAP_Templates.ttcn b/library/BSSMAP_Templates.ttcn index a93fb02..563d6d1 100644 --- a/library/BSSMAP_Templates.ttcn +++ b/library/BSSMAP_Templates.ttcn @@ -1450,24 +1450,6 @@ cIl_LAC := lacl } - -function f_enc_mcc_mnc(GsmMcc mcc, GsmMnc mnc) return OCT3 { - if (lengthof(mnc) == 2) { - return hex2oct(mcc[1] & mcc[0] & 'F'H & mcc[2] & mnc[1] & mnc[0]); - } else { - return hex2oct(mcc[1] & mcc[0] & mnc[2] & mcc[2] & mnc[1] & mnc[0]); - } -} - -function f_dec_mcc_mnc(in OCT3 mcc_mnc, out GsmMcc mcc, out GsmMnc mnc) { - var hexstring hs := oct2hex(mcc_mnc); - mcc := hs[1] & hs[0] & hs[3]; - mnc := hs[5] & hs[4]; - if (hs[2] == 'F'H) { - mnc := mnc & hs[2]; - } -} - template (value) BSSMAP_FIELD_CellIdentification_CGI ts_BSSMAP_CI_CGI(GsmMcc mcc, GsmMnc mnc, GsmLac lac, GsmCellId ci) := { mcc_mnc := f_enc_mcc_mnc(mcc, mnc), lac := int2oct(lac, 2), diff --git a/library/GSM_Types.ttcn b/library/GSM_Types.ttcn index 54c2e98..64581e5 100644 --- a/library/GSM_Types.ttcn +++ b/library/GSM_Types.ttcn @@ -492,6 +492,23 @@ setverdict(pass); } +function f_enc_mcc_mnc(GsmMcc mcc, GsmMnc mnc) return OCT3 { + if (lengthof(mnc) == 2) { + return hex2oct(mcc[1] & mcc[0] & 'F'H & mcc[2] & mnc[1] & mnc[0]); + } else { + return hex2oct(mcc[1] & mcc[0] & mnc[2] & mcc[2] & mnc[1] & mnc[0]); + } +} + +function f_dec_mcc_mnc(in OCT3 mcc_mnc, out GsmMcc mcc, out GsmMnc mnc) { + var hexstring hs := oct2hex(mcc_mnc); + mcc := hs[1] & hs[0] & hs[3]; + mnc := hs[5] & hs[4]; + if (hs[2] == 'F'H) { + mnc := mnc & hs[2]; + } +} + /* 24.008 10.5.1.3 */ type record LocationAreaIdentification { BcdMccMnc mcc_mnc, -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40112?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iafafd2957a11d34a9402d252a169fec40593f483 Gerrit-Change-Number: 40112 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

3 months, 3 weeks

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: Fix MNC decoding in f_dec_mcc_mnc()

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40113?usp=email ) Change subject: Fix MNC decoding in f_dec_mcc_mnc() ...................................................................... Fix MNC decoding in f_dec_mcc_mnc() This API is so far only used in MSC_Tests.ttcn f_sgs_perform_lu(), but will be used in more testsuites in follow-up commits. Change-Id: I9db37d0dc9abbbefd57af4f0e2b91bf8a918d4e9 --- M library/GSM_Types.ttcn 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: laforge: Looks good to me, but someone else must approve pespin: Looks good to me, approved fixeria: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/library/GSM_Types.ttcn b/library/GSM_Types.ttcn index 64581e5..6d3e170 100644 --- a/library/GSM_Types.ttcn +++ b/library/GSM_Types.ttcn @@ -504,7 +504,7 @@ var hexstring hs := oct2hex(mcc_mnc); mcc := hs[1] & hs[0] & hs[3]; mnc := hs[5] & hs[4]; - if (hs[2] == 'F'H) { + if (hs[2] != 'F'H) { mnc := mnc & hs[2]; } } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40113?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9db37d0dc9abbbefd57af4f0e2b91bf8a918d4e9 Gerrit-Change-Number: 40113 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

3 months, 3 weeks

1
0
0 0

2025

2024

2023

2022

gerrit-log April 2025