Attention is currently required from: fixeria.
pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/39493?usp=email )
Change subject: rebar.config: relx: generate the version automatically
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/39493?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: erlang/osmo-s1gw
Gerrit-Branch: master
Gerrit-Change-Id: I7a4ed74416d4eef3c3befc0605d1857e147324e7
Gerrit-Change-Number: 39493
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 07 Feb 2025 12:35:35 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: fixeria.
pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/39492?usp=email )
Change subject: rebar.config: relx: fix release name (must be an atom)
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/39492?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: erlang/osmo-s1gw
Gerrit-Branch: master
Gerrit-Change-Id: Ic788ebb1c78c890939bd8dfd9bc34b06fe5c26fd
Gerrit-Change-Number: 39492
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 07 Feb 2025 12:35:20 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: fixeria.
pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/39491?usp=email )
Change subject: rebar.config: cosmetic: use spaces, not tabs
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/39491?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: erlang/osmo-s1gw
Gerrit-Branch: master
Gerrit-Change-Id: Ia6a026b51a0219353b1e898d9fc643381e985dc7
Gerrit-Change-Number: 39491
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 07 Feb 2025 12:35:02 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: fixeria.
pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/39490?usp=email )
Change subject: osmo_s1gw.app.src: set 'vsn' to 'semver'
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/39490?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: erlang/osmo-s1gw
Gerrit-Branch: master
Gerrit-Change-Id: I8a39e632556c75648cef0fb79f47e61043a4149a
Gerrit-Change-Number: 39490
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 07 Feb 2025 12:34:51 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
pespin has submitted this change. ( https://gerrit.osmocom.org/c/upf-benchmark/+/39472?usp=email )
Change subject: Remove unused envnvar calling osmo-upf
......................................................................
Remove unused envnvar calling osmo-upf
This is a copy-paste typo from eupf.
Change-Id: I81de16bfe28b800e04bdaaf9e27d51ecbec33dd5
---
M testsuites/gtplab-sysmo2017/tunend/upf/osmo-upf/run.sh
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
laforge: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/testsuites/gtplab-sysmo2017/tunend/upf/osmo-upf/run.sh b/testsuites/gtplab-sysmo2017/tunend/upf/osmo-upf/run.sh
index 9dda226..a4951e9 100755
--- a/testsuites/gtplab-sysmo2017/tunend/upf/osmo-upf/run.sh
+++ b/testsuites/gtplab-sysmo2017/tunend/upf/osmo-upf/run.sh
@@ -2,7 +2,7 @@
SCRIPT_DIR=$( cd -- "$( dirname -- "${BASH_SOURCE[0]}" )" &> /dev/null && pwd )
-sudo GIN_MODE=release osmo-upf -c "$SCRIPT_DIR/osmo-upf.cfg"
+sudo osmo-upf -c "$SCRIPT_DIR/osmo-upf.cfg"
# TODO: Route needs to be set up manually on the tun iface once it becomes created, since osmo-upf is not yet doing it (OS#6585).
# For now, run this manually after starting osmo-upf with the current run.sh script:
--
To view, visit https://gerrit.osmocom.org/c/upf-benchmark/+/39472?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: upf-benchmark
Gerrit-Branch: master
Gerrit-Change-Id: I81de16bfe28b800e04bdaaf9e27d51ecbec33dd5
Gerrit-Change-Number: 39472
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
pespin has submitted this change. ( https://gerrit.osmocom.org/c/upf-benchmark/+/39473?usp=email )
Change subject: gtplab-sysmo2025/tunmap: Small fixes in configure scripts
......................................................................
gtplab-sysmo2025/tunmap: Small fixes in configure scripts
Fixes from copy-paste from older gtpal-sysmo2017/tunmap setup, which
doesn't appply to new TREx setuo anymore.
Those CPF IP addresses are actually not used.
Change-Id: I8b8ce66c8642ebaa59bdf9e238cdba7e40071726
---
M testsuites/gtplab-sysmo2025/tunmap/cpf/configure.sh
M testsuites/gtplab-sysmo2025/tunmap/upf/configure.sh
2 files changed, 5 insertions(+), 14 deletions(-)
Approvals:
laforge: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/testsuites/gtplab-sysmo2025/tunmap/cpf/configure.sh b/testsuites/gtplab-sysmo2025/tunmap/cpf/configure.sh
index 7f3c8af..2b24a65 100755
--- a/testsuites/gtplab-sysmo2025/tunmap/cpf/configure.sh
+++ b/testsuites/gtplab-sysmo2025/tunmap/cpf/configure.sh
@@ -1,10 +1 @@
#!/bin/bash -xe
-
-# Interface towards UPF:
-IFACE_UPF="enp2s0f0np0"
-NUM_ENB=50
-
-# Set up IP addresses:
-for i in $(seq "0" "$((NUM_ENB - 1))"); do
- sudo ip addr add "$(printf "172.16.31.1%02u/24" $i)" dev $IFACE_UPF || true;
-done
diff --git a/testsuites/gtplab-sysmo2025/tunmap/upf/configure.sh b/testsuites/gtplab-sysmo2025/tunmap/upf/configure.sh
index 58792fe..825e59f 100755
--- a/testsuites/gtplab-sysmo2025/tunmap/upf/configure.sh
+++ b/testsuites/gtplab-sysmo2025/tunmap/upf/configure.sh
@@ -1,8 +1,8 @@
#!/bin/bash -xe
# Interface towards UPF:
-IFACE_RAN="enp2s0f0np0"
-IFACE_CN="enp2s0f1np1"
+IFACE_RAN="enp2s0f1np1"
+IFACE_CN="enp2s0f0np0"
# Disable ethernet flow control:
sudo ethtool -A $IFACE_RAN autoneg off rx off tx off
@@ -25,8 +25,8 @@
sudo sysctl -w net.core.netdev_budget=600
# Set up UPF address:
-sudo ip addr add 172.16.31.2/24 dev $IFACE_RAN || true;
-sudo ip addr add 172.16.32.1/24 dev $IFACE_CN || true;
+sudo ip addr add 172.16.32.1/24 dev $IFACE_RAN || true;
+sudo ip addr add 172.16.31.2/24 dev $IFACE_CN || true;
# TRex doesn't answer ARPs, so we need to set up the CN-side peer:
-sudo ip neigh add 172.16.31.200 lladdr ec:0d:9a:8a:27:53 nud permanent dev $IFACE_RAN || true;
+sudo ip neigh add 172.16.31.200 lladdr ec:0d:9a:8a:27:53 nud permanent dev $IFACE_CN || true;
--
To view, visit https://gerrit.osmocom.org/c/upf-benchmark/+/39473?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: upf-benchmark
Gerrit-Branch: master
Gerrit-Change-Id: I8b8ce66c8642ebaa59bdf9e238cdba7e40071726
Gerrit-Change-Number: 39473
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>