November 2025 - gerrit-log - lists.osmocom.org

[XS] Change in docker-playground[master]: osmo-stp: add support for tcap-loadsharing
by fixeria 10 Nov '25

10 Nov '25

Attention is currently required from: lynxis lazus. fixeria has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/docker-playground/+/41390?usp=email ) Change subject: osmo-stp: add support for tcap-loadsharing ...................................................................... Patch Set 1: (1 comment) Commit Message: https://gerrit.osmocom.org/c/docker-playground/+/41390/comment/d098940d_581… : PS1, Line 10: Only build it when running debian. Is this really the case? I see you're also adding a dependency to `dnf install ...`. -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/41390?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ib58f07d28a38109b4dd053479ddbdb1937eda64e Gerrit-Change-Number: 41390 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 10 Nov 2025 11:37:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in osmo-dev[master]: gen_makefile: python: run build in venv too
by fixeria 10 Nov '25

10 Nov '25

Attention is currently required from: osmith, pespin. fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-dev/+/41391?usp=email ) Change subject: gen_makefile: python: run build in venv too ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-dev/+/41391/comment/d9912b35_86b2d10e?usp… : PS1, Line 14: older setuptools versions Older than what version? Maybe add a minimum version to `python-venv-requirements.txt`? -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/41391?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: Idbd826d65267c05dcf2d82f7429d53a52686d737 Gerrit-Change-Number: 41391 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 10 Nov 2025 11:34:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[M] Change in libosmo-sigtran[master]: Add test for tcap decoding/encoding
by fixeria 10 Nov '25

10 Nov '25

Attention is currently required from: lynxis lazus, pespin. fixeria has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41308?usp=email ) Change subject: Add test for tcap decoding/encoding ...................................................................... Patch Set 6: (1 comment) Patchset: PS6: > I don't see the point in having this here (polluting osmo-stp with more unnecessary tcap code) which […] Agreeing with Pau. Unit tests for TCAP codec should be in libosmo-asn1-tcap.git. Otherwise, one can submit a breaking change without even noticing because we don't seem to have any tests there... -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41308?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I8a0dbfaaa7182a5a72b279908be09e3adab254a2 Gerrit-Change-Number: 41308 Gerrit-PatchSet: 6 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: daniel <dwillmann(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 10 Nov 2025 11:30:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in libosmo-sigtran[master]: build-system: depend on libosmo-asn1-tcap
by fixeria 10 Nov '25

10 Nov '25

Attention is currently required from: lynxis lazus. fixeria has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41307?usp=email ) Change subject: build-system: depend on libosmo-asn1-tcap ...................................................................... Patch Set 4: (1 comment) File libosmo-sigtran.pc.in: https://gerrit.osmocom.org/c/libosmo-sigtran/+/41307/comment/56c6c044_bd6f0… : PS4, Line 11: Requires.private: libosmo-netif libosmocore @LIBSCTP_PC@ > Please put it at the start following the dependency order. BTW, why adding `@LIBSCTP_PC@` and not `libosmo-asn1-tcap` here? -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41307?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Ib485f786217166635377f931ab894e43a0680634 Gerrit-Change-Number: 41307 Gerrit-PatchSet: 4 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: daniel <dwillmann(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 10 Nov 2025 11:28:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in libosmo-sigtran[master]: build-system: depend on libosmo-asn1-tcap
by pespin 10 Nov '25

10 Nov '25

Attention is currently required from: fixeria, lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41307?usp=email ) Change subject: build-system: depend on libosmo-asn1-tcap ...................................................................... Patch Set 4: (1 comment) File libosmo-sigtran.pc.in: https://gerrit.osmocom.org/c/libosmo-sigtran/+/41307/comment/d6552f7c_70e3a… : PS4, Line 11: Requires.private: libosmo-netif libosmocore @LIBSCTP_PC@ Please put it at the start following the dependency order. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41307?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Ib485f786217166635377f931ab894e43a0680634 Gerrit-Change-Number: 41307 Gerrit-PatchSet: 4 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: daniel <dwillmann(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 10 Nov 2025 10:55:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[M] Change in libosmo-sigtran[master]: Add test for tcap decoding/encoding
by pespin 10 Nov '25

10 Nov '25

Attention is currently required from: fixeria, lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41308?usp=email ) Change subject: Add test for tcap decoding/encoding ...................................................................... Patch Set 6: Code-Review-2 (1 comment) Patchset: PS6: I don't see the point in having this here (polluting osmo-stp with more unnecessary tcap code) which can perfectly be put in the tcap library, where the related code is developed/maintained. So I keep my -2 for this patch. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41308?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I8a0dbfaaa7182a5a72b279908be09e3adab254a2 Gerrit-Change-Number: 41308 Gerrit-PatchSet: 6 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: daniel <dwillmann(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 10 Nov 2025 10:55:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-dev[master]: gen_makefile: python: run build in venv too
by osmith 10 Nov '25

10 Nov '25

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-dev/+/41391?usp=email ) Change subject: gen_makefile: python: run build in venv too ...................................................................... gen_makefile: python: run build in venv too The format of the license field in pyproject.toml was changed from a "table" to a a string with an SPDX license expression. The pyosmocom sources have been adjusted to use the new format to appease a warning ("By 2026-Feb-18, you need to update your project and remove deprecated calls or your builds will no longer be supported."). However now the build fails with older setuptools versions. Run the build of python packages in the venv too, to ensure we have a recent setuptools version. Related: pyosmocom I8416234ea02f337fabd075cc345af964c1b71adf Related: osmo-ci Ia8ef3a0301aeaad4691c197ed780e86b497def4a Related: https://packaging.python.org/en/latest/guides/writing-pyproject-toml/#licen… Change-Id: Idbd826d65267c05dcf2d82f7429d53a52686d737 --- M gen_makefile.py M python-venv-requirements.txt 2 files changed, 6 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-dev refs/changes/91/41391/1 diff --git a/gen_makefile.py b/gen_makefile.py index cfc681b..4ee5290 100755 --- a/gen_makefile.py +++ b/gen_makefile.py @@ -435,7 +435,7 @@ .make.{proj}.build: .make.{proj}.configure .make.{proj}.clone $({proj}_files) @echo "\\n\\n\\n===== $@\\n" rm -f {build_proj}/*.whl - python3 \ + {gen_venv_activate()} && python3 \ -m build \ --no-isolation \ {src_proj} \ diff --git a/python-venv-requirements.txt b/python-venv-requirements.txt index 2f5ab59..e81e215 100644 --- a/python-venv-requirements.txt +++ b/python-venv-requirements.txt @@ -21,3 +21,8 @@ redis==5.0.0 tzlocal==4.3 xmltodict==0.14.2 + +setuptools +build +poetry +wheel -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/41391?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: Idbd826d65267c05dcf2d82f7429d53a52686d737 Gerrit-Change-Number: 41391 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

1 0

[S] Change in osmo-ci[master]: jobs: libosmo-sigtran: add support for TCAP loadsharing
by osmith 10 Nov '25

10 Nov '25

Attention is currently required from: lynxis lazus. osmith has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ci/+/41388?usp=email ) Change subject: jobs: libosmo-sigtran: add support for TCAP loadsharing ...................................................................... Patch Set 2: Code-Review+2 (1 comment) Patchset: PS1: > @osmith@sysmocom.de hey this is untested, please take a closer look. […] I have verified that it works as expected with gerrit and master-builds: * https://jenkins.osmocom.org/jenkins/job/master-libosmo-sigtran/747/ * https://jenkins.osmocom.org/jenkins/job/gerrit-libosmo-sigtran-build/660/ -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/41388?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I47c193d8f5ce695fdc6c368eee94d21c5a4b2c6e Gerrit-Change-Number: 41388 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 10 Nov 2025 08:40:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>

1 0

[XS] Change in docker-playground[master]: osmo-stp: add support for tcap-loadsharing
by osmith 10 Nov '25

10 Nov '25

Attention is currently required from: lynxis lazus. osmith has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/docker-playground/+/41390?usp=email ) Change subject: osmo-stp: add support for tcap-loadsharing ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/41390?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ib58f07d28a38109b4dd053479ddbdb1937eda64e Gerrit-Change-Number: 41390 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 10 Nov 2025 08:29:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in ...pyosmocom[master]: Fix lint errors: don't use star imports
by osmith 10 Nov '25

10 Nov '25

Attention is currently required from: laforge. osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/python/pyosmocom/+/41384?usp=email ) Change subject: Fix lint errors: don't use star imports ...................................................................... Patch Set 2: (1 comment) File tests/test_construct.py: https://gerrit.osmocom.org/c/python/pyosmocom/+/41384/comment/f87bcc9a_d4fd… : PS2, Line 8: DnsAdapter, > we're not using this parenthesized list with one item per line anywhere else. […] So far we don't have a "from X import" line in pyosmocom that exceeds the 120 character limit which we use for lines, so we need to introduce a new way of writing this if we don't use star imports anymore. The alternatives would be: ``` from osmocom.construct import Asn1DerInteger, Bytes, DnsAdapter, GreedyInteger, GreedyBytes, PlmnAdapter, \ StripHeaderAdapter, StripTrailerAdapter, Ucs2Adapter, filter_dict ``` Or: ``` from osmocom.construct import (Asn1DerInteger, Bytes, DnsAdapter, GreedyInteger, GreedyBytes, PlmnAdapter, StripHeaderAdapter, StripTrailerAdapter, Ucs2Adapter, filter_dict) ``` Which IMHO are both less readable and less diff-friendly. The one item per line syntax is also what one gets with `ruff format` if the line exceeds the character limit, which is based on PEP 8 and the rules from "black" that are widely used (Django, pytest, [many more...](https://github.com/psf/black?tab=readme-ov-file#used-by)). With that being said, if you think another syntax is better then I can update the patch to use that. What do you think? -- To view, visit https://gerrit.osmocom.org/c/python/pyosmocom/+/41384?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: python/pyosmocom Gerrit-Branch: master Gerrit-Change-Id: I0ca76a40d47f72635682de9303ff73e9b2197266 Gerrit-Change-Number: 41384 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 10 Nov 2025 08:19:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org>

1 0

2025

2024

2023

2022

gerrit-log November 2025