November 2025 - gerrit-log - lists.osmocom.org

[XS] Change in libosmocore[master]: tests/osmo_io_test (io_uring): test_segmentation: Fix infinite loop i...
by pespin 06 Nov '25

06 Nov '25

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/41297?usp=email ) Change subject: tests/osmo_io_test (io_uring): test_segmentation: Fix infinite loop in read_cb rc=0 ...................................................................... tests/osmo_io_test (io_uring): test_segmentation: Fix infinite loop in read_cb rc=0 Under linux 6.17.6-arch1-1 & liburing 2.12-1, once we finish reading from the pipe (rc=0) because the write peer was closed and data has been consumed, we end up in some sort of infinite loop in the uring due to re-adding a sqe in iofd_uring_handle_recv()->iofd_uring_submit_recv() path and immediatelly consuming a cqe from the uring, without going through the poll() loop. The user is expected to close the fd once rc=0 is received anyway, which was not being done in this test. Doing so successfully unregisters the iofd and fixes the infinite loop. Fixes: 086ee51de416ae5276b4b185c055831e16c0ef85 Change-Id: I47b5fff04c601cd08ab2d46b88336247b2193808 --- M tests/osmo_io/osmo_io_test.c 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve fixeria: Looks good to me, approved Jenkins Builder: Verified jolly: Looks good to me, but someone else must approve diff --git a/tests/osmo_io/osmo_io_test.c b/tests/osmo_io/osmo_io_test.c index 693c428..0812ea8 100644 --- a/tests/osmo_io/osmo_io_test.c +++ b/tests/osmo_io/osmo_io_test.c @@ -280,6 +280,7 @@ } else { OSMO_ASSERT(rc == 0); file_eof_read = true; + osmo_iofd_close(iofd); } talloc_free(msg); } -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41297?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I47b5fff04c601cd08ab2d46b88336247b2193808 Gerrit-Change-Number: 41297 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in libosmocore[master]: io_uring: Avoid extra reads if iofd becomes unregistered by user
by pespin 06 Nov '25

06 Nov '25

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/41300?usp=email ) Change subject: io_uring: Avoid extra reads if iofd becomes unregistered by user ...................................................................... io_uring: Avoid extra reads if iofd becomes unregistered by user The user callback (read_cb, segmentation_cb, etc.) may decide to unregister the iofd instead of closing it. In this scenario, we should avoid calling the callback further until the iofd is registered again. Change-Id: I231d5a16768b730f67089090c244bcc10dc69c3a --- M src/core/osmo_io_uring.c M tests/osmo_io/osmo_io_test.c 2 files changed, 3 insertions(+), 3 deletions(-) Approvals: Jenkins Builder: Verified jolly: Looks good to me, but someone else must approve pespin: Looks good to me, approved laforge: Looks good to me, but someone else must approve fixeria: Looks good to me, but someone else must approve diff --git a/src/core/osmo_io_uring.c b/src/core/osmo_io_uring.c index 01b8063..e4a87ad 100644 --- a/src/core/osmo_io_uring.c +++ b/src/core/osmo_io_uring.c @@ -359,7 +359,7 @@ } /* Check for every iteration, because iofd might get unregistered/closed during receive function. */ - if (iofd->u.uring.read.enabled && !IOFD_FLAG_ISSET(iofd, IOFD_FLAG_CLOSED)) + if (IOFD_FLAG_ISSET(iofd, IOFD_FLAG_FD_REGISTERED) && iofd->u.uring.read.enabled) iofd_handle_recv(iofd, msg, chunk, msghdr); else msgb_free(msg); @@ -372,7 +372,7 @@ msghdr->msg[idx] = NULL; } - if (iofd->u.uring.read.enabled && !IOFD_FLAG_ISSET(iofd, IOFD_FLAG_CLOSED)) + if (IOFD_FLAG_ISSET(iofd, IOFD_FLAG_FD_REGISTERED) && iofd->u.uring.read.enabled) iofd_uring_submit_recv(iofd, msghdr->action); iofd_msghdr_free(msghdr); diff --git a/tests/osmo_io/osmo_io_test.c b/tests/osmo_io/osmo_io_test.c index 0812ea8..06491a7 100644 --- a/tests/osmo_io/osmo_io_test.c +++ b/tests/osmo_io/osmo_io_test.c @@ -280,7 +280,7 @@ } else { OSMO_ASSERT(rc == 0); file_eof_read = true; - osmo_iofd_close(iofd); + osmo_iofd_unregister(iofd); } talloc_free(msg); } -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41300?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I231d5a16768b730f67089090c244bcc10dc69c3a Gerrit-Change-Number: 41300 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in libosmocore[master]: io_uring: Avoid extra reads if iofd becomes unregistered by user
by pespin 06 Nov '25

06 Nov '25

pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmocore/+/41300?usp=email ) Change subject: io_uring: Avoid extra reads if iofd becomes unregistered by user ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41300?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I231d5a16768b730f67089090c244bcc10dc69c3a Gerrit-Change-Number: 41300 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 06 Nov 2025 13:01:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in osmocom-bb[master]: Add ER-GSM band support to all relevant applications
by jolly 06 Nov '25

06 Nov '25

Attention is currently required from: fixeria, jolly, laforge. Hello Jenkins Builder, fixeria, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmocom-bb/+/41359?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Code-Review+1 by laforge, Verified+1 by Jenkins Builder Change subject: Add ER-GSM band support to all relevant applications ...................................................................... Add ER-GSM band support to all relevant applications ER-GSM band expands the R-GSM band by additional 15 channels. Mobile application allows to turn on or off the support of these 15 channels. ER-GSM band is supported by default. Change-Id: I71baa3317df685cf6479b6e20e6ae078911aa24f --- M doc/examples/mobile/mobile.cfg M doc/examples/mobile/multi_ms.cfg M src/host/layer23/include/osmocom/bb/common/settings.h M src/host/layer23/include/osmocom/bb/common/support.h M src/host/layer23/src/common/settings.c M src/host/layer23/src/common/support.c M src/host/layer23/src/common/sysinfo.c M src/host/layer23/src/misc/bcch_scan.c M src/host/layer23/src/misc/cell_log.c M src/host/layer23/src/mobile/gsm48_rr.c M src/host/layer23/src/mobile/vty_interface.c M src/shared/libosmocore/src/gsm/gsm_utils.c M src/target/firmware/apps/rssi/main.c 13 files changed, 41 insertions(+), 24 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/59/41359/3 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/41359?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I71baa3317df685cf6479b6e20e6ae078911aa24f Gerrit-Change-Number: 41359 Gerrit-PatchSet: 3 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[S] Change in libosmocore[master]: tests/testsuite.at: properly skip disabled tests
by fixeria 06 Nov '25

06 Nov '25

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/41364?usp=email ) Change subject: tests/testsuite.at: properly skip disabled tests ...................................................................... tests/testsuite.at: properly skip disabled tests We should not be running these tests unconditionally because the respective binaries are built conditionally and may be missing. Change-Id: I7e9a0c84e510964e5d577e371d41f2023ab20840 --- M tests/testsuite.at 1 file changed, 15 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/64/41364/1 diff --git a/tests/testsuite.at b/tests/testsuite.at index 1c9a97e..bd251f0 100644 --- a/tests/testsuite.at +++ b/tests/testsuite.at @@ -17,6 +17,7 @@ AT_SETUP([ctrl]) AT_KEYWORDS([ctrl]) +AT_SKIP_IF([test ! -e $abs_top_builddir/tests/ctrl/ctrl_test]) cat $abs_srcdir/ctrl/ctrl_test.ok > expout AT_CHECK([$abs_top_builddir/tests/ctrl/ctrl_test], [0], [expout], [ignore]) AT_CLEANUP @@ -237,6 +238,7 @@ AT_SETUP([fr]) AT_KEYWORDS([fr]) +AT_SKIP_IF([test ! -e $abs_top_builddir/tests/fr/fr_test]) cat $abs_srcdir/fr/fr_test.ok > expout cat $abs_srcdir/fr/fr_test.err > experr AT_CHECK([$abs_top_builddir/tests/fr/fr_test], [0], [expout], [experr]) @@ -257,6 +259,7 @@ AT_SETUP([vty]) AT_KEYWORDS([vty]) +AT_SKIP_IF([test ! -e $abs_top_builddir/tests/vty/vty_test]) cat $abs_srcdir/vty/vty_test.ok > expout cat $abs_srcdir/vty/vty_test.err > experr AT_CHECK([$abs_top_builddir/tests/vty/vty_test $abs_srcdir/vty], [0], [expout], [experr]) @@ -264,18 +267,21 @@ AT_SETUP([gprs-bssgp]) AT_KEYWORDS([gprs-bssgp]) +AT_SKIP_IF([test ! -e $abs_top_builddir/tests/gb/gprs_bssgp_test]) cat $abs_srcdir/gb/gprs_bssgp_test.ok > expout AT_CHECK([$abs_top_builddir/tests/gb/gprs_bssgp_test], [0], [expout], [ignore]) AT_CLEANUP AT_SETUP([gprs-bssgp-rim]) AT_KEYWORDS([gprs-bssgp-rim]) +AT_SKIP_IF([test ! -e $abs_top_builddir/tests/gb/gprs_bssgp_rim_test]) cat $abs_srcdir/gb/gprs_bssgp_rim_test.ok > expout AT_CHECK([$abs_top_builddir/tests/gb/gprs_bssgp_rim_test], [0], [expout], [ignore]) AT_CLEANUP AT_SETUP([gprs-ns]) AT_KEYWORDS([gprs-ns]) +AT_SKIP_IF([test ! -e $abs_top_builddir/tests/gb/gprs_ns_test]) cat $abs_srcdir/gb/gprs_ns_test.ok > expout cat $abs_srcdir/gb/gprs_ns_test.err > experr AT_CHECK([$abs_top_builddir/tests/gb/gprs_ns_test], [0], [expout], [experr]) @@ -283,6 +289,7 @@ AT_SETUP([gprs-ns2]) AT_KEYWORDS([gprs-ns2]) +AT_SKIP_IF([test ! -e $abs_top_builddir/tests/gb/gprs_ns2_test]) cat $abs_srcdir/gb/gprs_ns2_test.ok > expout cat $abs_srcdir/gb/gprs_ns2_test.err > experr AT_CHECK([$abs_top_builddir/tests/gb/gprs_ns2_test], [0], [expout], [experr]) @@ -290,6 +297,7 @@ AT_SETUP([utils]) AT_KEYWORDS([utils]) +AT_SKIP_IF([test ! -e $abs_top_builddir/tests/utils/utils_test]) cat $abs_srcdir/utils/utils_test.ok > expout cat $abs_srcdir/utils/utils_test.err > experr AT_CHECK([$abs_top_builddir/tests/utils/utils_test], [0], [expout], [experr]) @@ -297,6 +305,7 @@ AT_SETUP([stats]) AT_KEYWORDS([stats]) +AT_SKIP_IF([test ! -e $abs_top_builddir/tests/stats/stats_test]) cat $abs_srcdir/stats/stats_test.ok > expout cat $abs_srcdir/stats/stats_test.err > experr AT_CHECK([$abs_top_builddir/tests/stats/stats_test], [0], [expout], [experr]) @@ -310,6 +319,7 @@ AT_SETUP([bssgp-fc]) AT_KEYWORDS([bssgp-fc]) +AT_SKIP_IF([test ! -e $abs_top_builddir/tests/gb/bssgp_fc_tests]) cat $abs_srcdir/gb/bssgp_fc_tests.ok > expout cat $abs_srcdir/gb/bssgp_fc_tests.err > experr AT_CHECK([$abs_top_srcdir/tests/gb/bssgp_fc_tests.sh $abs_top_builddir/tests/gb], [0], [expout], [experr]) @@ -342,6 +352,7 @@ AT_SETUP([gsup]) AT_KEYWORDS([gsup]) +AT_SKIP_IF([test ! -e $abs_top_builddir/tests/gsup/gsup_test]) cat $abs_srcdir/gsup/gsup_test.ok > expout cat $abs_srcdir/gsup/gsup_test.err > experr AT_CHECK([$abs_top_builddir/tests/gsup/gsup_test], [0], [expout], [experr]) @@ -349,6 +360,7 @@ AT_SETUP([fsm]) AT_KEYWORDS([fsm]) +AT_SKIP_IF([test ! -e $abs_top_builddir/tests/fsm/fsm_test]) cat $abs_srcdir/fsm/fsm_test.ok > expout cat $abs_srcdir/fsm/fsm_test.err > experr AT_CHECK([$abs_top_builddir/tests/fsm/fsm_test], [0], [expout], [experr]) @@ -356,6 +368,7 @@ AT_SETUP([fsm_dealloc]) AT_KEYWORDS([fsm_dealloc]) +AT_SKIP_IF([test ! -e $abs_top_builddir/tests/fsm/fsm_dealloc_test]) cat $abs_srcdir/fsm/fsm_dealloc_test.err > experr AT_CHECK([$abs_top_builddir/tests/fsm/fsm_dealloc_test], [0], [ignore], [experr]) AT_CLEANUP @@ -383,7 +396,7 @@ AT_SETUP([socket_sctp]) AT_KEYWORDS([socket_sctp]) -AT_SKIP_IF([! test -e $abs_top_builddir/tests/socket/socket_sctp_test]) +AT_SKIP_IF([test ! -e $abs_top_builddir/tests/socket/socket_sctp_test]) cat $abs_srcdir/socket/socket_sctp_test.ok > expout cat $abs_srcdir/socket/socket_sctp_test.err > experr AT_CHECK([$abs_top_builddir/tests/socket/socket_sctp_test], [0], [expout], [experr]) @@ -454,6 +467,7 @@ AT_SETUP([exec]) AT_KEYWORDS([exec]) +AT_SKIP_IF([test ! -e $abs_top_builddir/tests/exec/exec_test]) cat $abs_srcdir/exec/exec_test.ok > expout cat $abs_srcdir/exec/exec_test.err > experr AT_CHECK([$abs_top_builddir/tests/exec/exec_test], [0], [expout], [experr]) -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41364?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I7e9a0c84e510964e5d577e371d41f2023ab20840 Gerrit-Change-Number: 41364 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[XS] Change in libosmocore[master]: tests/testsuite.at: use AT_SKIP_IF for sim_test
by fixeria 06 Nov '25

06 Nov '25

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/41363?usp=email ) Change subject: tests/testsuite.at: use AT_SKIP_IF for sim_test ...................................................................... tests/testsuite.at: use AT_SKIP_IF for sim_test Whether to run the given test or not can be determined by presence of the respective `*_test` binary, since we build them conditionally in the `Makefile.am`. Get rid of more complicated logic by using AT_SKIP_IF and checking presence of `tests/sim/sim_test`. Change-Id: Ic90b3a39936888eda6c9d443420c4faa131ac78f --- M .gitignore M configure.ac M tests/Makefile.am D tests/atlocal.in M tests/testsuite.at 5 files changed, 2 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/63/41363/1 diff --git a/.gitignore b/.gitignore index b14f67c..907743f 100644 --- a/.gitignore +++ b/.gitignore @@ -61,7 +61,6 @@ #gnu autotest tests/package.m4 tests/atconfig -tests/atlocal tests/osmo-test tests/package.m4 tests/testsuite diff --git a/configure.ac b/configure.ac index 120500f..6a5f0c0 100644 --- a/configure.ac +++ b/configure.ac @@ -650,7 +650,6 @@ src/pseudotalloc/Makefile tapset/Makefile tests/Makefile - tests/atlocal tests/osmo-config-merge/Makefile utils/Makefile utils/osmo-stat-dummy/Makefile diff --git a/tests/Makefile.am b/tests/Makefile.am index 929cade..f98d67c 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -534,7 +534,7 @@ endif endif -DISTCLEANFILES = atconfig atlocal conv/gsm0503_test_vectors.c +DISTCLEANFILES = atconfig conv/gsm0503_test_vectors.c BUILT_SOURCES = conv/gsm0503_test_vectors.c noinst_HEADERS = conv/conv.h diff --git a/tests/atlocal.in b/tests/atlocal.in deleted file mode 100644 index cd27532..0000000 --- a/tests/atlocal.in +++ /dev/null @@ -1 +0,0 @@ -enable_sim_test='@ENABLE_PCSC@' diff --git a/tests/testsuite.at b/tests/testsuite.at index 82758b7..1c9a97e 100644 --- a/tests/testsuite.at +++ b/tests/testsuite.at @@ -317,7 +317,7 @@ AT_SETUP([sim]) AT_KEYWORDS([sim]) -AT_CHECK([test "x$enable_sim_test" = xyes || exit 77]) +AT_SKIP_IF([test ! -e $abs_top_builddir/tests/sim/sim_test]) cat $abs_srcdir/sim/sim_test.ok > expout AT_CHECK([$abs_top_builddir/tests/sim/sim_test], [0], [expout], [ignore]) AT_CLEANUP -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41363?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ic90b3a39936888eda6c9d443420c4faa131ac78f Gerrit-Change-Number: 41363 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[XS] Change in libosmocore[master]: tests/testsuite.at: fix invalid if-endif syntax
by lynxis lazus 06 Nov '25

06 Nov '25

Attention is currently required from: fixeria. lynxis lazus has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/libosmocore/+/41362?usp=email ) Change subject: tests/testsuite.at: fix invalid if-endif syntax ...................................................................... Patch Set 1: -Code-Review (1 comment) Patchset: PS1: what ever. autotools should burn in hell. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41362?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I81e044dc0bda4674c0d0dc46118d46816712a76c Gerrit-Change-Number: 41362 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 06 Nov 2025 12:35:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmocore[master]: tests/testsuite.at: fix invalid if-endif syntax
by fixeria 06 Nov '25

06 Nov '25

Attention is currently required from: lynxis lazus. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/libosmocore/+/41362?usp=email ) Change subject: tests/testsuite.at: fix invalid if-endif syntax ...................................................................... Patch Set 1: (1 comment) File tests/testsuite.at: https://gerrit.osmocom.org/c/libosmocore/+/41362/comment/b00c708a_7b0cd54e?… : PS1, Line 86: AT_SKIP_IF([test ! -e $abs_top_builddir/tests/msgfile/msgfile_test]) > Checking the file might be problematic, because old artifact might be still present. […] Well, we already do this kind of checking in several projects. Checking variables is more complicated because they do not magically materialize here. You would need to define `tests/atlocal.in` like libosmocore.git does for the `sim_test`. It's always a good practice to do `make distclean` before building the project with different configure flags, so I don't see a big problem here... -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41362?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I81e044dc0bda4674c0d0dc46118d46816712a76c Gerrit-Change-Number: 41362 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Thu, 06 Nov 2025 12:31:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>

1 0

[XS] Change in libosmocore[master]: tests/testsuite.at: fix invalid if-endif syntax
by lynxis lazus 06 Nov '25

06 Nov '25

Attention is currently required from: fixeria. lynxis lazus has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/libosmocore/+/41362?usp=email ) Change subject: tests/testsuite.at: fix invalid if-endif syntax ...................................................................... Patch Set 1: (1 comment) File tests/testsuite.at: https://gerrit.osmocom.org/c/libosmocore/+/41362/comment/89a4794f_8c41eafd?… : PS1, Line 86: AT_SKIP_IF([test ! -e $abs_top_builddir/tests/msgfile/msgfile_test]) Checking the file might be problematic, because old artifact might be still present. I'm trying to check if we can use the same test as used in configure.ac to check if it enabled by using the define/variable -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41362?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I81e044dc0bda4674c0d0dc46118d46816712a76c Gerrit-Change-Number: 41362 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 06 Nov 2025 12:27:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in libosmocore[master]: tests/testsuite.at: fix invalid if-endif syntax
by lynxis lazus 06 Nov '25

06 Nov '25

Attention is currently required from: fixeria. lynxis lazus has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/libosmocore/+/41362?usp=email ) The change is no longer submittable: Code-Review is unsatisfied now. Change subject: tests/testsuite.at: fix invalid if-endif syntax ...................................................................... Patch Set 1: Code-Review-2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41362?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I81e044dc0bda4674c0d0dc46118d46816712a76c Gerrit-Change-Number: 41362 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 06 Nov 2025 12:26:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

2025

2024

2023

2022

gerrit-log November 2025