November 2025 - gerrit-log - lists.osmocom.org

[S] Change in ...osmo-epdg[master]: aaa_diameter_swx: Avoid answering RTR with Success if already deregis...
by osmith 06 Nov '25

06 Nov '25

Attention is currently required from: laforge, pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/41303?usp=email ) Change subject: aaa_diameter_swx: Avoid answering RTR with Success if already deregistering ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/41303?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: I0ed13e9503ec380ce4331c662ca3eb966ccbda92 Gerrit-Change-Number: 41303 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 06 Nov 2025 13:42:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in ...osmo-epdg[master]: aaa_ue_fsm: Avoid immediate stop of fsm during 2nd SWx RTR
by osmith 06 Nov '25

06 Nov '25

Attention is currently required from: laforge, pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/41302?usp=email ) Change subject: aaa_ue_fsm: Avoid immediate stop of fsm during 2nd SWx RTR ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/41302?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: I6d564ec1583692a6b6f3f273268b400570b246ff Gerrit-Change-Number: 41302 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 06 Nov 2025 13:42:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in libosmocore[osmith/1.11.3]: Bump version: 1.11.2.2-f5e98-dirty → 1.11.3
by osmith 06 Nov '25

06 Nov '25

Attention is currently required from: fixeria, pespin. osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/libosmocore/+/41356?usp=email ) Change subject: Bump version: 1.11.2.2-f5e98-dirty → 1.11.3 ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: As discussed, added @pespin@sysmocom.de's patch https://gerrit.osmocom.org/c/libosmocore/+/41365/1. This is a backport of a patch merged to master today, so let's wait another day with the patch release until ttcn3 testsuites ran against it and there is no fallout from it. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41356?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: osmith/1.11.3 Gerrit-Change-Id: I8bec5917f1de938775401a1030cdd29b5700873e Gerrit-Change-Number: 41356 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 06 Nov 2025 13:39:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in libosmocore[osmith/1.11.3]: io_uring: Avoid extra reads if iofd becomes unregistered by user
by osmith 06 Nov '25

06 Nov '25

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/41365?usp=email ) Change subject: io_uring: Avoid extra reads if iofd becomes unregistered by user ...................................................................... io_uring: Avoid extra reads if iofd becomes unregistered by user The user callback (read_cb, segmentation_cb, etc.) may decide to unregister the iofd instead of closing it. In this scenario, we should avoid calling the callback further until the iofd is registered again. This is a backport of master branch commit 32efc324ce0b30280effef4860bb15588ecb1010. Change-Id: I514412ecfbb82d32cb3d9c2272795ebac42f55e9 --- M src/core/osmo_io_uring.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/65/41365/1 diff --git a/src/core/osmo_io_uring.c b/src/core/osmo_io_uring.c index b8b240f..cfd72fd 100644 --- a/src/core/osmo_io_uring.c +++ b/src/core/osmo_io_uring.c @@ -189,10 +189,10 @@ if (rc > 0) msgb_put(msg, rc); - if (!IOFD_FLAG_ISSET(iofd, IOFD_FLAG_CLOSED)) + if (IOFD_FLAG_ISSET(iofd, IOFD_FLAG_FD_REGISTERED)) iofd_handle_recv(iofd, msg, rc, msghdr); - if (iofd->u.uring.read_enabled && !IOFD_FLAG_ISSET(iofd, IOFD_FLAG_CLOSED)) + if (IOFD_FLAG_ISSET(iofd, IOFD_FLAG_FD_REGISTERED) && iofd->u.uring.read_enabled) iofd_uring_submit_recv(iofd, msghdr->action); else iofd->u.uring.read_msghdr = NULL; -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41365?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmocore Gerrit-Branch: osmith/1.11.3 Gerrit-Change-Id: I514412ecfbb82d32cb3d9c2272795ebac42f55e9 Gerrit-Change-Number: 41365 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in libosmocore[osmith/1.11.3]: Bump version: 1.11.2.2-f5e98-dirty → 1.11.3
by osmith 06 Nov '25

06 Nov '25

Attention is currently required from: fixeria, osmith, pespin. Hello Jenkins Builder, fixeria, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/41356?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by fixeria, Verified+1 by Jenkins Builder Change subject: Bump version: 1.11.2.2-f5e98-dirty → 1.11.3 ...................................................................... Bump version: 1.11.2.2-f5e98-dirty → 1.11.3 Change-Id: I8bec5917f1de938775401a1030cdd29b5700873e --- M debian/changelog M src/core/Makefile.am M src/gsm/Makefile.am 3 files changed, 12 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/56/41356/2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41356?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmocore Gerrit-Branch: osmith/1.11.3 Gerrit-Change-Id: I8bec5917f1de938775401a1030cdd29b5700873e Gerrit-Change-Number: 41356 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in ...osmo-epdg[master]: aaa_diameter_swx: Avoid answering RTR with Success if already deregis...
by pespin 06 Nov '25

06 Nov '25

Attention is currently required from: laforge, osmith, pespin. Hello Jenkins Builder, laforge, osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/41303?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by laforge, Code-Review+1 by osmith, Verified+1 by Jenkins Builder Change subject: aaa_diameter_swx: Avoid answering RTR with Success if already deregistering ...................................................................... aaa_diameter_swx: Avoid answering RTR with Success if already deregistering When receiving an SWx RTR on our osmo-epdg (epdg+AAA), we initiate the deregistration against peer nodes on other interfaces and answer with SWx RTA. If a subsequent RTR for the subscriber arrives on the interface while the deregistration is in progress, we'd answer with RTA Result-Code 2001 SUCCESS. Let's instead answer already as if we didn't know about the subscriber, since it will end up being freed in a short span of time and nothing can be done about it. Related: OS#6796 Change-Id: I0ed13e9503ec380ce4331c662ca3eb966ccbda92 --- M src/aaa_diameter_swx_cb.erl M src/aaa_ue_fsm.erl 2 files changed, 21 insertions(+), 9 deletions(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-epdg refs/changes/03/41303/2 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/41303?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: I0ed13e9503ec380ce4331c662ca3eb966ccbda92 Gerrit-Change-Number: 41303 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in ...osmo-epdg[master]: aaa_ue_fsm: Avoid immediate stop of fsm during 2nd SWx RTR
by pespin 06 Nov '25

06 Nov '25

Attention is currently required from: laforge, pespin. Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/41302?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by laforge, Verified-1 by Jenkins Builder Change subject: aaa_ue_fsm: Avoid immediate stop of fsm during 2nd SWx RTR ...................................................................... aaa_ue_fsm: Avoid immediate stop of fsm during 2nd SWx RTR During Network Initiated De-Registration by HSS Procedure, if a 2nd RTR arrives for an aaa_ue_fsm which is already in state_dereg_net_initiated_*, let it continue with the ordered tear down consisting of informing peer nodes. Change-Id: I6d564ec1583692a6b6f3f273268b400570b246ff --- M src/aaa_ue_fsm.erl 1 file changed, 34 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-epdg refs/changes/02/41302/2 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/41302?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: I6d564ec1583692a6b6f3f273268b400570b246ff Gerrit-Change-Number: 41302 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in libosmo-sigtran[osmith/2.1.3]: Bump version: 2.1.2.2-a679-dirty → 2.1.3
by pespin 06 Nov '25

06 Nov '25

Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41354?usp=email ) Change subject: Bump version: 2.1.2.2-a679-dirty → 2.1.3 ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > These changes have been merged today, just a few hours ago. […] Agree with fixeria. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41354?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: osmith/2.1.3 Gerrit-Change-Id: I0a079e17bf2f5fa286c78a6a67cc675215a3d58e Gerrit-Change-Number: 41354 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 06 Nov 2025 13:30:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[XS] Change in ...osmo-epdg[master]: cosmetic: Fix typo in code documentation
by pespin 06 Nov '25

06 Nov '25

pespin has submitted this change. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/41301?usp=email ) Change subject: cosmetic: Fix typo in code documentation ...................................................................... cosmetic: Fix typo in code documentation Change-Id: I41da3bcc3b5f982901baa8162d7fd55f35d70485 --- M src/aaa_ue_fsm.erl 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: fixeria: Looks good to me, but someone else must approve Jenkins Builder: Verified osmith: Looks good to me, approved diff --git a/src/aaa_ue_fsm.erl b/src/aaa_ue_fsm.erl index c73f636..64f6cb3 100644 --- a/src/aaa_ue_fsm.erl +++ b/src/aaa_ue_fsm.erl @@ -454,7 +454,7 @@ {next_state, state_dereg_net_initiated_wait_swm_asa, Data}. %%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%% -%% state_dereg_net_initiated_wait_s6b_asa: +%% state_dereg_net_initiated_wait_swm_asa: %% HSS asked us to do deregistration towards the user. %% S6b (PGW) was already torn down. Now transmit SWm ASR towards ePDG and wait for ASA back. %%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%% -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/41301?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: I41da3bcc3b5f982901baa8162d7fd55f35d70485 Gerrit-Change-Number: 41301 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in libosmocore[master]: tests/osmo_io_test: test_segmentation: Use osmo_iofd_close() API
by pespin 06 Nov '25

06 Nov '25

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/41299?usp=email ) Change subject: tests/osmo_io_test: test_segmentation: Use osmo_iofd_close() API ...................................................................... tests/osmo_io_test: test_segmentation: Use osmo_iofd_close() API This is saner than doing osmo_iofd_unregister() + manual close(). Change-Id: Id910bfb4e0965700e2d378a513a9bf889b929d44 --- M tests/osmo_io/osmo_io_test.c 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved jolly: Looks good to me, but someone else must approve fixeria: Looks good to me, but someone else must approve diff --git a/tests/osmo_io/osmo_io_test.c b/tests/osmo_io/osmo_io_test.c index d3e22aa..693c428 100644 --- a/tests/osmo_io/osmo_io_test.c +++ b/tests/osmo_io/osmo_io_test.c @@ -323,8 +323,7 @@ fflush(stdout); OSMO_ASSERT(file_bytes_write_compl == 12); - osmo_iofd_unregister(iofd); - close(fd[1]); + osmo_iofd_close(iofd); /* Now, re-configure iofd to only read from the pipe. * Reduce the read buffer size, to verify correct segmentation operation: */ -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41299?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Id910bfb4e0965700e2d378a513a9bf889b929d44 Gerrit-Change-Number: 41299 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

2025

2024

2023

2022

gerrit-log November 2025