November 2025 - gerrit-log - lists.osmocom.org

[XS] Change in osmo-ci[master]: OBS: configure Osmocom pyhss fork
by osmith 06 Nov '25

06 Nov '25

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/41371?usp=email ) Change subject: OBS: configure Osmocom pyhss fork ...................................................................... OBS: configure Osmocom pyhss fork Add the Osmocom fork of PyHSS to scripts/obs/lib/config.py, so the Osmocom_OBS_* jobs build source packages for it and push them to our OBS where binary packages get built. We need to use a fork for now, as the official repository can't run outside of a git tree yet and doesn't have debian packaging. These changes are being upstreamed, the goal is that we don't need to use our fork in the long run. Related: SYS#6819 Change-Id: I8fc7ef9dc242248770711da2893492fae8a84522 --- M scripts/obs/lib/config.py 1 file changed, 7 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/71/41371/1 diff --git a/scripts/obs/lib/config.py b/scripts/obs/lib/config.py index 0a8d60d..b1384fd 100644 --- a/scripts/obs/lib/config.py +++ b/scripts/obs/lib/config.py @@ -100,6 +100,7 @@ projects_other = [ "neocon", "open5gs", + "pyhss", ] git_url_default = "https://gerrit.osmocom.org" # /project gets appended @@ -111,24 +112,28 @@ "rtl-sdr": "https://gitea.osmocom.org/sdr/rtl-sdr", "strongswan-epdg": "https://gitea.osmocom.org/ims-volte-vowifi/strongswan-epdg", "libosmo-sccp-legacy": "https://gitea.osmocom.org/osmocom/libosmo-sccp-legacy", + "pyhss": "https://gitea.osmocom.org/osmocom/pyhss", } git_branch_default = "master" git_branch_other = { "open5gs": "main", + "pyhss": "osmocom/master", } def tag_pattern(prefix: str = '', a: str = r'\d+', b: str = r'\.\d+', - c: str = r'\.\d+') -> str: - return rf'^{prefix}{a}{b}{c}$' + c: str = r'\.\d+', + suffix: str = '') -> str: + return rf'^{prefix}{a}{b}{c}{suffix}$' git_latest_tag_pattern_default = tag_pattern() git_latest_tag_pattern_other = { "gapk": tag_pattern('v', c=r'(\.\d+)?'), "open5gs": tag_pattern('v'), "osmo-fl2k": tag_pattern('v'), + "pyhss": tag_pattern(suffix='-osmocom\\d+'), "rtl-sdr": tag_pattern('v'), "strongswan-epdg": tag_pattern('osmo-epdg-', c=r'\.[0-9a-z]+'), "wireshark": tag_pattern('v', c=r'\.[0-9a-z]+'), -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/41371?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I8fc7ef9dc242248770711da2893492fae8a84522 Gerrit-Change-Number: 41371 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

1 0

[XS] Change in osmo-ci[master]: OBS: set default distro to debian 13
by osmith 06 Nov '25

06 Nov '25

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/41369?usp=email ) Change subject: OBS: set default distro to debian 13 ...................................................................... OBS: set default distro to debian 13 Change the distribution that is used to build the source packages to debian 13 so we are on the latest one again. Change-Id: I7c1dcca90e46645a497fd547ce1243b414c53201 --- M scripts/obs/lib/config.py 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/69/41369/1 diff --git a/scripts/obs/lib/config.py b/scripts/obs/lib/config.py index 8282d9e..0a8d60d 100644 --- a/scripts/obs/lib/config.py +++ b/scripts/obs/lib/config.py @@ -134,7 +134,7 @@ "wireshark": tag_pattern('v', c=r'\.[0-9a-z]+'), } -docker_distro_default = "debian:12" +docker_distro_default = "debian:13" docker_distro_other = [ "almalinux:*", # instead of centos (SYS#5818) "centos:7", # SYS#6760 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/41369?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I7c1dcca90e46645a497fd547ce1243b414c53201 Gerrit-Change-Number: 41369 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

1 0

[S] Change in osmo-ci[master]: OBS: build_srcpkg: install rebar3 without apt
by osmith 06 Nov '25

06 Nov '25

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/41368?usp=email ) Change subject: OBS: build_srcpkg: install rebar3 without apt ...................................................................... OBS: build_srcpkg: install rebar3 without apt Avoid pulling in 600 MB of GUI dependencies. Related: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1083096 Change-Id: I9a51df03ac173118c35d501bd21c6d023a436844 --- M scripts/obs/data/build_srcpkg.Dockerfile 1 file changed, 10 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/68/41368/1 diff --git a/scripts/obs/data/build_srcpkg.Dockerfile b/scripts/obs/data/build_srcpkg.Dockerfile index 4822450..8b57931 100644 --- a/scripts/obs/data/build_srcpkg.Dockerfile +++ b/scripts/obs/data/build_srcpkg.Dockerfile @@ -11,6 +11,7 @@ debhelper \ dh-python \ dpkg-dev \ + erlang-nox \ fakeroot \ git \ git-review \ @@ -22,11 +23,19 @@ python3-packaging \ python3-setuptools \ quilt \ - rebar3 \ sed \ sphinx-common \ + wget \ && \ apt-get clean +# Install rebar3 as described in https://rebar3.org/docs/getting-started/ +# instead of using the Debian package, as the latter pulls in ~600 MB of GUI +# dependencies that we don't need: +# https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1083096 +RUN wget https://github.com/erlang/rebar3/releases/download/3.24.0/rebar3 -O /usr/bin/rebar3 && \ + chmod +x /usr/bin/rebar3 && \ + rebar3 --version + RUN useradd --uid=${UID} -m user USER user -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/41368?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I9a51df03ac173118c35d501bd21c6d023a436844 Gerrit-Change-Number: 41368 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

1 0

[XS] Change in osmo-ci[master]: OBS: gerrit_binpkgs: print verbose output
by osmith 06 Nov '25

06 Nov '25

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/41367?usp=email ) Change subject: OBS: gerrit_binpkgs: print verbose output ...................................................................... OBS: gerrit_binpkgs: print verbose output Print all shell commands and their output executed by build_srcpkgs.py and build_binpkgs.py, instead of only printing them on error. This is useful to see the output of the scripts downloading dependencies when building sourcepackages. Change-Id: Ie1dbde603351b1d26b66f3834b645b1f1f5bbfc8 --- M scripts/obs/gerrit_binpkgs.sh 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/67/41367/1 diff --git a/scripts/obs/gerrit_binpkgs.sh b/scripts/obs/gerrit_binpkgs.sh index 34f90c4..c077065 100755 --- a/scripts/obs/gerrit_binpkgs.sh +++ b/scripts/obs/gerrit_binpkgs.sh @@ -50,12 +50,14 @@ --git-skip-fetch \ --git-skip-checkout \ --no-meta \ + --verbose \ "$PROJECT_NAME" || error_exit echo ":: Building the binary packages" "$SCRIPTS_OBS_DIR"/build_binpkg.py \ --docker "$DISTRO" \ --feed "$FEED" \ + --verbose \ "$PROJECT_NAME" || error_exit echo ":: Find binary packages in: $SCRIPTS_OBS_DIR/_temp/binpkgs" -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/41367?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ie1dbde603351b1d26b66f3834b645b1f1f5bbfc8 Gerrit-Change-Number: 41367 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

1 0

[M] Change in osmo-ci[master]: OBS: lib/srcpkg: format with ruff
by osmith 06 Nov '25

06 Nov '25

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/41366?usp=email ) Change subject: OBS: lib/srcpkg: format with ruff ...................................................................... OBS: lib/srcpkg: format with ruff Change-Id: I2cfb8fc5bd78449e62526758ddb9263cf3d8ced1 --- M .ruff.toml M scripts/obs/lib/srcpkg.py 2 files changed, 59 insertions(+), 38 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/66/41366/1 diff --git a/.ruff.toml b/.ruff.toml index a75a783..c0b9b9d 100644 --- a/.ruff.toml +++ b/.ruff.toml @@ -16,7 +16,6 @@ "scripts/obs/lib/metapkg.py", "scripts/obs/lib/osc.py", "scripts/obs/lib/rpm_spec.py", - "scripts/obs/lib/srcpkg.py", "scripts/obs/update_obs_project.py", "scripts/osmo-depcheck/buildstack.py", "scripts/osmo-depcheck/config.py", diff --git a/scripts/obs/lib/srcpkg.py b/scripts/obs/lib/srcpkg.py index 7b93937..78e49d1 100644 --- a/scripts/obs/lib/srcpkg.py +++ b/scripts/obs/lib/srcpkg.py @@ -10,7 +10,7 @@ def checkout_for_feed(project): - """ checkout a commit, either latest tag or master or 20YY branch """ + """checkout a commit, either latest tag or master or 20YY branch""" feed = lib.args.feed branch = lib.args.git_branch if branch: @@ -24,7 +24,7 @@ def get_git_version(project): - """ :returns: the string from git-version-gen, e.g. '1.7.0.10-76bdb' """ + """:returns: the string from git-version-gen, e.g. '1.7.0.10-76bdb'""" repo_path = lib.git.get_repo_path(project) # Run git-version-gen if it is in the repository @@ -41,18 +41,29 @@ pattern = lib.git.get_latest_tag_pattern(project) pattern = pattern.replace("^", "", 1) pattern = pattern.replace("$", "", -1) - result = lib.run_cmd(["git", "describe", - "--abbrev=4", - "--tags", - f"--match={pattern}", - "HEAD"], cwd=repo_path, check=False) + result = lib.run_cmd( + [ + "git", + "describe", + "--abbrev=4", + "--tags", + f"--match={pattern}", + "HEAD", + ], + cwd=repo_path, + check=False, + ) if result.returncode == 128: print(f"{project}: has no git tags") - commit = lib.run_cmd(["git", "rev-parse", "HEAD"], - cwd=repo_path).output[0:4] - count = lib.run_cmd(["git", "rev-list", "--count", "HEAD"], - cwd=repo_path).output.rstrip() + commit = lib.run_cmd( + ["git", "rev-parse", "HEAD"], + cwd=repo_path, + ).output[0:4] + count = lib.run_cmd( + ["git", "rev-list", "--count", "HEAD"], + cwd=repo_path, + ).output.rstrip() try: print(f"{project}: getting version from debian/changelog") version = lib.debian.get_last_version_from_changelog(project) @@ -105,14 +116,14 @@ def get_epoch(project): - """ The osmo-gbproxy used to have the same package version as osmo-sgsn - until 2021 where it was split into its own git repository. From then - on, osmo-gbproxy has a 0.*.* package version, which is smaller than - the previous 1.*.* from osmo-sgsn. We had to set the epoch to 1 for - osmo-gbproxy so package managers know these 0.*.* versions are higher - than the previous 1.*.* ones that are still found in e.g. debian 11. - The epoch is set in debian/changelog, retrieve it from there. - :returns: the epoch number if set, e.g. "1" or an empty string """ + """The osmo-gbproxy used to have the same package version as osmo-sgsn + until 2021 where it was split into its own git repository. From then on, + osmo-gbproxy has a 0.*.* package version, which is smaller than the + previous 1.*.* from osmo-sgsn. We had to set the epoch to 1 for + osmo-gbproxy so package managers know these 0.*.* versions are higher than + the previous 1.*.* ones that are still found in e.g. debian 11. The epoch + is set in debian/changelog, retrieve it from there. + :returns: the epoch number if set, e.g. "1" or an empty string""" version_epoch = lib.debian.get_last_version_from_changelog(project) if ":" in version_epoch: @@ -122,15 +133,17 @@ def prepare_project_open5gs(): - """ Download the subproject sources here, so the package can be built in - OBS without Internet access. """ - lib.run_cmd(["meson", "subprojects", "download"], - cwd=lib.git.get_repo_path("open5gs")) + """Download the subproject sources here, so the package can be built in + OBS without Internet access.""" + lib.run_cmd( + ["meson", "subprojects", "download"], + cwd=lib.git.get_repo_path("open5gs"), + ) def run_generate_build_dep(project): - """ Run contrib/generate_build_dep.sh if it exists in the given project, to - to download sources for dependencies (see e.g. osmo_dia2gsup.git). """ + """Run contrib/generate_build_dep.sh if it exists in the given project, to + to download sources for dependencies (see e.g. osmo_dia2gsup.git).""" repo_path = lib.git.get_repo_path(project) script_path = "contrib/generate_build_dep.sh" @@ -147,10 +160,10 @@ def write_commit_txt(project): - """ Write the current git commit to commit_$commit.txt file, so it gets - uploaded to OBS along with the rest of the source package. This allows - figuring out if the source package is still up-to-date or not for the - master feed. """ + """Write the current git commit to commit_$commit.txt file, so it gets + uploaded to OBS along with the rest of the source package. This allows + figuring out if the source package is still up-to-date or not for the + master feed.""" output_path = lib.get_output_path(project) commit = lib.git.get_head(project) @@ -160,16 +173,26 @@ def set_asciidoc_style_without_draft_watermark(project): repo_path = lib.git.get_repo_path(project) - doc_makefiles = lib.run_cmd(["grep", "-r", "-l", "include $(OSMO_GSM_MANUALS_DIR)/build/Makefile.asciidoc.inc"], cwd=repo_path, check=False) + doc_makefiles = lib.run_cmd( + ["grep", "-r", "-l", "include $(OSMO_GSM_MANUALS_DIR)/build/Makefile.asciidoc.inc"], + cwd=repo_path, + check=False, + ) doc_makefiles = doc_makefiles.output.rstrip().split("\n") for doc_makefile in doc_makefiles: if doc_makefile == "": continue print(f"{project}: setting asciidoc style to remove draft watermark in {doc_makefile}") - lib.run_cmd(["sed", "-i", - '/\\/build\\/Makefile\\.asciidoc\\.inc/s/^/ ASCIIDOCSTYLE = $(BUILDDIR)\\/custom-dblatex.sty\\n/', - doc_makefile], cwd=repo_path) + lib.run_cmd( + [ + "sed", + "-i", + "/\\/build\\/Makefile\\.asciidoc\\.inc/s/^/ ASCIIDOCSTYLE = $(BUILDDIR)\\/custom-dblatex.sty\\n/", + doc_makefile, + ], + cwd=repo_path, + ) def build(project, gerrit_id=0): @@ -237,15 +260,14 @@ def requires_osmo_gsm_manuals_dev(project): - """ Check if an already built source package has osmo-gsm-manuals-dev in - Build-Depends of the .dsc file """ + """Check if an already built source package has osmo-gsm-manuals-dev in + Build-Depends of the .dsc file""" path_dsc = glob.glob(f"{lib.get_output_path(project)}/*.dsc") assert len(path_dsc) == 1, f"failed to get dsc path for {project}" with open(path_dsc[0], "r") as handle: for line in handle.readlines(): - if line.startswith("Build-Depends:") \ - and "osmo-gsm-manuals-dev" in line: + if line.startswith("Build-Depends:") and "osmo-gsm-manuals-dev" in line: return True return False -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/41366?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I2cfb8fc5bd78449e62526758ddb9263cf3d8ced1 Gerrit-Change-Number: 41366 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

1 0

[S] Change in ...osmo-epdg[master]: aaa_ue_fsm: Avoid immediate stop of fsm during 2nd SWx RTR
by pespin 06 Nov '25

06 Nov '25

pespin has submitted this change. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/41302?usp=email ) Change subject: aaa_ue_fsm: Avoid immediate stop of fsm during 2nd SWx RTR ...................................................................... aaa_ue_fsm: Avoid immediate stop of fsm during 2nd SWx RTR During Network Initiated De-Registration by HSS Procedure, if a 2nd RTR arrives for an aaa_ue_fsm which is already in state_dereg_net_initiated_*, let it continue with the ordered tear down consisting of informing peer nodes. Change-Id: I6d564ec1583692a6b6f3f273268b400570b246ff --- M src/aaa_ue_fsm.erl 1 file changed, 34 insertions(+), 4 deletions(-) Approvals: osmith: Looks good to me, but someone else must approve pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/aaa_ue_fsm.erl b/src/aaa_ue_fsm.erl index 64f6cb3..97ad67f 100644 --- a/src/aaa_ue_fsm.erl +++ b/src/aaa_ue_fsm.erl @@ -256,7 +256,12 @@ case aaa_diameter_swx:server_assignment_request(Data#ue_fsm_data.imsi, 1, Apn, []) of ok -> {next_state, state_wait_swx_saa, Data, [{reply,From,ok}]}; {error, Err} -> {keep_state, Data, [{reply,From,{error, Err}}]} - end. + end; + +state_new({call, From}, rx_swx_rtr, Data) -> + lager:info("ue_fsm state_new event=rx_swx_rtr ~p~n", [Data]), + %% No need to inform anybody else, tear down FSM: + {stop_and_reply, normal, [{reply,From,ok}], Data}. %%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%% %% state_wait_swx_maa: @@ -268,7 +273,12 @@ state_wait_swx_maa({call, From}, {rx_swx_maa, Result}, Data) -> lager:info("ue_fsm state_wait_swx_maa event=rx_swx_maa, ~p~n", [Data]), aaa_diameter_swm:tx_dea_auth_response(Data#ue_fsm_data.imsi, Result), - {next_state, state_new, Data, [{reply,From,ok}]}. + {next_state, state_new, Data, [{reply,From,ok}]}; + +state_wait_swx_maa({call, From}, rx_swx_rtr, Data) -> + lager:info("ue_fsm state_wait_swx_maa event=rx_swx_rtr ~p~n", [Data]), + %% No need to inform anybody else, tear down FSM: + {stop_and_reply, normal, [{reply,From,ok}], Data}. %%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%% %% state_wait_swx_saa: @@ -286,7 +296,12 @@ {ok, _SAType, ResInfo} -> aaa_diameter_swm:tx_dea_auth_compl_response(Data#ue_fsm_data.imsi, {ok, ResInfo}), {next_state, state_authenticated, Data, [{reply,From,ok}]} - end. + end; + +state_wait_swx_saa({call, From}, rx_swx_rtr, Data) -> + lager:info("ue_fsm state_wait_swx_saa event=rx_swx_rtr ~p~n", [Data]), + %% No need to inform anybody else, tear down FSM: + {stop_and_reply, normal, [{reply,From,ok}], Data}. %%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%% %% state_authenticated: @@ -431,7 +446,12 @@ Data1 = Data#ue_fsm_data{pgw_sess_active = false, s6b_resp_pid = undefined}, {next_state, state_new, Data1, [{reply,From,ok}]} end - end. + end; + +state_authenticated_wait_swx_saa({call, From}, rx_swx_rtr, Data) -> + lager:info("ue_fsm state_authenticated_wait_swx_saa event=rx_swx_rtr ~p~n", [Data]), + %% We are already tearing down in an ordered manner, accept and do nothing. + {keep_state, Data, [{reply,From,ok}]}. %%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%% %% state_dereg_net_initiated_wait_s6b_asa: @@ -446,6 +466,11 @@ state_dereg_net_initiated_wait_s6b_asa({call, From}, {rx_s6b_asa, _Result}, Data) -> {next_state, state_dereg_net_initiated_wait_swm_asa, Data, [{reply,From,ok}]}; +state_dereg_net_initiated_wait_s6b_asa({call, From}, rx_swx_rtr, Data) -> + lager:info("ue_fsm state_dereg_net_initiated_wait_s6b_asa event=rx_swx_rtr ~p~n", [Data]), + %% We are already tearing down in an ordered manner, accept and do nothing. + {keep_state, Data, [{reply,From,ok}]}; + state_dereg_net_initiated_wait_s6b_asa({call, From}, Ev, Data) -> lager:notice("ue_fsm state_dereg_net_initiated_wait_s6b_asa: Unexpected call event ~p, ~p~n", [Ev, Data]), {keep_state, Data, [{reply,From,ok}]}; @@ -466,6 +491,11 @@ state_dereg_net_initiated_wait_swm_asa({call, From}, rx_swm_asa, Data) -> {stop_and_reply, normal, [{reply,From,ok}], Data}; +state_dereg_net_initiated_wait_swm_asa({call, From}, rx_swx_rtr, Data) -> + lager:info("ue_fsm state_dereg_net_initiated_wait_swm_asa event=rx_swx_rtr ~p~n", [Data]), + %% We are already tearing down in an ordered manner, accept and do nothing. + {keep_state, Data, [{reply,From,ok}]}; + state_dereg_net_initiated_wait_swm_asa({call, From}, Ev, Data) -> lager:notice("ue_fsm state_dereg_net_initiated_wait_swm_asa: Unexpected call event ~p, ~p~n", [Ev, Data]), {keep_state, Data, [{reply,From,ok}]}; -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/41302?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: I6d564ec1583692a6b6f3f273268b400570b246ff Gerrit-Change-Number: 41302 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in ...osmo-epdg[master]: aaa_diameter_swx: Avoid answering RTR with Success if already deregis...
by pespin 06 Nov '25

06 Nov '25

pespin has submitted this change. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/41303?usp=email ) Change subject: aaa_diameter_swx: Avoid answering RTR with Success if already deregistering ...................................................................... aaa_diameter_swx: Avoid answering RTR with Success if already deregistering When receiving an SWx RTR on our osmo-epdg (epdg+AAA), we initiate the deregistration against peer nodes on other interfaces and answer with SWx RTA. If a subsequent RTR for the subscriber arrives on the interface while the deregistration is in progress, we'd answer with RTA Result-Code 2001 SUCCESS. Let's instead answer already as if we didn't know about the subscriber, since it will end up being freed in a short span of time and nothing can be done about it. Related: OS#6796 Change-Id: I0ed13e9503ec380ce4331c662ca3eb966ccbda92 --- M src/aaa_diameter_swx_cb.erl M src/aaa_ue_fsm.erl 2 files changed, 21 insertions(+), 9 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved osmith: Looks good to me, but someone else must approve diff --git a/src/aaa_diameter_swx_cb.erl b/src/aaa_diameter_swx_cb.erl index 3ae11f0..f8ebd08 100644 --- a/src/aaa_diameter_swx_cb.erl +++ b/src/aaa_diameter_swx_cb.erl @@ -149,14 +149,26 @@ case DeregReason of #'Deregistration-Reason'{'Reason-Code' = ?'REASON-CODE_PERMANENT_TERMINATION'} -> case aaa_ue_fsm:ev_rx_swx_rtr(Pid) of - {error, _} -> aaa_ue_fsm:stop(Pid); - _ -> ok + {error, dereg_in_progress} -> + Res = [], + %% TS 29.229 6.2.2.1 DIAMETER_ERROR_USER_UNKNOWN + ERes = #'Experimental-Result'{'Vendor-Id' = ?VENDOR_ID_3GPP, + 'Experimental-Result-Code' = 5001}; + {error, _} -> + aaa_ue_fsm:stop(Pid), % unknown error, make sure we tear down. + Res = [], + %% TS 29.229 6.2.2.1 DIAMETER_ERROR_USER_UNKNOWN + ERes = #'Experimental-Result'{'Vendor-Id' = ?VENDOR_ID_3GPP, + 'Experimental-Result-Code' = 5001}; + _ -> + Res = 2001, %% Success + ERes = [] end; _ -> - aaa_ue_fsm:stop(Pid) - end, - Res = 2001, %% Success - ERes = []; + aaa_ue_fsm:stop(Pid), + Res = 2001, %% Success + ERes = [] + end; undefined -> Res = [], %% TS 29.229 6.2.2.1 DIAMETER_ERROR_USER_UNKNOWN diff --git a/src/aaa_ue_fsm.erl b/src/aaa_ue_fsm.erl index 97ad67f..91830d9 100644 --- a/src/aaa_ue_fsm.erl +++ b/src/aaa_ue_fsm.erl @@ -451,7 +451,7 @@ state_authenticated_wait_swx_saa({call, From}, rx_swx_rtr, Data) -> lager:info("ue_fsm state_authenticated_wait_swx_saa event=rx_swx_rtr ~p~n", [Data]), %% We are already tearing down in an ordered manner, accept and do nothing. - {keep_state, Data, [{reply,From,ok}]}. + {keep_state, Data, [{reply,From,{error,dereg_in_progress}}]}. %%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%% %% state_dereg_net_initiated_wait_s6b_asa: @@ -469,7 +469,7 @@ state_dereg_net_initiated_wait_s6b_asa({call, From}, rx_swx_rtr, Data) -> lager:info("ue_fsm state_dereg_net_initiated_wait_s6b_asa event=rx_swx_rtr ~p~n", [Data]), %% We are already tearing down in an ordered manner, accept and do nothing. - {keep_state, Data, [{reply,From,ok}]}; + {keep_state, Data, [{reply,From,{error,dereg_in_progress}}]}; state_dereg_net_initiated_wait_s6b_asa({call, From}, Ev, Data) -> lager:notice("ue_fsm state_dereg_net_initiated_wait_s6b_asa: Unexpected call event ~p, ~p~n", [Ev, Data]), @@ -494,7 +494,7 @@ state_dereg_net_initiated_wait_swm_asa({call, From}, rx_swx_rtr, Data) -> lager:info("ue_fsm state_dereg_net_initiated_wait_swm_asa event=rx_swx_rtr ~p~n", [Data]), %% We are already tearing down in an ordered manner, accept and do nothing. - {keep_state, Data, [{reply,From,ok}]}; + {keep_state, Data, [{reply,From,{error,dereg_in_progress}}]}; state_dereg_net_initiated_wait_swm_asa({call, From}, Ev, Data) -> lager:notice("ue_fsm state_dereg_net_initiated_wait_swm_asa: Unexpected call event ~p, ~p~n", [Ev, Data]), -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/41303?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: I0ed13e9503ec380ce4331c662ca3eb966ccbda92 Gerrit-Change-Number: 41303 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in ...osmo-epdg[master]: aaa_diameter_swx: Avoid answering RTR with Success if already deregis...
by pespin 06 Nov '25

06 Nov '25

Attention is currently required from: laforge. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/41303?usp=email ) Change subject: aaa_diameter_swx: Avoid answering RTR with Success if already deregistering ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/41303?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: I0ed13e9503ec380ce4331c662ca3eb966ccbda92 Gerrit-Change-Number: 41303 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Thu, 06 Nov 2025 13:53:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in ...osmo-epdg[master]: aaa_ue_fsm: Avoid immediate stop of fsm during 2nd SWx RTR
by pespin 06 Nov '25

06 Nov '25

Attention is currently required from: laforge. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/41302?usp=email ) Change subject: aaa_ue_fsm: Avoid immediate stop of fsm during 2nd SWx RTR ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/41302?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: I6d564ec1583692a6b6f3f273268b400570b246ff Gerrit-Change-Number: 41302 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Thu, 06 Nov 2025 13:52:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmo-sigtran[osmith/2.1.3]: ipa: fix a minor memleak when receiving invalid IPA CCM messages
by pespin 06 Nov '25

06 Nov '25

Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41352?usp=email ) The change is no longer submittable: Code-Review is unsatisfied now. Change subject: ipa: fix a minor memleak when receiving invalid IPA CCM messages ...................................................................... Patch Set 1: Code-Review-2 (1 comment) Patchset: PS1: Blockign for now due to concerns of this maybe causing major problems in the older code, which doesn't have other fixes/rewrites like dfccd989dbffe418d9ab7b4d3087345636da762d. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41352?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: osmith/2.1.3 Gerrit-Change-Id: I1b828c16350d10398810e60acbb35663f215c63f Gerrit-Change-Number: 41352 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 06 Nov 2025 13:51:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

2025

2024

2023

2022

gerrit-log November 2025