November 2025 - gerrit-log - lists.osmocom.org

[M] Change in osmocom-bb[master]: Indicate ER-GSM band support in MS classmark 3
by Jenkins Builder 06 Nov '25

06 Nov '25

Attention is currently required from: fixeria, jolly. Jenkins Builder has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmocom-bb/+/41360?usp=email ) Change subject: Indicate ER-GSM band support in MS classmark 3 ...................................................................... Patch Set 2: (1 comment) File src/host/layer23/src/mobile/gsm48_rr.c: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmocom-bb/+/41360/comment/1427e33e_5ce9e729?u… : PS2, Line 1508: if (set->er_gsm) { braces {} are not necessary for any arm of this statement -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/41360?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ica13814eddb5293c7d7a2a21dd6a7a437cd1d351 Gerrit-Change-Number: 41360 Gerrit-PatchSet: 2 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 06 Nov 2025 11:18:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[M] Change in osmocom-bb[master]: Add ER-GSM band support to all relevant applications
by jolly 06 Nov '25

06 Nov '25

Attention is currently required from: fixeria, jolly. Hello Jenkins Builder, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmocom-bb/+/41359?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: Add ER-GSM band support to all relevant applications ...................................................................... Add ER-GSM band support to all relevant applications ER-GSM band expands the R-GSM band by additional 15 channels. Mobile application allows to turn on or off the support of these 15 channels. ER-GSM band is supported by default. Change-Id: I71baa3317df685cf6479b6e20e6ae078911aa24f --- M src/host/layer23/include/osmocom/bb/common/settings.h M src/host/layer23/include/osmocom/bb/common/support.h M src/host/layer23/src/common/settings.c M src/host/layer23/src/common/support.c M src/host/layer23/src/common/sysinfo.c M src/host/layer23/src/misc/bcch_scan.c M src/host/layer23/src/misc/cell_log.c M src/host/layer23/src/mobile/gsm48_rr.c M src/host/layer23/src/mobile/vty_interface.c M src/shared/libosmocore/src/gsm/gsm_utils.c M src/target/firmware/apps/rssi/main.c 11 files changed, 38 insertions(+), 24 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/59/41359/2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/41359?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I71baa3317df685cf6479b6e20e6ae078911aa24f Gerrit-Change-Number: 41359 Gerrit-PatchSet: 2 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[S] Change in osmo-bsc[master]: Add ER-GSM band support
by jolly 06 Nov '25

06 Nov '25

jolly has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/41361?usp=email ) Change subject: Add ER-GSM band support ...................................................................... Add ER-GSM band support ER-GSM band expands the R-GSM band by additional 15 channels, starting from channel 940. Change-Id: I0a9a2f64d9db65967699453c26ae282c4ddf4558 --- M src/osmo-bsc/bts.c M src/osmo-bsc/system_information.c 2 files changed, 11 insertions(+), 11 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/61/41361/1 diff --git a/src/osmo-bsc/bts.c b/src/osmo-bsc/bts.c index 2cc6153..77721fb 100644 --- a/src/osmo-bsc/bts.c +++ b/src/osmo-bsc/bts.c @@ -525,9 +525,9 @@ } break; case GSM_BAND_900: - if ((bts->c0->arfcn > 124 && bts->c0->arfcn < 955) || + if ((bts->c0->arfcn > 124 && bts->c0->arfcn < 940) || bts->c0->arfcn > 1023) { - LOGP(DNM, LOGL_ERROR, "(bts=%u) GSM900 channel (%u) must be between 0-124, 955-1023.\n", + LOGP(DNM, LOGL_ERROR, "(bts=%u) GSM900 channel (%u) must be between 0-124, 940-1023.\n", bts->nr, bts->c0->arfcn); return -EINVAL; } diff --git a/src/osmo-bsc/system_information.c b/src/osmo-bsc/system_information.c index b438a49..41c7b81 100644 --- a/src/osmo-bsc/system_information.c +++ b/src/osmo-bsc/system_information.c @@ -545,8 +545,8 @@ /* Check presence of E-GSM ARFCN 0 */ if (pgsm && bitvec_get_bit_pos(bv, 0) == ONE) pgsm = false; - /* Check presence of R-GSM / E-GSM ARFCNs 955..1023 */ - for (i = 955; pgsm && i <= 1023; i++) { + /* Check presence of R-GSM / E-GSM ARFCNs 940..1023 */ + for (i = 940; pgsm && i <= 1023; i++) { if (bitvec_get_bit_pos(bv, i) == ONE) pgsm = false; } @@ -577,22 +577,22 @@ /* count the arfcns we want to carry */ arfcns += 1; - /* 955..1023 < 0..885 */ + /* 940..1023 < 0..885 */ if (min < 0) min = i; - if (i >= 955 && min < 955) + if (i >= 940 && min < 940) min = i; - if (i >= 955 && min >= 955 && i < min) + if (i >= 940 && min >= 940 && i < min) min = i; - if (i < 955 && min < 955 && i < min) + if (i < 940 && min < 940 && i < min) min = i; if (max < 0) max = i; - if (i < 955 && max >= 955) + if (i < 940 && max >= 940) max = i; - if (i >= 955 && max >= 955 && i > max) + if (i >= 940 && max >= 940 && i > max) max = i; - if (i < 955 && max < 955 && i > max) + if (i < 940 && max < 940 && i > max) max = i; } -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/41361?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I0a9a2f64d9db65967699453c26ae282c4ddf4558 Gerrit-Change-Number: 41361 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu>

1 0

[M] Change in osmocom-bb[master]: Add ER-GSM band support to all relevant applications
by Jenkins Builder 06 Nov '25

06 Nov '25

Jenkins Builder has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmocom-bb/+/41359?usp=email ) Change subject: Add ER-GSM band support to all relevant applications ...................................................................... Patch Set 1: (5 comments) File src/host/layer23/src/common/settings.c: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmocom-bb/+/41359/comment/9e504b0c_1a0b247d?u… : PS1, Line 187: for(i = 940; i <= 954; i++) space required before the open parenthesis '(' File src/target/firmware/apps/rssi/main.c: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmocom-bb/+/41359/comment/6bc36477_69543215?u… : PS1, Line 82: { 940, 124, 885, 128, 8732, 9182 }, /* P,E,(E)R GSM */ code indent should use tabs where possible Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmocom-bb/+/41359/comment/121462b5_86ff8d43?u… : PS1, Line 82: { 940, 124, 885, 128, 8732, 9182 }, /* P,E,(E)R GSM */ please, no spaces at the start of a line Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmocom-bb/+/41359/comment/9fb1599e_1e9761af?u… : PS1, Line 83: { 512, 885, 251, 940, 17102, 18052 }, /* DCS 1800 */ code indent should use tabs where possible Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmocom-bb/+/41359/comment/89aa4c5b_daee1dd4?u… : PS1, Line 83: { 512, 885, 251, 940, 17102, 18052 }, /* DCS 1800 */ please, no spaces at the start of a line -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/41359?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I71baa3317df685cf6479b6e20e6ae078911aa24f Gerrit-Change-Number: 41359 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Thu, 06 Nov 2025 10:52:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[M] Change in osmocom-bb[master]: Indicate ER-GSM band support in MS classmark 3
by Jenkins Builder 06 Nov '25

06 Nov '25

Jenkins Builder has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmocom-bb/+/41360?usp=email ) Change subject: Indicate ER-GSM band support in MS classmark 3 ...................................................................... Patch Set 1: (1 comment) File src/host/layer23/src/mobile/gsm48_rr.c: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmocom-bb/+/41360/comment/5c73b6f4_1d6ad8a4?u… : PS1, Line 1508: if (set->er_gsm) { braces {} are not necessary for any arm of this statement -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/41360?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ica13814eddb5293c7d7a2a21dd6a7a437cd1d351 Gerrit-Change-Number: 41360 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Thu, 06 Nov 2025 10:51:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[M] Change in osmocom-bb[master]: Indicate ER-GSM band support in MS classmark 3
by jolly 06 Nov '25

06 Nov '25

jolly has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/41360?usp=email ) Change subject: Indicate ER-GSM band support in MS classmark 3 ...................................................................... Indicate ER-GSM band support in MS classmark 3 Change-Id: Ica13814eddb5293c7d7a2a21dd6a7a437cd1d351 --- M src/host/layer23/src/mobile/gsm48_rr.c 1 file changed, 80 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/60/41360/1 diff --git a/src/host/layer23/src/mobile/gsm48_rr.c b/src/host/layer23/src/mobile/gsm48_rr.c index be0889f..45d5cdb 100644 --- a/src/host/layer23/src/mobile/gsm48_rr.c +++ b/src/host/layer23/src/mobile/gsm48_rr.c @@ -1274,7 +1274,7 @@ memset(&bv, 0, sizeof(bv)); bv.data = buf; - bv.data_len = 12; + bv.data_len = 32; /* spare bit */ bitvec_set_bit(&bv, 0); @@ -1439,7 +1439,85 @@ } else { bitvec_set_bit(&bv, ZERO); } - /* info: The max number of bits are about 80. */ + // FIXME: Add setting for the following features + /* Single Band Support */ + bitvec_set_bit(&bv, ZERO); + /* GSM 750 Band */ + bitvec_set_bit(&bv, ZERO); + /* UMTS 1.28 Mcps */ + bitvec_set_bit(&bv, ZERO); + /* Gerand Feature Package 1 */ + bitvec_set_bit(&bv, ZERO); + /* Extendet DTM GPRS Multi Slot Class */ + bitvec_set_bit(&bv, ZERO); + /* High Multislot Capability */ + bitvec_set_bit(&bv, ZERO); + /* 0 */ + bitvec_set_bit(&bv, ZERO); + /* Gerand Feature Package 1 */ + bitvec_set_bit(&bv, ZERO); + /* GMSK Multislot Power Profile */ + bitvec_set_uint(&bv, 0, 2); + /* 8-PSK Multislot Power Profile */ + bitvec_set_uint(&bv, 0, 2); + /* T-GSM 400 Bands */ + bitvec_set_bit(&bv, ZERO); + /* 0 */ + bitvec_set_bit(&bv, ZERO); + /* Downlink Advanced Receiver Performance */ + bitvec_set_uint(&bv, 0, 2); + /* DTM Enancements Capability */ + bitvec_set_bit(&bv, ZERO); + /* DTM GPRS High Multi Slot Class */ + bitvec_set_bit(&bv, ZERO); + /* Repeated ACCH Capability */ + bitvec_set_bit(&bv, ZERO); + /* GSM 710 Associated Radio Capability */ + bitvec_set_bit(&bv, ZERO); + /* T-GSM 810 Associated Radio Capability */ + bitvec_set_bit(&bv, ZERO); + /* Ciphering Mode Setting Capability */ + bitvec_set_bit(&bv, ZERO); + /* Additional Positioning Capabilities */ + bitvec_set_bit(&bv, ZERO); + /* E-UTRAN FDD supported */ + bitvec_set_bit(&bv, ZERO); + /* E-UTRAN TDD supported */ + bitvec_set_bit(&bv, ZERO); + /* E-UTRAN Measurement and Reporting supported */ + bitvec_set_bit(&bv, ZERO); + /* Priorify-based reselection supported */ + bitvec_set_bit(&bv, ZERO); + /* UTRA CSG Cell Reporting */ + bitvec_set_bit(&bv, ZERO); + /* VAMOS Level */ + bitvec_set_uint(&bv, 0, 2); + /* TIGHTER Capability */ + bitvec_set_uint(&bv, 0, 2); + /* Selective Ciphering of Downlink SACCH */ + bitvec_set_bit(&bv, ZERO); + /* CS to PS SRVCC from GERAN to UTRA */ + bitvec_set_uint(&bv, 0, 2); + /* CS to PS SRVCC from GERAN to E-UTRA */ + bitvec_set_uint(&bv, 0, 2); + /* GERAN Network Sharing support */ + bitvec_set_bit(&bv, ZERO); + /* E-UTRA Wideband RSRQ measurements support */ + bitvec_set_bit(&bv, ZERO); + /* GSM ER Band */ + if (set->er_gsm) { + bitvec_set_bit(&bv, ONE); + } else { + bitvec_set_bit(&bv, ZERO); + } + /* UTRA Multiple Frequency Band indicators support */ + bitvec_set_bit(&bv, ZERO); + /* E-UTRA Multiple Frequency Band indicators support */ + bitvec_set_bit(&bv, ZERO); + /* Extended TSC Set Capability support */ + bitvec_set_bit(&bv, ZERO); + /* Extended EARFCN value rande */ + bitvec_set_bit(&bv, ZERO); /* partial bytes will be padded with zero */ *len = (bv.cur_bit + 7) >> 3; -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/41360?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ica13814eddb5293c7d7a2a21dd6a7a437cd1d351 Gerrit-Change-Number: 41360 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu>

1 0

[S] Change in osmocom-bb[master]: Omit all-zero octets in MS Classmark 3
by jolly 06 Nov '25

06 Nov '25

jolly has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/41357?usp=email ) Change subject: Omit all-zero octets in MS Classmark 3 ...................................................................... Omit all-zero octets in MS Classmark 3 TS 24.008 Clause 10.5.7.1 allows us to omit all-zero octets at the end of the information element. The decoder will add them if needed. Older specs tell us to include the supported bands, a5 bits and radio capability. Therefore we don't omit them, even if their encoded octets are all-zero. Change-Id: I3f05893e60f37f349b77fbd15a20b7708c4c3481 --- M src/host/layer23/src/mobile/gsm48_rr.c 1 file changed, 13 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/57/41357/1 diff --git a/src/host/layer23/src/mobile/gsm48_rr.c b/src/host/layer23/src/mobile/gsm48_rr.c index 1750c57..c04193c 100644 --- a/src/host/layer23/src/mobile/gsm48_rr.c +++ b/src/host/layer23/src/mobile/gsm48_rr.c @@ -1270,6 +1270,7 @@ struct gsm_support *sup = &ms->support; struct gsm_settings *set = &ms->settings; struct bitvec bv; + int minimum_len; memset(&bv, 0, sizeof(bv)); bv.data = buf; @@ -1328,6 +1329,8 @@ bitvec_set_uint(&bv, 0, 4); bitvec_set_uint(&bv, set->class_900, 4); } + /* These octets above shall be included according to GSM 04.08 Version 5.3.0. */ + minimum_len = (bv.cur_bit + 7) >> 3; /* r support */ if (set->r_gsm) { bitvec_set_bit(&bv, ONE); @@ -1442,6 +1445,16 @@ *len = (bv.cur_bit + 7) >> 3; bitvec_fill(&bv, (*len*8) - bv.cur_bit, ZERO); + /* Remove all all-zero octets at the end. See the rule in Clause 10.5.7.1: + "Typically, the number of spare bits at the end is the minimum to reach an octet boundary. + The receiver may add any number of bits set to "0" at the end of the received string + if needed for correct decoding." + GSM 04.08 Version 5.3.0 states that spare octets after "octet 3" and "octet 3bis" may be omitted. + Note that "octet 3" refers to the first value (buf[0]) in this TLV information element. + */ + while (*len > minimum_len && buf[*len - 1] == 0x00) + (*len)--; + return 0; } -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/41357?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I3f05893e60f37f349b77fbd15a20b7708c4c3481 Gerrit-Change-Number: 41357 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu>

1 0

[XS] Change in osmocom-bb[master]: RSSI app: Use correct BSIC for RACH bursts
by jolly 06 Nov '25

06 Nov '25

jolly has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/41358?usp=email ) Change subject: RSSI app: Use correct BSIC for RACH bursts ...................................................................... RSSI app: Use correct BSIC for RACH bursts A regular RACH burst uses the BSIC of the cell. A 'uic' value of 0xff does not override the BSIC with a wrong value. Change-Id: I63ed20160d9d45cbc3f70cec8b1c0af262fdde19 --- M src/target/firmware/apps/rssi/main.c 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/58/41358/1 diff --git a/src/target/firmware/apps/rssi/main.c b/src/target/firmware/apps/rssi/main.c index 29c5430..b407caf 100644 --- a/src/target/firmware/apps/rssi/main.c +++ b/src/target/firmware/apps/rssi/main.c @@ -1209,6 +1209,7 @@ rach_req->ra = rach_ra; rach_req->offset = 0; rach_req->combined = (ccch_conf == 1); + rach_req->uic = 0xff; l1a_l23_rx(SC_DLCI_L1A_L23, msg1); l1a_l23_rx(SC_DLCI_L1A_L23, msg2); -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/41358?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I63ed20160d9d45cbc3f70cec8b1c0af262fdde19 Gerrit-Change-Number: 41358 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu>

1 0

[M] Change in osmocom-bb[master]: Add ER-GSM band support to all relevant applications
by jolly 06 Nov '25

06 Nov '25

jolly has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/41359?usp=email ) Change subject: Add ER-GSM band support to all relevant applications ...................................................................... Add ER-GSM band support to all relevant applications ER-GSM band expands the R-GSM band by additional 15 channels. Mobile application allows to turn on or off the support of these 15 channels. ER-GSM band is supported by default. Change-Id: I71baa3317df685cf6479b6e20e6ae078911aa24f --- M src/host/layer23/include/osmocom/bb/common/settings.h M src/host/layer23/include/osmocom/bb/common/support.h M src/host/layer23/src/common/settings.c M src/host/layer23/src/common/support.c M src/host/layer23/src/common/sysinfo.c M src/host/layer23/src/misc/bcch_scan.c M src/host/layer23/src/misc/cell_log.c M src/host/layer23/src/mobile/gsm48_rr.c M src/host/layer23/src/mobile/vty_interface.c M src/shared/libosmocore/src/gsm/gsm_utils.c M src/target/firmware/apps/rssi/main.c 11 files changed, 33 insertions(+), 21 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/59/41359/1 diff --git a/src/host/layer23/include/osmocom/bb/common/settings.h b/src/host/layer23/include/osmocom/bb/common/settings.h index 1d3e53d..6b40120 100644 --- a/src/host/layer23/include/osmocom/bb/common/settings.h +++ b/src/host/layer23/include/osmocom/bb/common/settings.h @@ -239,6 +239,7 @@ uint8_t p_gsm; uint8_t e_gsm; uint8_t r_gsm; + uint8_t er_gsm; uint8_t dcs; uint8_t gsm_850; uint8_t pcs; diff --git a/src/host/layer23/include/osmocom/bb/common/support.h b/src/host/layer23/include/osmocom/bb/common/support.h index b0c71f5..3dcfcab 100644 --- a/src/host/layer23/include/osmocom/bb/common/support.h +++ b/src/host/layer23/include/osmocom/bb/common/support.h @@ -49,6 +49,7 @@ uint8_t p_gsm; uint8_t e_gsm; uint8_t r_gsm; + uint8_t er_gsm; uint8_t dcs; uint8_t gsm_850; uint8_t pcs; diff --git a/src/host/layer23/src/common/settings.c b/src/host/layer23/src/common/settings.c index 6bc5634..c09aba5 100644 --- a/src/host/layer23/src/common/settings.c +++ b/src/host/layer23/src/common/settings.c @@ -95,6 +95,7 @@ set->p_gsm = sup->p_gsm; set->e_gsm = sup->e_gsm; set->r_gsm = sup->r_gsm; + set->er_gsm = sup->er_gsm; set->dcs = sup->dcs; set->class_900 = sup->class_900; set->class_dcs = sup->class_dcs; @@ -182,6 +183,9 @@ if (set->r_gsm) for(i = 955; i <= 974; i++) set->freq_map[i >> 3] |= (1 << (i & 7)); + if (set->er_gsm) + for(i = 940; i <= 954; i++) + set->freq_map[i >> 3] |= (1 << (i & 7)); return 0; } diff --git a/src/host/layer23/src/common/support.c b/src/host/layer23/src/common/support.c index a31b456..8bf034b 100644 --- a/src/host/layer23/src/common/support.c +++ b/src/host/layer23/src/common/support.c @@ -62,6 +62,7 @@ sup->p_gsm = 1; /* P-GSM */ sup->e_gsm = 1; /* E-GSM */ sup->r_gsm = 1; /* R-GSM */ + sup->er_gsm = 1; /* ER-GSM */ sup->dcs = 1; sup->gsm_850 = 1; sup->pcs = 1; @@ -113,7 +114,7 @@ { 306, 340, 15, 0 }, /* GSM 480 */ { 438, 511, 25, 0 }, { 128, 251, 30, 0 }, /* GSM 850 */ - { 955, 124, 30, 0 }, /* P,E,R GSM */ + { 940, 124, 30, 0 }, /* P,E,(E)R GSM */ { 512, 885, 40, 0 }, /* DCS 1800 */ { 1024, 1322, 40, 0 }, /* PCS 1900 */ { 0, 0, 0, 0 } @@ -130,10 +131,11 @@ print(priv, "Supported features of MS '%s':\n", sup->ms->name); print(priv, " Phase %d mobile station\n", sup->rev_lev + 1); + print(priv, " ER-GSM : %s\n", SUP_SET(er_gsm)); print(priv, " R-GSM : %s\n", SUP_SET(r_gsm)); print(priv, " E-GSM : %s\n", SUP_SET(e_gsm)); print(priv, " P-GSM : %s\n", SUP_SET(p_gsm)); - if (set->r_gsm || set->e_gsm || set->p_gsm) + if (set->er_gsm || set->r_gsm || set->e_gsm || set->p_gsm) print(priv, " GSM900 Class : %d\n", set->class_900); print(priv, " DCS 1800 : %s\n", SUP_SET(dcs)); if (set->dcs) diff --git a/src/host/layer23/src/common/sysinfo.c b/src/host/layer23/src/common/sysinfo.c index efbc519..1046e78 100644 --- a/src/host/layer23/src/common/sysinfo.c +++ b/src/host/layer23/src/common/sysinfo.c @@ -399,7 +399,7 @@ #if 0 /* only Bit map 0 format for P-GSM */ if ((cd[0] & 0xc0 & mask) != 0x00 && - (set->p_gsm && !set->e_gsm && !set->r_gsm && !set->dcs)) + (set->p_gsm && !set->e_gsm && !set->er_gsm && !set->r_gsm && !set->dcs)) return 0; #endif diff --git a/src/host/layer23/src/misc/bcch_scan.c b/src/host/layer23/src/misc/bcch_scan.c index 69df043..a2381d6 100644 --- a/src/host/layer23/src/misc/bcch_scan.c +++ b/src/host/layer23/src/misc/bcch_scan.c @@ -264,7 +264,7 @@ switch (fps.fps_state) { case FPS_S_PM_GSM900: fps.fps_state = FPS_S_PM_EGSM900; - return l1ctl_tx_pm_req_range(ms, 955, 1023); + return l1ctl_tx_pm_req_range(ms, 940, 1023); case FPS_S_PM_EGSM900: fps.fps_state = FPS_S_PM_GSM1800; return l1ctl_tx_pm_req_range(ms, 512, 885); diff --git a/src/host/layer23/src/misc/cell_log.c b/src/host/layer23/src/misc/cell_log.c index ed4d74d..3e0ae9c 100644 --- a/src/host/layer23/src/misc/cell_log.c +++ b/src/host/layer23/src/misc/cell_log.c @@ -59,7 +59,7 @@ }; /* ranges of bands */ -static uint16_t basic_band_range[][2] = {{0, 124}, {512, 885}, {955, 1023}, {0, 0}}; +static uint16_t basic_band_range[][2] = {{0, 124}, {512, 885}, {940, 1023}, {0, 0}}; uint16_t (*band_range)[][2] = &basic_band_range; #define INFO_FLG_PM 1 diff --git a/src/host/layer23/src/mobile/gsm48_rr.c b/src/host/layer23/src/mobile/gsm48_rr.c index c04193c..be0889f 100644 --- a/src/host/layer23/src/mobile/gsm48_rr.c +++ b/src/host/layer23/src/mobile/gsm48_rr.c @@ -1284,12 +1284,12 @@ else bitvec_set_bit(&bv, ZERO); /* band 2 supported */ - if (set->e_gsm || set->r_gsm) + if (set->e_gsm || set->r_gsm || set->er_gsm) bitvec_set_bit(&bv, ONE); else bitvec_set_bit(&bv, ZERO); /* band 1 supported */ - if (set->p_gsm && !(set->e_gsm || set->r_gsm)) + if (set->p_gsm && !(set->e_gsm || set->r_gsm || set->er_gsm)) bitvec_set_bit(&bv, ONE); else bitvec_set_bit(&bv, ZERO); @@ -1311,15 +1311,15 @@ else bitvec_set_bit(&bv, ZERO); /* radio capability */ - if (!set->dcs && !set->p_gsm && !(set->e_gsm || set->r_gsm)) { - /* Fig. 10.5.7 / TS 24.0008: none of dcs, p, e, r */ + if (!set->dcs && !set->p_gsm && !(set->e_gsm || set->r_gsm || set->er_gsm)) { + /* Fig. 10.5.7 / TS 24.0008: none of dcs, p, e, (e)r */ } else - if (set->dcs && !set->p_gsm && !(set->e_gsm || set->r_gsm)) { + if (set->dcs && !set->p_gsm && !(set->e_gsm || set->r_gsm || set->er_gsm)) { /* dcs only */ bitvec_set_uint(&bv, 0, 4); bitvec_set_uint(&bv, set->class_dcs, 4); } else - if (set->dcs && (set->p_gsm || (set->e_gsm || set->r_gsm))) { + if (set->dcs && (set->p_gsm || (set->e_gsm || set->r_gsm || set->er_gsm))) { /* dcs */ bitvec_set_uint(&bv, set->class_dcs, 4); /* low band */ @@ -1332,7 +1332,7 @@ /* These octets above shall be included according to GSM 04.08 Version 5.3.0. */ minimum_len = (bv.cur_bit + 7) >> 3; /* r support */ - if (set->r_gsm) { + if (set->r_gsm || set->er_gsm) { bitvec_set_bit(&bv, ONE); bitvec_set_uint(&bv, set->class_900, 3); } else { @@ -1388,7 +1388,7 @@ if (set->edge_psk_sup) { bitvec_set_bit(&bv, ONE); bitvec_set_bit(&bv, set->edge_psk_uplink == 1); - if (set->p_gsm || (set->e_gsm || set->r_gsm)) { + if (set->p_gsm || (set->e_gsm || set->r_gsm || set->er_gsm)) { bitvec_set_bit(&bv, ONE); bitvec_set_uint(&bv, set->class_900_edge, 2); } else { @@ -1469,7 +1469,7 @@ cm->a5_1 = !set->a5_1; cm->es_ind = sup->es_ind; cm->rev_lev = sup->rev_lev; - cm->fc = (set->r_gsm || set->e_gsm); + cm->fc = (set->er_gsm || set->r_gsm || set->e_gsm); cm->vgcs = sup->vgcs; cm->vbs = sup->vbs; cm->sm_cap = set->sms_ptp; @@ -1511,7 +1511,7 @@ gsm48_rr_enc_cm2(ms, &cc->cm2, rr->cd_now.arfcn); /* classmark 3 */ - if (set->dcs || set->pcs || set->e_gsm || set->r_gsm || set->gsm_850 + if (set->dcs || set->pcs || set->e_gsm || set->r_gsm || set->er_gsm || set->gsm_850 || set->a5_7 || set->a5_6 || set->a5_5 || set->a5_4 || sup->ms_sup || sup->ucs2_treat diff --git a/src/host/layer23/src/mobile/vty_interface.c b/src/host/layer23/src/mobile/vty_interface.c index eb582d3..b5b3128 100644 --- a/src/host/layer23/src/mobile/vty_interface.c +++ b/src/host/layer23/src/mobile/vty_interface.c @@ -1569,12 +1569,13 @@ SUP_WRITE(p_gsm, "p-gsm"); SUP_WRITE(e_gsm, "e-gsm"); SUP_WRITE(r_gsm, "r-gsm"); + SUP_WRITE(er_gsm, "er-gsm"); SUP_WRITE(gsm_850, "gsm-850"); SUP_WRITE(gsm_480, "gsm-480"); SUP_WRITE(gsm_450, "gsm-450"); SUP_WRITE(dcs, "dcs"); SUP_WRITE(pcs, "pcs"); - if (sup->r_gsm || sup->e_gsm || sup->p_gsm) + if (sup->er_gsm || sup->r_gsm || sup->e_gsm || sup->p_gsm) if (!l23_vty_hide_default || sup->class_900 != set->class_900) vty_out(vty, " class-900 %d%s", set->class_900, VTY_NEWLINE); @@ -2470,6 +2471,7 @@ SUP_EN_DI(p_gsm, "p-gsm", "P-GSM (900)", 1); SUP_EN_DI(e_gsm, "e-gsm", "E-GSM (850)", 1); SUP_EN_DI(r_gsm, "r-gsm", "R-GSM (850)", 1); +SUP_EN_DI(er_gsm, "er-gsm", "ER-GSM (850)", 1); SUP_EN_DI(dcs, "dcs", "DCS (1800)", 1); SUP_EN_DI(gsm_850, "gsm-850", "GSM 850", 1); SUP_EN_DI(pcs, "pcs", "PCS (1900)", 1); @@ -3111,6 +3113,8 @@ install_element(SUPPORT_NODE, &cfg_ms_sup_di_e_gsm_cmd); install_element(SUPPORT_NODE, &cfg_ms_sup_en_r_gsm_cmd); install_element(SUPPORT_NODE, &cfg_ms_sup_di_r_gsm_cmd); + install_element(SUPPORT_NODE, &cfg_ms_sup_en_er_gsm_cmd); + install_element(SUPPORT_NODE, &cfg_ms_sup_di_er_gsm_cmd); install_element(SUPPORT_NODE, &cfg_ms_sup_en_dcs_cmd); install_element(SUPPORT_NODE, &cfg_ms_sup_di_dcs_cmd); install_element(SUPPORT_NODE, &cfg_ms_sup_en_gsm_850_cmd); diff --git a/src/shared/libosmocore/src/gsm/gsm_utils.c b/src/shared/libosmocore/src/gsm/gsm_utils.c index 4b170df..66d5abb 100644 --- a/src/shared/libosmocore/src/gsm/gsm_utils.c +++ b/src/shared/libosmocore/src/gsm/gsm_utils.c @@ -481,7 +481,7 @@ return GSM_BAND_1900; else if (arfcn <= 124) return GSM_BAND_900; - else if (arfcn >= 955 && arfcn <= 1023) + else if (arfcn >= 940 && arfcn <= 1023) return GSM_BAND_900; else if (arfcn >= 128 && arfcn <= 251) return GSM_BAND_850; @@ -517,8 +517,8 @@ /* Primary GSM + ARFCN 0 of E-GSM */ freq10_ul = 8900 + 2 * arfcn; freq10_dl = freq10_ul + 450; - } else if (arfcn >= 955 && arfcn <= 1023) { - /* E-GSM and R-GSM */ + } else if (arfcn >= 940 && arfcn <= 1023) { + /* E-GSM and R-GSM and ER-GSM */ freq10_ul = 8900 + 2 * (arfcn - 1024); freq10_dl = freq10_ul + 450; } else if (arfcn >= 128 && arfcn <= 251) { diff --git a/src/target/firmware/apps/rssi/main.c b/src/target/firmware/apps/rssi/main.c index b407caf..b424f13 100644 --- a/src/target/firmware/apps/rssi/main.c +++ b/src/target/firmware/apps/rssi/main.c @@ -79,8 +79,8 @@ int min, max, prev, next, freq_ul, freq_dl; } bands[] = { { 128, 251, 124, 512, 8242, 8692 }, /* GSM 850 */ - { 955, 124, 885, 128, 8762, 9212 }, /* P,E,R GSM */ - { 512, 885, 251, 955, 17102, 18052 }, /* DCS 1800 */ + { 940, 124, 885, 128, 8732, 9182 }, /* P,E,(E)R GSM */ + { 512, 885, 251, 940, 17102, 18052 }, /* DCS 1800 */ { 0, 0, 0, 0, 0, 0}, }; -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/41359?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I71baa3317df685cf6479b6e20e6ae078911aa24f Gerrit-Change-Number: 41359 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu>

1 0

[XS] Change in libosmo-sigtran[osmith/2.1.3]: ipa: fix a minor memleak for unknown IPA packets
by fixeria 06 Nov '25

06 Nov '25

Attention is currently required from: osmith. fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41353?usp=email ) Change subject: ipa: fix a minor memleak for unknown IPA packets ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41353?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: osmith/2.1.3 Gerrit-Change-Id: Idb77d3d7dc9db1076b110fb4d17c951b161e77e2 Gerrit-Change-Number: 41353 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 06 Nov 2025 10:41:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

2025

2024

2023

2022

gerrit-log November 2025