January 2025 - gerrit-log - lists.osmocom.org

[S] Change in libosmo-sigtran[master]: ipa: Split msgb generation into its own helper function

by fixeria

Attention is currently required from: osmith, pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/39395?usp=email ) Change subject: ipa: Split msgb generation into its own helper function ...................................................................... Patch Set 2: Code-Review+1 (1 comment) File src/ipa.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/39395/comment/7b93af20_49cfc… : PS1, Line 102: OSMO_ASSERT(as->cfg.proto == OSMO_SS7_ASP_PROT_IPA); > Ok I actually got confused and they were fine, I updated it as suggested plus added some extra loggi […] Done -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/39395?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Ic0a405ab4d1811efea137167dcb08c9308a4d7e7 Gerrit-Change-Number: 39395 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 22 Jan 2025 13:12:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

5 months

1
0
0 0

[S] Change in libosmo-sigtran[master]: ipa: Split msgb generation into its own helper function

by pespin

Attention is currently required from: fixeria, osmith. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/39395?usp=email ) Change subject: ipa: Split msgb generation into its own helper function ...................................................................... Patch Set 2: (1 comment) File src/ipa.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/39395/comment/8cdb4e8d_f0612… : PS1, Line 102: OSMO_ASSERT(as->cfg.proto == OSMO_SS7_ASP_PROT_IPA); > ACK will probably submit a new version, I see now that sua and m3ua have different order between the […] Ok I actually got confused and they were fine, I updated it as suggested plus added some extra logging on m3ua/sua ones to look similar. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/39395?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Ic0a405ab4d1811efea137167dcb08c9308a4d7e7 Gerrit-Change-Number: 39395 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 22 Jan 2025 13:11:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

5 months

1
0
0 0

[S] Change in libosmo-sigtran[master]: ipa: Split msgb generation into its own helper function

by pespin

Attention is currently required from: fixeria, osmith. Hello Jenkins Builder, fixeria, osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/39395?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by fixeria, Verified+1 by Jenkins Builder Change subject: ipa: Split msgb generation into its own helper function ...................................................................... ipa: Split msgb generation into its own helper function This allows having a clearer picture when comparing against other protocol stacks like M3UA and SUA, since both have a sua_to_msg() and m3ua_to_msg() functions (which in turn call xua_to_msg()). This way ipa_tx_xua_as() also becomes much more similar to m3ua_tx_xua_as() and sua_tx_xua_as(). While at it, also add extra logging to m3ua/sua_tx_xua_as() to also provide AS context logging information when encoding fail. Change-Id: Ic0a405ab4d1811efea137167dcb08c9308a4d7e7 --- M src/ipa.c M src/m3ua.c M src/sua.c 3 files changed, 29 insertions(+), 15 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/95/39395/2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/39395?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Ic0a405ab4d1811efea137167dcb08c9308a4d7e7 Gerrit-Change-Number: 39395 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>

5 months

1
0
0 0

[S] Change in libosmo-sigtran[master]: ipa: Split msgb generation into its own helper function

by pespin

Attention is currently required from: fixeria, osmith. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/39395?usp=email ) Change subject: ipa: Split msgb generation into its own helper function ...................................................................... Patch Set 1: (1 comment) File src/ipa.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/39395/comment/49c48e55_9f755… : PS1, Line 102: OSMO_ASSERT(as->cfg.proto == OSMO_SS7_ASP_PROT_IPA); > Well, maybe the existing `sua/m3ua_tx_xua_as()` should be updated then? It's not super critical and […] ACK will probably submit a new version, I see now that sua and m3ua have different order between them actually. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/39395?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Ic0a405ab4d1811efea137167dcb08c9308a4d7e7 Gerrit-Change-Number: 39395 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 22 Jan 2025 13:03:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

5 months

1
0
0 0

[S] Change in libosmo-sigtran[master]: ipa: Split msgb generation into its own helper function

by fixeria

Attention is currently required from: osmith, pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/39395?usp=email ) Change subject: ipa: Split msgb generation into its own helper function ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File src/ipa.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/39395/comment/9ee2d7ad_9aa65… : PS1, Line 102: OSMO_ASSERT(as->cfg.proto == OSMO_SS7_ASP_PROT_IPA); > I initally did as you say but I later changed it since it was the other way in already existing sua/ […] Well, maybe the existing `sua/m3ua_tx_xua_as()` should be updated then? It's not super critical and I am not blocking. But it looks weird that the code is first assuming and doing something, and then asserting. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/39395?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Ic0a405ab4d1811efea137167dcb08c9308a4d7e7 Gerrit-Change-Number: 39395 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 22 Jan 2025 12:42:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

5 months

1
0
0 0

[S] Change in libosmo-sigtran[master]: ipa: Split msgb generation into its own helper function

by pespin

Attention is currently required from: fixeria, osmith. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/39395?usp=email ) Change subject: ipa: Split msgb generation into its own helper function ...................................................................... Patch Set 1: (1 comment) File src/ipa.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/39395/comment/3af0624e_64478… : PS1, Line 102: OSMO_ASSERT(as->cfg.proto == OSMO_SS7_ASP_PROT_IPA); > IMO, this should be done before calling `ipa_to_msg()`. Like it's done now. I initally did as you say but I later changed it since it was the other way in already existing sua/m3ua_tx_xua_as() -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/39395?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Ic0a405ab4d1811efea137167dcb08c9308a4d7e7 Gerrit-Change-Number: 39395 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 22 Jan 2025 12:35:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

5 months

1
0
0 0

[S] Change in libosmo-sigtran[master]: ipa: Split msgb generation into its own helper function

by fixeria

Attention is currently required from: osmith, pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/39395?usp=email ) Change subject: ipa: Split msgb generation into its own helper function ...................................................................... Patch Set 1: (1 comment) File src/ipa.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/39395/comment/07160537_5ff37… : PS1, Line 102: OSMO_ASSERT(as->cfg.proto == OSMO_SS7_ASP_PROT_IPA); IMO, this should be done before calling `ipa_to_msg()`. Like it's done now. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/39395?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Ic0a405ab4d1811efea137167dcb08c9308a4d7e7 Gerrit-Change-Number: 39395 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 22 Jan 2025 12:34:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

5 months

1
0
0 0

[S] Change in libosmo-sigtran[master]: cosmetic: whitespace improvements

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/39390?usp=email ) Change subject: cosmetic: whitespace improvements ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/39390?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I366944230e698c7805ab977a5205d0978d03998f Gerrit-Change-Number: 39390 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 22 Jan 2025 12:32:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

5 months

1
0
0 0

[XS] Change in ...osmo-s1gw[master]: erab_fsm: add more logging to clarify timeout events

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/39394?usp=email ) Change subject: erab_fsm: add more logging to clarify timeout events ...................................................................... erab_fsm: add more logging to clarify timeout events Change-Id: Iad64ce88e747951c0699074d95d504ccf9f61603 --- M src/erab_fsm.erl 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/src/erab_fsm.erl b/src/erab_fsm.erl index 0b4904d..ea1c11b 100644 --- a/src/erab_fsm.erl +++ b/src/erab_fsm.erl @@ -249,6 +249,7 @@ [{state_timeout, ?ERAB_T_WAIT_SETUP_RSP, ?FUNCTION_NAME}]}; erab_wait_setup_rsp(state_timeout, _Timeout, _S) -> + ?LOG_ERROR("Timeout waiting for E-RAB SETUP Rsp"), {stop, {shutdown, timeout}}; erab_wait_setup_rsp({call, From}, @@ -377,6 +378,7 @@ [{state_timeout, ?ERAB_T_WAIT_RELEASE_RSP, ?FUNCTION_NAME}]}; erab_wait_release_rsp(state_timeout, _Timeout, _S) -> + ?LOG_ERROR("Timeout waiting for E-RAB RELEASE Rsp"), {stop, {shutdown, timeout}}; erab_wait_release_rsp(cast, erab_release_rsp, -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/39394?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: Iad64ce88e747951c0699074d95d504ccf9f61603 Gerrit-Change-Number: 39394 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

5 months

1
0
0 0

[XS] Change in ...osmo-s1gw[master]: erab_fsm: fix copy-paste in a log message

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/39393?usp=email ) Change subject: erab_fsm: fix copy-paste in a log message ...................................................................... erab_fsm: fix copy-paste in a log message Change-Id: I50f78ac99ddb82244107ff9847acec64d2e9fce1 --- M src/erab_fsm.erl 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/erab_fsm.erl b/src/erab_fsm.erl index b249cd4..0b4904d 100644 --- a/src/erab_fsm.erl +++ b/src/erab_fsm.erl @@ -336,7 +336,7 @@ session_delete(state_timeout, _Timeout, #erab_state{from = From}) -> - ?LOG_ERROR("PFCP session modification timeout"), + ?LOG_ERROR("PFCP session deletion timeout"), {stop_and_reply, {shutdown, timeout}, {reply, From, {error, {timeout, ?FUNCTION_NAME}}}}; -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/39393?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I50f78ac99ddb82244107ff9847acec64d2e9fce1 Gerrit-Change-Number: 39393 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

5 months

1
0
0 0

2025

2024

2023

2022

gerrit-log January 2025