January 2025 - gerrit-log - lists.osmocom.org

[S] Change in osmo-gsm-manuals[master]: bibliography.adoc: add TW-TS-* references

by falconia

Attention is currently required from: laforge, pespin. falconia has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/39289?usp=email ) Change subject: bibliography.adoc: add TW-TS-* references ...................................................................... Patch Set 2: (1 comment) File common/chapters/bibliography.adoc: https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/39289/comment/6e0d1cd0_be14… : PS1, Line 240: - [[[tw-ts-005]]] TW-TS-005: Hexadecimal file format for sequences of RTP : payloads for GSM speech codecs : https://www.freecalypso.org/specs/tw-ts-005-v010003.txt > I think unit tests are of no interest in the User Manual, so they can most probably be dropped. The updated version of the patch drops TW-TS-005. -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/39289?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: Ia34a61b5f834f2c70f81012dcc816dd6014c784f Gerrit-Change-Number: 39289 Gerrit-PatchSet: 2 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 13 Jan 2025 13:19:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: falconia <falcon(a)freecalypso.org> Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

5 months, 1 week

1
0
0 0

[S] Change in osmo-gsm-manuals[master]: bibliography.adoc: add TW-TS-* references

by falconia

Attention is currently required from: falconia, laforge. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/39289?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: bibliography.adoc: add TW-TS-* references ...................................................................... bibliography.adoc: add TW-TS-* references Some Osmocom components include support for interfaces that are defined in Themyscira Wireless specs (TW-TS): * OsmoBTS includes support for TW-TS-001, may also support TW-TS-002 for HRv1 codec in the future; * OsmoBSC includes support for TW-TS-003 BSSMAP extension. Therefore, these specs should be linked from Osmocom bibliography. Change-Id: Ia34a61b5f834f2c70f81012dcc816dd6014c784f --- M common/chapters/bibliography.adoc 1 file changed, 10 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-manuals refs/changes/89/39289/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/39289?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: Ia34a61b5f834f2c70f81012dcc816dd6014c784f Gerrit-Change-Number: 39289 Gerrit-PatchSet: 2 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Attention: laforge <laforge(a)osmocom.org>

5 months, 1 week

1
0
0 0

[XS] Change in osmo-ci[master]: ansible: add IPv6 address of build5

by laforge

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/39295?usp=email ) Change subject: ansible: add IPv6 address of build5 ...................................................................... ansible: add IPv6 address of build5 Change-Id: Ic5d5ed254f3dc2786873e52c450fab320d03a1ed --- M ansible/hosts M ansible/util/known_hosts 2 files changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/95/39295/1 diff --git a/ansible/hosts b/ansible/hosts index f68ea52..0d8f5de 100644 --- a/ansible/hosts +++ b/ansible/hosts @@ -10,6 +10,7 @@ build2-deb10build-ansible ansible_host=2a01:4f8:10b:2ad9::1:10 osmocom_jenkins_slave_fstrim=True docker_max_image_space="80 GB" build2-deb11build-ansible ansible_host=2a01:4f8:10b:2ad9::1:13 osmocom_jenkins_slave_fstrim=True docker_max_image_space="80 GB" build4-deb12build-ansible ansible_host=2a01:4f8:121:200a::1:3 osmocom_jenkins_slave_fstrim=True docker_max_image_space="80 GB" +build5-deb12build-ansible ansible_host=2a01:4f8:140:926a::1:3 osmocom_jenkins_slave_fstrim=True docker_max_image_space="80 GB" host2-deb11build-ansible ansible_host=2a01:4f8:120:8470::1:4 osmocom_jenkins_slave_fstrim=True docker_max_image_space="80 GB" rpi4-raspbian12build-ansible-1 ansible_host=10.9.25.50 docker_max_image_space="20 GB" rpi4-raspbian12build-ansible-2 ansible_host=10.9.25.60 docker_max_image_space="20 GB" diff --git a/ansible/util/known_hosts b/ansible/util/known_hosts index 6067e86..8e8aee1 100644 --- a/ansible/util/known_hosts +++ b/ansible/util/known_hosts @@ -8,3 +8,4 @@ 2a01:4f8:121:200a::1:3 ssh-ed25519 AAAAC3NzaC1lZDI1NTE5AAAAIGafw2VdeZo4YNvbu8VEBjDrsCFL+ZSbHtvhspNIQ9PR 2a01:4f8:121:200a::1:2 ssh-ed25519 AAAAC3NzaC1lZDI1NTE5AAAAIFyp0daWkfsRHErCVCcP/FZmtiRvFNAsK2A5TlQ6Ja+P 10.9.25.28 ssh-ed25519 AAAAC3NzaC1lZDI1NTE5AAAAIG0rQGxSxWJHwNNT5XdeuMPSYCAXpcDnFDzvyw5+sH3l +2a01:4f8:140:926a::1:3 ssh-ed25519 AAAAC3NzaC1lZDI1NTE5AAAAIFU0ICXO2Mq6HjOrgWJqWifEYwz+Y3eyPd8ZOkp8el3l -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/39295?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ic5d5ed254f3dc2786873e52c450fab320d03a1ed Gerrit-Change-Number: 39295 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org>

5 months, 1 week

1
0
0 0

[S] Change in osmo-gsm-manuals[master]: bibliography.adoc: add TW-TS-* references

by pespin

Attention is currently required from: falconia, laforge. pespin has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/39289?usp=email ) Change subject: bibliography.adoc: add TW-TS-* references ...................................................................... Patch Set 1: (1 comment) File common/chapters/bibliography.adoc: https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/39289/comment/26ea7b81_ad7d… : PS1, Line 240: - [[[tw-ts-005]]] TW-TS-005: Hexadecimal file format for sequences of RTP : payloads for GSM speech codecs : https://www.freecalypso.org/specs/tw-ts-005-v010003.txt > Right now there are two unit tests in libosmocore (for `osmo_fr_sid_classify()` and `osmo_efr_sid_cl […] I think unit tests are of no interest in the User Manual, so they can most probably be dropped. -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/39289?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: Ia34a61b5f834f2c70f81012dcc816dd6014c784f Gerrit-Change-Number: 39289 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 13 Jan 2025 12:41:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: falconia <falcon(a)freecalypso.org> Comment-In-Reply-To: laforge <laforge(a)osmocom.org>

5 months, 1 week

1
0
0 0

[S] Change in osmo-gsm-manuals[master]: bibliography.adoc: add TW-TS-* references

by falconia

Attention is currently required from: laforge. falconia has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/39289?usp=email ) Change subject: bibliography.adoc: add TW-TS-* references ...................................................................... Patch Set 1: (1 comment) File common/chapters/bibliography.adoc: https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/39289/comment/534d7bbd_fe93… : PS1, Line 240: - [[[tw-ts-005]]] TW-TS-005: Hexadecimal file format for sequences of RTP : payloads for GSM speech codecs : https://www.freecalypso.org/specs/tw-ts-005-v010003.txt > do we really support that hexadecimal file format anywhere? Right now there are two unit tests in libosmocore (for `osmo_fr_sid_classify()` and `osmo_efr_sid_classify()`) where the input file to the unit test program is in the same hex format which I later codified as TW-TS-005. I also plan to add some unit tests for `osmo_rtp2trau()` followed by `osmo_trau_frame_encode`, using the same hex format for unit test input data. But I agree that unit tests are very internal components that don't constitute any kind of interface, so perhaps TW-TS-005 does not belong in the bibliography as it does not appear in any formal APIs or other accessible interfaces. Please indicate if I should resubmit this bibliography patch with TW-TS-005 omitted. -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/39289?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: Ia34a61b5f834f2c70f81012dcc816dd6014c784f Gerrit-Change-Number: 39289 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 13 Jan 2025 12:03:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org>

5 months, 1 week

1
0
0 0

[M] Change in osmo-bsc[master]: nokia_site: introduce hopping control for Nokia *Site

by pespin

Attention is currently required from: csaba.sipos, fixeria. pespin has posted comments on this change by csaba.sipos. ( https://gerrit.osmocom.org/c/osmo-bsc/+/39290?usp=email ) Change subject: nokia_site: introduce hopping control for Nokia *Site ...................................................................... Patch Set 6: (1 comment) File src/osmo-bsc/bts_vty.c: https://gerrit.osmocom.org/c/osmo-bsc/+/39290/comment/a7028216_e441ca16?usp… : PS6, Line 468: DEFUN_ATTR(cfg_bts_nokia_site_hopping_type, > > ... existing hopping support already in osmo-bsc. […] yes I think those, I recall we had some hopping support already for somo-bts, but maybe not the same thing? -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/39290?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Idb1d269d2ee80d72ede2394125e8acedf0ee8b06 Gerrit-Change-Number: 39290 Gerrit-PatchSet: 6 Gerrit-Owner: csaba.sipos <metro4(a)freemail.hu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: csaba.sipos <metro4(a)freemail.hu> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 13 Jan 2025 11:38:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

5 months, 1 week

1
0
0 0

[M] Change in osmo-iuh[master]: iu_client: add ranap_iu_page_cs2/ranap_iu_page_ps2

by lynxis lazus

Attention is currently required from: pespin. lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-iuh/+/38946?usp=email ) Change subject: iu_client: add ranap_iu_page_cs2/ranap_iu_page_ps2 ...................................................................... Patch Set 6: (1 comment) File src/iu_client.c: https://gerrit.osmocom.org/c/osmo-iuh/+/38946/comment/be06e6f4_4062d6a9?usp… : PS3, Line 901: }; > You still have the same problem with latest implementation. […] yes, you're right for CS -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/38946?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I1f07e96642737160d387de3e4c3f71d288d356dd Gerrit-Change-Number: 38946 Gerrit-PatchSet: 6 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 13 Jan 2025 11:06:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>

5 months, 1 week

1
0
0 0

[M] Change in osmo-bsc[master]: nokia_site: introduce hopping control for Nokia *Site

by fixeria

Attention is currently required from: csaba.sipos, pespin. fixeria has posted comments on this change by csaba.sipos. ( https://gerrit.osmocom.org/c/osmo-bsc/+/39290?usp=email ) Change subject: nokia_site: introduce hopping control for Nokia *Site ...................................................................... Patch Set 6: (3 comments) File src/osmo-bsc/bts_vty.c: https://gerrit.osmocom.org/c/osmo-bsc/+/39290/comment/d1750954_c4a3d22e?usp… : PS6, Line 468: DEFUN_ATTR(cfg_bts_nokia_site_hopping_type, > ... existing hopping support already in osmo-bsc. I guess you mean the existing per-`TS_NODE` commands for setting hopping params? What kind of integration you're suggesting? I can only think of adding a generic command that would not be Nokia *Site specific. https://gerrit.osmocom.org/c/osmo-bsc/+/39290/comment/a6f63eba_ae52f4a5?usp… : PS6, Line 470: nokia_hopping Maybe call this part `hopping-kind` or `hopping-mode`? Also, I don't like the choice of numeric modes (`0` and `1`), making it less obvious. I suggest using string literals instead: ``` nokia_site hopping-mode (baseband|synth) ``` https://gerrit.osmocom.org/c/osmo-bsc/+/39290/comment/c50289ac_4c82ba7f?usp… : PS6, Line 474: CMD_ATTR_IMMEDIATE Are you sure about the immediate effect? I doubt it applies to a working BTS immediately. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/39290?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Idb1d269d2ee80d72ede2394125e8acedf0ee8b06 Gerrit-Change-Number: 39290 Gerrit-PatchSet: 6 Gerrit-Owner: csaba.sipos <metro4(a)freemail.hu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: csaba.sipos <metro4(a)freemail.hu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 13 Jan 2025 10:54:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

5 months, 1 week

1
0
0 0

[L] Change in osmo-pcap[master]: client: Introduce osmo_pcap_file to prepare support for pcapng

by pespin

Attention is currently required from: laforge. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-pcap/+/39288?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: client: Introduce osmo_pcap_file to prepare support for pcapng ...................................................................... client: Introduce osmo_pcap_file to prepare support for pcapng This patch is a preparation patch refactoring code to make it easier to add pcapng format in follow-up patch. Different types of encodings are grouped in helper functions. Change-Id: Ifd389a2a32897e101c62fd280ddca984d485d373 --- M include/osmo-pcap/Makefile.am M include/osmo-pcap/osmo_pcap_client.h A include/osmo-pcap/osmo_pcap_file.h M src/Makefile.am M src/osmo_client_core.c M src/osmo_client_network.c A src/osmo_pcap_file.c 7 files changed, 240 insertions(+), 78 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcap refs/changes/88/39288/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/39288?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: Ifd389a2a32897e101c62fd280ddca984d485d373 Gerrit-Change-Number: 39288 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org>

5 months, 1 week

1
0
0 0

[L] Change in osmo-pcap[master]: client: Introduce osmo_pcap_file to prepare support for pcapng

by pespin

Attention is currently required from: laforge. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-pcap/+/39288?usp=email ) Change subject: client: Introduce osmo_pcap_file to prepare support for pcapng ...................................................................... Patch Set 1: (1 comment) File src/osmo_pcap_file.c: https://gerrit.osmocom.org/c/osmo-pcap/+/39288/comment/32809687_2bd397a7?us… : PS1, Line 38: osmo_pcap_file_global_header_size > do we reeally need a function for this? Do we ever expect that there will be a future file format wh […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/39288?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: Ifd389a2a32897e101c62fd280ddca984d485d373 Gerrit-Change-Number: 39288 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 13 Jan 2025 10:29:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org>

5 months, 1 week

1
0
0 0

2025

2024

2023

2022

gerrit-log January 2025