Attention is currently required from: dexter, fixeria.
laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/37819?usp=email )
Change subject: Testsuite for pySim-shell with real cards
......................................................................
Patch Set 15:
(1 comment)
File tests/pySim-shell_test/ara_m/test.py:
https://gerrit.osmocom.org/c/pysim/+/37819/comment/b4d8befa_4af41374?usp=em… :
PS15, Line 35: self.cleanup()
> This could actually work. I will try it.
I would prefer a solution that does not have to define a class variable in every derived class (testcase class). that's almost as cumbersome as calling the setup method from each derived class. Solving it without any extra lines here, in a generic way, should be preferable.
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/37819?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Ieae1330767a6e55e62437f5f988a0d33b727b5de
Gerrit-Change-Number: 37819
Gerrit-PatchSet: 15
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 02 Sep 2024 14:39:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>
Attention is currently required from: daniel, fixeria, laforge.
pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37956?usp=email )
Change subject: StatsD_Checker: Allow building and running without VTY support
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
> mh, sadly gerrit is unable to display the changes as the file is renamed in the same commit that als […]
I had it split initially but finally decided to merge it together since I was anyway changing quite a lot of stuff in StatsD_Checker. I'll try to split again.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37956?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I5421c76e4f303fd16d4db945a1c69910e40ac820
Gerrit-Change-Number: 37956
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 02 Sep 2024 14:18:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Attention is currently required from: osmith.
pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/37976?usp=email )
Change subject: jobs/{master,gerrit}: rpi4-raspbian11 -> raspbian
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
> I'm not sure why dropping the 11 or 12 from the name is good here, but ok.
Ah it's a label, I see nevermind.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/37976?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: I02dcf3098ffd3fa247c4f43c290d6e3fd809ad45
Gerrit-Change-Number: 37976
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 02 Sep 2024 13:58:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Attention is currently required from: osmith.
pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/37976?usp=email )
Change subject: jobs/{master,gerrit}: rpi4-raspbian11 -> raspbian
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
Patchset:
PS1:
I'm not sure why dropping the 11 or 12 from the name is good here, but ok.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/37976?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: I02dcf3098ffd3fa247c4f43c290d6e3fd809ad45
Gerrit-Change-Number: 37976
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 02 Sep 2024 13:57:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Attention is currently required from: osmith.
pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/37975?usp=email )
Change subject: jobs/{gerrit,master,update-osmo-ci}: add aarch64 case
......................................................................
Patch Set 1:
(1 comment)
File jobs/gerrit-verifications.yml:
https://gerrit.osmocom.org/c/osmo-ci/+/37975/comment/52513662_e0a6ed89?usp=… :
PS1, Line 181: arm*|aarch64) DOCKER_IMG="$DOCKER_IMG-arm" ;;
didn't you just change this docker image in the previous commit to always pull an arm32?
--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/37975?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: Iaf987d05870d842cd297f5f14c8542bf75835414
Gerrit-Change-Number: 37975
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 02 Sep 2024 13:56:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No