September 2024 - gerrit-log - lists.osmocom.org

[S] Change in osmo-ttcn3-hacks[master]: library/s1ap: comment out optional IE in tr_S1AP_InitialCtxSetupResp

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38277?usp=email ) Change subject: library/s1ap: comment out optional IE in tr_S1AP_InitialCtxSetupResp ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38277?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I4765036be69ff10adb8c510d4092834c4e923229 Gerrit-Change-Number: 38277 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 26 Sep 2024 21:26:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

9 months

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: library/s1ap: add templates for INITIAL CONTEXT SETUP

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38275?usp=email ) Change subject: library/s1ap: add templates for INITIAL CONTEXT SETUP ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38275?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I249e34ce91c874d4b6628d367672b58a77da041e Gerrit-Change-Number: 38275 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 26 Sep 2024 21:26:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

9 months

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: library/s1ap: fix wrong IDs in {ts,tr}_S1AP_InitialCtxSetupResp

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38276?usp=email ) Change subject: library/s1ap: fix wrong IDs in {ts,tr}_S1AP_InitialCtxSetupResp ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38276?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I752f202e891f7f6ff4f8f33b56de90c99c4ab456 Gerrit-Change-Number: 38276 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 26 Sep 2024 21:26:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

9 months

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: library/s1ap: add templates for INITIAL CONTEXT SETUP

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38275?usp=email ) Change subject: library/s1ap: add templates for INITIAL CONTEXT SETUP ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38275?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I249e34ce91c874d4b6628d367672b58a77da041e Gerrit-Change-Number: 38275 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 26 Sep 2024 21:25:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

9 months

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: s1gw: f_ConnHdlr_rx_erab_release_cmd(): fix wrong template

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38216?usp=email ) ( 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: s1gw: f_ConnHdlr_rx_erab_release_cmd(): fix wrong template ...................................................................... s1gw: f_ConnHdlr_rx_erab_release_cmd(): fix wrong template Change-Id: Ib6b9f346216aaa9587025e1c580876611e6fa7bc --- M s1gw/S1GW_ConnHdlr.ttcn 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/s1gw/S1GW_ConnHdlr.ttcn b/s1gw/S1GW_ConnHdlr.ttcn index 2833ce1..e4dc35b 100644 --- a/s1gw/S1GW_ConnHdlr.ttcn +++ b/s1gw/S1GW_ConnHdlr.ttcn @@ -422,7 +422,7 @@ for (var integer i := 0; i < lengthof(erabs); i := i + 1) { var template (present) E_RABItem item; - item := ts_E_RABItem(erabs[i].erab_id, cause); + item := tr_E_RABItem(erabs[i].erab_id, cause); items[i] := tr_E_RABList(item)[0]; } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38216?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ib6b9f346216aaa9587025e1c580876611e6fa7bc Gerrit-Change-Number: 38216 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

9 months

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: s1gw: add TC_e_rab_release_ind

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38217?usp=email ) ( 3 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: s1gw: add TC_e_rab_release_ind ...................................................................... s1gw: add TC_e_rab_release_ind Change-Id: Icc28a596b7646441761cc3f56653c5f7b3ddaaca --- M s1gw/S1GW_ConnHdlr.ttcn M s1gw/S1GW_Tests.ttcn M s1gw/expected-results.xml 3 files changed, 95 insertions(+), 18 deletions(-) Approvals: laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/s1gw/S1GW_ConnHdlr.ttcn b/s1gw/S1GW_ConnHdlr.ttcn index e4dc35b..a37cdd7 100644 --- a/s1gw/S1GW_ConnHdlr.ttcn +++ b/s1gw/S1GW_ConnHdlr.ttcn @@ -394,11 +394,9 @@ return pdu; } -function f_ConnHdlr_tx_erab_release_cmd(in ERabList erabs, - S1AP_IEs.Cause cause := c_REL_CMD_CAUSE, - MME_UE_S1AP_ID mme_ue_id := c_MME_UE_ID) -runs on ConnHdlr { - var ENB_UE_S1AP_ID enb_ue_id := g_pars.idx; +private function f_ts_E_RABList(in ERabList erabs, + S1AP_IEs.Cause cause) +return template (value) E_RABList { var template (value) E_RABList items; for (var integer i := 0; i < lengthof(erabs); i := i + 1) { @@ -408,16 +406,12 @@ items[i] := ts_E_RABList(item)[0]; } - f_ConnHdlr_tx_s1ap_from_mme(ts_S1AP_RABReleaseCmd(mme_ue_id, enb_ue_id, items)); + return items; } - -function f_ConnHdlr_rx_erab_release_cmd(in ERabList erabs, - S1AP_IEs.Cause cause := c_REL_CMD_CAUSE, - MME_UE_S1AP_ID mme_ue_id := c_MME_UE_ID) -runs on ConnHdlr return S1AP_PDU { - var ENB_UE_S1AP_ID enb_ue_id := g_pars.idx; +private function f_tr_E_RABList(in ERabList erabs, + S1AP_IEs.Cause cause) +return template (present) E_RABList { var template (present) E_RABList items; - var S1AP_PDU pdu; for (var integer i := 0; i < lengthof(erabs); i := i + 1) { var template (present) E_RABItem item; @@ -426,10 +420,53 @@ items[i] := tr_E_RABList(item)[0]; } + return items; +} + +function f_ConnHdlr_tx_erab_release_cmd(in ERabList erabs, + S1AP_IEs.Cause cause := c_REL_CMD_CAUSE, + MME_UE_S1AP_ID mme_ue_id := c_MME_UE_ID) +runs on ConnHdlr { + var template (value) E_RABList items := f_ts_E_RABList(erabs, cause); + var ENB_UE_S1AP_ID enb_ue_id := g_pars.idx; + + f_ConnHdlr_tx_s1ap_from_mme(ts_S1AP_RABReleaseCmd(mme_ue_id, enb_ue_id, items)); +} + +function f_ConnHdlr_rx_erab_release_cmd(in ERabList erabs, + S1AP_IEs.Cause cause := c_REL_CMD_CAUSE, + MME_UE_S1AP_ID mme_ue_id := c_MME_UE_ID) +runs on ConnHdlr return S1AP_PDU { + var template (present) E_RABList items := f_tr_E_RABList(erabs, cause); + var ENB_UE_S1AP_ID enb_ue_id := g_pars.idx; + var S1AP_PDU pdu; + f_ConnHdlr_rx_s1ap_from_mme(pdu, tr_S1AP_RABReleaseCmd(mme_ue_id, enb_ue_id, items)); return pdu; } +function f_ConnHdlr_tx_erab_release_ind(in ERabList erabs, + S1AP_IEs.Cause cause := c_REL_CMD_CAUSE, + MME_UE_S1AP_ID mme_ue_id := c_MME_UE_ID) +runs on ConnHdlr { + var template (value) E_RABList items := f_ts_E_RABList(erabs, cause); + var ENB_UE_S1AP_ID enb_ue_id := g_pars.idx; + + f_ConnHdlr_tx_s1ap_from_enb(ts_S1AP_RABReleaseInd(mme_ue_id, enb_ue_id, items)); +} + +function f_ConnHdlr_rx_erab_release_ind(in ERabList erabs, + S1AP_IEs.Cause cause := c_REL_CMD_CAUSE, + MME_UE_S1AP_ID mme_ue_id := c_MME_UE_ID) +runs on ConnHdlr return S1AP_PDU { + var template (present) E_RABList items := f_tr_E_RABList(erabs, cause); + var ENB_UE_S1AP_ID enb_ue_id := g_pars.idx; + var S1AP_PDU pdu; + + f_ConnHdlr_rx_s1ap_from_enb(pdu, tr_S1AP_RABReleaseInd(mme_ue_id, enb_ue_id, items)); + return pdu; +} + function f_ConnHdlr_rx_session_establish_req(in ERab erab) runs on ConnHdlr return PDU_PFCP { var OCT4 addr := f_inet_addr(g_pars.pfcp_rem_addr); @@ -604,10 +641,8 @@ f_ConnHdlr_rx_erab_setup_rsp(erabs); } -function f_ConnHdlr_erab_release_cmd(inout ERabList erabs, - S1AP_IEs.Cause cause := c_REL_CMD_CAUSE) +private function f_ConnHdlr_session_delete(inout ERabList erabs) runs on ConnHdlr { - f_ConnHdlr_tx_erab_release_cmd(erabs, cause); for (var integer i := 0; i < lengthof(erabs); i := i + 1) { log("UPF <- S1GW: PFCP Session Deletion Request for E-RAB ID ", erabs[i].erab_id); var PDU_PFCP pdu := f_ConnHdlr_rx_session_delete_req(erabs[i]); @@ -616,7 +651,24 @@ /* ask PFCPEM to *not* route PDUs with this SEID to us */ f_PFCPEM_unsubscribe_seid(erabs[i].pfcp_loc_seid); } +} + +function f_ConnHdlr_erab_release_cmd(inout ERabList erabs, + S1AP_IEs.Cause cause := c_REL_CMD_CAUSE) +runs on ConnHdlr { + f_ConnHdlr_tx_erab_release_cmd(erabs, cause); + f_ConnHdlr_session_delete(erabs); f_ConnHdlr_rx_erab_release_cmd(erabs, cause); } +function f_ConnHdlr_erab_release_ind(inout ERabList erabs, + S1AP_IEs.Cause cause := c_REL_CMD_CAUSE) +runs on ConnHdlr { + log("[eNB -> S1GW] -> MME: E-RAB RELEASE INDICATION"); + f_ConnHdlr_tx_erab_release_ind(erabs, cause); + f_ConnHdlr_session_delete(erabs); + log("eNB -> [S1GW -> MME]: E-RAB RELEASE INDICATION"); + f_ConnHdlr_rx_erab_release_ind(erabs, cause); +} + } diff --git a/s1gw/S1GW_Tests.ttcn b/s1gw/S1GW_Tests.ttcn index 940944a..8a259d3 100644 --- a/s1gw/S1GW_Tests.ttcn +++ b/s1gw/S1GW_Tests.ttcn @@ -299,7 +299,7 @@ vc_conn.done; } -/* Test E-RAB SETUP [and RELEASE] procedures */ +/* Test E-RAB SETUP and RELEASE.cmd procedures */ function f_TC_e_rab_setup(charstring id) runs on ConnHdlr { f_ConnHdlr_s1ap_register(g_pars.genb_id); f_ConnHdlr_s1ap_connect(mp_enb_bind_ip, mp_s1gw_enb_ip); @@ -342,6 +342,29 @@ f_TC_e_rab_setup_exec(num_enbs := mp_multi_enb_num, num_erabs := 3); } +/* Test E-RAB SETUP and RELEASE.ind procedures */ +function f_TC_e_rab_release_ind(charstring id) runs on ConnHdlr { + f_ConnHdlr_s1ap_register(g_pars.genb_id); + f_ConnHdlr_s1ap_connect(mp_enb_bind_ip, mp_s1gw_enb_ip); + f_ConnHdlr_s1ap_setup(g_pars.genb_id); + + f_ConnHdlr_erab_setup_req(g_pars.erabs); + f_ConnHdlr_erab_setup_rsp(g_pars.erabs); + f_ConnHdlr_erab_release_ind(g_pars.erabs); + + f_ConnHdlr_s1ap_disconnect(); + f_ConnHdlr_s1ap_unregister(g_pars.genb_id); +} +testcase TC_e_rab_release_ind() runs on test_CT { + var ConnHdlrPars pars := valueof(t_ConnHdlrPars); + var ConnHdlr vc_conn; + + f_init(); + + vc_conn := f_ConnHdlr_spawn(refers(f_TC_e_rab_release_ind), pars); + vc_conn.done; +} + function f_TC_pfcp_heartbeat(charstring id) runs on ConnHdlr { var integer rts := f_PFCPEM_get_recovery_timestamp(); var PDU_PFCP pfcp_pdu; @@ -374,6 +397,7 @@ execute( TC_e_rab_setup3() ); execute( TC_e_rab_setup_multi() ); execute( TC_e_rab_setup3_multi() ); + execute( TC_e_rab_release_ind() ); execute( TC_pfcp_heartbeat() ); } diff --git a/s1gw/expected-results.xml b/s1gw/expected-results.xml index 99a75d5..9075dc3 100644 --- a/s1gw/expected-results.xml +++ b/s1gw/expected-results.xml @@ -1,5 +1,5 @@ <?xml version="1.0"?> -<testsuite name='S1GW_Tests' tests='9' failures='0' errors='0' skipped='0' inconc='0' time='MASKED'> +<testsuite name='S1GW_Tests' tests='10' failures='0' errors='0' skipped='0' inconc='0' time='MASKED'> <testcase classname='S1GW_Tests' name='TC_setup' time='MASKED'/> <testcase classname='S1GW_Tests' name='TC_setup_multi' time='MASKED'/> <testcase classname='S1GW_Tests' name='TC_conn_term_by_mme' time='MASKED'/> @@ -8,5 +8,6 @@ <testcase classname='S1GW_Tests' name='TC_e_rab_setup3' time='MASKED'/> <testcase classname='S1GW_Tests' name='TC_e_rab_setup_multi' time='MASKED'/> <testcase classname='S1GW_Tests' name='TC_e_rab_setup3_multi' time='MASKED'/> + <testcase classname='S1GW_Tests' name='TC_e_rab_release_ind' time='MASKED'/> <testcase classname='S1GW_Tests' name='TC_pfcp_heartbeat' time='MASKED'/> </testsuite> -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38217?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Icc28a596b7646441761cc3f56653c5f7b3ddaaca Gerrit-Change-Number: 38217 Gerrit-PatchSet: 5 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

9 months

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: s1gw: f_ConnHdlr_erab_release_cmd(): add missing logging

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38236?usp=email ) ( 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: s1gw: f_ConnHdlr_erab_release_cmd(): add missing logging ...................................................................... s1gw: f_ConnHdlr_erab_release_cmd(): add missing logging Change-Id: I6e4574ebda2459f0a5f23ee51a21a883d079c54a --- M s1gw/S1GW_ConnHdlr.ttcn 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/s1gw/S1GW_ConnHdlr.ttcn b/s1gw/S1GW_ConnHdlr.ttcn index a37cdd7..a3d2aec 100644 --- a/s1gw/S1GW_ConnHdlr.ttcn +++ b/s1gw/S1GW_ConnHdlr.ttcn @@ -656,8 +656,10 @@ function f_ConnHdlr_erab_release_cmd(inout ERabList erabs, S1AP_IEs.Cause cause := c_REL_CMD_CAUSE) runs on ConnHdlr { + log("eNB <- [S1GW <- MME]: E-RAB RELEASE COMMAND"); f_ConnHdlr_tx_erab_release_cmd(erabs, cause); f_ConnHdlr_session_delete(erabs); + log("[eNB <- S1GW] <- MME: E-RAB RELEASE COMMAND"); f_ConnHdlr_rx_erab_release_cmd(erabs, cause); } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38236?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I6e4574ebda2459f0a5f23ee51a21a883d079c54a Gerrit-Change-Number: 38236 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

9 months

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: library/s1ap: fix wrong IE ID in E-RABReleaseListBearerRelComp

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38237?usp=email ) ( 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: library/s1ap: fix wrong IE ID in E-RABReleaseListBearerRelComp ...................................................................... library/s1ap: fix wrong IE ID in E-RABReleaseListBearerRelComp Change-Id: I22e80f418787c10ccd002e30a329c0271cdd1b8a Fixes: e59e681c "library/s1ap: add E-RAB RELEASE templates" --- M library/s1ap/S1AP_Templates.ttcn 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve diff --git a/library/s1ap/S1AP_Templates.ttcn b/library/s1ap/S1AP_Templates.ttcn index 4f0b5ee..dca5844 100644 --- a/library/s1ap/S1AP_Templates.ttcn +++ b/library/s1ap/S1AP_Templates.ttcn @@ -1411,7 +1411,7 @@ template (value) E_RABReleaseListBearerRelComp ts_E_RABReleaseListBearerRelComp(template (value) E_RABReleaseItemBearerRelComp it) := { { - id := S1AP_Constants.id_E_RABReleaseListBearerRelComp, + id := S1AP_Constants.id_E_RABReleaseItemBearerRelComp, criticality := ignore, value_ := { E_RABReleaseItemBearerRelComp := it } } @@ -1419,7 +1419,7 @@ template (present) E_RABReleaseListBearerRelComp tr_E_RABReleaseListBearerRelComp(template (present) E_RABReleaseItemBearerRelComp it := ?) := { { - id := S1AP_Constants.id_E_RABReleaseListBearerRelComp, + id := S1AP_Constants.id_E_RABReleaseItemBearerRelComp, criticality := ignore, value_ := { E_RABReleaseItemBearerRelComp := it } } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38237?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I22e80f418787c10ccd002e30a329c0271cdd1b8a Gerrit-Change-Number: 38237 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

9 months

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: library/s1ap: fix wrong field in S1AP-RABReleaseInd

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38243?usp=email ) ( 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: library/s1ap: fix wrong field in S1AP-RABReleaseInd ...................................................................... library/s1ap: fix wrong field in S1AP-RABReleaseInd Change-Id: I7a24b6401a19a6e37392083b26657bcb45b35cbe Fixes: e59e681c "library/s1ap: add E-RAB RELEASE templates" --- M library/s1ap/S1AP_Templates.ttcn 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/library/s1ap/S1AP_Templates.ttcn b/library/s1ap/S1AP_Templates.ttcn index dca5844..cd99ce2 100644 --- a/library/s1ap/S1AP_Templates.ttcn +++ b/library/s1ap/S1AP_Templates.ttcn @@ -1325,7 +1325,7 @@ procedureCode := S1AP_Constants.id_E_RABReleaseIndication, criticality := reject, value_ := { - e_RABReleaseCommand := { + e_RABReleaseIndication := { protocolIEs := { { id := S1AP_Constants.id_MME_UE_S1AP_ID, @@ -1353,7 +1353,7 @@ procedureCode := S1AP_Constants.id_E_RABReleaseIndication, criticality := reject, value_ := { - e_RABReleaseCommand := { + e_RABReleaseIndication := { protocolIEs := { { id := S1AP_Constants.id_MME_UE_S1AP_ID, -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38243?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I7a24b6401a19a6e37392083b26657bcb45b35cbe Gerrit-Change-Number: 38243 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

9 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: s1gw: make number of eNBs configurable via module params

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38210?usp=email ) Change subject: s1gw: make number of eNBs configurable via module params ...................................................................... s1gw: make number of eNBs configurable via module params ... so that we can scale the number of eNBs simulated in the *_multi TCs without having to touch and compile code. Change-Id: Ia80b9118e66a5d6721b89d3ba068227d30dcc01f --- M s1gw/S1GW_Tests.ttcn 1 file changed, 6 insertions(+), 5 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/s1gw/S1GW_Tests.ttcn b/s1gw/S1GW_Tests.ttcn index 1f94477..2090478 100644 --- a/s1gw/S1GW_Tests.ttcn +++ b/s1gw/S1GW_Tests.ttcn @@ -55,6 +55,8 @@ charstring mp_local_statsd_ip := "127.0.4.10"; integer mp_local_statsd_port := 8125; charstring mp_statsd_prefix := "s1gw."; + + integer mp_multi_enb_num := 42; /* number of eNBs in _multi TCs */ } type component test_CT extends StatsD_Checker_CT { @@ -215,17 +217,16 @@ f_ConnHdlr_s1ap_unregister(g_pars.genb_id); } testcase TC_setup_multi() runs on test_CT { - var ConnHdlrList vc_conns := { }; + var ConnHdlrList vc_conns; f_init(); - for (var integer i := 0; i < 42; i := i + 1) { + for (var integer i := 0; i < mp_multi_enb_num; i := i + 1) { var ConnHdlrPars pars := valueof(t_ConnHdlrPars(i)); - var ConnHdlr vc_conn := f_ConnHdlr_spawn(refers(f_TC_setup_multi), pars); - vc_conns := vc_conns & { vc_conn }; + vc_conns[i] := f_ConnHdlr_spawn(refers(f_TC_setup_multi), pars); } - for (var integer i := 0; i < 42; i := i + 1) { + for (var integer i := 0; i < mp_multi_enb_num; i := i + 1) { vc_conns[i].done; } } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38210?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia80b9118e66a5d6721b89d3ba068227d30dcc01f Gerrit-Change-Number: 38210 Gerrit-PatchSet: 5 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de>

9 months

1
0
0 0

2025

2024

2023

2022

gerrit-log September 2024