September 2024 - gerrit-log - lists.osmocom.org

[M] Change in ...osmo-s1gw[master]: s1ap_proxy: Support replying errors

by pespin

Attention is currently required from: fixeria, lynxis lazus. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37924?usp=email ) Change subject: s1ap_proxy: Support replying errors ...................................................................... Patch Set 4: (1 comment) Patchset: PS4: > And yet this continues blocked here. And yet another week passed with this commit blocked. -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37924?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I242e84fb09b00f4794b6e1aa770f348a0e60aea4 Gerrit-Change-Number: 37924 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Thu, 12 Sep 2024 14:02:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

9 months, 2 weeks

1
0
0 0

[XS] Change in docker-playground[master]: debian-buster-jenkins: remove pysim

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/38123?usp=email ) Change subject: debian-buster-jenkins: remove pysim ...................................................................... debian-buster-jenkins: remove pysim This container is still used for osmo-gsm-tester_virtual (OS#6126). pysim doesn't build anymore for some reason since the new dependency on pyosmocom was added to it. Since we don't use pysim in osmo-gsm-tester, simply don't install it in this container anymore. Change-Id: I89f667fe5603526d9f0118fc338745aab8273070 --- M debian-buster-jenkins/Dockerfile 1 file changed, 0 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/23/38123/1 diff --git a/debian-buster-jenkins/Dockerfile b/debian-buster-jenkins/Dockerfile index baa5931..44c382d 100644 --- a/debian-buster-jenkins/Dockerfile +++ b/debian-buster-jenkins/Dockerfile @@ -152,8 +152,6 @@ 'sphinx' \ 'sphinxcontrib-napoleon' \ 'swig' -ADD https://gitea.osmocom.org/sim-card/pysim/raw/branch/master/requirements.txt /tmp/pysim_requirements.txt -RUN pip3 install -r /tmp/pysim_requirements.txt # match the outside user RUN useradd --uid=1000 build -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/38123?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I89f667fe5603526d9f0118fc338745aab8273070 Gerrit-Change-Number: 38123 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

9 months, 2 weeks

1
0
0 0

[XS] Change in osmo-msc[master]: vlr.c: drop unused header limits.h

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/38104?usp=email ) Change subject: vlr.c: drop unused header limits.h ...................................................................... vlr.c: drop unused header limits.h Change-Id: I12a326e506551e97cb7d608dd16b28662a94927f --- M src/libvlr/vlr.c 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved laforge: Looks good to me, but someone else must approve diff --git a/src/libvlr/vlr.c b/src/libvlr/vlr.c index cb5794f..2140d25 100644 --- a/src/libvlr/vlr.c +++ b/src/libvlr/vlr.c @@ -40,7 +40,6 @@ #include <netinet/in.h> #include <arpa/inet.h> -#include <limits.h> #include <errno.h> #include "vlr_core.h" -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/38104?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I12a326e506551e97cb7d608dd16b28662a94927f Gerrit-Change-Number: 38104 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

9 months, 2 weeks

1
0
0 0

[XS] Change in osmo-msc[master]: vlr.h: remove unused ran_conn out of the header

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/38103?usp=email ) Change subject: vlr.h: remove unused ran_conn out of the header ...................................................................... vlr.h: remove unused ran_conn out of the header The ran_conn isn't used at all by the VLR Change-Id: I247d636d835c09f7a7b66dee52eb8608aa358815 --- M include/osmocom/msc/vlr.h M src/libmsc/msc_a.c M src/libmsc/msc_ho.c M src/libmsc/msc_vgcs.c M src/libmsc/msub.c 5 files changed, 4 insertions(+), 1 deletion(-) Approvals: laforge: Looks good to me, but someone else must approve pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/include/osmocom/msc/vlr.h b/include/osmocom/msc/vlr.h index a7707fd..562b30f 100644 --- a/include/osmocom/msc/vlr.h +++ b/include/osmocom/msc/vlr.h @@ -13,7 +13,6 @@ #include <osmocom/gsm/gsm0808.h> #include <osmocom/gsm/gsup.h> #include <osmocom/gsm/ipa.h> -#include <osmocom/msc/ran_conn.h> #include <osmocom/msc/msc_common.h> #include <osmocom/gsupclient/gsup_client.h> #include <osmocom/msc/vlr_sgs.h> diff --git a/src/libmsc/msc_a.c b/src/libmsc/msc_a.c index 2e88a32..59f1a57 100644 --- a/src/libmsc/msc_a.c +++ b/src/libmsc/msc_a.c @@ -37,6 +37,7 @@ #include <osmocom/msc/vlr.h> #include <osmocom/msc/transaction.h> #include <osmocom/msc/transaction_cc.h> +#include <osmocom/msc/ran_conn.h> #include <osmocom/msc/ran_peer.h> #include <osmocom/msc/ran_msg_a.h> #include <osmocom/msc/ran_msg_iu.h> diff --git a/src/libmsc/msc_ho.c b/src/libmsc/msc_ho.c index 54a959d..cea658c 100644 --- a/src/libmsc/msc_ho.c +++ b/src/libmsc/msc_ho.c @@ -23,6 +23,7 @@ #include <osmocom/sigtran/sccp_helpers.h> #include <osmocom/msc/msc_ho.h> +#include <osmocom/msc/ran_conn.h> #include <osmocom/msc/ran_msg.h> #include <osmocom/msc/msc_a.h> #include <osmocom/msc/msc_i.h> diff --git a/src/libmsc/msc_vgcs.c b/src/libmsc/msc_vgcs.c index 264fa49..4660a2c 100644 --- a/src/libmsc/msc_vgcs.c +++ b/src/libmsc/msc_vgcs.c @@ -86,6 +86,7 @@ #include <osmocom/msc/gsm_data.h> #include <osmocom/msc/sccp_ran.h> +#include <osmocom/msc/ran_conn.h> #include <osmocom/msc/ran_infra.h> #include <osmocom/msc/ran_peer.h> #include <osmocom/msc/ran_msg_a.h> diff --git a/src/libmsc/msub.c b/src/libmsc/msub.c index ac93665..8df8d26 100644 --- a/src/libmsc/msub.c +++ b/src/libmsc/msub.c @@ -28,6 +28,7 @@ #include <osmocom/msc/msc_a.h> #include <osmocom/msc/msc_i.h> #include <osmocom/msc/msc_t.h> +#include <osmocom/msc/ran_conn.h> #include <osmocom/msc/vlr.h> #include <osmocom/msc/e_link.h> -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/38103?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I247d636d835c09f7a7b66dee52eb8608aa358815 Gerrit-Change-Number: 38103 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

9 months, 2 weeks

1
0
0 0

[XS] Change in osmo-msc[master]: vlr_auth_fsm.h/vlr_sgs_fsm.h: forward declare struct vlr_subscr

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/38105?usp=email ) Change subject: vlr_auth_fsm.h/vlr_sgs_fsm.h: forward declare struct vlr_subscr ...................................................................... vlr_auth_fsm.h/vlr_sgs_fsm.h: forward declare struct vlr_subscr Make the headers self-contained to not depend on the include order. Change-Id: I0985b60ed252c37663b945eed939519d17c4c985 --- M src/libvlr/vlr_auth_fsm.h M src/libvlr/vlr_sgs_fsm.h 2 files changed, 4 insertions(+), 0 deletions(-) Approvals: pespin: Looks good to me, approved laforge: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/libvlr/vlr_auth_fsm.h b/src/libvlr/vlr_auth_fsm.h index 8283842..441a8ca 100644 --- a/src/libvlr/vlr_auth_fsm.h +++ b/src/libvlr/vlr_auth_fsm.h @@ -2,6 +2,8 @@ #include <osmocom/core/utils.h> +struct vlr_subscr; + /* Parameters to VLR_AUTH_E_MS_AUTH_RESP */ struct vlr_auth_resp_par { bool is_r99; diff --git a/src/libvlr/vlr_sgs_fsm.h b/src/libvlr/vlr_sgs_fsm.h index 94f202b..6a09433 100644 --- a/src/libvlr/vlr_sgs_fsm.h +++ b/src/libvlr/vlr_sgs_fsm.h @@ -20,6 +20,8 @@ #pragma once +struct vlr_subscr; + enum sgs_ue_fsm_event { SGS_UE_E_VLR_FAILURE, SGS_UE_E_RX_RESET_FROM_MME, -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/38105?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I0985b60ed252c37663b945eed939519d17c4c985 Gerrit-Change-Number: 38105 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

9 months, 2 weeks

1
0
0 0

[XS] Change in osmo-msc[master]: libvlr/vlr: remove gsm_subscriber.h

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/38106?usp=email ) Change subject: libvlr/vlr: remove gsm_subscriber.h ...................................................................... libvlr/vlr: remove gsm_subscriber.h There is no need for gsm_subscriber.h except its include of osmocom/core/stats.h Change-Id: I8e1839d0be0a04deba639f267f14ffc3d5ccc42b --- M src/libvlr/vlr.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: laforge: Looks good to me, but someone else must approve pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/libvlr/vlr.c b/src/libvlr/vlr.c index 2140d25..db4156f 100644 --- a/src/libvlr/vlr.c +++ b/src/libvlr/vlr.c @@ -21,6 +21,7 @@ #include <osmocom/core/linuxlist.h> #include <osmocom/core/fsm.h> +#include <osmocom/core/stats.h> #include <osmocom/core/utils.h> #include <osmocom/core/timer.h> #include <osmocom/core/tdef.h> @@ -30,7 +31,6 @@ #include <osmocom/gsm/apn.h> #include <osmocom/gsm/gsm48.h> #include <osmocom/gsm/ipa.h> -#include <osmocom/msc/gsm_subscriber.h> #include <osmocom/gsupclient/gsup_client.h> #include <osmocom/msc/vlr_sgs.h> #include <osmocom/msc/vlr.h> -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/38106?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I8e1839d0be0a04deba639f267f14ffc3d5ccc42b Gerrit-Change-Number: 38106 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

9 months, 2 weeks

1
0
0 0

[M] Change in osmo-msc[master]: Move vlr.h & vlr_sgs.h into osmocom/vlr/

by pespin

Attention is currently required from: lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-msc/+/38111?usp=email ) Change subject: Move vlr.h & vlr_sgs.h into osmocom/vlr/ ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/38111?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I8b18b05091b35e744b3234d1ce0d537f56bccf07 Gerrit-Change-Number: 38111 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Thu, 12 Sep 2024 14:01:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

9 months, 2 weeks

1
0
0 0

[XS] Change in osmo-msc[master]: libvlr: use correct log facility within the VLR

by pespin

Attention is currently required from: lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-msc/+/38110?usp=email ) Change subject: libvlr: use correct log facility within the VLR ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/38110?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ia3170c3fe48402ab01bf994fd8d3fa8eec699647 Gerrit-Change-Number: 38110 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Thu, 12 Sep 2024 14:00:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

9 months, 2 weeks

1
0
0 0

[XS] Change in osmo-msc[master]: libvlr: fix tab/space issue

by pespin

Attention is currently required from: lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-msc/+/38109?usp=email ) Change subject: libvlr: fix tab/space issue ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/38109?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I7f831e7ee0014a2241a69f7c75f2c6404bbb7087 Gerrit-Change-Number: 38109 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Thu, 12 Sep 2024 14:00:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

9 months, 2 weeks

1
0
0 0

[XS] Change in osmo-msc[master]: msc/gsup_client_mux.h: remove include of itself

by pespin

Attention is currently required from: lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-msc/+/38108?usp=email ) Change subject: msc/gsup_client_mux.h: remove include of itself ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/38108?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I89ffdb98e98133bd28023a19076f3a5f02e520d2 Gerrit-Change-Number: 38108 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Thu, 12 Sep 2024 14:00:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

9 months, 2 weeks

1
0
0 0

2025

2024

2023

2022

gerrit-log September 2024