Attention is currently required from: daniel, fixeria, laforge, lynxis lazus.
pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37892?usp=email )
Change subject: mme: expect authentication during 2g->4G TAU procedure
......................................................................
Patch Set 3:
(1 comment)
File library/NAS_Templates.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37892/comment/b3d36829_7f3b… :
PS3, Line 1302: }
> Why adding this? I don't see any new types being added here, which would require the RAW codec. […]
Otherwise it fails with related error. I think it's because of the LENGHTOF stuff in the type of UENetworkCapabilityLV.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37892?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I5ebcaf23a643b6cb97534328737257d26d3981fe
Gerrit-Change-Number: 37892
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Wed, 21 Aug 2024 21:44:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/37875?usp=email )
Change subject: tests/mgcp/mgcp_test: Add some extra asserts in code
......................................................................
tests/mgcp/mgcp_test: Add some extra asserts in code
This makes it easier to catch possible failures while running the test,
plus makes gcc on OpenSUSE_Factory happy and not warn.
Related: OS#5044
Change-Id: I01c3c84e58a11055f0e0a6955016dc2489c73379
---
M tests/mgcp/mgcp_test.c
1 file changed, 2 insertions(+), 0 deletions(-)
Approvals:
osmith: Looks good to me, but someone else must approve
Jenkins Builder: Verified
fixeria: Looks good to me, approved
diff --git a/tests/mgcp/mgcp_test.c b/tests/mgcp/mgcp_test.c
index 21be037..de359d5 100644
--- a/tests/mgcp/mgcp_test.c
+++ b/tests/mgcp/mgcp_test.c
@@ -1208,7 +1208,9 @@
_conn =
mgcp_conn_alloc(NULL, &endp, MGCP_CONN_TYPE_RTP,
"test-connection");
+ OSMO_ASSERT(_conn);
conn = mgcp_conn_get_rtp(&endp, _conn->id);
+ OSMO_ASSERT(conn);
state = &conn->state;
packets_rx = rate_ctr_group_get_ctr(conn->ctrg, RTP_PACKETS_RX_CTR);
--
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/37875?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: I01c3c84e58a11055f0e0a6955016dc2489c73379
Gerrit-Change-Number: 37875
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Attention is currently required from: daniel, laforge, lynxis lazus, pespin.
fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37892?usp=email )
Change subject: mme: expect authentication during 2g->4G TAU procedure
......................................................................
Patch Set 3: Code-Review+1
(1 comment)
File library/NAS_Templates.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37892/comment/9a6aedef_f1a7… :
PS3, Line 1302: }
Why adding this? I don't see any new types being added here, which would require the RAW codec. You're just adding new templates...
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37892?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I5ebcaf23a643b6cb97534328737257d26d3981fe
Gerrit-Change-Number: 37892
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Wed, 21 Aug 2024 20:14:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Attention is currently required from: dexter.
fixeria has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/37821?usp=email )
Change subject: tests: move unittests into a sub directory
......................................................................
Patch Set 5: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/37821?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I0978c5353d0d479a050bbb6e7ae5a63db5e08d24
Gerrit-Change-Number: 37821
Gerrit-PatchSet: 5
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 21 Aug 2024 20:10:44 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: dexter, laforge.
fixeria has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/37839?usp=email )
Change subject: pySim-shell: prevent opening/closing logical channel 0
......................................................................
Patch Set 4:
(1 comment)
File pySim-shell.py:
https://gerrit.osmocom.org/c/pysim/+/37839/comment/821461ed_fe9c1710?usp=em… :
PS4, Line 968: choices=range(1,4),
(just to be sure) the new value range is `[1, 2, 3]` (excluding `4`), correct?
Looking at the code (specifically `lchan_nr_to_cla()`), I see that 0..3 is the "standard logical channel number" and 4..16 is the "extended logical channel number". Do you permit only the standard one for a reason?
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/37839?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I4eebd9f15fadd18e1caeb033fda36c59446fcab8
Gerrit-Change-Number: 37839
Gerrit-PatchSet: 4
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 21 Aug 2024 20:03:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: dexter.
fixeria has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/37838?usp=email )
Change subject: pySim-shell: fix CardKeyProvider for chv management commands
......................................................................
Patch Set 3: Code-Review-1
(2 comments)
File pySim-shell.py:
https://gerrit.osmocom.org/c/pysim/+/37838/comment/5fb50fcd_164719e4?usp=em… :
PS3, Line 868: verify_chv_parser.add_argument('PIN', nargs='?', type=is_decimal,
Why are you moving positional arguments before the optional `--pin-nr`? It's not critical, but makes the patch a bit harder to read. It also brings inconsistency, because below you keep it under the `--pin-nr`. I guess this also affects argument order in the help message?
https://gerrit.osmocom.org/c/pysim/+/37838/comment/f4d9ba02_bcb5f360?usp=em… :
PS3, Line 902: change_chv_parser.add_argument('NEWPIN', nargs='?', type=is_decimal,
You're breaking compatibility by changing the ordering here: currently it's `OLD NEW`, but your patch is changing it to `NEW OLD`. Let's keep the old (more logical, IMO) ordering to avoid breaking scripts for people. It's also inconsistent with `unblock_chv_parser`, where you have `PUK NEWPIN`.
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/37838?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I565b56ac608e801c67ca53d337bdec9efa3f3817
Gerrit-Change-Number: 37838
Gerrit-PatchSet: 3
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 21 Aug 2024 19:57:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Attention is currently required from: fixeria.
laforge has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/37849?usp=email )
Change subject: contrib/saip-tool: Add 'tree' command to display filesystem tree of profile
......................................................................
Patch Set 9: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/37849?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I5cda7ef814648543c63938ac6a4fb9dba79379ff
Gerrit-Change-Number: 37849
Gerrit-PatchSet: 9
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 21 Aug 2024 19:48:23 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: fixeria, laforge.
Hello Jenkins Builder, fixeria,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/pysim/+/37849?usp=email
to look at the new patch set (#9).
The following approvals got outdated and were removed:
Code-Review+2 by fixeria
The change is no longer submittable: Code-Review is unsatisfied now.
Change subject: contrib/saip-tool: Add 'tree' command to display filesystem tree of profile
......................................................................
contrib/saip-tool: Add 'tree' command to display filesystem tree of profile
Change-Id: I5cda7ef814648543c63938ac6a4fb9dba79379ff
---
M contrib/saip-tool.py
1 file changed, 6 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/49/37849/9
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/37849?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I5cda7ef814648543c63938ac6a4fb9dba79379ff
Gerrit-Change-Number: 37849
Gerrit-PatchSet: 9
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
