Attention is currently required from: lynxis lazus, pespin.
laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37892?usp=email )
Change subject: mme: expect authentication during 2g->4G TAU procedure
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37892/comment/22f025c9_e5c3… :
PS2, Line 9: If TAU happens with an existing security context, network for sure wants
without?
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37892?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I5ebcaf23a643b6cb97534328737257d26d3981fe
Gerrit-Change-Number: 37892
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Wed, 21 Aug 2024 16:54:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: daniel, lynxis lazus, pespin.
laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37890?usp=email )
Change subject: S1AP_Emulation: Fix new_ctx never set when building security header
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37890?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I76ad46f7ee5f49698e41da729cb6422866202951
Gerrit-Change-Number: 37890
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Wed, 21 Aug 2024 16:53:11 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: daniel, lynxis lazus.
Hello Jenkins Builder, daniel, lynxis lazus,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37890?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Code-Review+1 by daniel
Change subject: S1AP_Emulation: Fix new_ctx never set when building security header
......................................................................
S1AP_Emulation: Fix new_ctx never set when building security header
The flag was never set to true. It needs to be set to true when building
the security head of Security Mode Complete after receiving Security
Mode Command with a new EPS security context.
TS 24.301 5.4.3.3
Change-Id: I76ad46f7ee5f49698e41da729cb6422866202951
---
M library/S1AP_Emulation.ttcn
M mme/LTE_CryptoFunctions.ttcn
2 files changed, 12 insertions(+), 6 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/90/37890/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37890?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I76ad46f7ee5f49698e41da729cb6422866202951
Gerrit-Change-Number: 37890
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Attention is currently required from: daniel, lynxis lazus.
Hello Jenkins Builder, daniel, lynxis lazus,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37891?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Code-Review+1 by daniel
Change subject: S1AP_Emulation: Fix building security headers for Integrity and Ciphering
......................................................................
S1AP_Emulation: Fix building security headers for Integrity and Ciphering
The fact that the network instructs the UE to use EEA0 encryption (null
algo) doesn't mean the UE should mark the NAS frames in the security
header as non-ciphered. They need to be marked as IP+ciphered in the
outer header, and as plain in the inner one.
Now TTCN3 behaves like a UE recorded while executing a similar test
case. Moreover, wireshark is now happy decoding the messages.
Change-Id: Ifd4fe83e7b5aefdaafe7ce1c8b1ec6a67c65819c
---
M library/S1AP_Emulation.ttcn
M mme/LTE_CryptoFunctions.ttcn
M mme/MME_Tests.ttcn
3 files changed, 41 insertions(+), 18 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/91/37891/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37891?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ifd4fe83e7b5aefdaafe7ce1c8b1ec6a67c65819c
Gerrit-Change-Number: 37891
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Attention is currently required from: daniel, lynxis lazus.
pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37890?usp=email )
Change subject: S1AP_Emulation: Fix new_ctx never set when building security header
......................................................................
Patch Set 1:
(2 comments)
Commit Message:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37890/comment/21122f89_acf2… :
PS1, Line 10: recieving
> receiving
Done
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37890/comment/b718c81a_d7db… :
PS1, Line 10: secutiry
> security
Done
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37890?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I76ad46f7ee5f49698e41da729cb6422866202951
Gerrit-Change-Number: 37890
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Wed, 21 Aug 2024 16:38:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: daniel <dwillmann(a)sysmocom.de>
Attention is currently required from: lynxis lazus, pespin.
daniel has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37890?usp=email )
Change subject: S1AP_Emulation: Fix new_ctx never set when building security header
......................................................................
Patch Set 1: Code-Review+1
(3 comments)
Patchset:
PS1:
Need a new kexboard? :-)
Commit Message:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37890/comment/c98ad847_3617… :
PS1, Line 10: secutiry
security
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37890/comment/1edf59e5_56c3… :
PS1, Line 10: recieving
receiving
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37890?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I76ad46f7ee5f49698e41da729cb6422866202951
Gerrit-Change-Number: 37890
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Wed, 21 Aug 2024 16:36:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Attention is currently required from: laforge, neels.
fixeria has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/osmo-upf/+/37830?usp=email )
Change subject: add VTY 'gtp-echo' command
......................................................................
Patch Set 2:
(2 comments)
File src/osmo-upf/upf_vty.c:
https://gerrit.osmocom.org/c/osmo-upf/+/37830/comment/4b09c019_20fbc45f?usp… :
PS1, Line 491: tx to
> Would you accept this?
> `gtp-echo tx remote-ip IP_ADDR [(local-ip|local-dev)] [IP_ADDR_OR_DEV]`
The problem with this all-in-one command is that the syntax is misleading: you're adding two optional parts (`(local-ip|local-dev)` and `IP_ADDR_OR_DEV`), which are in fact one optional part. The command syntax suggests that you may pass only the `(local-ip|local-dev)` part and the command would be accepted, but the actual command logic will throw an error. This is why I suggested to **define them as separate DEFUNs**.
> What if we want to allow resolving a hostname [...]
Ok, I see why you're specifically prefixing it with `remote-ip`. However you're not limiting the value format by using `VTY_IPV46_CMD`, so the user can still pass non-IP values like `gtp-echo tx remote-ip google.com`.
I think you can define it as `gtp-echo tx VTY_IPV46_CMD ...` for now and change to `"gtp-echo tx (RHOST | " VTY_IPV4_CMD "|" VTY_IPV6_CMD ") ..."` in case you want to add hostname resolution.
I can't imagine (maybe due to limited vision) what else we may want to do with GTP ECHO from the `ENABLE_NODE` (not the config) other than sending it, but I understand the problem and generally fine keeping the `tx` part. Maybe change it to `send` to be more user-friendly.
Just sharing my view here. You have CR+1 from Harald. If others are fine with the proposed command syntax, than feel free to merge the patch as-is. It's unlikely that I am going to use this command a lot during my usual development anyway ;)
https://gerrit.osmocom.org/c/osmo-upf/+/37830/comment/0dab7412_784fe107?usp… :
PS1, Line 556: %%Error
> missing space?
yes, between the `%%` and `Error`
--
To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/37830?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-upf
Gerrit-Branch: master
Gerrit-Change-Id: I970dccd7a27b098eea9e660822e24e2c4b059fc6
Gerrit-Change-Number: 37830
Gerrit-PatchSet: 2
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Wed, 21 Aug 2024 16:36:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de>
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
