August 2024 - gerrit-log - lists.osmocom.org

[S] Change in osmo-ttcn3-hacks[master]: testenv: add TESTENV_REBUILD_OUTDATED_IMAGE

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37887?usp=email ) Change subject: testenv: add TESTENV_REBUILD_OUTDATED_IMAGE ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37887?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia1243320b6d310c69ef9291cca69a1594b1a8a70 Gerrit-Change-Number: 37887 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Wed, 21 Aug 2024 16:13:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 year

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: testenv/README: update

by fixeria

Attention is currently required from: osmith, pespin. fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37886?usp=email ) Change subject: testenv/README: update ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37886?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie9eee8cf14ba2069c1cd5bd6ab703f3f6ccdc100 Gerrit-Change-Number: 37886 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 21 Aug 2024 15:52:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 year

1
0
0 0

[S] Change in osmo-dev[master]: gen_makefile: support symlinks for src + src_proj

by fixeria

Attention is currently required from: osmith, pespin. fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-dev/+/37888?usp=email ) Change subject: gen_makefile: support symlinks for src + src_proj ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/37888?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: Ic5ffa132b29e0a2ca78b02e4c8c05492471b3966 Gerrit-Change-Number: 37888 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 21 Aug 2024 15:51:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 year

1
0
0 0

[S] Change in osmo-dev[master]: gen_makefile: support symlinks for src + src_proj

by osmith

Attention is currently required from: pespin. osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-dev/+/37888?usp=email ) Change subject: gen_makefile: support symlinks for src + src_proj ...................................................................... Patch Set 1: (1 comment) File gen_makefile.py: https://gerrit.osmocom.org/c/osmo-dev/+/37888/comment/c8e7246a_2fc17852?usp… : PS1, Line 225: @if ! [ -e {src} ]; then \\ > adding "/" to it ({src}/) may help with not accepting regular files? description from man test sound […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/37888?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: Ic5ffa132b29e0a2ca78b02e4c8c05492471b3966 Gerrit-Change-Number: 37888 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 21 Aug 2024 15:00:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 year

1
0
0 0

[S] Change in osmo-dev[master]: gen_makefile: support symlinks for src + src_proj

by osmith

Attention is currently required from: osmith, pespin. Hello pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-dev/+/37888?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by pespin Change subject: gen_makefile: support symlinks for src + src_proj ...................................................................... gen_makefile: support symlinks for src + src_proj Support the src and src_proj directories to be symlinks by checking if these paths exist only (-e), instead of checking if these are directories (-d). Add a second check to detect broken symlinks and inform the user about those, so it does not fail later on with a more confusing error. This may happen if the user runs testenv inside podman, and has a symlink pointing to a directory that is not mounted inside podman. Related: OS#6494 Change-Id: Ic5ffa132b29e0a2ca78b02e4c8c05492471b3966 --- M gen_makefile.py 1 file changed, 19 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-dev refs/changes/88/37888/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/37888?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: Ic5ffa132b29e0a2ca78b02e4c8c05492471b3966 Gerrit-Change-Number: 37888 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de>

1 year

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: testenv: add TESTENV_REBUILD_OUTDATED_IMAGE

by osmith

Attention is currently required from: pespin. osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37887?usp=email ) Change subject: testenv: add TESTENV_REBUILD_OUTDATED_IMAGE ...................................................................... Patch Set 2: (1 comment) File _testenv/testenv/podman.py: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37887/comment/23769c65_bd51… : PS1, Line 60: logging.debug("Building anyway since --force was used") > oh, so there's already a cmdline param for that? then this commit is just adding yet another way to […] The `--force` parameter does something different, it allows force-rebuilding the image with `./testenv.py init podman` even if we detected that the image should be up-to-date. The environment variable will automatically rebuild the image if we detect it is outdated during `./testenv.py run ...`. ``` ./testenv.py init podman [testenv] + ['podman', 'image', 'exists', 'debian-bookworm-osmo-ttcn3-testenv'] [testenv] + ['podman', 'history', 'debian-bookworm-osmo-ttcn3-testenv', '--format', 'json'] [testenv] Image creation date: 2024-08-21 14:02:19 [testenv] Dockerfile last modified: 2024-08-21 14:01:23 [testenv] Podman image is up-to-date: debian-bookworm-osmo-ttcn3-testenv ``` ``` ./testenv.py init podman --force [testenv] + ['podman', 'image', 'exists', 'debian-bookworm-osmo-ttcn3-testenv'] [testenv] + ['podman', 'history', 'debian-bookworm-osmo-ttcn3-testenv', '--format', 'json'] [testenv] Image creation date: 2024-08-21 14:02:19 [testenv] Dockerfile last modified: 2024-08-21 14:01:23 [testenv] Podman image is up-to-date: debian-bookworm-osmo-ttcn3-testenv [testenv] Building anyway since --force was used [testenv] Building podman image: debian-bookworm-osmo-ttcn3-testenv [testenv] + ['buildah', 'build', '--build-arg', 'DISTRO=debian:bookworm', '-t', 'debian-bookworm-osmo-ttcn3-testenv', '/home/user/code/osmo-dev/src/osmo-ttcn3-hacks/_testenv/data/podman'] ``` -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37887?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia1243320b6d310c69ef9291cca69a1594b1a8a70 Gerrit-Change-Number: 37887 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 21 Aug 2024 14:55:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 year

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: testenv/README: update

by osmith

Attention is currently required from: pespin. osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37886?usp=email ) Change subject: testenv/README: update ...................................................................... Patch Set 1: (1 comment) File _testenv/README.md: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37886/comment/9a15ec5b_25f9… : PS1, Line 7: Testenv builds and runs a testsuite and all its test components in the same > One of the problems I faced initially as a user is that I thought it would run by default under a co […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37886?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie9eee8cf14ba2069c1cd5bd6ab703f3f6ccdc100 Gerrit-Change-Number: 37886 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 21 Aug 2024 14:52:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 year

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: testenv/README: update

by osmith

Attention is currently required from: osmith, pespin. Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37886?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by pespin, Verified+1 by Jenkins Builder Change subject: testenv/README: update ...................................................................... testenv/README: update Point at ./testenv.py -h and describe that everything runs in 1 container with --podman. Change-Id: Ie9eee8cf14ba2069c1cd5bd6ab703f3f6ccdc100 --- M _testenv/README.md 1 file changed, 19 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/86/37886/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37886?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie9eee8cf14ba2069c1cd5bd6ab703f3f6ccdc100 Gerrit-Change-Number: 37886 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de>

1 year

1
0
0 0

[XS] Change in pysim[master]: runtime: fix get_file_by_name

by dexter

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/37889?usp=email ) Change subject: runtime: fix get_file_by_name ...................................................................... runtime: fix get_file_by_name The method get_file_by_name compares the selectable directly with the given file name. This is not correct. The comparison should be with the path element from the pathlist. Related: OS#6092 Change-Id: Id2d0704678935d9b9e2f1aeb6eaccbff6fa9d429 --- M pySim/runtime.py 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/89/37889/1 diff --git a/pySim/runtime.py b/pySim/runtime.py index 5ffbee6..a813e6d 100644 --- a/pySim/runtime.py +++ b/pySim/runtime.py @@ -256,11 +256,11 @@ for p in pathlist: # Look for the next file in the path list - selectables = file.get_selectables().items() + selectables = file.get_selectables() file = None for selectable in selectables: - if selectable[1].name == name: - file = selectable[1] + if selectable == p: + file = selectables[selectable] break # When we hit none, then the given path must be invalid -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37889?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Id2d0704678935d9b9e2f1aeb6eaccbff6fa9d429 Gerrit-Change-Number: 37889 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de>

1 year

1
0
0 0

[S] Change in osmo-dev[master]: gen_makefile: support symlinks for src + src_proj

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-dev/+/37888?usp=email ) Change subject: gen_makefile: support symlinks for src + src_proj ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File gen_makefile.py: https://gerrit.osmocom.org/c/osmo-dev/+/37888/comment/cb06ab35_f76cc00a?usp… : PS1, Line 225: @if ! [ -e {src} ]; then \\ adding "/" to it ({src}/) may help with not accepting regular files? description from man test sounded like a regular file would pass this test here. -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/37888?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: Ic5ffa132b29e0a2ca78b02e4c8c05492471b3966 Gerrit-Change-Number: 37888 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Wed, 21 Aug 2024 14:39:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 year

1
0
0 0

2025

2024

2023

2022

gerrit-log August 2024