August 2024 - gerrit-log - lists.osmocom.org

[S] Change in pysim[master]: pySim.esim.saip: Back-reference from ProfileElement to ProfileElement...

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/37842?usp=email ) Change subject: pySim.esim.saip: Back-reference from ProfileElement to ProfileElementSequence ...................................................................... pySim.esim.saip: Back-reference from ProfileElement to ProfileElementSequence Store a back-reference to the PE-Sequence in the PE object; this is neccessary for some upcoming patches, e.g. to determine the position in the sequence, access the global filesystem hierarchy, etc. Change-Id: I24b692e47e4dd0afb5a17b04d5e0251dded3d611 --- M pySim/esim/saip/__init__.py 1 file changed, 24 insertions(+), 6 deletions(-) Approvals: fixeria: Looks good to me, but someone else must approve Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/pySim/esim/saip/__init__.py b/pySim/esim/saip/__init__.py index 7898f47..45ca48e 100644 --- a/pySim/esim/saip/__init__.py +++ b/pySim/esim/saip/__init__.py @@ -225,7 +225,19 @@ 'securityDomain': 'sd-Header', } - def __init__(self, decoded = None, mandated: bool = True): + def __init__(self, decoded = None, mandated: bool = True, + pe_sequence: Optional['ProfileElementSequence'] = None): + """ + Instantiate a new ProfileElement. This is usually either called with the 'decoded' argument after + reading a SAIP-DER-encoded PE. Alternatively, when constructing a PE from scratch, decoded is None, + and a minimal PE-Header is generated. + + Args: + decoded: asn1tools-generated decoded structure for this PE + mandated: Whether or not the PE-Header should contain the mandated attribute + pe_sequence: back-reference to the PE-Sequence of which we're part of + """ + self.pe_sequence = pe_sequence if decoded: self.decoded = decoded else: @@ -301,14 +313,20 @@ return None @classmethod - def from_der(cls, der: bytes) -> 'ProfileElement': - """Construct an instance from given raw, DER encoded bytes.""" + def from_der(cls, der: bytes, + pe_sequence: Optional['ProfileElementSequence'] = None) -> 'ProfileElement': + """Construct an instance from given raw, DER encoded bytes. + + Args: + der: raw, DER-encoded bytes of a single PE + pe_sequence: back-reference to the PE-Sequence of which this PE is part of + """ pe_type, decoded = asn1.decode('ProfileElement', der) pe_cls = cls.class_for_petype(pe_type) if pe_cls: - inst = pe_cls(decoded) + inst = pe_cls(decoded, pe_sequence=pe_sequence) else: - inst = ProfileElement(decoded) + inst = ProfileElement(decoded, pe_sequence=pe_sequence) inst.type = pe_type # run any post-decoder a derived class may have if hasattr(inst, '_post_decode'): @@ -984,7 +1002,7 @@ remainder = der while len(remainder): first_tlv, remainder = bertlv_first_segment(remainder) - self.pe_list.append(ProfileElement.from_der(first_tlv)) + self.pe_list.append(ProfileElement.from_der(first_tlv, pe_sequence=self)) self._process_pelist() def _process_pelist(self) -> None: -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37842?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I24b692e47e4dd0afb5a17b04d5e0251dded3d611 Gerrit-Change-Number: 37842 Gerrit-PatchSet: 4 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

1 year

1
0
0 0

[M] Change in pysim[master]: pySim.esim.saip: pass up **kwargs from ProfileElement sub-class const...

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/37843?usp=email ) Change subject: pySim.esim.saip: pass up **kwargs from ProfileElement sub-class constructors ...................................................................... pySim.esim.saip: pass up **kwargs from ProfileElement sub-class constructors Change-Id: Ib2b7f6d7428d03e9a8c23af39a61f450096c12bc --- M pySim/esim/saip/__init__.py 1 file changed, 70 insertions(+), 47 deletions(-) Approvals: laforge: Looks good to me, approved fixeria: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/pySim/esim/saip/__init__.py b/pySim/esim/saip/__init__.py index fb2097a..7898f47 100644 --- a/pySim/esim/saip/__init__.py +++ b/pySim/esim/saip/__init__.py @@ -326,12 +326,19 @@ return self.type class FsProfileElement(ProfileElement): - """A file-system bearing profile element, like MF, USIM, ....""" + """A file-system bearing profile element, like MF, USIM, .... - def __init__(self, decoded = None, mandated: bool = True): - super().__init__(decoded, mandated) + We keep two major representations of the data: + * The "decoded" member, as introduced by our parent class, containing asn1tools syntax + * the "files" dict, consisting of File values indexed by PE-name strings + + The methods pe2files and files2pe convert between those two representations. + """ + def __init__(self, decoded = None, mandated: bool = True, **kwargs): + super().__init__(decoded, mandated, **kwargs) # indexed by PE-Name self.files = {} + # resolve ASN.1 type definition; needed to e.g. iterate field names (for file pe-names) self.tdef = asn1.types['ProfileElement'].type.name_to_member[self.type] def add_file(self, file: File): @@ -365,8 +372,12 @@ class ProfileElementGFM(ProfileElement): type = 'genericFileManagement' - def __init__(self, decoded = None, mandated: bool = True): - super().__init__(decoded, mandated) + @staticmethod + def path_str(path: List[int]) -> str: + return '/'.join(['%04X' % x for x in path]) + + def __init__(self, decoded = None, mandated: bool = True, **kwargs): + super().__init__(decoded, mandated, **kwargs) # indexed by PE-Name self.files = {} self.tdef = asn1.types['ProfileElement'].type.name_to_member[self.type] @@ -416,8 +427,8 @@ class ProfileElementMF(FsProfileElement): type = 'mf' - def __init__(self, decoded: Optional[dict] = None): - super().__init__(decoded) + def __init__(self, decoded: Optional[dict] = None, **kwargs): + super().__init__(decoded, **kwargs) if decoded: return # provide some reasonable defaults @@ -429,8 +440,8 @@ class ProfileElementPuk(ProfileElement): type = 'pukCodes' - def __init__(self, decoded: Optional[dict] = None): - super().__init__(decoded) + def __init__(self, decoded: Optional[dict] = None, **kwargs): + super().__init__(decoded, **kwargs) if decoded: return # provide some reasonable defaults @@ -459,8 +470,8 @@ class ProfileElementPin(ProfileElement): type = 'pinCodes' - def __init__(self, decoded: Optional[dict] = None): - super().__init__(decoded) + def __init__(self, decoded: Optional[dict] = None, **kwargs): + super().__init__(decoded, **kwargs) if decoded: return # provide some reasonable defaults @@ -495,8 +506,8 @@ class ProfileElementTelecom(FsProfileElement): type = 'telecom' - def __init__(self, decoded: Optional[dict] = None): - super().__init__(decoded) + def __init__(self, decoded: Optional[dict] = None, **kwargs): + super().__init__(decoded, **kwargs) if decoded: return # provide some reasonable defaults for a MNO-SD @@ -507,8 +518,8 @@ class ProfileElementPhonebook(FsProfileElement): type = 'phonebook' - def __init__(self, decoded: Optional[dict] = None): - super().__init__(decoded) + def __init__(self, decoded: Optional[dict] = None, **kwargs): + super().__init__(decoded, **kwargs) if decoded: return # provide some reasonable defaults @@ -519,8 +530,8 @@ class ProfileElementGsmAccess(FsProfileElement): type = 'gsm-access' - def __init__(self, decoded: Optional[dict] = None): - super().__init__(decoded) + def __init__(self, decoded: Optional[dict] = None, **kwargs): + super().__init__(decoded, **kwargs) if decoded: return # provide some reasonable defaults @@ -531,8 +542,8 @@ class ProfileElementDf5GS(FsProfileElement): type = 'df-5gs' - def __init__(self, decoded: Optional[dict] = None): - super().__init__(decoded) + def __init__(self, decoded: Optional[dict] = None, **kwargs): + super().__init__(decoded, **kwargs) if decoded: return # provide some reasonable defaults @@ -543,8 +554,8 @@ class ProfileElementEAP(FsProfileElement): type = 'eap' - def __init__(self, decoded: Optional[dict] = None): - super().__init__(decoded) + def __init__(self, decoded: Optional[dict] = None, **kwargs): + super().__init__(decoded, **kwargs) if decoded: return # provide some reasonable defaults @@ -555,8 +566,8 @@ class ProfileElementDfSAIP(FsProfileElement): type = 'df-saip' - def __init__(self, decoded: Optional[dict] = None): - super().__init__(decoded) + def __init__(self, decoded: Optional[dict] = None, **kwargs): + super().__init__(decoded, **kwargs) if decoded: return # provide some reasonable defaults @@ -567,8 +578,8 @@ class ProfileElementDfSNPN(FsProfileElement): type = 'df-snpn' - def __init__(self, decoded: Optional[dict] = None): - super().__init__(decoded) + def __init__(self, decoded: Optional[dict] = None, **kwargs): + super().__init__(decoded, **kwargs) if decoded: return # provide some reasonable defaults @@ -579,8 +590,8 @@ class ProfileElementDf5GProSe(FsProfileElement): type = 'df-5gprose' - def __init__(self, decoded: Optional[dict] = None): - super().__init__(decoded) + def __init__(self, decoded: Optional[dict] = None, **kwargs): + super().__init__(decoded, **kwargs) if decoded: return # provide some reasonable defaults @@ -650,8 +661,8 @@ class C9(BER_TLV_IE, tag=0xC9, nested=UiccSdInstallParams): pass - def __init__(self, decoded: Optional[dict] = None): - super().__init__(decoded) + def __init__(self, decoded: Optional[dict] = None, **kwargs): + super().__init__(decoded, **kwargs) if decoded: return # provide some reasonable defaults for a MNO-SD @@ -725,8 +736,8 @@ class ProfileElementSSD(ProfileElementSD): """Class representing a securityDomain ProfileElement for a SSD.""" - def __init__(self, decoded: Optional[dict] = None): - super().__init__(decoded) + def __init__(self, decoded: Optional[dict] = None, **kwargs): + super().__init__(decoded, **kwargs) if decoded: return # defaults [overriding ProfileElementSD) taken from SAIP v2.3.1 Section 11.2.12 @@ -743,8 +754,8 @@ def __init__(self, decoded: Optional[dict] = None, inst_aid: Optional[bytes] = None, sd_aid: Optional[bytes] = None, adf_aid: Optional[bytes] = None, - tar_list: Optional[List[bytes]] = [], msl: Optional[int] = 0x06): - super().__init__(decoded) + tar_list: Optional[List[bytes]] = [], msl: Optional[int] = 0x06, **kwargs): + super().__init__(decoded, **kwargs) ADM1_ACCESS = h2b('02000100') if decoded: return @@ -765,8 +776,8 @@ class ProfileElementUSIM(FsProfileElement): type = 'usim' - def __init__(self, decoded: Optional[dict] = None): - super().__init__(decoded) + def __init__(self, decoded: Optional[dict] = None, **kwargs): + super().__init__(decoded, **kwargs) if decoded: return # provide some reasonable defaults for a MNO-SD @@ -786,8 +797,8 @@ class ProfileElementOptUSIM(FsProfileElement): type = 'opt-usim' - def __init__(self, decoded: Optional[dict] = None): - super().__init__(decoded) + def __init__(self, decoded: Optional[dict] = None, **kwargs): + super().__init__(decoded, **kwargs) if decoded: return # provide some reasonable defaults for a MNO-SD @@ -796,8 +807,8 @@ class ProfileElementISIM(FsProfileElement): type = 'isim' - def __init__(self, decoded: Optional[dict] = None): - super().__init__(decoded) + def __init__(self, decoded: Optional[dict] = None, **kwargs): + super().__init__(decoded, **kwargs) if decoded: return # provide some reasonable defaults for a MNO-SD @@ -812,8 +823,8 @@ class ProfileElementOptISIM(FsProfileElement): type = 'opt-isim' - def __init__(self, decoded: Optional[dict] = None): - super().__init__(decoded) + def __init__(self, decoded: Optional[dict] = None, **kwargs): + super().__init__(decoded, **kwargs) if decoded: return # provide some reasonable defaults for a MNO-SD @@ -823,8 +834,8 @@ class ProfileElementAKA(ProfileElement): type = 'akaParameter' - def __init__(self, decoded: Optional[dict] = None): - super().__init__(decoded) + def __init__(self, decoded: Optional[dict] = None, **kwargs): + super().__init__(decoded, **kwargs) if decoded: return # provide some reasonable defaults for a MNO-SD @@ -900,8 +911,20 @@ type = 'header' def __init__(self, decoded: Optional[dict] = None, ver_major: Optional[int] = 2, ver_minor: Optional[int] = 3, - iccid: Optional[Hexstr] = '0'*20, profile_type: Optional[str] = None): - super().__init__(decoded) + iccid: Optional[Hexstr] = '0'*20, profile_type: Optional[str] = None, + **kwargs): + """You would usually initialize an instance either with a "decoded" argument (as read from + a DER-encoded SAIP file via asn1tools), or [some of] the othe arguments in case you're + constructing a Profile Header from scratch. + + Args: + decoded: asn1tools-generated decoded structure for this PE + ver_major: Major SAIP version + ver_minor: Minor SAIP version + iccid: ICCID of the profile + profile_type: operational, testing or bootstrap + """ + super().__init__(decoded, **kwargs) if decoded: return # provide some reasonable defaults @@ -917,8 +940,8 @@ class ProfileElementEnd(ProfileElement): type = 'end' - def __init__(self, decoded: Optional[dict] = None): - super().__init__(decoded) + def __init__(self, decoded: Optional[dict] = None, **kwargs): + super().__init__(decoded, **kwargs) def bertlv_first_segment(binary: bytes) -> Tuple[bytes, bytes]: """obtain the first segment of a binary concatenation of BER-TLV objects. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37843?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ib2b7f6d7428d03e9a8c23af39a61f450096c12bc Gerrit-Change-Number: 37843 Gerrit-PatchSet: 4 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

1 year

1
0
0 0

[S] Change in pysim[master]: pySim.esim.saip: Add some more docstring comments

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/37844?usp=email ) Change subject: pySim.esim.saip: Add some more docstring comments ...................................................................... pySim.esim.saip: Add some more docstring comments Change-Id: I70cf2b4dff1952f581efa3b21211c542f43ce565 --- M pySim/esim/saip/__init__.py 1 file changed, 31 insertions(+), 8 deletions(-) Approvals: laforge: Looks good to me, approved fixeria: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/pySim/esim/saip/__init__.py b/pySim/esim/saip/__init__.py index 45ca48e..dfc4584 100644 --- a/pySim/esim/saip/__init__.py +++ b/pySim/esim/saip/__init__.py @@ -193,6 +193,7 @@ if k == 'fileDescriptor': pass elif k == 'fillFileOffset': + # FIXME: respect the fillPattern! stream.write(b'\xff' * v) elif k == 'fillFileContent': stream.write(v) @@ -207,7 +208,10 @@ return "File(%s): %s" % (self.pe_name, self.fileDescriptor) class ProfileElement: - """Class representing a Profile Element (PE) within a SAIP Profile.""" + """Generic Class representing a Profile Element (PE) within a SAIP Profile. This may be used directly, + but ist more likely sub-classed with a specific class for the specific profile element type, like e.g + ProfileElementHeader, ProfileElementMF, ... + """ FILE_BEARING = ['mf', 'cd', 'telecom', 'usim', 'opt-usim', 'isim', 'opt-isim', 'phonebook', 'gsm-access', 'csim', 'opt-csim', 'eap', 'df-5gs', 'df-saip', 'df-snpn', 'df-5gprose', 'iot', 'opt-iot'] # in their infinite wisdom the spec authors used inconsistent/irregular naming of PE type vs. hedaer field @@ -259,11 +263,12 @@ @property def header(self): - """Return the decoded ProfileHeader.""" + """The decoded ProfileHeader.""" return self.decoded.get(self.header_name, None) @property def identification(self): + """The identification value: An unique number for the PE within the PE-Sequence.""" if self.header: return self.header['identification'] else: @@ -379,7 +384,7 @@ self.add_file(File(k, v, template.files_by_pename.get(k, None))) def _post_decode(self): - # not entirely sure about this automatism + # not entirely sure about doing this this automatism self.pe2files() def _pre_encode(self): @@ -676,6 +681,10 @@ """Class representing a securityDomain ProfileElement.""" type = 'securityDomain' + # TODO: New parameters "openPersoData" and "catTpParameters" have been defined for Security + # Domains in v2.2. A V2.0 or V2.1 eUICC may reject these new options; it is hence recommended to + # avoid using such parameters in Profiles downloaded to a V2.0 or V2.1 eUICC. + class C9(BER_TLV_IE, tag=0xC9, nested=UiccSdInstallParams): pass @@ -851,6 +860,9 @@ class ProfileElementAKA(ProfileElement): type = 'akaParameter' + # TODO: RES size for USIM test algorithm can be set to 32, 64 or 128 bits. This value was + # previously limited to 128 bits. Recommendation: Avoid using RES size 32 or 64 in Profiles + # downloaded to V2.1 eUICCs. def __init__(self, decoded: Optional[dict] = None, **kwargs): super().__init__(decoded, **kwargs) @@ -971,14 +983,21 @@ return binary[:tlv_length], binary[tlv_length:] class ProfileElementSequence: - """A sequence of ProfileElement objects, which is the overall representation of an eSIM profile.""" + """A sequence of ProfileElement objects, which is the overall representation of an eSIM profile. + + This primarily contains a list of PEs (pe_list member) as well as a number of convenience indexes + like the pe_by_type and pes_by_naa dicts that allow easier access to individual PEs within the + sequence.""" def __init__(self): + """After calling the constructor, you have to further initialize the instance by either + calling the parse_der() method, or by manually adding individual PEs, including the hedaer and + end PEs.""" self.pe_list: List[ProfileElement] = [] self.pe_by_type: Dict = {} self.pes_by_naa: Dict = {} def append(self, pe: ProfileElement): - """Append a PE to the PE Sequence""" + """Append a given PE to the end of the PE Sequence""" self.pe_list.append(pe) self._process_pelist() self.renumber_identification() @@ -997,7 +1016,7 @@ return l[0] def parse_der(self, der: bytes) -> None: - """Parse a sequence of PE and store the result in self.pe_list.""" + """Parse a sequence of PE from SAIP DER format and store the result in self.pe_list.""" self.pe_list = [] remainder = der while len(remainder): @@ -1006,10 +1025,12 @@ self._process_pelist() def _process_pelist(self) -> None: + """Post-process the PE-list; update convenience accessor dicts.""" self._rebuild_pe_by_type() self._rebuild_pes_by_naa() def _rebuild_pe_by_type(self) -> None: + """Re-build the self.pe_by_type convenience accessor dict.""" self.pe_by_type = {} # build a dict {pe_type: [pe, pe, pe]} for pe in self.pe_list: @@ -1047,7 +1068,8 @@ def rebuild_mandatory_services(self): """(Re-)build the eUICC Mandatory services list of the ProfileHeader based on what's in the - PE-Sequence.""" + PE-Sequence. You would normally call this at the very end, before encoding a PE-Sequence + to its DER format.""" # services that we cannot auto-determine and which must hence be manually specified manual_services = ['contactless', 'mbms', 'cat-tp', 'suciCalculatorApi', 'dns-resolution', 'scp11ac', 'scp11c-authorization-mechanism', 's16mode', 'eaka'] @@ -1106,7 +1128,8 @@ def rebuild_mandatory_gfstelist(self): """(Re-)build the eUICC Mandatory GFSTEList of the ProfileHeader based on what's in the - PE-Sequence.""" + PE-Sequence. You would normally call this at the very end, before encoding a PE-Sequence + to its DER format.""" template_set = set() for pe in self.pe_list: if pe.header and 'mandated' in pe.header: -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37844?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I70cf2b4dff1952f581efa3b21211c542f43ce565 Gerrit-Change-Number: 37844 Gerrit-PatchSet: 4 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

1 year

1
0
0 0

[S] Change in pysim[master]: pySim.esim.saip.File: move away from stream for file content

by laforge

Attention is currently required from: dexter. laforge has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/37847?usp=email ) Change subject: pySim.esim.saip.File: move away from stream for file content ...................................................................... Patch Set 6: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37847?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I6cb23a3a644854abd3dfd3b50b586ce80da21353 Gerrit-Change-Number: 37847 Gerrit-PatchSet: 6 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 21 Aug 2024 14:23:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 year

1
0
0 0

[S] Change in pysim[master]: pySim.esim.saip: Add some more docstring comments

by laforge

Attention is currently required from: dexter. laforge has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/37844?usp=email ) Change subject: pySim.esim.saip: Add some more docstring comments ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37844?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I70cf2b4dff1952f581efa3b21211c542f43ce565 Gerrit-Change-Number: 37844 Gerrit-PatchSet: 4 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 21 Aug 2024 14:23:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 year

1
0
0 0

[S] Change in pysim[master]: pySim.esim.saip: Back-reference from ProfileElement to ProfileElement...

by laforge

Attention is currently required from: dexter. laforge has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/37842?usp=email ) Change subject: pySim.esim.saip: Back-reference from ProfileElement to ProfileElementSequence ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37842?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I24b692e47e4dd0afb5a17b04d5e0251dded3d611 Gerrit-Change-Number: 37842 Gerrit-PatchSet: 4 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 21 Aug 2024 14:23:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 year

1
0
0 0

[M] Change in pysim[master]: pySim.esim.saip: pass up **kwargs from ProfileElement sub-class const...

by laforge

Attention is currently required from: dexter. laforge has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/37843?usp=email ) Change subject: pySim.esim.saip: pass up **kwargs from ProfileElement sub-class constructors ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37843?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ib2b7f6d7428d03e9a8c23af39a61f450096c12bc Gerrit-Change-Number: 37843 Gerrit-PatchSet: 4 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 21 Aug 2024 14:23:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 year

1
0
0 0

[M] Change in pysim[master]: pySim.esim.saip: Move AKA specific post_dec + pre_enc to AKA subclass

by laforge

Attention is currently required from: dexter. laforge has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/37837?usp=email ) Change subject: pySim.esim.saip: Move AKA specific post_dec + pre_enc to AKA subclass ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37837?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Icd332183758b8ef20a77507b728f5e455698def0 Gerrit-Change-Number: 37837 Gerrit-PatchSet: 5 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 21 Aug 2024 14:23:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 year

1
0
0 0

[S] Change in pysim[master]: pySim.esim.saip: Improve File.from_template feature support

by laforge

Attention is currently required from: dexter. laforge has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/37835?usp=email ) Change subject: pySim.esim.saip: Improve File.from_template feature support ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37835?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I3ba092e0893f53a18264dff5fa37b12ccd9bd47e Gerrit-Change-Number: 37835 Gerrit-PatchSet: 4 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 21 Aug 2024 14:22:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 year

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: testenv/README: describe architecture

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37886?usp=email ) Change subject: testenv/README: describe architecture ...................................................................... testenv/README: describe architecture Describe that everything runs in one container. Change-Id: Ie9eee8cf14ba2069c1cd5bd6ab703f3f6ccdc100 --- M _testenv/README.md 1 file changed, 8 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/86/37886/1 diff --git a/_testenv/README.md b/_testenv/README.md index 2c5a181..8b868d6 100644 --- a/_testenv/README.md +++ b/_testenv/README.md @@ -2,6 +2,14 @@ Build everything needed for running Osmocom TTCN-3 testsuites and execute them. +## Architecture + +Testenv builds and runs a testsuite and all its test components in the same +environment, either on the host or in just one container (with `--podman`). +This container is the same, no matter which testsuite gets executed. Additional +packages get installed after starting the container, with a package cache +mounted to avoid unnecessary downloads. + ## testenv.cfg The `testenv.cfg` file has one `[testsuite]` section, typically with one or -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37886?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie9eee8cf14ba2069c1cd5bd6ab703f3f6ccdc100 Gerrit-Change-Number: 37886 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

1 year

1
0
0 0

2025

2024

2023

2022

gerrit-log August 2024