August 2024 - gerrit-log - lists.osmocom.org

[XS] Change in libosmo-sccp[master]: ss7_as: Avoid dispatch event to asp with uninitialized FSM

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/37876?usp=email ) Change subject: ss7_as: Avoid dispatch event to asp with uninitialized FSM ...................................................................... ss7_as: Avoid dispatch event to asp with uninitialized FSM It is expected that before being started (osmo_ss7_asp_restart() -> xua_asp_fsm_start()), an asp doesn't have an asp->fi pointer set. This is already checked in several places in code and even used to print "unitialized" state in vty introspection. If the asp was assigned to an as (eg through vty) before it was started, then it would print the error log: "Trying to dispatch event 17 to non-existent FSM instance!" Hence, check the fi is available. If it is not, it's totally fine not dispatching that event because it means the asp is still not started, and it will catch up taking the ipa-name from the when it is started. Related: OS#6356 Related: SYS#5914 Fixes: 57444690212b1576eaf0a7156448ba2d27c59050 Fixes: 65741dca056e3a16973ad156dd4c09760a6a945b Change-Id: I4d201a60ecd1a4d8a5aa87e1fdb236f755ec152b --- M src/osmo_ss7_as.c 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: pespin: Looks good to me, approved fixeria: Looks good to me, but someone else must approve Jenkins Builder: Verified osmith: Looks good to me, but someone else must approve diff --git a/src/osmo_ss7_as.c b/src/osmo_ss7_as.c index 9d78897..9683e94 100644 --- a/src/osmo_ss7_as.c +++ b/src/osmo_ss7_as.c @@ -115,7 +115,8 @@ for (i = 0; i < ARRAY_SIZE(as->cfg.asps); i++) { if (!as->cfg.asps[i]) { as->cfg.asps[i] = asp; - osmo_fsm_inst_dispatch(asp->fi, XUA_ASP_E_AS_ASSIGNED, as); + if (asp->fi) + osmo_fsm_inst_dispatch(asp->fi, XUA_ASP_E_AS_ASSIGNED, as); return 0; } } -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/37876?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I4d201a60ecd1a4d8a5aa87e1fdb236f755ec152b Gerrit-Change-Number: 37876 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 year

1
0
0 0

[XS] Change in libosmo-sccp[master]: ss7_as: Avoid dispatch event to asp with uninitialized FSM

by pespin

Attention is currently required from: neels. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/37876?usp=email ) Change subject: ss7_as: Avoid dispatch event to asp with uninitialized FSM ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/37876?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I4d201a60ecd1a4d8a5aa87e1fdb236f755ec152b Gerrit-Change-Number: 37876 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Wed, 21 Aug 2024 18:24:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 year

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: S1AP_Emulation: Fix new_ctx never set when building security header

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37890?usp=email ) Change subject: S1AP_Emulation: Fix new_ctx never set when building security header ...................................................................... S1AP_Emulation: Fix new_ctx never set when building security header The flag was never set to true. It needs to be set to true when building the security head of Security Mode Complete after receiving Security Mode Command with a new EPS security context. TS 24.301 5.4.3.3 Change-Id: I76ad46f7ee5f49698e41da729cb6422866202951 --- M library/S1AP_Emulation.ttcn M mme/LTE_CryptoFunctions.ttcn 2 files changed, 12 insertions(+), 6 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/library/S1AP_Emulation.ttcn b/library/S1AP_Emulation.ttcn index 3cce091..bc117ac 100644 --- a/library/S1AP_Emulation.ttcn +++ b/library/S1AP_Emulation.ttcn @@ -458,7 +458,7 @@ [] S1AP_CLIENT.receive(PDU_NAS_EPS:?) -> value nas sender vc_conn { var integer assoc_id := f_assoc_id_by_comp(vc_conn); var AssociationData ad := S1apAssociationTable[assoc_id]; - nas := f_nas_encaps(S1apAssociationTable[assoc_id].nus, nas, new_ctx := false); + nas := f_nas_encaps(S1apAssociationTable[assoc_id].nus, nas); var octetstring nas_enc := enc_PDU_NAS_EPS(nas); S1AP.send(t_S1AP_Send(g_s1ap_conn_id, ts_S1AP_UlNasTransport(ad.mme_ue_s1ap_id, diff --git a/mme/LTE_CryptoFunctions.ttcn b/mme/LTE_CryptoFunctions.ttcn index f0ea990..c223409 100644 --- a/mme/LTE_CryptoFunctions.ttcn +++ b/mme/LTE_CryptoFunctions.ttcn @@ -88,7 +88,8 @@ NAS_ALG_ENC alg_enc, /* NAS Encryption Algorithm */ octetstring k_nas_enc, /* NAS Encryption Key */ integer rx_count, /* frame counter (ATS rx side) */ - integer tx_count /* frame counter (ATS tx side) */ + integer tx_count, /* frame counter (ATS tx side) */ + boolean new_ctx /* Use "New EPS Security Context" when building next sec_hdr_t */ }; template (value) NAS_UE_State t_NAS_UE_State(NAS_Role role) := { @@ -98,7 +99,8 @@ alg_enc := NAS_ALG_ENC_EEA0, k_nas_enc := ''O, rx_count := 0, - tx_count := 0 + tx_count := 0, + new_ctx := false }; type enumerated NAS_Role { @@ -173,6 +175,7 @@ secp_nas := nas.ePS_messages.ePS_MobilityManagement.pDU_NAS_EPS_SecurityProtectedNASMessage; select (secp_nas.securityHeaderType) { case ('0011'B) { /* IP with new EPS security context */ + nus.new_ctx := true; nus.rx_count := 0; nus.alg_int := NAS_ALG_IP_EIA1; /* FIXME: from decoded inner message! */ if (not f_nas_check_ip(nus, secp_nas)) { @@ -182,6 +185,7 @@ return dec_PDU_NAS_EPS(secp_nas.nAS_Message); } case ('0001'B) { /* IP only */ + nus.new_ctx := false; if (not f_nas_check_ip(nus, secp_nas)) { Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, "f_nas_check_ip() failed"); } @@ -189,6 +193,7 @@ return dec_PDU_NAS_EPS(secp_nas.nAS_Message); } case ('0010'B) { /* IP + ciphered */ + nus.new_ctx := false; if (not f_nas_check_ip(nus, secp_nas)) { Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, "f_nas_check_ip() failed"); } @@ -198,6 +203,7 @@ return dec_PDU_NAS_EPS(secp_nas.nAS_Message); } case ('0100'B) { /* IP + ciphered; new EPS security context */ + nus.new_ctx := true; nus.rx_count := 0; if (not f_nas_check_ip(nus, secp_nas)) { Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, "f_nas_check_ip() failed"); @@ -236,7 +242,7 @@ } /* encapsulate a NAS message (encrypt, MAC) */ -function f_nas_encaps(inout NAS_UE_State nus, PDU_NAS_EPS nas_in, boolean new_ctx := false) +function f_nas_encaps(inout NAS_UE_State nus, PDU_NAS_EPS nas_in) return PDU_NAS_EPS { var boolean encrypt := false; @@ -252,11 +258,11 @@ return nas_in; } - if (new_ctx) { + if (nus.new_ctx) { nus.tx_count := 0; } - var BIT4 sec_hdr_t := f_nas_determine_sec_hdr_t(encrypt, authenticate, new_ctx); + var BIT4 sec_hdr_t := f_nas_determine_sec_hdr_t(encrypt, authenticate, nus.new_ctx); var octetstring nas_enc := enc_PDU_NAS_EPS(nas_in); if (encrypt) { f_nas_encrypt(nus.alg_enc, nus.k_nas_enc, nus.tx_count, 0, -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37890?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I76ad46f7ee5f49698e41da729cb6422866202951 Gerrit-Change-Number: 37890 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 year

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: S1AP_Emulation: Fix building security headers for Integrity and Ciphe...

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37891?usp=email ) Change subject: S1AP_Emulation: Fix building security headers for Integrity and Ciphering ...................................................................... S1AP_Emulation: Fix building security headers for Integrity and Ciphering The fact that the network instructs the UE to use EEA0 encryption (null algo) doesn't mean the UE should mark the NAS frames in the security header as non-ciphered. They need to be marked as IP+ciphered in the outer header, and as plain in the inner one. Now TTCN3 behaves like a UE recorded while executing a similar test case. Moreover, wireshark is now happy decoding the messages. Change-Id: Ifd4fe83e7b5aefdaafe7ce1c8b1ec6a67c65819c --- M library/S1AP_Emulation.ttcn M mme/LTE_CryptoFunctions.ttcn M mme/MME_Tests.ttcn 3 files changed, 41 insertions(+), 18 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/library/S1AP_Emulation.ttcn b/library/S1AP_Emulation.ttcn index bc117ac..f81441f 100644 --- a/library/S1AP_Emulation.ttcn +++ b/library/S1AP_Emulation.ttcn @@ -74,7 +74,8 @@ type union S1APEM_Config { NAS_Keys set_nas_keys, ResetNAScounts reset_nas_counts, - NAS_ALG_INT set_nas_alg_int + NAS_ALG_INT set_nas_alg_int, + NAS_ALG_ENC set_nas_alg_enc }; type enumerated S1APEM_EventUpDown { @@ -443,6 +444,15 @@ [] S1AP_CLIENT.receive(S1APEM_Config:{set_nas_alg_int:=?}) -> value s1cfg sender vc_conn { var integer assoc_id := f_assoc_id_by_comp(vc_conn); S1apAssociationTable[assoc_id].nus.alg_int := s1cfg.set_nas_alg_int; + /* Mark ciphering even if using EIA0: */ + S1apAssociationTable[assoc_id].nus.use_int := true; + } + /* Configuration primitive from client */ + [] S1AP_CLIENT.receive(S1APEM_Config:{set_nas_alg_enc:=?}) -> value s1cfg sender vc_conn { + var integer assoc_id := f_assoc_id_by_comp(vc_conn); + S1apAssociationTable[assoc_id].nus.alg_enc := s1cfg.set_nas_alg_enc; + /* Mark ciphering even if using EEA0: */ + S1apAssociationTable[assoc_id].nus.use_enc := true; } /* S1AP from client: InitialUE */ [] S1AP_CLIENT.receive(tr_S1AP_InitialUE) -> value msg sender vc_conn { diff --git a/mme/LTE_CryptoFunctions.ttcn b/mme/LTE_CryptoFunctions.ttcn index c223409..48b5a07 100644 --- a/mme/LTE_CryptoFunctions.ttcn +++ b/mme/LTE_CryptoFunctions.ttcn @@ -89,7 +89,9 @@ octetstring k_nas_enc, /* NAS Encryption Key */ integer rx_count, /* frame counter (ATS rx side) */ integer tx_count, /* frame counter (ATS tx side) */ - boolean new_ctx /* Use "New EPS Security Context" when building next sec_hdr_t */ + boolean new_ctx, /* Use "New EPS Security Context" when building next sec_hdr_t */ + boolean use_int, /* Whether to use "Integrity" in sec_hdr_t */ + boolean use_enc /* Whether to use "Ciphering" in sec_hdr_t */ }; template (value) NAS_UE_State t_NAS_UE_State(NAS_Role role) := { @@ -100,7 +102,9 @@ k_nas_enc := ''O, rx_count := 0, tx_count := 0, - new_ctx := false + new_ctx := false, + use_int := false, + use_enc := false }; type enumerated NAS_Role { @@ -245,16 +249,10 @@ function f_nas_encaps(inout NAS_UE_State nus, PDU_NAS_EPS nas_in) return PDU_NAS_EPS { - var boolean encrypt := false; - var boolean authenticate := false; - if (nus.alg_int != NAS_ALG_IP_EIA0) { - authenticate := true; - } - if (nus.alg_enc != NAS_ALG_ENC_EEA0) { - encrypt := true; - } + var BIT4 sec_hdr_t; + var PDU_NAS_EPS nas_out; - if (encrypt == false and authenticate == false) { + if (nus.use_enc == false and nus.use_int == false) { return nas_in; } @@ -262,15 +260,15 @@ nus.tx_count := 0; } - var BIT4 sec_hdr_t := f_nas_determine_sec_hdr_t(encrypt, authenticate, nus.new_ctx); var octetstring nas_enc := enc_PDU_NAS_EPS(nas_in); - if (encrypt) { + if (nus.use_enc) { f_nas_encrypt(nus.alg_enc, nus.k_nas_enc, nus.tx_count, 0, f_tx_is_downlink(nus), nas_enc); } - var PDU_NAS_EPS nas_out; + + sec_hdr_t := f_nas_determine_sec_hdr_t(nus.use_enc, nus.use_int, nus.new_ctx); nas_out := valueof(ts_NAS_EMM_SecurityProtected(sec_hdr_t, nus.tx_count, nas_enc)); - if (authenticate) { + if (nus.use_int) { var OCT4 mac := f_nas_mac_calc(nus.alg_int, nus.k_nas_int, nus.tx_count, 0, f_tx_is_downlink(nus), '00'O & nas_enc); nas_out.ePS_messages.ePS_MobilityManagement.pDU_NAS_EPS_SecurityProtectedNASMessage.messageAuthenticationCode := mac; diff --git a/mme/MME_Tests.ttcn b/mme/MME_Tests.ttcn index 7a6b34c..4edeb99 100644 --- a/mme/MME_Tests.ttcn +++ b/mme/MME_Tests.ttcn @@ -602,6 +602,7 @@ } private altstep as_s1ap_handle_sec_mode() runs on ConnHdlr { + var S1APEM_Config cfg; var PDU_NAS_EPS rx_nas; var NAS_SecurityAlgorithmsV alg := { typeOfIntegrityProtection := '001'B, @@ -614,6 +615,20 @@ tSC := '0'B }; [] S1AP.receive(tr_NAS_SecModeCmd(alg, kset_id, ?)) { + /* TODO: apply below integrity and ciphering based on + * Security Mode Command field "NAS security algorithms - Selected NAS security algorithms"*/ + + /* Configure integrity protection: */ + cfg := { + set_nas_alg_int := NAS_ALG_IP_EIA1 + }; + S1AP.send(cfg); + /* Configure Ciphering: */ + cfg := { + set_nas_alg_enc := NAS_ALG_ENC_EEA0 + }; + S1AP.send(cfg); + S1AP.send(ts_NAS_SecModeCmpl); } } @@ -682,8 +697,8 @@ S1AP.send(ts_S1AP_InitialCtxSetupResp(valueof(mme_ue_id), valueof(enb_ue_id), rab_setup_items)); /* 3GPP TS 23.401 D.3.6 step 23: */ - /* Integrity Protection: TS 24.301 Section 4.4.4.3*/ - S1AP.send(ts_PDU_NAS_EPS_TrackingAreaUpdateComplete(c_EPS_SEC_IP)); + /* Integrity Protection and Ciphering implemented by S1AP_Emulation: */ + S1AP.send(ts_PDU_NAS_EPS_TrackingAreaUpdateComplete(c_EPS_SEC_NONE)); } [] S1AP.receive(PDU_NAS_EPS:?) -> value rx_nas { Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, log2str("Rx Unexpected NAS PDU msg: ", rx_nas)); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37891?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ifd4fe83e7b5aefdaafe7ce1c8b1ec6a67c65819c Gerrit-Change-Number: 37891 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 year

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: mme: expect authentication during 2g->4G TAU procedure

by pespin

Attention is currently required from: daniel, laforge, lynxis lazus. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37892?usp=email ) Change subject: mme: expect authentication during 2g->4G TAU procedure ...................................................................... Patch Set 3: (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37892/comment/78349d4c_72f3… : PS3, Line 9: If TAU happens without an existing security context, network for sure wants > acutally it has a mapped security context from a 3G security context, but we couldn't manage to get […] that's the case I described in the paragraph below (from your pcap with a real phone). THis paragraph is about the case triggered by the ttcn3 test where there was no previous knowledge of the UE at the MME. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37892?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I5ebcaf23a643b6cb97534328737257d26d3981fe Gerrit-Change-Number: 37892 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 21 Aug 2024 18:24:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>

1 year

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: mme: Fix order in eutran_to_geran testcase

by lynxis lazus

Attention is currently required from: daniel. lynxis lazus has posted comments on this change by daniel. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37893?usp=email ) Change subject: mme: Fix order in eutran_to_geran testcase ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37893?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0d7a388dc8b1a1c13de8f7e3fe7781423fc90868 Gerrit-Change-Number: 37893 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Wed, 21 Aug 2024 17:08:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 year

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: mme: expect authentication during 2g->4G TAU procedure

by lynxis lazus

Attention is currently required from: daniel, laforge, pespin. lynxis lazus has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37892?usp=email ) Change subject: mme: expect authentication during 2g->4G TAU procedure ...................................................................... Patch Set 3: (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37892/comment/f84ebb1b_af8a… : PS3, Line 9: If TAU happens without an existing security context, network for sure wants acutally it has a mapped security context from a 3G security context, but we couldn't manage to get it working atm. IMHO: the correct way would be only a security mode and have auth optional. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37892?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I5ebcaf23a643b6cb97534328737257d26d3981fe Gerrit-Change-Number: 37892 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Wed, 21 Aug 2024 17:04:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 year

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: S1AP_Emulation: Fix building security headers for Integrity and Ciphe...

by pespin

Attention is currently required from: daniel, lynxis lazus. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37891?usp=email ) Change subject: S1AP_Emulation: Fix building security headers for Integrity and Ciphering ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37891?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ifd4fe83e7b5aefdaafe7ce1c8b1ec6a67c65819c Gerrit-Change-Number: 37891 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 21 Aug 2024 16:56:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 year

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: S1AP_Emulation: Fix new_ctx never set when building security header

by pespin

Attention is currently required from: daniel, lynxis lazus. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37890?usp=email ) Change subject: S1AP_Emulation: Fix new_ctx never set when building security header ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37890?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I76ad46f7ee5f49698e41da729cb6422866202951 Gerrit-Change-Number: 37890 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 21 Aug 2024 16:55:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 year

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: mme: expect authentication during 2g->4G TAU procedure

by pespin

Attention is currently required from: daniel, laforge, lynxis lazus. Hello Jenkins Builder, daniel, lynxis lazus, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37892?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Code-Review+1 by daniel Change subject: mme: expect authentication during 2g->4G TAU procedure ...................................................................... mme: expect authentication during 2g->4G TAU procedure If TAU happens without an existing security context, network for sure wants to authenticate the UE. This is the scenario being tested here. If there was a security context (eg. from a previous 4G Attach), then it's up to the network to decide (or be capable) to implicitly authenticate the UE. Change-Id: I5ebcaf23a643b6cb97534328737257d26d3981fe --- M library/NAS_Templates.ttcn M mme/MME_Tests.ttcn 2 files changed, 28 insertions(+), 10 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/92/37892/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37892?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I5ebcaf23a643b6cb97534328737257d26d3981fe Gerrit-Change-Number: 37892 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>

1 year

1
0
0 0

2025

2024

2023

2022

gerrit-log August 2024