Attention is currently required from: dexter, laforge. fixeria has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/37839?usp=email ) Change subject: pySim-shell: prevent opening/closing logical channel 0 ...................................................................... Patch Set 4: (1 comment) File pySim-shell.py: https://gerrit.osmocom.org/c/pysim/+/37839/comment/821461ed_fe9c1710?usp=ema... : PS4, Line 968: choices=range(1,4), (just to be sure) the new value range is `[1, 2, 3]` (excluding `4`), correct? Looking at the code (specifically `lchan_nr_to_cla()`), I see that 0..3 is the "standard logical channel number" and 4..16 is the "extended logical channel number". Do you permit only the standard one for a reason? -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37839?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I4eebd9f15fadd18e1caeb033fda36c59446fcab8 Gerrit-Change-Number: 37839 Gerrit-PatchSet: 4 Gerrit-Owner: dexter <pmaier@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy@sysmocom.de> Gerrit-CC: laforge <laforge@osmocom.org> Gerrit-Attention: laforge <laforge@osmocom.org> Gerrit-Attention: dexter <pmaier@sysmocom.de> Gerrit-Comment-Date: Wed, 21 Aug 2024 20:03:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No