Attention is currently required from: dexter, fixeria.
laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/37840?usp=email )
Change subject: ara_m: use class byte of current lchan
......................................................................
Patch Set 6: Code-Review-1
(1 comment)
Patchset:
PS6:
I think if you make apply_lchan=True the default (to which I agree!), then you have to audit the existing code to set apply_lchan=False on all commands where it must not be set. Off my head, this would at least be the command for opening a logical channel (MANAGE CHANNEL).
You can possibl use the libosmocore/src/sim/class_tables.c file as a helper. If it is correct, uicc_ins_tbl_80 is registered with mask FF, so TERMINAL PROFILE, ENVELOPE, FETCH, TERMINAL RESPONS, SUSPEND UICC and EXCHANGE CAPABILITIES would also not report any non-zero lchan.
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/37840?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Ie3e48678f178a488bfaea6cc2b9a3e18145a8d10
Gerrit-Change-Number: 37840
Gerrit-PatchSet: 6
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 22 Aug 2024 11:01:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Attention is currently required from: dexter.
laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/37895?usp=email )
Change subject: pySim-shell, cosmetic: define positional arguments last
......................................................................
Patch Set 1: Code-Review-1
(1 comment)
File pySim-shell.py:
https://gerrit.osmocom.org/c/pysim/+/37895/comment/8b29a5ca_b1d7fa21?usp=em… :
PS1, Line 238: apdu_cmd_parser = argparse.ArgumentParser()
is this really a cosmetic change? I would expect that before this change, the --opts would have to come after the APDU, while now they would have to come before the APDU? If this is the case, this would break tons of scripts I have here, e.g. for card personalization.
Please verify that this change still accepts the existing/old argument ordering.
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/37895?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I2412eb6e7dc32ae95a575f31d4489ce210d85ea0
Gerrit-Change-Number: 37895
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 22 Aug 2024 10:55:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
