Attention is currently required from: daniel, laforge, osmith, pespin.
Hello Jenkins Builder, daniel, fixeria, laforge, pespin,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37694?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed:
Code-Review-1 by laforge, Verified+1 by Jenkins Builder
Change subject: testenv: add test environment script
......................................................................
testenv: add test environment script
Add a new testenv.py script that builds/installs all components needed
for a testsuite, builds the testsuite from source and runs it.
Features:
* --binary-repo argument to install packages from osmocom:latest or any
other repository from the Osmocom OBS instead of building from source
* without --binary-repo, the test components are built with osmo-dev,
cloning the missing source git repositories and building them in the
right order
* --podman argument to run the testsuite and its components inside a
container (using podman instead of docker so it runs rootless)
* Simple testenv.cfg file to specify components for running testsuites
* Iterative compilation of components and testsuite
* Using ccache
* Testsuite doesn't start if any of the components fail to start (e.g.
because of a config error)
* Testsuite gets stopped if any of the components crash
* ^C stops the testsuite + all components
* Test component output logs to stdout in addition to a log file (turn
off with --no-tee)
* --test argument to only run one specific test
* --shell argument to run an interactive shell before teardown to
inspect the test environment while components are still running
This script unifies the use cases of running a testsuite without
containers (for local development), and with containers (as jenkins
runs it, but can also be used for local development e.g. to get a clean
pcap). Previously jenkins used a different set of configurations from
docker-playground.git and many different containers instead of just one.
Related: OS#6494
Change-Id: If9f8b79dd6e5b4f06be4e5ff73db97759c3acfb2
---
M .gitignore
M README.md
A _testenv/README.md
A _testenv/data/osmo-dev/osmo-bts-trx.opts
A _testenv/data/podman/Dockerfile
A _testenv/data/podman/obs.key
A _testenv/data/scripts/log_format.sh
A _testenv/data/scripts/rename_junit_xml_classname.sh
A _testenv/data/scripts/respawn.sh
A _testenv/data/scripts/testenv-podman-main.sh
A _testenv/pyproject.toml
A _testenv/testenv.py
A _testenv/testenv/__init__.py
A _testenv/testenv/cmd.py
A _testenv/testenv/daemons.py
A _testenv/testenv/osmo_dev.py
A _testenv/testenv/podman.py
A _testenv/testenv/podman_install.py
A _testenv/testenv/requirements.py
A _testenv/testenv/testdir.py
A _testenv/testenv/testenv_cfg.py
A _testenv/testenv/testsuite.py
A testenv.py
23 files changed, 2,240 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/94/37694/3
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37694?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: If9f8b79dd6e5b4f06be4e5ff73db97759c3acfb2
Gerrit-Change-Number: 37694
Gerrit-PatchSet: 3
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: laforge.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/37685?usp=email )
Change subject: pySim-shell: Support other ADMx values beyond ADM1 from 'verify_adm'
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
> Likewise, I find this weird. I am also getting this with pylint v3.2.5.
This makes the linter happy:
```diff
diff --git a/pySim-shell.py b/pySim-shell.py
index 174df62..6ee127e 100755
--- a/pySim-shell.py
+++ b/pySim-shell.py
@@ -839,7 +839,8 @@ class PySimCommands(CommandSet):
to get write/update permissions to most of the files on SIM cards.
"""
if opts.adm_type:
- adm_chv_num = pin_names.inverse[opts.adm_type]
+ pin_values = dict(pin_names.inverse)
+ adm_chv_num = pin_values[opts.adm_type]
else:
adm_chv_num = self._cmd.card._adm_chv_num
if opts.ADM:
```
But I think we can just do `pylint: disable=unsubscriptable-object`.
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/37685?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Icce6903c1e449889f8bc5003ccfe6af767a26d44
Gerrit-Change-Number: 37685
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Fri, 02 Aug 2024 10:15:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: laforge.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/37685?usp=email )
Change subject: pySim-shell: Support other ADMx values beyond ADM1 from 'verify_adm'
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
> I really don't understand why we get this […]
Likewise, I find this weird. I am also getting this with pylint v3.2.5.
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/37685?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Icce6903c1e449889f8bc5003ccfe6af767a26d44
Gerrit-Change-Number: 37685
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Fri, 02 Aug 2024 10:03:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: comment