August 2024 - gerrit-log - lists.osmocom.org

[XL] Change in osmo-ttcn3-hacks[master]: testenv: seccomp_profile: import

by laforge

Attention is currently required from: osmith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37715?usp=email ) Change subject: testenv: seccomp_profile: import ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37715?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id52e63b7ab4150def084aa0b02efbf731f4224d8 Gerrit-Change-Number: 37715 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 02 Aug 2024 12:29:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

11 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: hlr: initial testenv.cfg

by laforge

Attention is currently required from: osmith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37695?usp=email ) Change subject: hlr: initial testenv.cfg ...................................................................... Patch Set 3: (1 comment) File hlr/testenv.cfg: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37695/comment/34774b41_fa9b… PS2, Line 6: program=osmo-hlr > I have considered doing that, but decided against it for the following reasons: […] I don't feel strongly about it, was just a comment. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37695?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If937f021a33bf81b4e7296c2efdbd13a73cdaca9 Gerrit-Change-Number: 37695 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 02 Aug 2024 12:29:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

11 months

1
0
0 0

[S] Change in ...osmo_dia2gsup[master]: examples/{sys,dev}.config: enable colored logging

by osmith

Attention is currently required from: fixeria. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/37722?usp=email ) Change subject: examples/{sys,dev}.config: enable colored logging ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Patchset: PS1: nice! -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/37722?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I9f88cb289b6be110bd3087aadd9750bcada20a1a Gerrit-Change-Number: 37722 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 02 Aug 2024 12:18:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

11 months

1
0
0 0

[S] Change in ...osmo_dia2gsup[master]: examples: add dev.config, let 'make run' use it by default

by osmith

Attention is currently required from: fixeria. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/37721?usp=email ) Change subject: examples: add dev.config, let 'make run' use it by default ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/37721?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I4928051be173b8e5d0977d8039dbe5bc3ed9c1ab Gerrit-Change-Number: 37721 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 02 Aug 2024 12:17:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

11 months

1
0
0 0

[S] Change in ...osmo_dia2gsup[master]: examples/sys.config: add pid, delete time

by osmith

Attention is currently required from: fixeria. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/37720?usp=email ) Change subject: examples/sys.config: add pid, delete time ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/37720?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I1dd98bae69c6d644870d44f8217262669fc20c6d Gerrit-Change-Number: 37720 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 02 Aug 2024 12:17:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

11 months

1
0
0 0

[S] Change in ...osmo_dia2gsup[master]: examples/sys.config: add default lager formatting config

by osmith

Attention is currently required from: fixeria. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/37719?usp=email ) Change subject: examples/sys.config: add default lager formatting config ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/37719?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I2b9c3111a0539703f96c265ae16a0413460d0217 Gerrit-Change-Number: 37719 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 02 Aug 2024 12:16:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

11 months

1
0
0 0

[S] Change in ...osmo_dia2gsup[master]: debian: install sys.config to /etc/osmocom/osmo-dia2gsup.config

by osmith

Attention is currently required from: fixeria. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/37717?usp=email ) Change subject: debian: install sys.config to /etc/osmocom/osmo-dia2gsup.config ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/37717?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I3b2595ca3d82a2ead8fb5560fcc281091e320aa9 Gerrit-Change-Number: 37717 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 02 Aug 2024 12:14:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

11 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: hlr: initial testenv.cfg

by osmith

Attention is currently required from: laforge. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37695?usp=email ) Change subject: hlr: initial testenv.cfg ...................................................................... Patch Set 3: (1 comment) File hlr/testenv.cfg: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37695/comment/212eb6f3_8bb6… PS2, Line 6: program=osmo-hlr > would it possibly make sense to use the below patterns as implicit defaults? So basically just spec […] I have considered doing that, but decided against it for the following reasons: * This may lead to confusing errors down the line, in case the values for `make=`, `package=` and `copy=` inherited from the program name would not be correct. The testenv script would try to e.g. install the wrong package and fail, then users need to spend additional time (way more time than adding these few lines IMHO) to read the docs to understand this implicit behavior, figure out that they need to add a `package=` line and test again. Whereas if we already have a `package=` line it is explicit and self-explaining IMHO. * It could also be that we get config files that look correct, but were only tested with either binary repository or the make target, and the other one could be broken if the implicit value is wrong. By having it explicit, I think it's more likely that people will try to figure out the correct value. * `program=` may be more than just the program name, have environment variables or additional arguments (e.g. `ERL_FLAGS="-config osmo_dia2gsup.config" osmo-dia2gsup`, `osmo-sgsn -c osmo-sgsn.sns.cfg`) or even run a launcher script. But if you feel strongly about this, I could also rework it to separate the commandline from `program=` (adding a new `commandline=` variable), and use defaults for `commandline=`, `make=`, `package=` and `copy=` based on program. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37695?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If937f021a33bf81b4e7296c2efdbd13a73cdaca9 Gerrit-Change-Number: 37695 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Fri, 02 Aug 2024 11:49:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

11 months

1
0
0 0

[XL] Change in osmo-ttcn3-hacks[master]: testenv: add test environment script

by osmith

Attention is currently required from: daniel, fixeria, laforge, pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37694?usp=email ) Change subject: testenv: add test environment script ...................................................................... Patch Set 3: (5 comments) File _testenv/data/podman/Dockerfile: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37694/comment/368c33f5_43a7… PS2, Line 94: python3 setup.py clean build install > we should finally start using `pip install`, since running `setup. […] Done File _testenv/data/podman/seccomp_profile.json: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37694/comment/712a2e2b_d52a… PS2, Line 20: "subArchitectures": [ > is this file a modified file from some other source? If yes, then I would appreciate if we can chec […] Done File _testenv/data/scripts/rename_junit_xml_classname.sh: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37694/comment/cdc17970_eb1b… PS2, Line 1: #!/bin/sh -e > maybe 1-2 line description on top of the file what it does? Yes, rename something - but why and how […] Done File _testenv/testenv.py: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37694/comment/59154094_5889… PS2, Line 2: import logging > please add some kind of copyright statement, license header and summary description to all of the py […] Done File _testenv/testenv/osmo_dev.py: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37694/comment/3a969f1a_a3fd… PS2, Line 49: logging.error(testenv.src_dir) > I see a some line wrapping that looks like its way before we hit the 120 character max line length o […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37694?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If9f8b79dd6e5b4f06be4e5ff73db97759c3acfb2 Gerrit-Change-Number: 37694 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Fri, 02 Aug 2024 11:25:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

11 months

1
0
0 0

[S] Change in ...osmo_dia2gsup[master]: debian: install sys.config to /etc/osmocom/osmo-dia2gsup.config

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/37717?usp=email ) Change subject: debian: install sys.config to /etc/osmocom/osmo-dia2gsup.config ...................................................................... debian: install sys.config to /etc/osmocom/osmo-dia2gsup.config Related: OS#6148 Change-Id: I3b2595ca3d82a2ead8fb5560fcc281091e320aa9 --- M debian/osmo-diameter2gsup.install 1 file changed, 11 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo_dia2gsup refs/changes/17/37717/1 diff --git a/debian/osmo-diameter2gsup.install b/debian/osmo-diameter2gsup.install index 398a000..8dae0fd 100644 --- a/debian/osmo-diameter2gsup.install +++ b/debian/osmo-diameter2gsup.install @@ -1,2 +1,3 @@ /contrib/systemd/osmo_dia2gsup.service /lib/systemd/system/ +/examples/sys.config /etc/osmocom/osmo-dia2gsup.config /_build/default/bin/osmo-dia2gsup /usr/bin/ -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/37717?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I3b2595ca3d82a2ead8fb5560fcc281091e320aa9 Gerrit-Change-Number: 37717 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

11 months

1
0
0 0

2025

2024

2023

2022

gerrit-log August 2024