Attention is currently required from: laforge.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/37685?usp=email )
Change subject: pySim-shell: Support other ADMx values beyond ADM1 from 'verify_adm'
......................................................................
Patch Set 1:
(2 comments)
File pySim-shell.py:
https://gerrit.osmocom.org/c/pysim/+/37685/comment/add00bf8_157a997c
PS1, Line 832: '--adm-type',
> No, that would break the default ADM number being retrieved from the CardProfile. […]
Oh, good to know. Maybe clarify this in the help message? Wasn't obvious to me.
Something like `(default is chosen automatically depending on card type; usually 1)`.
https://gerrit.osmocom.org/c/pysim/+/37685/comment/2be6de27_f7ae02b2
PS1, Line 842: inverse
> https://bidict.readthedocs.io/en/main/basic-usage.html uses the inverse[] approach. […]
Oh, I see it's actually a `bidict`. I was not careful enough and assumed that it's a list and that you're getting a value by index. Nevermind.
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/37685?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Icce6903c1e449889f8bc5003ccfe6af767a26d44
Gerrit-Change-Number: 37685
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Fri, 02 Aug 2024 09:54:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: daniel, osmith, pespin.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37694?usp=email )
Change subject: testenv: add test environment script
......................................................................
Patch Set 2:
(2 comments)
File _testenv/data/podman/Dockerfile:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37694/comment/820bcb70_1327…
PS2, Line 94: python3 setup.py clean build install
we should finally start using `pip install`, since running `setup.py` is deprecated and will not be possible at some point in the future
File testenv.py:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37694/comment/3f181fb6_bcb4…
PS2, Line 1: _testenv/testenv.py
FYI: "No newline at end of right file." is expected because it's a symlink.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37694?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: If9f8b79dd6e5b4f06be4e5ff73db97759c3acfb2
Gerrit-Change-Number: 37694
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 02 Aug 2024 09:33:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: osmith.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37695?usp=email )
Change subject: hlr: initial testenv.cfg
......................................................................
Patch Set 2:
(1 comment)
File hlr/testenv.cfg:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37695/comment/b889c834_0446…
PS2, Line 6: program=osmo-hlr
would it possibly make sense to use the below patterns as implicit defaults? So basically just specify "program=osmo-hlr" and then testenv would assume "make=$program, package=$program, copy=$program.cfg" unless overridden in the config file?
Likewise for [testsuite] above. The config is (almost?) always $program.cfg, so why not spare the user from having to copy+paste this everywhere?
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37695?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: If937f021a33bf81b4e7296c2efdbd13a73cdaca9
Gerrit-Change-Number: 37695
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 02 Aug 2024 08:21:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: daniel, fixeria, osmith, pespin.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37694?usp=email )
Change subject: testenv: add test environment script
......................................................................
Patch Set 2:
(4 comments)
File _testenv/data/podman/seccomp_profile.json:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37694/comment/f555f325_8f83…
PS2, Line 20: "subArchitectures": [
is this file a modified file from some other source? If yes, then I would appreciate if we can check in the original, unmodified file first, and then add our modifications to it, so we can see them in the changelog and have an easier chance of ever applying our diff on top of a modified upstream at a later point.
Also, if it's a modified version of an upstream file, it would explain why we have config about MIPS and S390 in osmocom projects 😊
File _testenv/data/scripts/rename_junit_xml_classname.sh:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37694/comment/81719487_cac6…
PS2, Line 1: #!/bin/sh -e
maybe 1-2 line description on top of the file what it does? Yes, rename something - but why and how is it used/neeed in our context?
File _testenv/testenv.py:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37694/comment/ddc794e5_1a8e…
PS2, Line 2: import logging
please add some kind of copyright statement, license header and summary description to all of the python files here. Choice of license is up to you, copyright would be sysmocom, for anything done during working hours.
File _testenv/testenv/osmo_dev.py:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37694/comment/8ebd60d7_d469…
PS2, Line 49: logging.error(testenv.src_dir)
I see a some line wrapping that looks like its way before we hit the 120 character max line length of our coding style?
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37694?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: If9f8b79dd6e5b4f06be4e5ff73db97759c3acfb2
Gerrit-Change-Number: 37694
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 02 Aug 2024 08:19:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment