July 2024 - gerrit-log - lists.osmocom.org

[S] Change in osmo-bts[master]: doc/examples: osmo-bts-trx.cfg: set 'oml remote-ip' to '127.0.0.1'

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/37516?usp=email ) Change subject: doc/examples: osmo-bts-trx.cfg: set 'oml remote-ip' to '127.0.0.1' ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/37516?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I41b8de14c19088ef614ce751c738e4fc5969f0da Gerrit-Change-Number: 37516 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 19 Jul 2024 17:41:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 1 month

1
0
0 0

[M] Change in pysim[master]: pySim.apdu: Get rid of HexAdapter

by laforge

Attention is currently required from: laforge. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/37535?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: pySim.apdu: Get rid of HexAdapter ...................................................................... pySim.apdu: Get rid of HexAdapter In the past, we always wrapped a HexAdapter around bytes-like data in order to make sure it's printed as hex-digits. However, now that we are doing JSON output it's much easier to let the pySim.utils.JsonEncoder take care of this in a generic way. We should do a similar migrtaion all over pySim (pySim-shell, filesystem, etc.) - but for now only do it in the low-hanging fruit of pySim-trace aka pySim.apdu Change-Id: I0cde40b2db08b4db9c10c1ece9ca6fdd42aa9154 --- M pySim/apdu/__init__.py M pySim/apdu/ts_102_221.py M pySim/apdu/ts_31_102.py M tests/test_apdu.py 4 files changed, 51 insertions(+), 33 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/35/37535/2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37535?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I0cde40b2db08b4db9c10c1ece9ca6fdd42aa9154 Gerrit-Change-Number: 37535 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newpatchset

1 year, 1 month

1
0
0 0

[S] Change in osmo-bts[master]: doc/examples: osmo-bts-trx.cfg: set 'oml remote-ip' to '127.0.0.1'

by pespin

Attention is currently required from: fixeria, laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/37516?usp=email ) Change subject: doc/examples: osmo-bts-trx.cfg: set 'oml remote-ip' to '127.0.0.1' ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/37516?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I41b8de14c19088ef614ce751c738e4fc5969f0da Gerrit-Change-Number: 37516 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 19 Jul 2024 17:30:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 1 month

1
0
0 0

[S] Change in osmo-bts[master]: doc/examples: drop no-op 'gsmtap-sapi' lines

by pespin

Attention is currently required from: fixeria, laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/37518?usp=email ) Change subject: doc/examples: drop no-op 'gsmtap-sapi' lines ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/37518?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Icde668b5829a56663c258e54957e2f639a8e82a9 Gerrit-Change-Number: 37518 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 19 Jul 2024 17:29:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 1 month

1
0
0 0

[S] Change in osmo-bts[master]: doc/examples: use common 'ipa unit-id' in all files

by pespin

Attention is currently required from: fixeria, laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/37517?usp=email ) Change subject: doc/examples: use common 'ipa unit-id' in all files ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/37517?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I2b5ed8eaa5c2cbfe20091dcfea0dd1a70f148f7c Gerrit-Change-Number: 37517 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 19 Jul 2024 17:28:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 1 month

1
0
0 0

[S] Change in osmo-bts[master]: doc/examples: osmo-bts-trx.cfg: set 'oml remote-ip' to '127.0.0.1'

by fixeria

Attention is currently required from: laforge, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/37516?usp=email ) Change subject: doc/examples: osmo-bts-trx.cfg: set 'oml remote-ip' to '127.0.0.1' ...................................................................... Patch Set 3: (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-bts/+/37516/comment/f2890291_9ecb3fb1 PS1, Line 9: n a typical lab setup the BSC is co-located on the same host with : the BTS process. > for lc15/sysmo/oc2g it is very unlikely that you'd have 127.0.0.1 for BTS+BSC. Done -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/37516?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I41b8de14c19088ef614ce751c738e4fc5969f0da Gerrit-Change-Number: 37516 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 19 Jul 2024 17:02:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

1 year, 1 month

1
0
0 0

[S] Change in osmo-bts[master]: doc/examples: use common 'ipa unit-id' in all files

by fixeria

Attention is currently required from: fixeria, laforge, pespin. Hello Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bts/+/37517?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by pespin, Code-Review+2 by laforge, Verified+1 by Jenkins Builder The change is no longer submittable: Code-Review and Verified are unsatisfied now. Change subject: doc/examples: use common 'ipa unit-id' in all files ...................................................................... doc/examples: use common 'ipa unit-id' in all files Ensure that the 'ipa unit-id' in all config examples is set to value 6969, matching the value used in the osmo-bsc config examples. Change-Id: I2b5ed8eaa5c2cbfe20091dcfea0dd1a70f148f7c --- M doc/examples/litecell15/osmo-bts-lc15.cfg M doc/examples/oc2g/osmo-bts-oc2g.cfg M doc/examples/octphy/osmo-bts-octphy.cfg M doc/examples/octphy/osmo-bts-trx2dsp1.cfg M doc/examples/sysmo/osmo-bts-sysmo.cfg 5 files changed, 17 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/17/37517/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/37517?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I2b5ed8eaa5c2cbfe20091dcfea0dd1a70f148f7c Gerrit-Change-Number: 37517 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 year, 1 month

1
0
0 0

[S] Change in osmo-bts[master]: doc/examples: osmo-bts-trx.cfg: set 'oml remote-ip' to '127.0.0.1'

by fixeria

Attention is currently required from: fixeria, pespin. Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bts/+/37516?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by pespin, Verified+1 by Jenkins Builder Change subject: doc/examples: osmo-bts-trx.cfg: set 'oml remote-ip' to '127.0.0.1' ...................................................................... doc/examples: osmo-bts-trx.cfg: set 'oml remote-ip' to '127.0.0.1' In a typical lab setup the BSC is co-located on the same host with the BTS process. Using the localhost address instead of random addresses makes life easier for those using example configs. Change-Id: I41b8de14c19088ef614ce751c738e4fc5969f0da --- M doc/examples/trx/osmo-bts-trx.cfg 1 file changed, 14 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/16/37516/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/37516?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I41b8de14c19088ef614ce751c738e4fc5969f0da Gerrit-Change-Number: 37516 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 year, 1 month

1
0
0 0

[S] Change in osmo-bts[master]: doc/examples: drop no-op 'gsmtap-sapi' lines

by fixeria

Attention is currently required from: fixeria, laforge, pespin. Hello Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bts/+/37518?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by pespin, Code-Review+2 by laforge, Verified+1 by Jenkins Builder The change is no longer submittable: Code-Review and Verified are unsatisfied now. Change subject: doc/examples: drop no-op 'gsmtap-sapi' lines ...................................................................... doc/examples: drop no-op 'gsmtap-sapi' lines These lines yield nothing without the 'gsmtap-remote-host' parameter actually enabling GSMTAP Um logging. Remove them to avoid confusion. Change-Id: Icde668b5829a56663c258e54957e2f639a8e82a9 --- M doc/examples/trx/osmo-bts-trx-calypso.cfg M doc/examples/trx/osmo-bts-trx.cfg 2 files changed, 12 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/18/37518/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/37518?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Icde668b5829a56663c258e54957e2f639a8e82a9 Gerrit-Change-Number: 37518 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 year, 1 month

1
0
0 0

[S] Change in pysim[master]: pySim.apdu: Fix APDU CLA matching

by laforge

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/37532?usp=email ) Change subject: pySim.apdu: Fix APDU CLA matching ...................................................................... pySim.apdu: Fix APDU CLA matching The cla values as hex strings must be compared in case insensitive manner Change-Id: I890bc385d6209e6cfe9b0c38bd9deee7ae50e5f5 --- M pySim/apdu/__init__.py 1 file changed, 13 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/32/37532/1 diff --git a/pySim/apdu/__init__.py b/pySim/apdu/__init__.py index 6613e91..fbe7e6b 100644 --- a/pySim/apdu/__init__.py +++ b/pySim/apdu/__init__.py @@ -272,7 +272,7 @@ """Does the given CLA match the CLA list of the command?.""" if not isinstance(cla, str): cla = '%02X' % cla - cla = cla.lower() + cla = cla.upper() # see https://github.com/PyCQA/pylint/issues/7219 # pylint: disable=no-member for cla_match in cls._cla: @@ -282,7 +282,7 @@ cla_masked += 'X' else: cla_masked += cla[i] - if cla_masked == cla_match: + if cla_masked == cla_match.upper(): return True return False -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37532?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I890bc385d6209e6cfe9b0c38bd9deee7ae50e5f5 Gerrit-Change-Number: 37532 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

1 year, 1 month

1
0
0 0

2025

2024

2023

2022

gerrit-log July 2024