July 2024 - gerrit-log - lists.osmocom.org

[S] Change in osmo-ci[master]: OBS: osmocom:master: ignore missing commit_*.txt

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/37630?usp=email ) Change subject: OBS: osmocom:master: ignore missing commit_*.txt ...................................................................... OBS: osmocom:master: ignore missing commit_*.txt Do not abort if the commit_*.txt file has been deleted from a package in osmocom:master. Instead, assume the package is outdated, create a new source package (with commit_*.txt) and replace the existing source package. This is useful to force rebuilding a package, e.g. if the previous source package was built when the git tag was not pushed yet, and therefore the version in the package and for libraries, in the pkg-config data, don't have the proper version yet. Change-Id: Ia6129f533394b94d5d8525eb0513a38a6e1eb7b6 --- M scripts/obs/lib/osc.py 1 file changed, 22 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/30/37630/1 diff --git a/scripts/obs/lib/osc.py b/scripts/obs/lib/osc.py index ef2fc4b..57be783 100644 --- a/scripts/obs/lib/osc.py +++ b/scripts/obs/lib/osc.py @@ -86,8 +86,9 @@ if line.endswith(".dsc"): return line.split("_")[-1][:-4] - lib.exit_error_cmd(ret, "failed to find package version on OBS by" - " extracting the version from the file list") + print(f"{package}: WARNING: failed to find package version on OBS!") + print(f"{package}: assuming the package is outdated") + return "0" def create_package(package): -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/37630?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ia6129f533394b94d5d8525eb0513a38a6e1eb7b6 Gerrit-Change-Number: 37630 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

11 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: stp: remove <= 1.8.x code paths

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37629?usp=email ) Change subject: stp: remove <= 1.8.x code paths ...................................................................... stp: remove <= 1.8.x code paths Change-Id: I31a1516215237984c029c02dfa30aa223c3d06a3 --- M stp/STP_Tests_M3UA.ttcn 1 file changed, 9 insertions(+), 25 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/29/37629/1 diff --git a/stp/STP_Tests_M3UA.ttcn b/stp/STP_Tests_M3UA.ttcn index 9c45a32..2cac7cc 100644 --- a/stp/STP_Tests_M3UA.ttcn +++ b/stp/STP_Tests_M3UA.ttcn @@ -272,13 +272,6 @@ var M3uaConfig m3cfg := mp_m3ua_configs[i]; var Result res; - /* XXX: M3UA-over-TCP is not supported by osmo-stp <= 1.8.1 */ - if (not Misc_Helpers.f_osmo_repo_is("nightly")) { - log("Not connect()ing m3cfg := ", m3cfg, " (not supported by IUT)"); - g_m3ua_conn_id[i] := -1; - return; - } - if (lengthof(mp_local_m3ua_ip) == 0 or lengthof(mp_stp_m3ua_ip) == 0) { setverdict(fail, "Empty local or remote address trying to connect TCP socket: ", mp_local_m3ua_ip, " / ", mp_stp_m3ua_ip); @@ -317,12 +310,6 @@ var OptionList opt_list := {}; var M3uaConfig m3cfg := mp_m3ua_configs[i]; - /* XXX: M3UA-over-TCP is not supported by osmo-stp <= 1.8.1 */ - if (not Misc_Helpers.f_osmo_repo_is("nightly") and m3cfg.use_tcp) { - log("Not listen()ing m3cfg := ", m3cfg, " (not supported by IUT)"); - return; - } - if (lengthof(mp_local_m3ua_ip) == 0 ) { setverdict(fail, "Empty local address trying to bind SCTP socket: ", mp_local_m3ua_ip); @@ -362,12 +349,6 @@ } for (i := 0; i < NR_M3UA; i:=i+1) { - /* XXX: M3UA-over-TCP is not supported by osmo-stp <= 1.8.1 */ - if (not Misc_Helpers.f_osmo_repo_is("nightly") and mp_m3ua_configs[i].use_tcp) { - log("Not connect()ing m3cfg := ", mp_m3ua_configs[i], " (not supported by IUT)"); - g_m3ua_conn_id[i] := -1; - continue; - } map(self:M3UA[i], system:M3UA_CODEC_PT); if (mp_m3ua_configs[i].use_tcp) { f_M3UA_connect_tcp(i); @@ -395,12 +376,6 @@ var PortEvent port_evt; for (i := NR_M3UA; i < NR_M3UA+NR_M3UA_SRV; i:=i+1) { - /* XXX: M3UA-over-TCP is not supported by osmo-stp <= 1.8.1 */ - if (not Misc_Helpers.f_osmo_repo_is("nightly") and mp_m3ua_configs[i].use_tcp) { - log("Not listen()ing m3cfg := ", mp_m3ua_configs[i], " (not supported by IUT)"); - g_m3ua_conn_id[i] := -1; - continue; - } map(self:M3UA[i], system:M3UA_CODEC_PT); /* bind+ listen */ f_M3UA_listen(i); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37629?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I31a1516215237984c029c02dfa30aa223c3d06a3 Gerrit-Change-Number: 37629 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

11 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: hnbgw: remove <= 1.5.x code paths

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37627?usp=email ) Change subject: hnbgw: remove <= 1.5.x code paths ...................................................................... hnbgw: remove <= 1.5.x code paths Change-Id: Ie1336a7372a46439cf53e38a555f36d0201fa230 --- M hnbgw/HNBGW_Tests.ttcn 1 file changed, 16 insertions(+), 24 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/27/37627/1 diff --git a/hnbgw/HNBGW_Tests.ttcn b/hnbgw/HNBGW_Tests.ttcn index 273627d..3765411 100644 --- a/hnbgw/HNBGW_Tests.ttcn +++ b/hnbgw/HNBGW_Tests.ttcn @@ -1560,9 +1560,7 @@ {name := hnb0_ctr_prefix & "ranap.cs.rab_act.cnf", mtype := "c", min := 0, max := 0}, {name := hnb0_ctr_prefix & "ranap.cs.rab_act.fail", mtype := "c", min := 0, max := 0} }; - if (f_osmo_repo_is("nightly")) { - f_statsd_expect(expect); - } + f_statsd_expect(expect); f_create_rab(pars.mgcp_pars); @@ -1571,9 +1569,7 @@ {name := hnb0_ctr_prefix & "ranap.cs.rab_act.cnf", mtype := "c", min := 1, max := 1}, {name := hnb0_ctr_prefix & "ranap.cs.rab_act.fail", mtype := "c", min := 0, max := 0} }; - if (f_osmo_repo_is("nightly")) { - f_statsd_expect(expect); - } + f_statsd_expect(expect); /* Send Iu Release */ tx := valueof(ts_RANAP_IuReleaseCommand(pars.rab_rel_cause)); @@ -1622,9 +1618,7 @@ {name := hnb0_ctr_prefix & "ranap.cs.rab_act.cnf", mtype := "c", min := 0, max := 0}, {name := hnb0_ctr_prefix & "ranap.cs.rab_act.fail", mtype := "c", min := 0, max := 0} }; - if (f_osmo_repo_is("nightly")) { - f_statsd_expect(expect); - } + f_statsd_expect(expect); f_rab_ass_req(pars.mgcp_pars); @@ -1637,9 +1631,7 @@ {name := hnb0_ctr_prefix & "ranap.cs.rab_act.cnf", mtype := "c", min := 0, max := 0}, {name := hnb0_ctr_prefix & "ranap.cs.rab_act.fail", mtype := "c", min := 1, max := 1} }; - if (f_osmo_repo_is("nightly")) { - f_statsd_expect(expect); - } + f_statsd_expect(expect); T.start; @@ -1689,9 +1681,7 @@ var StatsDExpects expect := { {name := hnb0_ctr_prefix & ctr_name, mtype := "c", min := 0, max := 0} }; - if (f_osmo_repo_is("nightly")) { - f_statsd_expect(expect); - } + f_statsd_expect(expect); /* Send RAB Release */ tx := valueof(ts_RANAP_RabAssReq(rab_rl := ts_RAB_RL(t_RAB_id(23), pars.rab_rel_cause))); @@ -1700,9 +1690,7 @@ expect := { {name := hnb0_ctr_prefix & ctr_name, mtype := "c", min := 1, max := 1} }; - if (f_osmo_repo_is("nightly")) { - f_statsd_expect(expect); - } + f_statsd_expect(expect); T.start; @@ -3049,12 +3037,7 @@ execute( TC_sgsnpool_sccp_n_pcstate_detaches_cnlink() ); execute( TC_sgsnpool_sccp_n_pcstate_attaches_cnlink() ); - /* Run only on nightly since it makes osmo-hnbgw <= 1.5.0 crash: OS#6253 */ - if (f_osmo_repo_is("nightly")) { - execute(TC_second_rab_assignment()); - } - - /* Run at the end since it makes osmo-hnbgw <= 1.3.0 crash: OS#5676 */ + execute(TC_second_rab_assignment()); execute(TC_hnb_reregister_reuse_sctp_assoc()); /* Run at the end since it messes with the SCCP config */ -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37627?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie1336a7372a46439cf53e38a555f36d0201fa230 Gerrit-Change-Number: 37627 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

11 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: msc: remove <= 1.11.x code path

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37628?usp=email ) Change subject: msc: remove <= 1.11.x code path ...................................................................... msc: remove <= 1.11.x code path Change-Id: I865f53ca0e6dd90401f8cabe5c60ad812d91e5bb --- M msc/MSC_Tests.ttcn 1 file changed, 10 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/28/37628/1 diff --git a/msc/MSC_Tests.ttcn b/msc/MSC_Tests.ttcn index a503d20..283ced6 100644 --- a/msc/MSC_Tests.ttcn +++ b/msc/MSC_Tests.ttcn @@ -7527,11 +7527,7 @@ execute( TC_gsup_mt_sms_rp_mr() ); execute( TC_gsup_mo_mt_sms_rp_mr() ); execute( TC_gsup_mt_multi_part_sms() ); - if (Misc_Helpers.f_osmo_repo_is("nightly")) { - /* timer X36 is not supported by osmo-msc <= 1.11.1 - * Related: osmo-msc.git Ic519cab55d65e47b2636124427dab1a1d80fab78 */ - execute( TC_gsup_mt_sms_lu_delay() ); - } + execute( TC_gsup_mt_sms_lu_delay() ); execute( TC_lu_and_mo_ussd_single_request() ); execute( TC_lu_and_mt_ussd_notification() ); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37628?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I865f53ca0e6dd90401f8cabe5c60ad812d91e5bb Gerrit-Change-Number: 37628 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

11 months

1
0
0 0

[M] Change in docker-playground[master]: ttcn3-stp-test: remove <= 1.8.x code path

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/37626?usp=email ) Change subject: ttcn3-stp-test: remove <= 1.8.x code path ...................................................................... ttcn3-stp-test: remove <= 1.8.x code path Change-Id: I3c134df2e194dbad47261eed5c0b3b54ed39a383 --- M ttcn3-stp-test/jenkins.sh D ttcn3-stp-test/osmo-stp-tcp.confmerge M ttcn3-stp-test/osmo-stp.cfg 3 files changed, 36 insertions(+), 35 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/26/37626/1 diff --git a/ttcn3-stp-test/jenkins.sh b/ttcn3-stp-test/jenkins.sh index 9975f5e..35393e3 100755 --- a/ttcn3-stp-test/jenkins.sh +++ b/ttcn3-stp-test/jenkins.sh @@ -16,13 +16,6 @@ mkdir $VOL_BASE_DIR/stp cp osmo-stp.cfg $VOL_BASE_DIR/stp/ -# XXX: M3UA-over-TCP is not supported by osmo-stp <= 1.8.1 -if osmo_repo_is_nightly; then - osmo-config-merge ./osmo-stp.cfg \ - ./osmo-stp-tcp.confmerge \ - > "$VOL_BASE_DIR/stp/osmo-stp.cfg" -fi - network_create network_replace_subnet_in_configs diff --git a/ttcn3-stp-test/osmo-stp-tcp.confmerge b/ttcn3-stp-test/osmo-stp-tcp.confmerge deleted file mode 100644 index 8772c35..0000000 --- a/ttcn3-stp-test/osmo-stp-tcp.confmerge +++ /dev/null @@ -1,28 +0,0 @@ -cs7 instance 0 - asp asp-sender-tcp 9999 2905 m3ua tcp - local-ip 172.18.19.200 - local-ip fd02:db8:19::200 - remote-ip 172.18.19.203 - remote-ip fd02:db8:19::203 - role sg - transport-role server - asp asp-client0-tcp 10002 2906 m3ua tcp - local-ip 172.18.19.200 - local-ip fd02:db8:19::200 - remote-ip 172.18.19.203 - remote-ip fd02:db8:19::203 - role asp - transport-role client - as as-sender-tcp m3ua - asp asp-sender-tcp - routing-key 1123 123 - as as-client-tcp m3ua - routing-key 1155 155 - asp asp-client0-tcp - route-table system - update route 123 16777215 linkset as-sender-tcp - update route 155 16777215 linkset as-client-tcp - listen m3ua 2905 tcp - local-ip 172.18.19.200 - local-ip fd02:db8:19::200 - accept-asp-connections dynamic-permitted diff --git a/ttcn3-stp-test/osmo-stp.cfg b/ttcn3-stp-test/osmo-stp.cfg index 28e2363..16181c2 100644 --- a/ttcn3-stp-test/osmo-stp.cfg +++ b/ttcn3-stp-test/osmo-stp.cfg @@ -21,6 +21,33 @@ ! cs7 instance 0 point-code format 24 + asp asp-sender-tcp 9999 2905 m3ua tcp + local-ip 172.18.19.200 + local-ip fd02:db8:19::200 + remote-ip 172.18.19.203 + remote-ip fd02:db8:19::203 + role sg + transport-role server + asp asp-client0-tcp 10002 2906 m3ua tcp + local-ip 172.18.19.200 + local-ip fd02:db8:19::200 + remote-ip 172.18.19.203 + remote-ip fd02:db8:19::203 + role asp + transport-role client + as as-sender-tcp m3ua + asp asp-sender-tcp + routing-key 1123 123 + as as-client-tcp m3ua + routing-key 1155 155 + asp asp-client0-tcp + route-table system + update route 123 16777215 linkset as-sender-tcp + update route 155 16777215 linkset as-client-tcp + listen m3ua 2905 tcp + local-ip 172.18.19.200 + local-ip fd02:db8:19::200 + accept-asp-connections dynamic-permitted ! !M3UA AS/ASP: ! -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/37626?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I3c134df2e194dbad47261eed5c0b3b54ed39a383 Gerrit-Change-Number: 37626 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

11 months

1
0
0 0

[S] Change in osmo-ggsn[master]: gtp: Allow tx Direct Tunnel Flags in UpdatePDPCtx{Req,Resp}

by osmith

Attention is currently required from: daniel, laforge, pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/37594?usp=email ) Change subject: gtp: Allow tx Direct Tunnel Flags in UpdatePDPCtx{Req,Resp} ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/37594?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I36d93619e2fe9cafd3092515df18b82d29099d2d Gerrit-Change-Number: 37594 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Fri, 26 Jul 2024 10:45:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

11 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: ggsn: Fix function name

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37616?usp=email ) ( 2 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: ggsn: Fix function name ...................................................................... ggsn: Fix function name The function is used to handle a UpdatePDPCtxResp, not a Req. While at it, mark the function as private. Change-Id: Ia455af1cd64ffce53b454e611c4fc85816e785bc --- M ggsn_tests/GGSN_Tests.ttcn 1 file changed, 14 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, approved diff --git a/ggsn_tests/GGSN_Tests.ttcn b/ggsn_tests/GGSN_Tests.ttcn index 23a9924..3f373aa 100644 --- a/ggsn_tests/GGSN_Tests.ttcn +++ b/ggsn_tests/GGSN_Tests.ttcn @@ -472,7 +472,7 @@ setverdict(pass); } - function f_handle_update_req(inout PdpContext ctx, in Gtp1cUnitdata ud, in OCT1 exp_cause := '80'O) runs on GT_CT { + private function f_handle_update_resp(inout PdpContext ctx, in Gtp1cUnitdata ud, in OCT1 exp_cause := '80'O) runs on GT_CT { var UpdatePDPContextResponseGGSN upr := ud.gtpc.gtpc_pdu.updatePDPContextResponse.updatePDPContextResponseGGSN; if (exp_cause == '80'O and exp_cause == upr.cause.causevalue) { ctx.teid_remote := upr.teidDataI.teidDataI; @@ -828,7 +828,7 @@ d := activate(pingpong()); alt { [] GTPC.receive(tr_GTPC_MsgType(g_peer_c, updatePDPContextResponse, ctx.teic)) -> value ud { - f_handle_update_req(ctx, ud, exp_cause); + f_handle_update_resp(ctx, ud, exp_cause); } } deactivate(d); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37616?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia455af1cd64ffce53b454e611c4fc85816e785bc Gerrit-Change-Number: 37616 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

11 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: sgsn: Validate Direct Tunnel Flags DTI=1 is set during UpdatePDPConte...

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37598?usp=email ) ( 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: sgsn: Validate Direct Tunnel Flags DTI=1 is set during UpdatePDPContextReq ...................................................................... sgsn: Validate Direct Tunnel Flags DTI=1 is set during UpdatePDPContextReq Related: SYS#5435 Change-Id: Iadd30318d02fbc304f65840f2299e5ec8b5b08e9 --- M sgsn/BSSGP_ConnHdlr.ttcn 1 file changed, 17 insertions(+), 0 deletions(-) Approvals: fixeria: Looks good to me, approved Jenkins Builder: Verified diff --git a/sgsn/BSSGP_ConnHdlr.ttcn b/sgsn/BSSGP_ConnHdlr.ttcn index fcadffc..d62f7f8 100644 --- a/sgsn/BSSGP_ConnHdlr.ttcn +++ b/sgsn/BSSGP_ConnHdlr.ttcn @@ -696,6 +696,13 @@ function f_process_gtp_ctx_upd_req(inout PdpActPars apars, PDU_GTPC gtpc, integer ran_index := 0) runs on BSSGP_ConnHdlr { var UpdatePDPContextRequestSGSN upd := gtpc.gtpc_pdu.updatePDPContextRequest.updatePDPContextRequestSGSN; + + if (not ispresent(upd.directTunnelFlags) or upd.directTunnelFlags.dTI != '1'B) { + Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, + log2str("Rx UpdatePDPCtxReq with Direct Tunnel Flags ", + upd.directTunnelFlags, " vs exp DTI=1")); + } + if (ispresent(upd.teidControlPlane.teidControlPlane)) { apars.sgsn_tei_c := upd.teidControlPlane.teidControlPlane; } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37598?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iadd30318d02fbc304f65840f2299e5ec8b5b08e9 Gerrit-Change-Number: 37598 Gerrit-PatchSet: 5 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

11 months

1
0
0 0

[L] Change in osmo-ttcn3-hacks[master]: sgsn: Introduce test TC_attach_pdp_act_user

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37593?usp=email ) Change subject: sgsn: Introduce test TC_attach_pdp_act_user ...................................................................... sgsn: Introduce test TC_attach_pdp_act_user Related: SYS#5435 Change-Id: I5f0cb51457395d95bde22732b032786211cb7b61 --- M sgsn/BSSGP_ConnHdlr.ttcn M sgsn/SGSN_Tests_Iu.ttcn M sgsn/expected-results.xml 3 files changed, 247 insertions(+), 53 deletions(-) Approvals: osmith: Looks good to me, approved pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/sgsn/BSSGP_ConnHdlr.ttcn b/sgsn/BSSGP_ConnHdlr.ttcn index 5847ac0..fcadffc 100644 --- a/sgsn/BSSGP_ConnHdlr.ttcn +++ b/sgsn/BSSGP_ConnHdlr.ttcn @@ -4,6 +4,7 @@ import from Osmocom_Types all; import from GSM_Types all; import from Native_Functions all; +import from Misc_Helpers all; import from NS_Types all; import from NS_Emulation all; import from BSSGP_Types all; @@ -23,10 +24,12 @@ import from IPA_Emulation all; import from RAN_Adapter all; +import from RANAP_Constants all; +import from RANAP_PDU_Descriptions all; +import from RANAP_PDU_Contents all; +import from RANAP_IEs all; import from RAN_Emulation all; import from RANAP_Templates all; -import from RANAP_PDU_Descriptions all; -import from RANAP_IEs all; import from GTPv1C_CodecPort all; import from GTPv1U_CodecPort all; @@ -51,6 +54,9 @@ /* Emulated GGSN is at GTP_ConnHdlr.GTP[0] */ const integer GTP_GGSN_IDX := 0; +private function ran2gtp_idx(integer ran_index) return integer { + return ran_index + 1 - NUM_GB; +} type component BSSGP_ConnHdlr extends BSSGP_Client_CT, GSUP_ConnHdlr, GTP_ConnHdlr, RAN_ConnHdlr { var BSSGP_ConnHdlrPars g_pars; @@ -145,7 +151,7 @@ /* tell GSUP dispatcher to send this IMSI to us */ f_create_gsup_expect(hex2str(g_pars.imsi)); /* tell GTP dispatcher to send this IMSI to us */ - f_gtp_register_imsi(g_pars.imsi); + f_gtp_register_imsi(g_pars.imsi, GTP_GGSN_IDX); g_Tguard.start(pars.t_guard); activate(as_Tguard()); @@ -489,6 +495,8 @@ /* IuPS case: Expect Iu Release */ if (is_iu(ran_index)) { as_iu_release_compl_disc(); + /* Next message will be an InitialUE since conn was torn down */ + g_pars.rnc_send_initial_ue := true; } /* Race condition @@ -603,6 +611,51 @@ } } +/* Iu only */ +altstep as_service_request(integer ran_index := 0) runs on BSSGP_ConnHdlr { + var PDU_DTAP_PS_MT mt; + + [] BSSAP.receive(tr_PDU_DTAP_PS_MT(tr_GMM_SERVICE_ACC)) -> value mt { + setverdict(pass); + } + [] BSSAP.receive(tr_PDU_DTAP_PS_MT(tr_GMM_SERVICE_REJ)) { + setverdict(fail, "Unexpected Service Reject"); + mtc.stop; + } + [] BSSAP.receive(tr_RANAP_SecurityModeCmd(uia_algs := ?, + uia_key := oct2bit(g_pars.vec.ik), + key_sts := ?)) { + var IntegrityProtectionAlgorithm uia_chosen := 0; /* 0 = standard_UMTS_integrity_algorithm_UIA1 */ + BSSAP.send(ts_RANAP_SecurityModeComplete(uia_chosen)); + BSSAP.receive(tr_RANAP_CommonId(imsi_hex2oct(g_pars.imsi))) + repeat; + } +} + +function f_service_request(ServiceType service_type := SERVICE_TYPE_Signalling, + integer ran_index := 0, + float Tval := 2.0) runs on BSSGP_ConnHdlr { + timer T := Tval; + + if (not is_iu(ran_index)) { + Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, + "GMM Service Request called on non-Iu RAN index"); + } + + + f_send_l3(ts_GMM_SERVICE_REQ(service_type, p_tmsi := g_pars.p_tmsi), ran_index); + + T.start; + alt { + [] as_service_request(ran_index) { setverdict(pass); } + [] BSSAP.receive { repeat; } + [] T.timeout { + Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, + "Timeout completing the RAU procedure"); + } + } +} + type record PdpActPars { BIT3 tid, /* L3 Transaction ID */ BIT4 nsapi, /* SNDCP NSAPI */ @@ -621,6 +674,9 @@ octetstring ggsn_ip_u, /* GGSN IP User */ OCT1 ggsn_restart_ctr, /* GGSN Restart Counter */ + OCT4 rnc_tei_u, /* SGSN TEI User */ + octetstring rnc_ip_u, /* SGSN IP USer */ + OCT4 sgsn_tei_c optional, /* SGSN TEI Control */ OCT4 sgsn_tei_u optional, /* SGSN TEI User */ octetstring sgsn_ip_c optional, /* SGSN IP Control */ @@ -634,33 +690,26 @@ apars.sgsn_tei_u := gtpc_rx.createPDPContextRequest.teidDataI.teidDataI; apars.sgsn_ip_c := gtpc_rx.createPDPContextRequest.sgsn_addr_signalling.addressf; apars.sgsn_ip_u := gtpc_rx.createPDPContextRequest.sgsn_addr_traffic.addressf; - f_gtp_register_teid(apars.ggsn_tei_c); - f_gtp_register_teid(apars.ggsn_tei_u); + f_gtp_register_teid(apars.ggsn_tei_c, GTP_GGSN_IDX); + f_gtp_register_teid(apars.ggsn_tei_u, GTP_GGSN_IDX); } -function f_pdp_ctx_act(inout PdpActPars apars, boolean send_recovery := false, integer ran_index := 0) -runs on BSSGP_ConnHdlr { +function f_process_gtp_ctx_upd_req(inout PdpActPars apars, PDU_GTPC gtpc, integer ran_index := 0) runs on BSSGP_ConnHdlr { + var UpdatePDPContextRequestSGSN upd := gtpc.gtpc_pdu.updatePDPContextRequest.updatePDPContextRequestSGSN; + if (ispresent(upd.teidControlPlane.teidControlPlane)) { + apars.sgsn_tei_c := upd.teidControlPlane.teidControlPlane; + } + apars.sgsn_tei_u := upd.teidDataI.teidDataI; + apars.sgsn_ip_c := upd.sgsn_addr_controlPlane.addressf; + apars.sgsn_ip_u := upd.sgsn_addr_traffic.addressf; + f_gtp_register_teid(apars.rnc_tei_u, ran2gtp_idx(ran_index)); + /* TODO: If "Direct Tunnel" flag, update apars.rnc_{tei,ip}_u instead, + * and store "direct_tunnel" in ggsn state */ +} + +altstep as_pdp_ctx_act_gb(inout PdpActPars apars, integer ran_index := 0) runs on BSSGP_ConnHdlr { var boolean exp_rej := ispresent(apars.exp_rej_cause); - var Gtp1cUnitdata g_ud; - var template Recovery_gtpc recovery := omit; - if (send_recovery) { - recovery := ts_Recovery(apars.ggsn_restart_ctr); - } - - f_send_l3(ts_SM_ACT_PDP_REQ(apars.tid, apars.nsapi, apars.sapi, apars.qos, apars.addr, - apars.apn, apars.pco), ran_index); - GTP[GTP_GGSN_IDX].receive(tr_GTPC_MsgType(?, createPDPContextRequest, ?)) -> value g_ud { - f_process_gtp_ctx_act_req(apars, g_ud.gtpc); - var integer seq_nr := oct2int(g_ud.gtpc.opt_part.sequenceNumber); - GTP[GTP_GGSN_IDX].send(ts_GTPC_CreatePdpResp(g_ud.peer, seq_nr, - apars.sgsn_tei_c, apars.gtp_resp_cause, - apars.ggsn_tei_c, apars.ggsn_tei_u, - apars.nsapi, - apars.ggsn_ip_c, apars.ggsn_ip_u, apars.chg_id, - omit, recovery)); - } - alt { [exp_rej] BSSGP[ran_index].receive(tr_SM_ACT_PDP_REJ(apars.tid, apars.exp_rej_cause)) { setverdict(pass); } @@ -680,6 +729,92 @@ setverdict(pass); } [] as_xid(apars, ran_index); +} +altstep as_pdp_ctx_act_iu(inout PdpActPars apars, integer ran_index := 0) runs on BSSGP_ConnHdlr { + var boolean exp_rej := ispresent(apars.exp_rej_cause); + + [exp_rej] BSSAP.receive(tr_PDU_DTAP_PS_MT(tr_SM_ACT_PDP_REJ(apars.tid, apars.exp_rej_cause))) { + setverdict(pass); + } + [exp_rej] BSSAP.receive(tr_PDU_DTAP_PS_MT(tr_SM_ACT_PDP_ACCEPT)) { + setverdict(fail, "Unexpected PDP CTX ACT ACC"); + mtc.stop; + } + [not exp_rej] BSSAP.receive(tr_PDU_DTAP_PS_MT(tr_SM_ACT_PDP_REJ(apars.tid, ?))) { + setverdict(fail, "Unexpected PDP CTX ACT FAIL"); + mtc.stop; + } + [not exp_rej] BSSAP.receive(tr_PDU_DTAP_PS_MT(tr_SM_ACT_PDP_REJ(apars.tid, ?))) { + setverdict(fail, "Unexpected PDP CTX ACT FAIL"); + mtc.stop; + } + [not exp_rej] BSSAP.receive(tr_PDU_DTAP_PS_MT(tr_SM_ACT_PDP_ACCEPT(apars.tid, apars.sapi))) { + setverdict(pass); + } +} +altstep as_pdp_ctx_act(inout PdpActPars apars, integer ran_index := 0) runs on BSSGP_ConnHdlr { + [is_gb(ran_index)] as_pdp_ctx_act_gb(apars, ran_index); + [is_iu(ran_index)] as_pdp_ctx_act_iu(apars, ran_index); +} + +function f_pdp_ctx_act(inout PdpActPars apars, boolean send_recovery := false, integer ran_index := 0, float Tval := 5.0) +runs on BSSGP_ConnHdlr { + var Gtp1cUnitdata g_ud; + var template Recovery_gtpc recovery := omit; + timer T := Tval; + + f_send_l3(ts_SM_ACT_PDP_REQ(apars.tid, apars.nsapi, apars.sapi, apars.qos, apars.addr, + apars.apn, apars.pco), ran_index); + + if (send_recovery) { + recovery := ts_Recovery(apars.ggsn_restart_ctr); + } + GTP[GTP_GGSN_IDX].receive(tr_GTPC_MsgType(?, createPDPContextRequest, ?)) -> value g_ud { + f_process_gtp_ctx_act_req(apars, g_ud.gtpc); + var integer seq_nr := oct2int(g_ud.gtpc.opt_part.sequenceNumber); + GTP[GTP_GGSN_IDX].send(ts_GTPC_CreatePdpResp(g_ud.peer, seq_nr, + apars.sgsn_tei_c, apars.gtp_resp_cause, + apars.ggsn_tei_c, apars.ggsn_tei_u, + apars.nsapi, + apars.ggsn_ip_c, apars.ggsn_ip_u, apars.chg_id, + omit, recovery)); + } + + T.start; + if (is_iu(ran_index)) { + var RANAP_PDU ranap; + alt { + [] BSSAP.receive(tr_RANAP_RabAssReq(?)) -> value ranap { + var RAB_ID rab_id := f_ranap_rab_ass_req_extract_rab_id(ranap); + var template (value) RAB_SetupOrModifiedList l; + l := ts_RAB_SMdL_ps(rab_id, oct2bit(apars.rnc_ip_u), apars.rnc_tei_u); + BSSAP.send(ts_RANAP_RabAssResp(l)); + + GTP[GTP_GGSN_IDX].receive(tr_GTPC_MsgType(?, updatePDPContextRequest, ?)) -> value g_ud { + f_process_gtp_ctx_upd_req(apars, g_ud.gtpc, ran_index); + var integer seq_nr := oct2int(g_ud.gtpc.opt_part.sequenceNumber); + GTP[GTP_GGSN_IDX].send(ts_GTPC_UpdatePdpRespGGSN(g_ud.peer, seq_nr, + apars.sgsn_tei_c, apars.gtp_resp_cause, + apars.ggsn_tei_c, apars.ggsn_tei_u, + apars.ggsn_ip_c, apars.ggsn_ip_u, apars.chg_id, + omit, recovery)); + } + } + [] T.timeout { + Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, + "Timeout waiting for RANAP RAB AssReq"); + } + } + } + + alt { + [] as_pdp_ctx_act(apars, ran_index) { setverdict(pass); } + [is_gb(ran_index)] BSSGP[ran_index].receive { repeat; } + [is_iu(ran_index)] BSSAP.receive { repeat; } + [] T.timeout { + Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, + "Timeout completing the PDP ACT"); + } } } @@ -691,15 +826,17 @@ f_send_l3(ts_SM_DEACT_PDP_REQ_MO(apars.tid, cause, false, omit), ran_index); GTP[GTP_GGSN_IDX].receive(tr_GTPC_MsgType(?, deletePDPContextRequest, apars.ggsn_tei_c)) -> value g_ud { var integer seq_nr := oct2int(g_ud.gtpc.opt_part.sequenceNumber); - BSSGP[ran_index].clear; + if (is_gb(ran_index)) { + BSSGP[ran_index].clear; + } GTP[GTP_GGSN_IDX].send(ts_GTPC_DeletePdpResp(g_ud.peer, seq_nr, apars.sgsn_tei_c, '7F'O)); } alt { - [] BSSGP[ran_index].receive(tr_SM_DEACT_PDP_ACCEPT_MT(apars.tid)) { - setverdict(pass); - } - [] as_xid(apars, ran_index); + [is_gb(ran_index)] BSSGP[ran_index].receive(tr_SM_DEACT_PDP_ACCEPT_MT(apars.tid)); + [is_gb(ran_index)] as_xid(apars, ran_index); + [is_iu(ran_index)] BSSAP.receive(tr_PDU_DTAP_PS_MT(tr_SM_DEACT_PDP_ACCEPT_MT(apars.tid))); } + setverdict(pass); } function f_pdp_ctx_deact_mt(inout PdpActPars apars, boolean error_ind := false, integer ran_index := 0) @@ -720,7 +857,10 @@ T.start; alt { - [] BSSGP[ran_index].receive(tr_SM_DEACT_PDP_REQ_MT(apars.tid, ?, true)) { + [is_gb(ran_index)] BSSGP[ran_index].receive(tr_SM_DEACT_PDP_REQ_MT(apars.tid, ?, true)) { + f_send_l3(ts_SM_DEACT_PDP_ACCEPT_MO(apars.tid), ran_index); + } + [is_iu(ran_index)] BSSAP.receive(tr_PDU_DTAP_PS_MT(tr_SM_DEACT_PDP_REQ_MT(apars.tid, ?, true))) { f_send_l3(ts_SM_DEACT_PDP_ACCEPT_MO(apars.tid), ran_index); } [not error_ind] GTP[GTP_GGSN_IDX].receive(tr_GTPC_MsgType(?, deletePDPContextResponse, apars.ggsn_tei_c)) { @@ -782,7 +922,8 @@ addressInfo := omit } -template (value) PdpActPars t_PdpActPars(charstring ggsn_ip) := { +template (value) PdpActPars t_PdpActPars(charstring ggsn_ip, + charstring rnc_ip := "127.0.0.1") := { tid := '000'B, nsapi := '0101'B, /* < 5 are reserved */ sapi := '0011'B, /* 3/5/9/11 */ @@ -801,6 +942,9 @@ ggsn_ip_u := f_inet_addr(ggsn_ip), ggsn_restart_ctr := int2oct(2, 1), + rnc_tei_u := f_rnd_octstring(4), + rnc_ip_u := f_inet_addr(rnc_ip), + sgsn_tei_c := omit, sgsn_tei_u := omit, sgsn_ip_c := omit, @@ -863,40 +1007,52 @@ } } -/* Transceive given 'payload' as MT message from GTP -> OsmoSGSN -> Gb */ +/* Transceive given 'payload' as MT message from GTP -> OsmoSGSN -> {Gb,Iu} */ function f_gtpu_xceive_mt(inout PdpActPars apars, octetstring payload, integer ran_index := 0, boolean expect_fwd := true) runs on BSSGP_ConnHdlr { timer T := 5.0; /* Send PDU via GTP from our simulated GGSN to the SGSN */ f_gtpu_send(apars, payload); T.start; - /* Expect PDU via BSSGP/LLC on simulated PCU from SGSN */ + alt { - [] as_xid(apars, ran_index); + /* Expect PDU via BSSGP/LLC on simulated PCU from SGSN: */ + [is_gb(ran_index)] as_xid(apars, ran_index); //[] BSSGP[ran_index].receive(tr_BD_SNDCP(apars.sapi, tr_SN_UD(apars.nsapi, payload))); - [expect_fwd] BSSGP[ran_index].receive(tr_SN_UD(apars.nsapi, payload)); - [expect_fwd] T.timeout { - setverdict(fail, "Timeout waiting for GTP-U to appear on BSSGP"); - mtc.stop; + [is_gb(ran_index) and expect_fwd] BSSGP[ran_index].receive(tr_SN_UD(apars.nsapi, payload)); + [is_gb(ran_index) and not expect_fwd] BSSGP[ran_index].receive(tr_SN_UD(apars.nsapi, payload)) { + Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, "GTP-U forwarded to BSSGP but not expected"); } - [not expect_fwd] BSSGP[ran_index].receive(tr_SN_UD(apars.nsapi, payload)) { - setverdict(fail, "GTP-U forwarded to BSSGP but not expected") - mtc.stop; + /* Expect PDU directly from RNC (Direct Tunnel): */ + [is_iu(ran_index) and expect_fwd] GTP[ran2gtp_idx(ran_index)].receive(tr_GTPU_GPDU(valueof(ts_GtpPeerU(apars.ggsn_ip_u)), apars.rnc_tei_u, payload)); + [is_iu(ran_index) and not expect_fwd] GTP[ran2gtp_idx(ran_index)].receive(tr_GTPU_GPDU(valueof(ts_GtpPeerU(apars.ggsn_ip_u)), apars.rnc_tei_u, payload)) { + Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, "GTP-U forwarded to BSSGP but not expected") + } + [expect_fwd] T.timeout { + Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, "Timeout waiting for GTP-U to appear on Gb/Iu"); } [not expect_fwd] T.timeout {} } } -/* Transceive given 'payload' as MO message from Gb -> OsmoSGSN -> GTP */ +/* Transceive given 'payload' as MO message from {Gb,Iu} -> OsmoSGSN -> GTP */ function f_gtpu_xceive_mo(inout PdpActPars apars, octetstring payload, integer ran_index := 0, uint9_t n_u := 0) runs on BSSGP_ConnHdlr { - /* Send PDU via SNDCP/LLC/BSSGP/NS via simulated MS/PCU to the SGSN */ - var Gtp1uPeer peer := valueof(ts_GtpPeerU(apars.sgsn_ip_u)); - var PDU_SN sndcp := valueof(ts_SN_UD(apars.nsapi, payload)); - BSSGP[ran_index].send(ts_LLC_UI(enc_PDU_SN(sndcp), apars.sapi, '0'B, n_u)); - /* Expect PDU via GTP from SGSN on simulated GGSN */ + var Gtp1uPeer rx_peer; + + if (is_gb(ran_index)) { + /* Send PDU via SNDCP/LLC/BSSGP/NS via simulated MS/PCU to the SGSN: */ + rx_peer := valueof(ts_GtpPeerU(apars.sgsn_ip_u)); + var PDU_SN sndcp := valueof(ts_SN_UD(apars.nsapi, payload)); + BSSGP[ran_index].send(ts_LLC_UI(enc_PDU_SN(sndcp), apars.sapi, '0'B, n_u)); + } else if (is_iu(ran_index)) { + /* Send PDU via GTPv1U from simulated MS/RNC directly to the simulated GGSN: */ + rx_peer := valueof(ts_GtpPeerU(apars.rnc_ip_u)); + GTP[ran2gtp_idx(ran_index)].send(ts_GTP1U_GPDU(valueof(ts_GtpPeerU(apars.ggsn_ip_u)), 0 /*seq*/, apars.ggsn_tei_u, payload)); + } + /* Expect PDU via GTP from RNC/SGSN on simulated GGSN */ alt { - [] GTP[GTP_GGSN_IDX].receive(tr_GTPU_GPDU(peer, apars.ggsn_tei_u, payload)); + [] GTP[GTP_GGSN_IDX].receive(tr_GTPU_GPDU(rx_peer, apars.ggsn_tei_u, payload)); } } diff --git a/sgsn/SGSN_Tests_Iu.ttcn b/sgsn/SGSN_Tests_Iu.ttcn index 84679cd..7ee4c51 100644 --- a/sgsn/SGSN_Tests_Iu.ttcn +++ b/sgsn/SGSN_Tests_Iu.ttcn @@ -23,7 +23,7 @@ } private function f_TC_iu_attach(charstring id) runs on BSSGP_ConnHdlr { - var PdpActPars apars := valueof(t_PdpActPars(mp_ggsn_ip)); + var PdpActPars apars := valueof(t_PdpActPars(mp_ggsn_ip, mp_ranap_cfg[0].sctp_addr.local_ip_addr)); /* first perform regular attach */ f_gmm_attach(umts_aka_challenge := true, force_gsm_sres := false, ran_index := 3); @@ -69,7 +69,7 @@ } private function f_TC_iu_attach_geran_rau(charstring id) runs on BSSGP_ConnHdlr { - var PdpActPars apars := valueof(t_PdpActPars(mp_ggsn_ip)); + var PdpActPars apars := valueof(t_PdpActPars(mp_ggsn_ip, mp_ranap_cfg[0].sctp_addr.local_ip_addr)); /* first perform regular attach */ f_gmm_attach(umts_aka_challenge := true, force_gsm_sres := false, ran_index := 3); @@ -95,7 +95,7 @@ } private function f_TC_geran_attach_iu_rau(charstring id) runs on BSSGP_ConnHdlr { - var PdpActPars apars := valueof(t_PdpActPars(mp_ggsn_ip)); + var PdpActPars apars := valueof(t_PdpActPars(mp_ggsn_ip, mp_ranap_cfg[0].sctp_addr.local_ip_addr)); /* first perform regular attach */ f_gmm_attach(umts_aka_challenge := true, force_gsm_sres := false, ran_index := 0); @@ -117,11 +117,38 @@ f_cleanup(); } +private function f_TC_attach_pdp_act_user(charstring id) runs on BSSGP_ConnHdlr { + var PdpActPars apars := valueof(t_PdpActPars(mp_ggsn_ip, mp_ranap_cfg[0].sctp_addr.local_ip_addr)); + + /* first perform regular attach */ + f_gmm_attach(umts_aka_challenge := true, force_gsm_sres := false, ran_index := 3); + + f_service_request(ran_index := 3); + + f_pdp_ctx_act(apars, ran_index := 3); + + /* then transceive a downlink PDU */ + f_gtpu_xceive_mt(apars, f_rnd_octstring(100), ran_index := 3); + f_gtpu_xceive_mo(apars, f_rnd_octstring(200), ran_index := 3); + + f_pdp_ctx_deact_mo(apars, '00'O, ran_index := 3); + setverdict(pass); +} +testcase TC_attach_pdp_act_user() runs on test_CT { + var BSSGP_ConnHdlr vc_conn; + f_init(); + f_sleep(1.0); + vc_conn := f_start_handler(refers(f_TC_attach_pdp_act_user), testcasename(), g_gb, 1001); + vc_conn.done; + f_cleanup(); +} + control { execute( TC_iu_attach() ); execute( TC_iu_attach_encr() ); execute( TC_iu_attach_geran_rau() ); execute( TC_geran_attach_iu_rau() ); + execute( TC_attach_pdp_act_user() ); } diff --git a/sgsn/expected-results.xml b/sgsn/expected-results.xml index 4dde651..1e7367d 100644 --- a/sgsn/expected-results.xml +++ b/sgsn/expected-results.xml @@ -92,6 +92,7 @@ <testcase classname='SGSN_Tests_Iu' name='TC_iu_attach_encr' time='MASKED'/> <testcase classname='SGSN_Tests_Iu' name='TC_iu_attach_geran_rau' time='MASKED'/> <testcase classname='SGSN_Tests_Iu' name='TC_geran_attach_iu_rau' time='MASKED'/> + <testcase classname='SGSN_Tests_Iu' name='TC_attach_pdp_act_user' time='MASKED'/>  <testcase classname='SGSN_Tests_NS' name='TC_SNS_size' time='MASKED'/> <testcase classname='SGSN_Tests_NS' name='TC_SNS_size_too_big' time='MASKED'/> -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37593?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I5f0cb51457395d95bde22732b032786211cb7b61 Gerrit-Change-Number: 37593 Gerrit-PatchSet: 6 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

11 months

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: sgsn: Introduce test TC_attach_pdp_act_pmm_idle

by osmith

Attention is currently required from: fixeria, pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37617?usp=email ) Change subject: sgsn: Introduce test TC_attach_pdp_act_pmm_idle ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37617?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id46ccd9db11c8b792e1c071de91ef092ed1544c7 Gerrit-Change-Number: 37617 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 26 Jul 2024 10:42:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

11 months

1
0
0 0

2025

2024

2023

2022

gerrit-log July 2024