July 2024 - gerrit-log - lists.osmocom.org

[S] Change in osmo-bsc[master]: osmo_bsc_sigtran: Don't try to decode ipaccess_head a second time

by laforge

Attention is currently required from: daniel. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/37662?usp=email ) Change subject: osmo_bsc_sigtran: Don't try to decode ipaccess_head a second time ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: does this risk breaking functionality when built with older libosmocore? Or is this a follow-up fix to a commit that first introduced osmo_io support here? If so, please name the commit change-id that this fixes. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/37662?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I300bbab3c0215d52bc5f6232ace5c37a6613feb7 Gerrit-Change-Number: 37662 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Tue, 30 Jul 2024 09:36:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

10 months, 4 weeks

1
0
0 0

[M] Change in libosmocore[master]: codec: add osmo_hr_sid_classify()

by laforge

Attention is currently required from: falconia, fixeria, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/37558?usp=email ) Change subject: codec: add osmo_hr_sid_classify() ...................................................................... Patch Set 3: Code-Review+1 (1 comment) Patchset: PS3: Not critical, but I would appreciate if we could introduce a unit test with at least a few sample input data. This of course doesn't only apply to this new function but really to all of those classifiers. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/37558?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I5f4eb65379646125b966cf182775b6e9348900bd Gerrit-Change-Number: 37558 Gerrit-PatchSet: 3 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 30 Jul 2024 09:35:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

10 months, 4 weeks

1
0
0 0

[S] Change in osmo-ci[master]: OBS: fix changelog_add_entry_if_needed

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/37663?usp=email ) Change subject: OBS: fix changelog_add_entry_if_needed ...................................................................... OBS: fix changelog_add_entry_if_needed Fix a copy paste error, the variable is named version here, not latest_version. Fixes: 9b36d2a8 ("OBS: fix up-to-date check for strongswan-epdg") Change-Id: Idff3733d902be6f84bd62813f6e704267538a07b --- M scripts/obs/lib/debian.py 1 file changed, 14 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved fixeria: Looks good to me, but someone else must approve diff --git a/scripts/obs/lib/debian.py b/scripts/obs/lib/debian.py index 585c447..68459c8 100644 --- a/scripts/obs/lib/debian.py +++ b/scripts/obs/lib/debian.py @@ -121,7 +121,7 @@ pass # Debian versions must start with a digit - version = transform_version(latest_version) + version = transform_version(version) if version_changelog == version: return -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/37663?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Idff3733d902be6f84bd62813f6e704267538a07b Gerrit-Change-Number: 37663 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

10 months, 4 weeks

1
0
0 0

[S] Change in osmo-ci[master]: OBS: fix changelog_add_entry_if_needed

by laforge

Attention is currently required from: daniel, osmith, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/37663?usp=email ) Change subject: OBS: fix changelog_add_entry_if_needed ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/37663?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Idff3733d902be6f84bd62813f6e704267538a07b Gerrit-Change-Number: 37663 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Tue, 30 Jul 2024 09:34:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

10 months, 4 weeks

1
0
0 0

[S] Change in osmo-ci[master]: OBS: fix changelog_add_entry_if_needed

by fixeria

Attention is currently required from: daniel, osmith, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/37663?usp=email ) Change subject: OBS: fix changelog_add_entry_if_needed ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/37663?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Idff3733d902be6f84bd62813f6e704267538a07b Gerrit-Change-Number: 37663 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Tue, 30 Jul 2024 09:17:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

10 months, 4 weeks

1
0
0 0

[M] Change in libosmocore[master]: codec: add osmo_hr_sid_classify()

by osmith

Attention is currently required from: falconia, fixeria, laforge, pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/37558?usp=email ) Change subject: codec: add osmo_hr_sid_classify() ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: > @osmith@sysmocom.de looks like a regression of your recent patches. yep, fixed it and retriggered CI for patches that failed because of this. https://gerrit.osmocom.org/c/osmo-ci/+/37663 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/37558?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I5f4eb65379646125b966cf182775b6e9348900bd Gerrit-Change-Number: 37558 Gerrit-PatchSet: 3 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 30 Jul 2024 09:15:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: falconia <falcon(a)freecalypso.org> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

10 months, 4 weeks

1
0
0 0

[S] Change in osmo-ci[master]: OBS: fix changelog_add_entry_if_needed

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/37663?usp=email ) Change subject: OBS: fix changelog_add_entry_if_needed ...................................................................... OBS: fix changelog_add_entry_if_needed Fix a copy paste error, the variable is named version here, not latest_version. Fixes: 9b36d2a8 ("OBS: fix up-to-date check for strongswan-epdg") Change-Id: Idff3733d902be6f84bd62813f6e704267538a07b --- M scripts/obs/lib/debian.py 1 file changed, 14 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/63/37663/1 diff --git a/scripts/obs/lib/debian.py b/scripts/obs/lib/debian.py index 585c447..68459c8 100644 --- a/scripts/obs/lib/debian.py +++ b/scripts/obs/lib/debian.py @@ -121,7 +121,7 @@ pass # Debian versions must start with a digit - version = transform_version(latest_version) + version = transform_version(version) if version_changelog == version: return -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/37663?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Idff3733d902be6f84bd62813f6e704267538a07b Gerrit-Change-Number: 37663 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

10 months, 4 weeks

1
0
0 0

[S] Change in osmo-bsc[master]: osmo_bsc_sigtran: Don't try to decode ipaccess_head a second time

by pespin

Attention is currently required from: daniel. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/37662?usp=email ) Change subject: osmo_bsc_sigtran: Don't try to decode ipaccess_head a second time ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Patchset: PS1: IIUC this is not really a fix of a bug, but simply a code cleanup/improvement right? -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/37662?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I300bbab3c0215d52bc5f6232ace5c37a6613feb7 Gerrit-Change-Number: 37662 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Tue, 30 Jul 2024 08:54:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

10 months, 4 weeks

1
0
0 0

[S] Change in libosmo-netif[master]: ipa: Ensure osmo_ipa_segmentation_cb sets msg->l2h to the payload data

by pespin

Attention is currently required from: daniel. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/37661?usp=email ) Change subject: ipa: Ensure osmo_ipa_segmentation_cb sets msg->l2h to the payload data ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Patchset: PS1: Sounds like this deserves a patch release? -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/37661?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Id91cddf9948ca49abf092850fae3a8f17e445b45 Gerrit-Change-Number: 37661 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Tue, 30 Jul 2024 08:52:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

10 months, 4 weeks

1
0
0 0

[S] Change in osmo-bsc[master]: osmo_bsc_sigtran: Don't try to decode ipaccess_head a second time

by daniel

daniel has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/37662?usp=email ) Change subject: osmo_bsc_sigtran: Don't try to decode ipaccess_head a second time ...................................................................... osmo_bsc_sigtran: Don't try to decode ipaccess_head a second time osmo_io segmentation will already parse the ipaccess_header and set msg->data to the payload of the control command. Depends: Id91cddf9948ca49abf092850fae3a8f17e445b45 (libosmo-netif.git) Related: OS#6422 Change-Id: I300bbab3c0215d52bc5f6232ace5c37a6613feb7 --- M src/osmo-bsc/osmo_bsc_sigtran.c 1 file changed, 16 insertions(+), 12 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/62/37662/1 diff --git a/src/osmo-bsc/osmo_bsc_sigtran.c b/src/osmo-bsc/osmo_bsc_sigtran.c index 224e2c6..cdc5785 100644 --- a/src/osmo-bsc/osmo_bsc_sigtran.c +++ b/src/osmo-bsc/osmo_bsc_sigtran.c @@ -38,6 +38,7 @@ #include <osmocom/bsc/paging.h> #include <osmocom/bsc/bssmap_reset.h> #include <osmocom/mgcp_client/mgcp_common.h> +#include <osmocom/netif/ipa.h> /* A pointer to a list with all involved MSCs * (a copy of the pointer location submitted with osmo_bsc_sigtran_init() */ @@ -733,9 +734,6 @@ * libosmo-sigtran doesn't know about, such as piggy-backed CTRL and/or MGCP */ static int asp_rx_unknown(struct osmo_ss7_asp *asp, int ppid_mux, struct msgb *msg) { - struct ipaccess_head *iph; - struct ipaccess_head_ext *iph_ext; - if (osmo_ss7_asp_get_proto(asp) != OSMO_SS7_ASP_PROT_IPA) { msgb_free(msg); return 0; @@ -743,15 +741,7 @@ switch (ppid_mux) { case IPAC_PROTO_OSMO: - if (msg->len < sizeof(*iph) + sizeof(*iph_ext)) { - LOGP(DMSC, LOGL_ERROR, "The message is too short.\n"); - msgb_free(msg); - return -EINVAL; - } - iph = (struct ipaccess_head *) msg->data; - iph_ext = (struct ipaccess_head_ext *) iph->data; - msg->l2h = iph_ext->data; - switch (iph_ext->proto) { + switch (osmo_ipa_msgb_cb_proto_ext(msg)) { case IPAC_PROTO_EXT_CTRL: return bsc_sccplite_rx_ctrl(asp, msg); case IPAC_PROTO_EXT_MGCP: -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/37662?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I300bbab3c0215d52bc5f6232ace5c37a6613feb7 Gerrit-Change-Number: 37662 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-MessageType: newchange

10 months, 4 weeks

1
0
0 0

2025

2024

2023

2022

gerrit-log July 2024