May 2024 - gerrit-log - lists.osmocom.org

[M] Change in osmo-msc[master]: libmsc: add X5 timer for delaying LU transactions

by fixeria

Attention is currently required from: laforge, neels, pespin. Hello Jenkins Builder, laforge, neels, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-msc/+/36760?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Code-Review+1 by laforge, Code-Review-1 by neels, Verified+1 by Jenkins Builder Change subject: libmsc: add X5 timer for delaying LU transactions ...................................................................... libmsc: add X5 timer for delaying LU transactions The idea is to allow re-using the radio channel that was used for Location Updating to deliver MT SMS over GSUP. This is achieved by delaying release of a BSSAP/RANAP connection and thus delaying the release of the radio channel. The delay can be configured using new timer X5 (default 0 ms), separately for GERAN and UTRAN. Change-Id: Ic519cab55d65e47b2636124427dab1a1d80fab78 Related: osmo-ttcn3-hacks.git I74fa174ea649adb2112c8e471c0e339a2197a08d Related: SYS#6913 --- M include/osmocom/msc/msc_a.h M src/libmsc/msc_a.c M src/libmsc/ran_infra.c 3 files changed, 63 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/60/36760/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/36760?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ic519cab55d65e47b2636124427dab1a1d80fab78 Gerrit-Change-Number: 36760 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 year, 1 month

1
0
0 0

[M] Change in osmo-msc[master]: libmsc: add X5 timer for delaying LU transactions

by fixeria

Attention is currently required from: neels, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/36760?usp=email ) Change subject: libmsc: add X5 timer for delaying LU transactions ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: There is definitely some confusion here. The commit message clearly states MT SMS over GSUP, which is not using the MSC's internal SMSC. The customer explicitly requested to implement this delay for the SMS over GSUP user case. Neels: what you're describing applies to the MSC's built-in SMSC. It already does deliver MT SMS just fine using the existing LU transaction (grep for `S_SUBSCR_ATTACHED`). And yes, we do check the SMS queue before put()ing the LU token. However things get a bit more complicated when using SMS over GSUP, i.e. external 3rd party SMSC. You cannot know in advance if there is pending SMS for a subscriber, and you cannot query that asynchronously because there exists no primitive for that. This is why we're adding this delay: to give the external SMSC a bit more time to deliver MT SMS, which can be sent over the existing RR connection. I did not ask the customer why or for what they want to optimize delivery of MT SMS during Location Updating, but I can imagine a use case of sending "welcome SMS" to newly registered subscribers. > Re Pau's remark, if you keep this patch with the timer delay instead of running the SMS queue like I am suggesting, some of msc_a_fsm_cleanup() or trans_free() should osmo_timer_del() the timer, to make very sure that the timer cb does not try to access a freed pointer. Oh, I get the point now. Will update the patch. > (A consideration: if we ever remove the SMS queue implementation from osmo-msc to a separate SMSC, there should be some async operation to ask for a pending SMS before releasing a conn. [...] AFAIK, there exists no such primitive/procedure in MAP protocol. We want to keep GSUP as close as possible to MAP, so I don't think we should be adding this. There is a concept of `readyForSM`, when after an unsuccessful MT SMS delivery attempt (e.g. subscriber was not present, did not respond to paging) the MSC/VLR sets `MNRF` flag and then sends this primitive when subscriber is back online. But this is a different thing. > I guess that's well under 5 seconds or alike in usual case? You both keep mentioning this, not sure where this 5 seconds comes from. It's a configurable value, which is expected to be set to accomodate for delay between the MSC and the external SMSC. The exact value may vary depending on the expected delay between CNI components. I am even considering to allow using milliseconds instead of seconds. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/36760?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ic519cab55d65e47b2636124427dab1a1d80fab78 Gerrit-Change-Number: 36760 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sat, 11 May 2024 11:11:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 year, 1 month

1
0
0 0

[S] Change in pysim[master]: pySim-trace: Support decoding of eUICC traces

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/36777?usp=email ) Change subject: pySim-trace: Support decoding of eUICC traces ...................................................................... pySim-trace: Support decoding of eUICC traces Let's register the ISD-R and ECASD applications so we avoid the warnings printed when processing an eUICC protocol trace: WARNING pySim.apdu.ts_102_221: SELECT UNKNOWN AID a0000005591010ffffffff8900000100 Change-Id: I362a1a7f12d979ff0b7971d5300db9ed56bb1ee5 --- M pySim-trace.py M pysim-testdata/pySim-trace_test_gsmtap.pcapng.ok 2 files changed, 19 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/pySim-trace.py b/pySim-trace.py index 91f50a3..be1d40b 100755 --- a/pySim-trace.py +++ b/pySim-trace.py @@ -14,6 +14,7 @@ from pySim.ts_102_221 import CardProfileUICC from pySim.ts_31_102 import CardApplicationUSIM from pySim.ts_31_103 import CardApplicationISIM +from pySim.euicc import CardApplicationISDR, CardApplicationECASD from pySim.transport import LinkBase from pySim.apdu_source.gsmtap import GsmtapApduSource @@ -78,6 +79,8 @@ profile = CardProfileUICC() profile.add_application(CardApplicationUSIM()) profile.add_application(CardApplicationISIM()) + profile.add_application(CardApplicationISDR()) + profile.add_application(CardApplicationECASD()) scc = SimCardCommands(transport=DummySimLink()) card = UiccCardBase(scc) self.rs = RuntimeState(card, profile) diff --git a/pysim-testdata/pySim-trace_test_gsmtap.pcapng.ok b/pysim-testdata/pySim-trace_test_gsmtap.pcapng.ok index 047f9de..b947983 100644 --- a/pysim-testdata/pySim-trace_test_gsmtap.pcapng.ok +++ b/pysim-testdata/pySim-trace_test_gsmtap.pcapng.ok @@ -3,6 +3,8 @@ Detected UICC Add-on "RUIM" Can't read AIDs from SIM -- 'list' object has no attribute 'lower' warning: EF.DIR seems to be empty! + ADF.ECASD: a0000005591010ffffffff8900000200 + ADF.ISD-R: a0000005591010ffffffff8900000100 ISIM: a0000000871004 USIM: a0000000871002 CardReset(3b9f96801f878031e073fe211b674a4c753034054ba9) -- To view, visit https://gerrit.osmocom.org/c/pysim/+/36777?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I362a1a7f12d979ff0b7971d5300db9ed56bb1ee5 Gerrit-Change-Number: 36777 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

1 year, 1 month

1
0
0 0

[S] Change in pysim[master]: pySim-trace: Support decoding of eUICC traces

by laforge

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/36777?usp=email ) Change subject: pySim-trace: Support decoding of eUICC traces ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/36777?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I362a1a7f12d979ff0b7971d5300db9ed56bb1ee5 Gerrit-Change-Number: 36777 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Fri, 10 May 2024 19:18:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 1 month

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: SIP_Templates: Allow setting transport in Via templates

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36780?usp=email ) Change subject: SIP_Templates: Allow setting transport in Via templates ...................................................................... SIP_Templates: Allow setting transport in Via templates This is needed when using IMS, since TCP is used. Change-Id: Id45491615bcb5c074ef4fc298cbb24b2e034972d --- M asterisk/SIP_ConnectionHandler.ttcn M library/SIP_Templates.ttcn 2 files changed, 17 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/80/36780/1 diff --git a/asterisk/SIP_ConnectionHandler.ttcn b/asterisk/SIP_ConnectionHandler.ttcn index 13b5f04..9c7cca5 100644 --- a/asterisk/SIP_ConnectionHandler.ttcn +++ b/asterisk/SIP_ConnectionHandler.ttcn @@ -178,6 +178,7 @@ { id := "received", paramValue := g_pars.remote_sip_host } }; */ return tr_Via_from(via_req.viaBody[0].sentBy, + via_req.viaBody[0].sentProtocol.transport, via_resp_params); } diff --git a/library/SIP_Templates.ttcn b/library/SIP_Templates.ttcn index 3492dc4..e22646c 100644 --- a/library/SIP_Templates.ttcn +++ b/library/SIP_Templates.ttcn @@ -372,22 +372,24 @@ mediaType := "application/sdp" }; -template (value) Via ts_Via_from(template (value) HostPort addr) := { +template (value) Via ts_Via_from(template (value) HostPort addr, + template (value) charstring transport := "UDP") := { fieldName := VIA_E, viaBody := { { - sentProtocol := { "SIP", "2.0", "UDP" }, + sentProtocol := { "SIP", "2.0", transport }, sentBy := addr, viaParams := omit } } } template (present) Via tr_Via_from(template (present) HostPort host_port := ?, + template (present) charstring transport := ?, template SemicolonParam_List viaParams := *) := { fieldName := VIA_E, viaBody := { { - sentProtocol := { "SIP", "2.0", "UDP" }, + sentProtocol := { "SIP", "2.0", ? }, sentBy := host_port, viaParams := viaParams } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36780?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id45491615bcb5c074ef4fc298cbb24b2e034972d Gerrit-Change-Number: 36780 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 1 month

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: SIP_Templates: Allow passing WwwAuthenticate to ts_SIP_msgh_std

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36781?usp=email ) Change subject: SIP_Templates: Allow passing WwwAuthenticate to ts_SIP_msgh_std ...................................................................... SIP_Templates: Allow passing WwwAuthenticate to ts_SIP_msgh_std The field could already be passed to its tr_* counterpart, but not the the ts_* one. Change-Id: Ibc6cc5320f24ce82165c1b2140bad30cb356f8ae --- M library/SIP_Templates.ttcn 1 file changed, 16 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/81/36781/1 diff --git a/library/SIP_Templates.ttcn b/library/SIP_Templates.ttcn index e22646c..2498f49 100644 --- a/library/SIP_Templates.ttcn +++ b/library/SIP_Templates.ttcn @@ -454,7 +454,8 @@ template (omit) ContentType content_type := omit, template (omit)Authorization authorization := omit, template (value) Method_List allow_methods := c_SIP_defaultMethods, - template (omit) Expires expires := omit + template (omit) Expires expires := omit, + template (omit) WwwAuthenticate wwwAuthenticate := omit ) modifies ts_SIP_msgHeader_empty := { allow := { fieldName := ALLOW_E, @@ -489,7 +490,8 @@ "osmo-ttcn3-hacks/0.23" } }, - via := via + via := via, + wwwAuthenticate := wwwAuthenticate } function tr_AllowMethods(template Method_List allow_methods) return template Allow { -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36781?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ibc6cc5320f24ce82165c1b2140bad30cb356f8ae Gerrit-Change-Number: 36781 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 1 month

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: SIP_Templates: Allow passing Require,Security-client,Supported fields...

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36782?usp=email ) Change subject: SIP_Templates: Allow passing Require,Security-client,Supported fields to REGISTER templates ...................................................................... SIP_Templates: Allow passing Require,Security-client,Supported fields to REGISTER templates These fields are used in IMS. Change-Id: I20a0df5633db8c0e7732659c1316b85e63317afc --- M library/SIP_Templates.ttcn 1 file changed, 84 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/82/36782/1 diff --git a/library/SIP_Templates.ttcn b/library/SIP_Templates.ttcn index 2498f49..7e33b3b 100644 --- a/library/SIP_Templates.ttcn +++ b/library/SIP_Templates.ttcn @@ -197,6 +197,28 @@ deltaSec := deltaSec } + +// [20.32] +template (value) Require ts_Require(template (value) OptionTag_List optionsTags := {}) := { + fieldName := REQUIRE_E, + optionsTags := optionsTags +} +template (present) Require tr_Require(template (present) OptionTag_List optionsTags := ?) := { + fieldName := REQUIRE_E, + optionsTags := optionsTags +} + +// [20.37] +template (value) Supported ts_Supported(template (value) OptionTag_List optionsTags := {}) := { + fieldName := SUPPORTED_E, + optionsTags := optionsTags +} +template (present) Supported tr_Supported(template (present) OptionTag_List optionsTags := ?) := { + fieldName := SUPPORTED_E, + optionsTags := optionsTags +} + + template (value) SipAddr ts_SipAddr(template (value) HostPort host_port, template (omit) UserInfo user_info := omit, template (omit) charstring displayName := omit, @@ -442,6 +464,31 @@ challenge := challenge } +// RFC3329 +template (present) Security_client +tr_Security_client(template (present) Security_mechanism_list sec_mechanism_list := ?) := { + fieldName := SECURITY_CLIENT_E, + sec_mechanism_list := sec_mechanism_list +} +template (value) Security_client +ts_Security_client(template (value) Security_mechanism_list sec_mechanism_list) := { + fieldName := SECURITY_CLIENT_E, + sec_mechanism_list := sec_mechanism_list +} + +template (present) Security_mechanism +tr_Security_mechanism(template (present) charstring name := ?, + template SemicolonParam_List params := *) := { + mechanism_name := name, + mechanism_params := params +} +template (value) Security_mechanism +ts_Security_mechanism(template (value) charstring name, + template (omit) SemicolonParam_List params := omit) := { + mechanism_name := name, + mechanism_params := params +} + template (value) MessageHeader ts_SIP_msgHeader_empty := c_SIP_msgHeader_empty; template (value) MessageHeader ts_SIP_msgh_std(template (value) CallidString call_id, @@ -455,6 +502,9 @@ template (omit)Authorization authorization := omit, template (value) Method_List allow_methods := c_SIP_defaultMethods, template (omit) Expires expires := omit, + template (omit) Require require := omit, + template (omit) Security_client security_client := omit, + template (omit) Supported supported := omit, template (omit) WwwAuthenticate wwwAuthenticate := omit ) modifies ts_SIP_msgHeader_empty := { allow := { @@ -479,6 +529,9 @@ addressField := from_addr.addr, fromParams := from_addr.params }, + require := require, + security_client := security_client, + supported := supported, toField := { fieldName := TO_E, addressField := to_addr.addr, @@ -520,6 +573,9 @@ template integer seq_nr := ?, template Method_List allow_methods := *, template Expires expires := *, + template Require require := *, + template Security_client security_client := *, + template Supported supported := *, template WwwAuthenticate wwwAuthenticate := * ) modifies t_SIP_msgHeader_any := { allow := tr_AllowMethods(allow_methods), @@ -540,6 +596,9 @@ addressField := from_addr.addr, fromParams := from_addr.params }, + require := require, + security_client := security_client, + supported := supported, toField := { fieldName := TO_E, addressField := to_addr.addr, @@ -561,13 +620,19 @@ template (omit) Contact contact, template (omit) Expires expires, template (omit) Authorization authorization := omit, + template (omit) Require require := omit, + template (omit) Security_client security_client := omit, + template (omit) Supported supported := omit, template (omit) charstring body := omit) := { requestLine := ts_SIP_ReqLine(REGISTER_E, sip_url_host_port), msgHeader := ts_SIP_msgh_std(call_id, from_addr, to_addr, contact, "REGISTER", seq_nr, via, f_ContentTypeOrOmit(ts_CT_SDP, body), authorization := authorization, - expires := expires), + expires := expires, + require := require, + security_client := security_client, + supported := supported), messageBody := body, payload := omit } @@ -580,11 +645,17 @@ template integer seq_nr := *, template Contact contact := *, template Expires expires := *, + template Require require := *, + template Security_client security_client := *, + template Supported supported := *, template charstring body := *) := { requestLine := tr_SIP_ReqLine(REGISTER_E, sip_url_host_port), msgHeader := tr_SIP_msgh_std(call_id, from_addr, to_addr, contact, via, "REGISTER", *, seq_nr, - expires := expires), + expires := expires, + require := require, + security_client := security_client, + supported := supported), messageBody := body, payload := omit } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36782?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I20a0df5633db8c0e7732659c1316b85e63317afc Gerrit-Change-Number: 36782 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 1 month

1
0
0 0

[S] Change in pysim[master]: pySim-trace: Support decoding of eUICC traces

by laforge

Attention is currently required from: laforge. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/36777?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: pySim-trace: Support decoding of eUICC traces ...................................................................... pySim-trace: Support decoding of eUICC traces Let's register the ISD-R and ECASD applications so we avoid the warnings printed when processing an eUICC protocol trace: WARNING pySim.apdu.ts_102_221: SELECT UNKNOWN AID a0000005591010ffffffff8900000100 Change-Id: I362a1a7f12d979ff0b7971d5300db9ed56bb1ee5 --- M pySim-trace.py M pysim-testdata/pySim-trace_test_gsmtap.pcapng.ok 2 files changed, 19 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/77/36777/2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/36777?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I362a1a7f12d979ff0b7971d5300db9ed56bb1ee5 Gerrit-Change-Number: 36777 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newpatchset

1 year, 1 month

1
0
0 0

[S] Change in pysim[master]: pySim.global_platform: Fix key encryption with DEK

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/36779?usp=email ) Change subject: pySim.global_platform: Fix key encryption with DEK ...................................................................... pySim.global_platform: Fix key encryption with DEK When a SCP is active, the DEK is used to encrypt any key material that's installed using PUT KEY. The code prior to this patch fails to handle this case as it calls the encrypt_key() method on the wrong object. Change-Id: I6e10fb9c7881ba74ad2986c36bba95b336470838 --- M pySim/global_platform/__init__.py 1 file changed, 15 insertions(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/pySim/global_platform/__init__.py b/pySim/global_platform/__init__.py index 9960560..5086721 100644 --- a/pySim/global_platform/__init__.py +++ b/pySim/global_platform/__init__.py @@ -550,7 +550,7 @@ kcv = b2h(kcv_bin) if self._cmd.lchan.scc.scp: # encrypte key data with DEK of current SCP - kcb = b2h(self._cmd.lchan.scc.scp.card_keys.encrypt_key(h2b(opts.key_data[i]))) + kcb = b2h(self._cmd.lchan.scc.scp.encrypt_key(h2b(opts.key_data[i]))) else: # (for example) during personalization, DEK might not be required) kcb = opts.key_data[i] -- To view, visit https://gerrit.osmocom.org/c/pysim/+/36779?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I6e10fb9c7881ba74ad2986c36bba95b336470838 Gerrit-Change-Number: 36779 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

1 year, 1 month

1
0
0 0

[S] Change in pysim[master]: euicc: Fix shell command for SGP.31 get_certs

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/36778?usp=email ) Change subject: euicc: Fix shell command for SGP.31 get_certs ...................................................................... euicc: Fix shell command for SGP.31 get_certs Change-Id: I2e59070992bb522d14a5e4956f0d8e738a785dd8 --- M pySim/euicc.py 1 file changed, 11 insertions(+), 2 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/pySim/euicc.py b/pySim/euicc.py index 8b8b973..c27c91f 100644 --- a/pySim/euicc.py +++ b/pySim/euicc.py @@ -279,7 +279,7 @@ _construct = GreedyBytes class EuiccCertificate(BER_TLV_IE, tag=0xa6): _construct = GreedyBytes -class GetCertsError(BER_TLV_IE, tag=0x80): +class GetCertsError(BER_TLV_IE, tag=0x81): _construct = Enum(Int8ub, invalidCiPKId=1, undefinedError=127) class GetCertsResp(BER_TLV_IE, tag=0xbf56, nested=[EumCertificate, EuiccCertificate, GetCertsError]): pass @@ -501,7 +501,7 @@ """Perform an ES10c GetCerts() function on an IoT eUICC.""" gc = CardApplicationISDR.store_data_tlv(self._cmd.lchan.scc, GetCertsReq(), GetCertsResp) d = gc.to_dict() - self._cmd.poutput_json(flatten_dict_lists(d['get_certficiates_resp'])) + self._cmd.poutput_json(flatten_dict_lists(d['get_certs_resp'])) def do_get_eim_configuration_data(self, _opts): """Perform an ES10b GetEimConfigurationData function on an Iot eUICC.""" -- To view, visit https://gerrit.osmocom.org/c/pysim/+/36778?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I2e59070992bb522d14a5e4956f0d8e738a785dd8 Gerrit-Change-Number: 36778 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

1 year, 1 month

1
0
0 0

2025

2024

2023

2022

gerrit-log May 2024