May 2024 - gerrit-log - lists.osmocom.org

[S] Change in pysim[master]: filesystem: Enforce lower-case hex AID

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/36776?usp=email ) Change subject: filesystem: Enforce lower-case hex AID ...................................................................... filesystem: Enforce lower-case hex AID our utils.b2h() returns values in lower-case hex string notation, so let's make sure the CardADF and CardApplication AID values are also stored in lower case notation, othewise the matching baesd on AIDs returned from the card will not work, specifically as we use uppercase AIDs in pySim.euicc for CardApplicationECASD and CardApplicationISDR. Rather than change those two instances, let's solve it in a generic way. We already do the same for the CardFile.fid member. Change-Id: Ie42392412d9eb817fbc563d9165faab198ffa7a9 --- M pySim/filesystem.py 1 file changed, 22 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/pySim/filesystem.py b/pySim/filesystem.py index 4d5fde9..77482cc 100644 --- a/pySim/filesystem.py +++ b/pySim/filesystem.py @@ -512,7 +512,7 @@ super().__init__(**kwargs) # reference to CardApplication may be set from CardApplication constructor self.application = None # type: Optional[CardApplication] - self.aid = aid # Application Identifier + self.aid = aid.lower() # Application Identifier self.has_fs = has_fs # Flag to tell whether the ADF supports a filesystem or not mf = self.get_mf() if mf: @@ -1294,6 +1294,8 @@ adf : ADF name sw : Dict of status word conversions """ + if aid: + aid = aid.lower() self.name = name self.adf = adf self.sw = sw or {} -- To view, visit https://gerrit.osmocom.org/c/pysim/+/36776?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ie42392412d9eb817fbc563d9165faab198ffa7a9 Gerrit-Change-Number: 36776 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

1 year, 1 month

1
0
0 0

[S] Change in pysim[master]: filesystem: Enforce lower-case hex AID

by laforge

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/36776?usp=email ) Change subject: filesystem: Enforce lower-case hex AID ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Patchset: PS1: trivial fix -- To view, visit https://gerrit.osmocom.org/c/pysim/+/36776?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ie42392412d9eb817fbc563d9165faab198ffa7a9 Gerrit-Change-Number: 36776 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Fri, 10 May 2024 18:17:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 1 month

1
0
0 0

[S] Change in pysim[master]: pySim.global_platform: Fix key encryption with DEK

by laforge

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/36779?usp=email ) Change subject: pySim.global_platform: Fix key encryption with DEK ...................................................................... Patch Set 2: Code-Review+2 (1 comment) Patchset: PS2: trivial fix -- To view, visit https://gerrit.osmocom.org/c/pysim/+/36779?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I6e10fb9c7881ba74ad2986c36bba95b336470838 Gerrit-Change-Number: 36779 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Fri, 10 May 2024 18:16:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 1 month

1
0
0 0

[S] Change in pysim[master]: euicc: Fix shell command for SGP.31 get_certs

by laforge

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/36778?usp=email ) Change subject: euicc: Fix shell command for SGP.31 get_certs ...................................................................... Patch Set 2: Code-Review+2 (1 comment) Patchset: PS2: trivial fix -- To view, visit https://gerrit.osmocom.org/c/pysim/+/36778?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I2e59070992bb522d14a5e4956f0d8e738a785dd8 Gerrit-Change-Number: 36778 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Fri, 10 May 2024 18:16:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 1 month

1
0
0 0

[S] Change in osmo-mgw[master]: contrib/systemd: run as osmocom user

by pespin

Attention is currently required from: fixeria, lynxis lazus, msuraev, osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/30094?usp=email ) Change subject: contrib/systemd: run as osmocom user ...................................................................... Patch Set 8: (1 comment) Patchset: PS8: > -1: Please add a warning for the user, because you're changing something what the user doesn't expec […] Debian changelog is generated automatically when we do a new release. -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/30094?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ibb83c231231b39dc6732c0f375aeb3b21f3938ef Gerrit-Change-Number: 30094 Gerrit-PatchSet: 8 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Fri, 10 May 2024 18:11:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu> Gerrit-MessageType: comment

1 year, 1 month

1
0
0 0

[S] Change in pysim[master]: docs/shell: Add missing :ref: when referencing other command

by laforge

Attention is currently required from: laforge. Hello Jenkins Builder, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/36224?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: docs/shell: Add missing :ref: when referencing other command ...................................................................... docs/shell: Add missing :ref: when referencing other command Change-Id: I18f110e6313932d82b19ecaa7e07ef00c2339513 --- M docs/shell.rst 1 file changed, 10 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/24/36224/4 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/36224?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I18f110e6313932d82b19ecaa7e07ef00c2339513 Gerrit-Change-Number: 36224 Gerrit-PatchSet: 4 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newpatchset

1 year, 1 month

1
0
0 0

[S] Change in pysim[master]: filesystem: Enforce lower-case hex AID

by laforge

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/36776?usp=email ) Change subject: filesystem: Enforce lower-case hex AID ...................................................................... filesystem: Enforce lower-case hex AID our utils.b2h() returns values in lower-case hex string notation, so let's make sure the CardADF and CardApplication AID values are also stored in lower case notation, othewise the matching baesd on AIDs returned from the card will not work, specifically as we use uppercase AIDs in pySim.euicc for CardApplicationECASD and CardApplicationISDR. Rather than change those two instances, let's solve it in a generic way. We already do the same for the CardFile.fid member. Change-Id: Ie42392412d9eb817fbc563d9165faab198ffa7a9 --- M pySim/filesystem.py 1 file changed, 22 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/76/36776/1 diff --git a/pySim/filesystem.py b/pySim/filesystem.py index 4d5fde9..77482cc 100644 --- a/pySim/filesystem.py +++ b/pySim/filesystem.py @@ -512,7 +512,7 @@ super().__init__(**kwargs) # reference to CardApplication may be set from CardApplication constructor self.application = None # type: Optional[CardApplication] - self.aid = aid # Application Identifier + self.aid = aid.lower() # Application Identifier self.has_fs = has_fs # Flag to tell whether the ADF supports a filesystem or not mf = self.get_mf() if mf: @@ -1294,6 +1294,8 @@ adf : ADF name sw : Dict of status word conversions """ + if aid: + aid = aid.lower() self.name = name self.adf = adf self.sw = sw or {} -- To view, visit https://gerrit.osmocom.org/c/pysim/+/36776?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ie42392412d9eb817fbc563d9165faab198ffa7a9 Gerrit-Change-Number: 36776 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

1 year, 1 month

1
0
0 0

[S] Change in pysim[master]: euicc: Fix shell command for SGP.31 get_certs

by laforge

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/36778?usp=email ) Change subject: euicc: Fix shell command for SGP.31 get_certs ...................................................................... euicc: Fix shell command for SGP.31 get_certs Change-Id: I2e59070992bb522d14a5e4956f0d8e738a785dd8 --- M pySim/euicc.py 1 file changed, 11 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/78/36778/1 diff --git a/pySim/euicc.py b/pySim/euicc.py index 8b8b973..c27c91f 100644 --- a/pySim/euicc.py +++ b/pySim/euicc.py @@ -279,7 +279,7 @@ _construct = GreedyBytes class EuiccCertificate(BER_TLV_IE, tag=0xa6): _construct = GreedyBytes -class GetCertsError(BER_TLV_IE, tag=0x80): +class GetCertsError(BER_TLV_IE, tag=0x81): _construct = Enum(Int8ub, invalidCiPKId=1, undefinedError=127) class GetCertsResp(BER_TLV_IE, tag=0xbf56, nested=[EumCertificate, EuiccCertificate, GetCertsError]): pass @@ -501,7 +501,7 @@ """Perform an ES10c GetCerts() function on an IoT eUICC.""" gc = CardApplicationISDR.store_data_tlv(self._cmd.lchan.scc, GetCertsReq(), GetCertsResp) d = gc.to_dict() - self._cmd.poutput_json(flatten_dict_lists(d['get_certficiates_resp'])) + self._cmd.poutput_json(flatten_dict_lists(d['get_certs_resp'])) def do_get_eim_configuration_data(self, _opts): """Perform an ES10b GetEimConfigurationData function on an Iot eUICC.""" -- To view, visit https://gerrit.osmocom.org/c/pysim/+/36778?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I2e59070992bb522d14a5e4956f0d8e738a785dd8 Gerrit-Change-Number: 36778 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

1 year, 1 month

1
0
0 0

[S] Change in pysim[master]: pySim-trace: Support decoding of eUICC traces

by laforge

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/36777?usp=email ) Change subject: pySim-trace: Support decoding of eUICC traces ...................................................................... pySim-trace: Support decoding of eUICC traces Let's register the ISD-R and ECASD applications so we avoid the warnings printed when processing an eUICC protocol trace: WARNING pySim.apdu.ts_102_221: SELECT UNKNOWN AID a0000005591010ffffffff8900000100 Change-Id: I362a1a7f12d979ff0b7971d5300db9ed56bb1ee5 --- M pySim-trace.py 1 file changed, 17 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/77/36777/1 diff --git a/pySim-trace.py b/pySim-trace.py index 91f50a3..be1d40b 100755 --- a/pySim-trace.py +++ b/pySim-trace.py @@ -14,6 +14,7 @@ from pySim.ts_102_221 import CardProfileUICC from pySim.ts_31_102 import CardApplicationUSIM from pySim.ts_31_103 import CardApplicationISIM +from pySim.euicc import CardApplicationISDR, CardApplicationECASD from pySim.transport import LinkBase from pySim.apdu_source.gsmtap import GsmtapApduSource @@ -78,6 +79,8 @@ profile = CardProfileUICC() profile.add_application(CardApplicationUSIM()) profile.add_application(CardApplicationISIM()) + profile.add_application(CardApplicationISDR()) + profile.add_application(CardApplicationECASD()) scc = SimCardCommands(transport=DummySimLink()) card = UiccCardBase(scc) self.rs = RuntimeState(card, profile) -- To view, visit https://gerrit.osmocom.org/c/pysim/+/36777?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I362a1a7f12d979ff0b7971d5300db9ed56bb1ee5 Gerrit-Change-Number: 36777 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

1 year, 1 month

1
0
0 0

[S] Change in pysim[master]: pySim.global_platform: Fix key encryption with DEK

by laforge

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/36779?usp=email ) Change subject: pySim.global_platform: Fix key encryption with DEK ...................................................................... pySim.global_platform: Fix key encryption with DEK When a SCP is active, the DEK is used to encrypt any key material that's installed using PUT KEY. The code prior to this patch fails to handle this case as it calls the encrypt_key() method on the wrong object. Change-Id: I6e10fb9c7881ba74ad2986c36bba95b336470838 --- M pySim/global_platform/__init__.py 1 file changed, 15 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/79/36779/1 diff --git a/pySim/global_platform/__init__.py b/pySim/global_platform/__init__.py index 9960560..5086721 100644 --- a/pySim/global_platform/__init__.py +++ b/pySim/global_platform/__init__.py @@ -550,7 +550,7 @@ kcv = b2h(kcv_bin) if self._cmd.lchan.scc.scp: # encrypte key data with DEK of current SCP - kcb = b2h(self._cmd.lchan.scc.scp.card_keys.encrypt_key(h2b(opts.key_data[i]))) + kcb = b2h(self._cmd.lchan.scc.scp.encrypt_key(h2b(opts.key_data[i]))) else: # (for example) during personalization, DEK might not be required) kcb = opts.key_data[i] -- To view, visit https://gerrit.osmocom.org/c/pysim/+/36779?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I6e10fb9c7881ba74ad2986c36bba95b336470838 Gerrit-Change-Number: 36779 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

1 year, 1 month

1
0
0 0

2025

2024

2023

2022

gerrit-log May 2024