May 2024 - gerrit-log - lists.osmocom.org

[S] Change in osmo-mgw[master]: contrib/systemd: run as osmocom user

by osmith

Attention is currently required from: fixeria, lynxis lazus, msuraev. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/30094?usp=email ) Change subject: contrib/systemd: run as osmocom user ...................................................................... Patch Set 8: (1 comment) File debian/postinst: https://gerrit.osmocom.org/c/osmo-mgw/+/30094/comment/8715b23e_86e4d5ee PS8, Line 18: # Fix permissions of previous (root-owned) install (OS#4107) Please note that changing the user the Osmocom programs run as, from root to the new osmocom user, is a lot of effort. It affects lots of repositories, and I'm trying to do it consistently across all of them. So if we make such a change here, we would also need to do it with the other repositories (and for many the related changes were already merged: https://gerrit.osmocom.org/q/topic:nonroot+is:merged). The issue has also been open for 5 years at this point with previous attempts stuck as in WIP due the scope of having to adjust all repositories (and making sure it doesn't affect OE, ...), and I would be happy to have it finished up: https://osmocom.org/issues/4107 With that being said: > It would be great to show a warning or something, so the user know those file has been changed. One way to do it without introducing additional complexity could be `chown -v`, and `chmod -v`. But that also causes a line to be printed if the permissions do not change. ``` # chown -v osmocom:osmocom /etc/osmocom/osmo-mgw.cfg changed ownership of '/etc/osmocom/osmo-mgw.cfg' from root:root to osmocom:osmocom # chown -v osmocom:osmocom /etc/osmocom/osmo-mgw.cfg ownership of '/etc/osmocom/osmo-mgw.cfg' retained as osmocom:osmocom # chmod -v 0660 /etc/osmocom/osmo-mgw.cfg mode of '/etc/osmocom/osmo-mgw.cfg' retained as 0660 (rw-rw----) ``` > Can't you detect if this is an upgrade and from which version you're upgrading from? This doesn't really work for the nightly packages, and it would also mean that we need to hardcode the version that introduces this change for every repository into this postinst file. I'd rather avoid this effort, as mentioned this is already a big undertaking. Additionally, the more logic we put into such postinst files, the more likeyl they are to have bugs... IMHO it's better to just run this unconditionally, if we have to do this (and we do, because otherwise we break the feature that allows writing back config files). Since similar patches were already +2'd and merged, I suggest we do it the same way here. -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/30094?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ibb83c231231b39dc6732c0f375aeb3b21f3938ef Gerrit-Change-Number: 30094 Gerrit-PatchSet: 8 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Mon, 13 May 2024 07:54:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu> Gerrit-MessageType: comment

1 year, 1 month

1
0
0 0

[S] Change in ...osmo_dia2gsup[master]: debian/postinst: chmod +x

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/36773?usp=email ) Change subject: debian/postinst: chmod +x ...................................................................... debian/postinst: chmod +x Fixes: 240b43f3 ("contrib/systemd: run as osmocom user") Change-Id: I281d55eaa9e058018604544599e80e60fb0aca79 --- M debian/postinst 1 file changed, 10 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve osmith: Looks good to me, approved diff --git a/debian/postinst b/debian/postinst old mode 100644 new mode 100755 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/36773?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I281d55eaa9e058018604544599e80e60fb0aca79 Gerrit-Change-Number: 36773 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 1 month

1
0
0 0

[S] Change in ...osmo_dia2gsup[master]: debian/postinst: chmod +x

by osmith

osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/36773?usp=email ) Change subject: debian/postinst: chmod +x ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Patchset: PS1: trivial fixup -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/36773?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I281d55eaa9e058018604544599e80e60fb0aca79 Gerrit-Change-Number: 36773 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Mon, 13 May 2024 06:41:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 1 month

1
0
0 0

[M] Change in libosmo-netif[master]: contrib: remove rpm spec file

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/36725?usp=email ) Change subject: contrib: remove rpm spec file ...................................................................... contrib: remove rpm spec file Related: https://osmocom.org/news/255 Related: OS#6446 Change-Id: Iff549b7695512c76514ed8915c4807c455e2bdcc --- M Makefile.am M configure.ac D contrib/libosmo-netif.spec.in 3 files changed, 12 insertions(+), 87 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/Makefile.am b/Makefile.am index f50cd0f..fd03b74 100644 --- a/Makefile.am +++ b/Makefile.am @@ -9,7 +9,6 @@ EXTRA_DIST = \ .version \ README.md \ - contrib/libosmo-netif.spec.in \ debian \ git-version-gen \ $(NULL) diff --git a/configure.ac b/configure.ac index 6b4c2be..8016bdd 100644 --- a/configure.ac +++ b/configure.ac @@ -148,5 +148,4 @@ utils/Makefile tests/Makefile Doxyfile - Makefile - contrib/libosmo-netif.spec) + Makefile) diff --git a/contrib/libosmo-netif.spec.in b/contrib/libosmo-netif.spec.in deleted file mode 100644 index 4ac1302..0000000 --- a/contrib/libosmo-netif.spec.in +++ /dev/null @@ -1,84 +0,0 @@ -# -# spec file for package libosmo-netif -# -# Copyright (c) 2018 SUSE LINUX GmbH, Nuernberg, Germany. -# -# All modifications and additions to the file contributed by third parties -# remain the property of their copyright owners, unless otherwise agreed -# upon. The license for this file, and modifications and additions to the -# file, is the same license as for the pristine package itself (unless the -# license for the pristine package is not an Open Source License, in which -# case the license is the MIT License). An "Open Source License" is a -# license that conforms to the Open Source Definition (Version 1.9) -# published by the Open Source Initiative. - -Name: libosmo-netif -Version: @VERSION@ -Release: 0 -Summary: Osmocom library for muxed audio -License: GPL-2.0-or-later -Group: Productivity/Telephony/Utilities -URL: https://osmocom.org/projects/libosmo-netif -Source: %{name}-%{version}.tar.xz -BuildRequires: automake -BuildRequires: libtool >= 2 -BuildRequires: lksctp-tools-devel -BuildRequires: pkgconfig >= 0.20 -BuildRequires: pkgconfig(libosmocore) >= 1.9.0 -BuildRequires: pkgconfig(libosmogsm) >= 1.9.0 -BuildRequires: pkgconfig(libosmocodec) >= 1.9.0 - -%description -Network interface demuxer library for OsmoCom projects. - -%package -n libosmonetif11 -Summary: Osmocom library for muxed audio -License: AGPL-3.0-or-later -Group: System/Libraries - -%description -n libosmonetif11 -Network interface demuxer library for OsmoCom projects. - -%package -n libosmonetif-devel -Summary: Development files for the Osmocom muxed audio library -License: AGPL-3.0-or-later -Group: Development/Libraries/C and C++ -Requires: libosmonetif11 = %{version} - -%description -n libosmonetif-devel -Network interface demuxer library for OsmoCom projects. - -This subpackage contains libraries and header files for developing -applications that want to make use of libosmo-netif. - -%prep -%setup -q - -%build -echo "%{version}" >.tarball-version -autoreconf -fiv -%configure --enable-shared --disable-static --includedir="%{_includedir}/%{name}" -make %{?_smp_mflags} - -%install -%make_install -find %{buildroot} -type f -name "*.la" -delete -print - -%check -make %{?_smp_mflags} check || (find . -name testsuite.log -exec cat {} +) - -%post -n libosmonetif11 -p /sbin/ldconfig -%postun -n libosmonetif11 -p /sbin/ldconfig - -%files -n libosmonetif11 -%{_libdir}/libosmonetif.so.11* - -%files -n libosmonetif-devel -%license COPYING -%dir %{_includedir}/%{name} -%dir %{_includedir}/%{name}/osmocom -%{_includedir}/%{name}/osmocom/netif/ -%{_libdir}/libosmonetif.so -%{_libdir}/pkgconfig/libosmo-netif.pc - -%changelog -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/36725?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Iff549b7695512c76514ed8915c4807c455e2bdcc Gerrit-Change-Number: 36725 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 1 month

1
0
0 0

[M] Change in libosmo-sccp[master]: contrib: remove rpm spec file

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/36727?usp=email ) Change subject: contrib: remove rpm spec file ...................................................................... contrib: remove rpm spec file Related: https://osmocom.org/news/255 Related: OS#6446 Change-Id: Iff549b7695512c76514ed8915c4807c455e2bdcc --- M Makefile.am M configure.ac D contrib/libosmo-sccp.spec.in 3 files changed, 11 insertions(+), 206 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/Makefile.am b/Makefile.am index bece371..5a2cad4 100644 --- a/Makefile.am +++ b/Makefile.am @@ -9,7 +9,6 @@ EXTRA_DIST = \ .version \ README.md \ - contrib/libosmo-sccp.spec.in \ debian \ git-version-gen \ osmoappdesc.py \ diff --git a/configure.ac b/configure.ac index 322a57a..115fe67 100644 --- a/configure.ac +++ b/configure.ac @@ -206,6 +206,5 @@ doc/manuals/Makefile contrib/Makefile contrib/systemd/Makefile - contrib/libosmo-sccp.spec Doxyfile Makefile) diff --git a/contrib/libosmo-sccp.spec.in b/contrib/libosmo-sccp.spec.in deleted file mode 100644 index 9d70874..0000000 --- a/contrib/libosmo-sccp.spec.in +++ /dev/null @@ -1,204 +0,0 @@ -# -# spec file for package libosmo-sccp -# -# Copyright (c) 2018 SUSE LINUX GmbH, Nuernberg, Germany. -# -# All modifications and additions to the file contributed by third parties -# remain the property of their copyright owners, unless otherwise agreed -# upon. The license for this file, and modifications and additions to the -# file, is the same license as for the pristine package itself (unless the -# license for the pristine package is not an Open Source License, in which -# case the license is the MIT License). An "Open Source License" is a -# license that conforms to the Open Source Definition (Version 1.9) -# published by the Open Source Initiative. - -# Avoid "E: lto-no-text-in-archive" -# https://en.opensuse.org/openSUSE:LTO#Static_libraries -%if 0%{?suse_version} -%global _lto_cflags %{?_lto_cflags} -ffat-lto-objects -%endif - -Name: libosmo-sccp -Version: @VERSION@ -Release: 0 -Summary: Osmocom library for the A-bis interface between BTS and BSC -License: AGPL-3.0-or-later AND GPL-2.0-or-later -Group: Hardware/Mobile -URL: https://osmocom.org/projects/libosmo-sccp -Source: %{name}-%{version}.tar.xz -BuildRequires: automake >= 1.6 -BuildRequires: libtool >= 2 -BuildRequires: lksctp-tools-devel -BuildRequires: pkgconfig >= 0.20 -%if 0%{?suse_version} -BuildRequires: systemd-rpm-macros -%endif -BuildRequires: xz -BuildRequires: pkgconfig(libosmo-netif) >= 1.4.0 -BuildRequires: pkgconfig(libosmocore) >= 1.9.0 -BuildRequires: pkgconfig(libosmogsm) >= 1.9.0 -BuildRequires: pkgconfig(libosmovty) >= 1.9.0 -%{?systemd_requires} - -%description -SCCP is a network layer protocol that provides extended routing, flow -control, segmentation, connection-orientation, and error correction -facilities in Signaling System 7 telecommunications networks. SCCP is -heavily used in cellular networks such as GSM. - -%package -n libosmo-mtp-devel -Summary: Development files for the Osmocom MTP library -License: GPL-2.0-or-later -Group: Development/Libraries/C and C++ - -%description -n libosmo-mtp-devel -MTP is part of SS7 used for communication in Public Switched -Telephone Networks. - -This subpackage contains the development files for the Osmocom MTP -library. - -%package -n libosmo-sccp-devel -Summary: Development files for the Osmocom SCCP library -License: GPL-2.0-or-later -Group: Development/Libraries/C and C++ - -%description -n libosmo-sccp-devel -SCCP is a network layer protocol that provides routing, flow control, -segmentation, connection-orientation, and error correction facilities -in SS7 telecommunications networks. - -This subpackage contains the development files for the Osmocom SCCP -library. - -%package -n libosmo-sigtran9 -Summary: Osmocom SIGTRAN library -License: GPL-2.0-or-later -Group: System/Libraries - -%description -n libosmo-sigtran9 -Osmocom implementation of (parts of) SIGTRAN. - -%package -n libosmo-sigtran-devel -Summary: Development files for the Osmocom sigtran library -License: GPL-2.0-or-later -Group: Development/Libraries/C and C++ -Requires: libosmo-sigtran9 = %{version} - -%description -n libosmo-sigtran-devel -Osmocom implementation of (parts of) SIGTRAN. - -This subpackage contains the development files for the Osmocom -SIGTRAN library. - -%package -n libosmo-xua-devel -Summary: Development files for the Osmocom M2UA library -License: GPL-2.0-or-later -Group: Development/Libraries/C and C++ -Requires: libosmo-sigtran-devel = %{version} - -%description -n libosmo-xua-devel -M2UA provides an SCTP adaptation layer for MTP level 2 user messages -and service interface across an IP network. - -This subpackage contains the development files for the Osmocom M2UA -library. - -%package -n osmo-stp -Summary: Osmocom SIGTRAN STP (Signaling Transfer Point) -License: GPL-2.0-or-later -Group: Productivity/Telephony/Servers - -%description -n osmo-stp -This is the Osmocom (Open Source Mobile Communications) implementation -of a Signaling Transfer Point (STP) for SS7/SIGTRAN telecommunication -networks. At this point it is a very minimal implementation, missing -lots of the functionality usually present in a STP, such as Global Title -Routing, Global Title Translation. - -%prep -%setup -q - -%build -echo "%{version}" >.tarball-version -autoreconf -fiv -%configure \ - --enable-shared \ - --includedir="%{_includedir}/%{name}" \ - --docdir="%{_docdir}/%{name}" \ - --with-systemdsystemunitdir=%{_unitdir} -make %{?_smp_mflags} - -%install -%make_install -find %{buildroot} -type f -name "*.la" -delete -print - -%check -make %{?_smp_mflags} check || (find . -name testsuite.log -exec cat {} +) - -%post -n libosmo-sigtran9 -p /sbin/ldconfig -%postun -n libosmo-sigtran9 -p /sbin/ldconfig -%if 0%{?suse_version} -%preun -n osmo-stp %service_del_preun osmo-stp.service -%postun -n osmo-stp %service_del_postun osmo-stp.service -%endif -%pre -n osmo-stp -getent group osmocom >/dev/null || groupadd --system osmocom -getent passwd osmocom >/dev/null || useradd --system --gid osmocom --home-dir /var/lib/osmocom \ - --shell /sbin/nologin --comment "Open Source Mobile Communications" osmocom -%if 0%{?suse_version} -%service_add_pre osmo-stp.service -%endif - -%post -n osmo-stp -%if 0%{?suse_version} -%service_add_post osmo-stp.service -%endif -chown osmocom:osmocom /etc/osmocom/osmo-stp.cfg -chmod 0660 /etc/osmocom/osmo-stp.cfg -chown root:osmocom /etc/osmocom -chmod 2775 /etc/osmocom -mkdir -p /var/lib/osmocom -chown -R osmocom:osmocom /var/lib/osmocom - -%files -n libosmo-mtp-devel -%dir %{_includedir}/%{name} -%dir %{_includedir}/%{name}/osmocom -%{_includedir}/%{name}/osmocom/mtp/ -%{_libdir}/libmtp.a -%{_libdir}/pkgconfig/libosmo-mtp.pc - -%files -n libosmo-sccp-devel -%dir %{_includedir}/%{name} -%dir %{_includedir}/%{name}/osmocom -%{_includedir}/%{name}/osmocom/sccp/ -%{_libdir}/libsccp.a -%{_libdir}/pkgconfig/libosmo-sccp.pc - -%files -n libosmo-sigtran9 -%{_libdir}/libosmo-sigtran.so.9* - -%files -n libosmo-sigtran-devel -%dir %{_includedir}/%{name} -%dir %{_includedir}/%{name}/osmocom -%{_includedir}/%{name}/osmocom/sigtran -%{_libdir}/libosmo-sigtran.so -%{_libdir}/libosmo-sigtran.a -%{_libdir}/pkgconfig/libosmo-sigtran.pc - -%files -n libosmo-xua-devel -%{_libdir}/libxua.a -%{_libdir}/pkgconfig/libosmo-xua.pc - -%files -n osmo-stp -%{_bindir}/osmo-stp -%dir %{_sysconfdir}/osmocom -%config(noreplace) %{_sysconfdir}/osmocom/osmo-stp.cfg -%{_unitdir}/osmo-stp.service -%dir %{_docdir}/%{name} -%dir %{_docdir}/%{name}/examples -%dir %{_docdir}/%{name}/examples/osmo-stp -%{_docdir}/%{name}/examples/osmo-stp/osmo-stp.cfg -%{_docdir}/%{name}/examples/osmo-stp/osmo-stp-multihome.cfg - -%changelog -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/36727?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: Iff549b7695512c76514ed8915c4807c455e2bdcc Gerrit-Change-Number: 36727 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 1 month

1
0
0 0

[S] Change in libosmocore[master]: Omit octet 3a in mobile-terminating setup requests if speech version ...

by nt2mku

Attention is currently required from: nt2mku. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/36784?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: Omit octet 3a in mobile-terminating setup requests if speech version is GSM-FR only ...................................................................... Omit octet 3a in mobile-terminating setup requests if speech version is GSM-FR only Some early GSM phones (like the Siemens P1 Porty) do not accept a mobile-terminating call setup if octet 3a is present. If speech version is GSM-FR (v1, 0x00) only, omit octet 3a. Change-Id: Ia09abb32a8458384151a6ae28744835ea440fc5b --- M src/gsm/gsm48_ie.c 1 file changed, 19 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/84/36784/2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/36784?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ia09abb32a8458384151a6ae28744835ea440fc5b Gerrit-Change-Number: 36784 Gerrit-PatchSet: 2 Gerrit-Owner: nt2mku <degrunert.web(a)googlemail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: nt2mku <degrunert.web(a)googlemail.com> Gerrit-MessageType: newpatchset

1 year, 1 month

1
0
0 0

[S] Change in libosmocore[master]: Omit octet 3a in mobile-terminating setup requests if speech version ...

by Jenkins Builder

Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/36784?usp=email ) Change subject: Omit octet 3a in mobile-terminating setup requests if speech version is GSM-FR only ...................................................................... Patch Set 1: (1 comment) File src/gsm/gsm48_ie.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-16054): https://gerrit.osmocom.org/c/libosmocore/+/36784/comment/af277dc6_87732f13 PS1, Line 331: if(bcap->speech_ver[1] >= 0 || (bcap->speech_ver[0] & 0x0f) != 0x00) { space required before the open parenthesis '(' -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/36784?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ia09abb32a8458384151a6ae28744835ea440fc5b Gerrit-Change-Number: 36784 Gerrit-PatchSet: 1 Gerrit-Owner: nt2mku <degrunert.web(a)googlemail.com> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Sun, 12 May 2024 19:36:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 year, 1 month

1
0
0 0

[S] Change in libosmocore[master]: Omit octet 3a in mobile-terminating setup requests if speech version ...

by nt2mku

nt2mku has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/36784?usp=email ) Change subject: Omit octet 3a in mobile-terminating setup requests if speech version is GSM-FR only ...................................................................... Omit octet 3a in mobile-terminating setup requests if speech version is GSM-FR only Some early GSM phones (like the Siemens P1 Porty) do not accept a mobile-terminating call setup if octet 3a is present. If speech version is GSM-FR (v1, 0x00) only, omit octet 3a. Change-Id: Ia09abb32a8458384151a6ae28744835ea440fc5b --- M src/gsm/gsm48_ie.c 1 file changed, 19 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/84/36784/1 diff --git a/src/gsm/gsm48_ie.c b/src/gsm/gsm48_ie.c index b95609f..0d938d4 100644 --- a/src/gsm/gsm48_ie.c +++ b/src/gsm/gsm48_ie.c @@ -327,11 +327,14 @@ switch (bcap->transfer) { case GSM_MNCC_BCAP_SPEECH: - for (s = 0; bcap->speech_ver[s] >= 0; s++) { - i++; /* octet 3a etc */ - lv[i] = bcap->speech_ver[s]; - if (i == 2) /* octet 3a */ - lv[i] |= bcap->speech_ctm << 5; + /* if we have only one speech version, which is FR, skip octet 3a */ + if(bcap->speech_ver[1] >= 0 || (bcap->speech_ver[0] & 0x0f) != 0x00) { + for (s = 0; bcap->speech_ver[s] >= 0; s++) { + i++; /* octet 3a etc */ + lv[i] = bcap->speech_ver[s]; + if (i == 2) /* octet 3a */ + lv[i] |= bcap->speech_ctm << 5; + } } lv[i] |= 0x80; /* last IE of octet 3 etc */ break; -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/36784?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ia09abb32a8458384151a6ae28744835ea440fc5b Gerrit-Change-Number: 36784 Gerrit-PatchSet: 1 Gerrit-Owner: nt2mku <degrunert.web(a)googlemail.com> Gerrit-MessageType: newchange

1 year, 1 month

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: SIP_Templates: Allow passing Require,Security-client,Supported fields...

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36782?usp=email ) Change subject: SIP_Templates: Allow passing Require,Security-client,Supported fields to REGISTER templates ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36782?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I20a0df5633db8c0e7732659c1316b85e63317afc Gerrit-Change-Number: 36782 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sun, 12 May 2024 13:01:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 1 month

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: SIP_Templates: Allow passing WwwAuthenticate to ts_SIP_msgh_std

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36781?usp=email ) Change subject: SIP_Templates: Allow passing WwwAuthenticate to ts_SIP_msgh_std ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36781?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ibc6cc5320f24ce82165c1b2140bad30cb356f8ae Gerrit-Change-Number: 36781 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sun, 12 May 2024 13:01:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 1 month

1
0
0 0

2025

2024

2023

2022

gerrit-log May 2024