April 2024 - gerrit-log - lists.osmocom.org

[S] Change in osmo-ttcn3-hacks[master]: library: GTPv1C: fix ts_MM_Context{GSM,UMTS} templates

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36599?usp=email ) Change subject: library: GTPv1C: fix ts_MM_Context{GSM,UMTS} templates ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36599?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic8abb048f7c1fa795ee472820c5b88de0073dc66 Gerrit-Change-Number: 36599 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 18 Apr 2024 22:24:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 2 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: library: GTPv1C: make ts_GTPC_SGSNContextAck more compact

by pespin

Attention is currently required from: fixeria, osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36598?usp=email ) Change subject: library: GTPv1C: make ts_GTPC_SGSNContextAck more compact ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36598?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9b0c948f295fd73fad79c8d09b45fd992c90a015 Gerrit-Change-Number: 36598 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 18 Apr 2024 22:24:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 2 months

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: sgsn: TC_sgsn_context_req_in: match PDP Context IE

by fixeria

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36601?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: sgsn: TC_sgsn_context_req_in: match PDP Context IE ...................................................................... sgsn: TC_sgsn_context_req_in: match PDP Context IE Change-Id: I965c0200ea380c55dc0cd8d3f8e5110883ce2646 Related: SYS#6603, OS#6294 --- M library/GTPv1C_Templates.ttcn M sgsn/SGSN_Tests.ttcn 2 files changed, 87 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/01/36601/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36601?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I965c0200ea380c55dc0cd8d3f8e5110883ce2646 Gerrit-Change-Number: 36601 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset

1 year, 2 months

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: sgsn: TC_sgsn_context_req_in: match MM Context & GSN Address IEs

by fixeria

Attention is currently required from: fixeria. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36600?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: sgsn: TC_sgsn_context_req_in: match MM Context & GSN Address IEs ...................................................................... sgsn: TC_sgsn_context_req_in: match MM Context & GSN Address IEs Change-Id: Ie68794c309e548279381d044a3e34dcdf405084f Related: SYS#6603, OS#6294 --- M library/GTPv1C_Templates.ttcn M sgsn/SGSN_Tests.ttcn 2 files changed, 55 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/00/36600/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36600?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie68794c309e548279381d044a3e34dcdf405084f Gerrit-Change-Number: 36600 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 year, 2 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: library: GTPv1C: make ts_GTPC_SGSNContextAck more compact

by fixeria

Attention is currently required from: osmith, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36598?usp=email ) Change subject: library: GTPv1C: make ts_GTPC_SGSNContextAck more compact ...................................................................... Patch Set 1: (1 comment) File library/GTPv1C_Templates.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36598/comment/b6034b8b_b9d0… PS1, Line 1353: cause := GTP_CAUSE_REQUEST_ACCEPTED Note it's the default value here. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36598?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9b0c948f295fd73fad79c8d09b45fd992c90a015 Gerrit-Change-Number: 36598 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 18 Apr 2024 20:53:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 year, 2 months

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: sgsn: add testcases for SGSN Context Request procedure

by fixeria

Attention is currently required from: osmith, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36589?usp=email ) Change subject: sgsn: add testcases for SGSN Context Request procedure ...................................................................... Patch Set 2: (3 comments) File sgsn/SGSN_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36589/comment/127b479d_9cdf… PS1, Line 3772: Contect > Context Done https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36589/comment/2a90776b_d051… PS1, Line 3814: Contect > Context Done https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36589/comment/ab469934_806e… PS1, Line 3950: execute( TC_sgsn_context_req_in() ); > Ah indeed, there's no RAT type being sent in there, good point. Done -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36589?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If71de10897a8a9f6612cd46c760cd89c0299ac2c Gerrit-Change-Number: 36589 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 18 Apr 2024 20:52:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 year, 2 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: library: GTPv1C: fix ts_MM_Context{GSM,UMTS} templates

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36599?usp=email ) Change subject: library: GTPv1C: fix ts_MM_Context{GSM,UMTS} templates ...................................................................... library: GTPv1C: fix ts_MM_Context{GSM,UMTS} templates Set the values according to 3GPP TS 29.060 version 17.4.0 Release 17. * Field 'spare' is defined as 'Spare 1111' in Table 40 (missing '1'). * Field 'spare1' is defined as 'Spare 111' in Table 41. * Field 'security' must be set as per Table 47. Change-Id: Ic8abb048f7c1fa795ee472820c5b88de0073dc66 Fixes: f95460b55 "GTP_Templates: Add templates for some GTPv1C IEs" Fixes: fdde16846 "library: GTPv1C add ts_MM_ContextGSM" --- M library/GTPv1C_Templates.ttcn 1 file changed, 22 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/99/36599/1 diff --git a/library/GTPv1C_Templates.ttcn b/library/GTPv1C_Templates.ttcn index 0dc30be..e9cf797 100644 --- a/library/GTPv1C_Templates.ttcn +++ b/library/GTPv1C_Templates.ttcn @@ -346,10 +346,10 @@ mmcontGSM := { lengthf := 0, /* overwritten */ cksn := cksn, - spare := '00000'B, + spare := '11111'B, usedCipher := gea, - noofVectors := 0, - security := '00'B, /* XXX */ + noofVectors := 0, /* overwritten */ + security := '01'B, /* GSM key and triplets */ kc := kc, triplet := ''O, drx_par := '0000'O, @@ -372,9 +372,9 @@ usedGPRSIntegrityAlgorithm := '000'B, ugipai := '1'B, /* Integrity Protection not required */ gupii := '1'B, /* Ignore "Used GPRS integrity protection algorithm" field" */ - spare1 := '000'B, + spare1 := '111'B, noofVectors := 0, /* TODO: fill quintpuplets*/ - security := '01'B, /* UMTS key and quintuplets */ + security := '10'B, /* UMTS key and quintuplets */ ck := ck, ik := ik, quintupletlength := 0, /* overwritten */ -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36599?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic8abb048f7c1fa795ee472820c5b88de0073dc66 Gerrit-Change-Number: 36599 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 2 months

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: sgsn: add testcases for SGSN Context Request procedure

by fixeria

Attention is currently required from: fixeria, osmith, pespin. Hello Jenkins Builder, osmith, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36589?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by osmith, Code-Review+1 by pespin, Verified+1 by Jenkins Builder Change subject: sgsn: add testcases for SGSN Context Request procedure ...................................................................... sgsn: add testcases for SGSN Context Request procedure Change-Id: If71de10897a8a9f6612cd46c760cd89c0299ac2c Related: SYS#6603, OS#6294 --- M library/GTPv1C_Templates.ttcn M sgsn/SGSN_Tests.ttcn 2 files changed, 170 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/89/36589/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36589?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If71de10897a8a9f6612cd46c760cd89c0299ac2c Gerrit-Change-Number: 36589 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 year, 2 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: library: GTPv1C: make ts_GTPC_SGSNContextAck more compact

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36598?usp=email ) Change subject: library: GTPv1C: make ts_GTPC_SGSNContextAck more compact ...................................................................... library: GTPv1C: make ts_GTPC_SGSNContextAck more compact Change-Id: I9b0c948f295fd73fad79c8d09b45fd992c90a015 --- M library/GTPv1C_Templates.ttcn 1 file changed, 11 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/98/36598/1 diff --git a/library/GTPv1C_Templates.ttcn b/library/GTPv1C_Templates.ttcn index dcb8e60..0dc30be 100644 --- a/library/GTPv1C_Templates.ttcn +++ b/library/GTPv1C_Templates.ttcn @@ -1360,8 +1360,9 @@ private_extension_gtpc := omit } } + template (value) Gtp1cUnitdata ts_GTPC_SGSNContextAck(Gtp1cPeer peer, OCT4 teid, uint16_t seq, - template (value) GTPC_PDUs SGSNContextAckPDU := ts_SGSNContextAckPDU(GTP_CAUSE_REQUEST_ACCEPTED)) := { + template (value) GTPC_PDUs SGSNContextAckPDU := ts_SGSNContextAckPDU) := { peer := peer, gtpc := ts_GTP1C_PDU(sgsnContextAcknowledge, teid, valueof(SGSNContextAckPDU), seq) } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36598?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9b0c948f295fd73fad79c8d09b45fd992c90a015 Gerrit-Change-Number: 36598 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 2 months

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: sgsn: TC_sgsn_context_req_in: match MM Context & GSN Address IEs

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36600?usp=email ) Change subject: sgsn: TC_sgsn_context_req_in: match MM Context & GSN Address IEs ...................................................................... sgsn: TC_sgsn_context_req_in: match MM Context & GSN Address IEs Change-Id: Ie68794c309e548279381d044a3e34dcdf405084f Related: SYS#6603, OS#6294 --- M library/GTPv1C_Templates.ttcn M sgsn/SGSN_Tests.ttcn 2 files changed, 55 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/00/36600/1 diff --git a/library/GTPv1C_Templates.ttcn b/library/GTPv1C_Templates.ttcn index 0907c5e..2eb1d7e 100644 --- a/library/GTPv1C_Templates.ttcn +++ b/library/GTPv1C_Templates.ttcn @@ -341,7 +341,8 @@ /* 7.7.28 MM Context */ template (value) MM_Context ts_MM_ContextGSM(template (value) OCT8 kc, template (value) BIT3 cksn := '000'B, - template (value) BIT3 gea := '000'B) := { + template (value) BIT3 gea := '000'B, + template (value) octetstring triplet := ''O) := { type_gtpc := '81'O, context := { mmcontGSM := { @@ -352,7 +353,7 @@ noofVectors := 0, /* overwritten */ security := '01'B, /* GSM key and triplets */ kc := kc, - triplet := ''O, + triplet := triplet, drx_par := '0000'O, msNetW_cap_length := 0, /* overwritten */ msNetw_cap := omit, @@ -363,6 +364,32 @@ } } } + template (present) MM_Context tr_MM_ContextGSM(template (present) OCT8 kc := ?, + template (present) BIT3 cksn := ?, + template (present) BIT3 gea := ?, + template (present) octetstring triplet := ?) := { + type_gtpc := '81'O, + context := { + mmcontGSM := { + lengthf := ?, + cksn := cksn, + spare := ?, + usedCipher := gea, + noofVectors := ?, + security := '01'B, /* GSM key and triplets */ + kc := kc, + triplet := triplet, + drx_par := ?, + msNetW_cap_length := ?, + msNetw_cap := *, + containerLength := ?, + container := *, + access_restriction_data_length := ?, + access_restriction_data := * + } + } + } + template (value) MM_Context ts_MM_ContextUMTS(template (value) OCT16 ck, template (value) OCT16 ik) := { type_gtpc := '81'O, diff --git a/sgsn/SGSN_Tests.ttcn b/sgsn/SGSN_Tests.ttcn index 08ae9bc..da1511b 100644 --- a/sgsn/SGSN_Tests.ttcn +++ b/sgsn/SGSN_Tests.ttcn @@ -3757,7 +3757,22 @@ var template (present) GTPC_PDUs ctx_rsp; ctx_rsp := tr_SGSNContextRespPDU(cause := GTP_CAUSE_REQUEST_ACCEPTED, imsi := g_pars.imsi); - /* TODO: match MM/PDP Context, GSN Address */ + + /* SGSN Address for Control Plane */ + var octetstring sgsn_addr := f_inet_addr(mp_sgsn_gtp_ip); + ctx_rsp.sgsn_ContextResponse.sgsn_addr_controlPlane := tr_GsnAddr(mp_sgsn_gtp_ip); + + /* Match MM Context */ + if (ispresent(g_pars.vec)) { + /* XXX: this is only valid for GERAN */ + var octetstring triplet := g_pars.vec.rand & g_pars.vec.sres & g_pars.vec.kc; + ctx_rsp.sgsn_ContextResponse.mm_Context := tr_MM_ContextGSM(kc := g_pars.vec.kc, + triplet := triplet); + /* TODO: 7.5.4 "The IMEISV shall, if available, be included in the MM Context". + * See also 3GPP TS 29.060, section 7.7.28 and Table 47A */ + } + + /* TODO: match PDP Context */ T.start(2.0); alt { -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36600?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie68794c309e548279381d044a3e34dcdf405084f Gerrit-Change-Number: 36600 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 2 months

1
0
0 0

2025

2024

2023

2022

gerrit-log April 2024