April 2024 - gerrit-log - lists.osmocom.org

[XS] Change in osmo-mgw[master]: (do not merge) commit for testing CI

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-mgw/+/36638?usp=email ) Change subject: (do not merge) commit for testing CI ...................................................................... (do not merge) commit for testing CI Change-Id: I4463ea2cb93b1a0b138ea19a6a9d43f674f7349d --- A test 1 file changed, 9 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/38/36638/1 diff --git a/test b/test new file mode 100644 index 0000000..e69de29 --- /dev/null +++ b/test -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/36638?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I4463ea2cb93b1a0b138ea19a6a9d43f674f7349d Gerrit-Change-Number: 36638 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 2 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: epdg: Add README.md

by pespin

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36637?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: epdg: Add README.md ...................................................................... epdg: Add README.md Change-Id: I6326b6c35f66d30787758d83e96e8a070375b0c0 --- A epdg/README.md 1 file changed, 35 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/37/36637/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36637?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I6326b6c35f66d30787758d83e96e8a070375b0c0 Gerrit-Change-Number: 36637 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset

1 year, 2 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: epdg: Add README.md

by pespin

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36637?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: epdg: Add README.md ...................................................................... epdg: Add README.md Change-Id: I6326b6c35f66d30787758d83e96e8a070375b0c0 --- A epdg/README.md 1 file changed, 35 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/37/36637/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36637?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I6326b6c35f66d30787758d83e96e8a070375b0c0 Gerrit-Change-Number: 36637 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset

1 year, 2 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: epdg: Add README.md

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36637?usp=email ) Change subject: epdg: Add README.md ...................................................................... epdg: Add README.md Change-Id: I6326b6c35f66d30787758d83e96e8a070375b0c0 --- A epdg/README.md 1 file changed, 35 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/37/36637/1 diff --git a/epdg/README.md b/epdg/README.md new file mode 100644 index 0000000..4d902e5 --- /dev/null +++ b/epdg/README.md @@ -0,0 +1,26 @@ +# EPDG_Tests.ttcn + +* external interfaces + * CEAI: GSUP (emulates strongswan) + * SWx: Diameter (emulates HSS) + * S6b: Diameter (emulates SMF) + * S2b: GTPv2C (emulates SMF) + * Emulates userplane IPsec decapsulated IP traffic at strongswan + * Emulates userplane GTPv1U encapsulated IP traffic at UPF + +{% dot epdg_tests.svg +digraph G { + rankdir=LR; + ATS [label="ATS\nGEPDG_Tests.ttcn"]; + EPDG [label="EPDG\nosmo-epdg",shape="box", color=red]; + GTP_KERN [label="gtp\nkernel-module", shape="box"]; + + ATS -> EPDG [label="CEAI (GSUP)"]; + EPDG -> ATS [label="S6b (Diameter)"]; + ATS -> EPDG [label="SWx (Diameter)"] + ATS -> EPDG [label="S2b (GTPv2C)"]; + ATS -> EPDG [label="IP traffic (to/from strongswan ipsec)", style=dashed]; + EPDG -> GTP_KERN [label="netlink"] + GTP_KERN -> ATS [label="IP traffic (GTPv1U to/from UPF)", style=dashed] +} +%} -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36637?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I6326b6c35f66d30787758d83e96e8a070375b0c0 Gerrit-Change-Number: 36637 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 2 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: {cbc,remsim}: fix unbound 'use_ssl' field in HTTP_Adapter_Params

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36636?usp=email ) Change subject: {cbc,remsim}: fix unbound 'use_ssl' field in HTTP_Adapter_Params ...................................................................... {cbc,remsim}: fix unbound 'use_ssl' field in HTTP_Adapter_Params A recent commit added a new field to record HTTP_Adapter_Params, but forgot to update the callers f_http_init() to actually set this field. Change-Id: I534d087b71cefd683a0c7411a415049c5e1ee519 Fixes: 832b1efe "HTTP_Adapter: Allow API users to enable/disable SSL" --- M cbc/CBC_Tests.ttcn M remsim/RemsimServer_Tests.ttcn 2 files changed, 18 insertions(+), 4 deletions(-) Approvals: osmith: Looks good to me, but someone else must approve Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/cbc/CBC_Tests.ttcn b/cbc/CBC_Tests.ttcn index 57f4d9e..52f6378 100644 --- a/cbc/CBC_Tests.ttcn +++ b/cbc/CBC_Tests.ttcn @@ -187,10 +187,10 @@ } private function f_init(integer num_bsc := 0, integer num_mme := 0) runs on test_CT { - var HTTP_Adapter_Params http_adapter_pars; - http_adapter_pars := { + var HTTP_Adapter_Params http_adapter_pars := { http_host := mp_cbc_host, - http_port := mp_cbc_ecbe_port + http_port := mp_cbc_ecbe_port, + use_ssl := false }; f_http_init(http_adapter_pars); diff --git a/remsim/RemsimServer_Tests.ttcn b/remsim/RemsimServer_Tests.ttcn index 94529b2..23ea8cb 100644 --- a/remsim/RemsimServer_Tests.ttcn +++ b/remsim/RemsimServer_Tests.ttcn @@ -71,7 +71,8 @@ var HTTP_Adapter_Params http_adapter_pars; http_adapter_pars := { http_host := mp_server_ip, - http_port := mp_rsres_port + http_port := mp_rsres_port, + use_ssl := false }; f_http_init(http_adapter_pars); f_rsres_post_reset(); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36636?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I534d087b71cefd683a0c7411a415049c5e1ee519 Gerrit-Change-Number: 36636 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 2 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: {cbc,remsim}: fix unbound 'use_ssl' field in HTTP_Adapter_Params

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36636?usp=email ) Change subject: {cbc,remsim}: fix unbound 'use_ssl' field in HTTP_Adapter_Params ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36636?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I534d087b71cefd683a0c7411a415049c5e1ee519 Gerrit-Change-Number: 36636 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 25 Apr 2024 09:15:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 2 months

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: asterisk: Use Titan TEXT encoder to implement AMI record enc/dec

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36610?usp=email ) Change subject: asterisk: Use Titan TEXT encoder to implement AMI record enc/dec ...................................................................... asterisk: Use Titan TEXT encoder to implement AMI record enc/dec f_ami_wait_for_prompt_str had to be fixed since it was returning content like this: "Response: Success\nMessage: Authentication accepted" Instead, the TEXT encoding expects: "Response: Success\nMessage: Authentication accepted\n" which is actually more in line with proper expectancies. Change-Id: If179e45307a7e42b81b28db6ee4b7bf5eeb8b5f1 --- M asterisk/AMI_Functions.ttcn 1 file changed, 34 insertions(+), 48 deletions(-) Approvals: fixeria: Looks good to me, but someone else must approve osmith: Looks good to me, approved Jenkins Builder: Verified diff --git a/asterisk/AMI_Functions.ttcn b/asterisk/AMI_Functions.ttcn index 53a7964..d5139f5 100644 --- a/asterisk/AMI_Functions.ttcn +++ b/asterisk/AMI_Functions.ttcn @@ -32,8 +32,21 @@ type record AMI_Field { charstring key, charstring val +} with { + encode "TEXT" + variant "SEPARATOR(': ', ':\s+')" }; -type set of AMI_Field AMI_Msg; + +type set of AMI_Field AMI_Msg with { + encode "TEXT" + variant "SEPARATOR('\r\n', '(\r\n)|[\n]')" + variant "END('\r\n', '(\r\n)|[\n]')" +}; + +external function enc_AMI_Msg(in AMI_Msg msg) return charstring + with { extension "prototype(convert) encode(TEXT)" } +external function dec_AMI_Msg(in charstring stream) return AMI_Msg + with { extension "prototype(convert) decode(TEXT)" } template (value) AMI_Field ts_AMI_Field(template (value) charstring key, @@ -102,49 +115,6 @@ * Functions: */ -function f_AMI_Field_from_str(charstring str) return AMI_Field { - var AMI_Field field; - /* "each field is a key value pair delineated by a ':'. - * A single space MUST follow the ':' and precede the value. "*/ - var integer pos := f_strstr(str, ": ", 0); - if (pos < 0) { - Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, - log2str("Failed parsing AMI_Field: ", str)); - } - field.key := substr(str, 0, pos); - /* skip ": " */ - pos := pos + 2; - field.val := substr(str, pos, lengthof(str) - pos); - return field; -} - -function f_AMI_Msg_from_str(charstring str) return AMI_Msg { - var AMI_Msg msg := {}; - var Misc_Helpers.ro_charstring lines := f_str_split(str, "\n"); - - for (var integer i := 0; i < lengthof(lines); i := i + 1) { - var charstring line := lines[i]; - var AMI_Field field := f_AMI_Field_from_str(lines[i]); - msg := msg & { field }; - } - return msg; -} - -function f_AMI_Field_to_str(AMI_Field field) return charstring { - return field.key & ": " & field.val; -} - -function f_AMI_Msg_to_str(AMI_Msg msg) return charstring { - var charstring str := ""; - - for (var integer i := 0; i < lengthof(msg); i := i + 1) { - str := str & f_AMI_Field_to_str(msg[i]) & "\r\n"; - } - - str := str & "\r\n"; - return str; -} - private function f_ami_wait_for_prompt_str(TELNETasp_PT pt, charstring log_label := "(?)") return charstring { var charstring rx, buf := ""; @@ -153,7 +123,7 @@ T.start(mp_ami_prompt_timeout); alt { - [] pt.receive(pattern "\n") { }; + [] pt.receive(pattern "\n") { buf := buf & "\n" }; [] pt.receive(charstring:?) -> value rx { buf := buf & rx; repeat }; [] pt.receive(integer:?) -> value fd { if (fd == -1) { @@ -174,7 +144,7 @@ function f_ami_wait_for_prompt(TELNETasp_PT pt, charstring log_label := "(?)") return AMI_Msg { var charstring buf := f_ami_wait_for_prompt_str(pt, log_label); - var AMI_Msg msg := f_AMI_Msg_from_str(buf); + var AMI_Msg msg := dec_AMI_Msg(buf); return msg; } @@ -185,9 +155,9 @@ } function f_ami_transceive_ret(TELNETasp_PT pt, template (value) AMI_Msg tx_msg) return AMI_Msg { - var charstring tx_txt := f_AMI_Msg_to_str(valueof(tx_msg)); + var charstring tx_txt := enc_AMI_Msg(valueof(tx_msg)); var charstring resp_txt := f_ami_transceive_ret_str(pt, tx_txt); - return f_AMI_Msg_from_str(resp_txt); + return dec_AMI_Msg(resp_txt); } function f_ami_transceive_match(TELNETasp_PT pt, -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36610?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If179e45307a7e42b81b28db6ee4b7bf5eeb8b5f1 Gerrit-Change-Number: 36610 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 2 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: {cbc,remsim}: fix unbound 'use_ssl' field in HTTP_Adapter_Params

by osmith

Attention is currently required from: fixeria. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36636?usp=email ) Change subject: {cbc,remsim}: fix unbound 'use_ssl' field in HTTP_Adapter_Params ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36636?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I534d087b71cefd683a0c7411a415049c5e1ee519 Gerrit-Change-Number: 36636 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 25 Apr 2024 09:15:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 2 months

1
0
0 0

[S] Change in osmo-hnbgw[master]: drop legacy hack: do not start MGW endp in loopback mode

by pespin

Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/36634?usp=email ) Change subject: drop legacy hack: do not start MGW endp in loopback mode ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Patchset: PS1: Just to be sure: do we test in MGCP_Tests with SEND_RECV already and it works fine? Otherwise we need to make sure we do the proper thing in MGCP_Tests before merging this to make sure we don't break current systems. -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/36634?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I0eca75d7abf66f8b9fde9c68ec10d4265f64a189 Gerrit-Change-Number: 36634 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Thu, 25 Apr 2024 09:14:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 2 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: {cbc,remsim}: fix unbound 'use_ssl' field in HTTP_Adapter_Params

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36636?usp=email ) Change subject: {cbc,remsim}: fix unbound 'use_ssl' field in HTTP_Adapter_Params ...................................................................... {cbc,remsim}: fix unbound 'use_ssl' field in HTTP_Adapter_Params A recent commit added a new field to record HTTP_Adapter_Params, but forgot to update the callers f_http_init() to actually set this field. Change-Id: I534d087b71cefd683a0c7411a415049c5e1ee519 Fixes: 832b1efe "HTTP_Adapter: Allow API users to enable/disable SSL" --- M cbc/CBC_Tests.ttcn M remsim/RemsimServer_Tests.ttcn 2 files changed, 18 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/36/36636/1 diff --git a/cbc/CBC_Tests.ttcn b/cbc/CBC_Tests.ttcn index 57f4d9e..52f6378 100644 --- a/cbc/CBC_Tests.ttcn +++ b/cbc/CBC_Tests.ttcn @@ -187,10 +187,10 @@ } private function f_init(integer num_bsc := 0, integer num_mme := 0) runs on test_CT { - var HTTP_Adapter_Params http_adapter_pars; - http_adapter_pars := { + var HTTP_Adapter_Params http_adapter_pars := { http_host := mp_cbc_host, - http_port := mp_cbc_ecbe_port + http_port := mp_cbc_ecbe_port, + use_ssl := false }; f_http_init(http_adapter_pars); diff --git a/remsim/RemsimServer_Tests.ttcn b/remsim/RemsimServer_Tests.ttcn index 94529b2..23ea8cb 100644 --- a/remsim/RemsimServer_Tests.ttcn +++ b/remsim/RemsimServer_Tests.ttcn @@ -71,7 +71,8 @@ var HTTP_Adapter_Params http_adapter_pars; http_adapter_pars := { http_host := mp_server_ip, - http_port := mp_rsres_port + http_port := mp_rsres_port, + use_ssl := false }; f_http_init(http_adapter_pars); f_rsres_post_reset(); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36636?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I534d087b71cefd683a0c7411a415049c5e1ee519 Gerrit-Change-Number: 36636 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 2 months

1
0
0 0

2025

2024

2023

2022

gerrit-log April 2024